almalinux/cas_wrapper
14
0
Fork 2
Code Issues Pull requests Releases Activity

ALBS-443: Integrate CodeNotary with git updater tool #1

Merged
soksanichenko merged 10 commits from ALBS-443 into master 2022-06-22 11:07:24 +00:00
Conversation 2 Commits 10 Files changed 2 +121
soksanichenko commented 2022-06-20 10:20:21 +00:00
Owner
Copy link

Add cas wrapper

Add cas wrapper
Add cas wrapper
- Additional metadata for notarizing
- Additional metadata for notarizing
- Additional metadata for notarizing
- Env vars with credentials
anfimovdm approved these changes 2022-06-21 08:19:20 +00:00
anfimovdm left a comment
Copy link

lgtm

lgtm
AvoidMe reviewed 2022-06-21 08:38:24 +00:00
cas_wrapper.py
@ -0,0 +28,4 @@
SIGNER_ID=self._cas_signer_id
):
self._cas = local['cas']
self._cas['login']()
AvoidMe commented 2022-06-21 08:38:24 +00:00
First-time contributor
Copy link

I feel uncomfortable with login() in __init__, can't we do it in __enter__ and __exit__?

I feel uncomfortable with `login()` in `__init__`, can't we do it in `__enter__` and `__exit__`?
soksanichenko commented 2022-06-21 10:46:18 +00:00
Author
Owner
Copy link

Do you suggest convert it to context manager?

Do you suggest convert it to context manager?
AvoidMe commented 2022-06-21 11:14:18 +00:00
First-time contributor
Copy link

yes

yes
soksanichenko marked this conversation as resolved 
- setup.py
- setup.py
- setup.py
Sign in to join this conversation.
Reviewers
No reviewers
anfimovdm
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
almalinux/cas_wrapper!1
No description provided.