import rpcbind-1.2.5-7.el8

.gitignore

@@ -0,0 +1 @@
+SOURCES/rpcbind-1.2.5.tar.bz2

.rpcbind.metadata

@@ -0,0 +1 @@
+e9f8046b69b45efe2396a8cca1c1f090644c6d31 SOURCES/rpcbind-1.2.5.tar.bz2

SOURCES/rpcbind-0.2.3-systemd-envfile.patch

@@ -0,0 +1,11 @@
+diff -up rpcbind-0.2.4/systemd/rpcbind.service.in.orig rpcbind-0.2.4/systemd/rpcbind.service.in
+--- rpcbind-0.2.4/systemd/rpcbind.service.in.orig	2017-12-16 15:49:07.830889473 -0500
++++ rpcbind-0.2.4/systemd/rpcbind.service.in	2017-12-16 15:49:43.156610673 -0500
+@@ -12,6 +12,7 @@ Wants=rpcbind.target
+ [Service]
+ Type=notify
+ # distro can provide a drop-in adding EnvironmentFile=-/??? if needed.
++EnvironmentFile=/etc/sysconfig/rpcbind
+ ExecStart=@_sbindir@/rpcbind $RPCBIND_OPTIONS -w -f
+ 
+ [Install]

SOURCES/rpcbind-0.2.3-systemd-tmpfiles.patch

@@ -0,0 +1,40 @@
+diff -up rpcbind-0.2.4/configure.ac.orig rpcbind-0.2.4/configure.ac
+--- rpcbind-0.2.4/configure.ac.orig	2017-12-16 15:52:22.774298138 -0500
++++ rpcbind-0.2.4/configure.ac	2017-12-16 15:52:45.301075188 -0500
+@@ -52,6 +52,17 @@ AC_ARG_WITH([systemdsystemunitdir],
+   fi
+ AM_CONDITIONAL(SYSTEMD, [test -n "$with_systemdsystemunitdir" -a "x$with_systemdsystemunitdir" != xno ])
+ 
++AC_ARG_WITH([systemdtmpfilesdir],
++  AS_HELP_STRING([--with-systemdtmpfilesdir=DIR], [Directory for systemd tmp files]),
++  [], [with_systemdtmpfilesdir=$($PKG_CONFIG --variable=tmpfilesdir systemd)])
++  if test "x$with_systemdtmpfilesdir" != xno; then
++    AC_SUBST([systemdtmpfilesdir], [$with_systemdtmpfilesdir])
++     PKG_CHECK_MODULES([SYSTEMD], [libsystemd], [],
++	   [PKG_CHECK_MODULES([SYSTEMD], [libsystemd-daemon], [],
++	   AC_MSG_ERROR([libsystemd support requested but found]))])
++  fi
++AM_CONDITIONAL(SYSTEMD, [test -n "$with_systemdtmpfilesdir" -a "x$with_systemdtmpfilesdir" != xno ])
++
+ AS_IF([test x$enable_libwrap = xyes], [
+ 	AC_CHECK_LIB([wrap], [hosts_access], ,
+ 		AC_MSG_ERROR([libwrap support requested but unable to find libwrap]))
+diff -up rpcbind-0.2.4/Makefile.am.orig rpcbind-0.2.4/Makefile.am
+--- rpcbind-0.2.4/Makefile.am.orig	2017-12-16 15:52:22.774298138 -0500
++++ rpcbind-0.2.4/Makefile.am	2017-12-16 15:52:45.301075188 -0500
+@@ -55,6 +55,9 @@ rpcbind_LDADD += $(SYSTEMD_LIBS)
+ systemdsystemunit_DATA = \
+ 	systemd/rpcbind.service \
+ 	systemd/rpcbind.socket
++
++systemdtmpfiles_DATA = \
++	systemd/rpcbind.conf
+ endif
+ 
+ rpcinfo_SOURCES =       src/rpcinfo.c
+diff -up rpcbind-0.2.4/systemd/rpcbind.conf.orig rpcbind-0.2.4/systemd/rpcbind.conf
+--- rpcbind-0.2.4/systemd/rpcbind.conf.orig	2017-12-16 15:52:45.301075188 -0500
++++ rpcbind-0.2.4/systemd/rpcbind.conf	2017-12-16 15:52:45.301075188 -0500
+@@ -0,0 +1,2 @@
++#Type Path         Mode  UID  GID Age Argument
++D     /run/rpcbind 0700  rpc  rpc  -  -

SOURCES/rpcbind-0.2.4-runstatdir.patch

@@ -0,0 +1,61 @@
+diff -up rpcbind-1.2.5/configure.ac.orig rpcbind-1.2.5/configure.ac
+--- rpcbind-1.2.5/configure.ac.orig	2018-08-21 13:16:53.778658897 -0400
++++ rpcbind-1.2.5/configure.ac	2018-08-21 13:18:30.810307201 -0400
+@@ -26,8 +26,8 @@ AC_ARG_ENABLE([rmtcalls],
+ AM_CONDITIONAL(RMTCALLS, test x$enable_rmtcalls = xyes)
+ 
+ AC_ARG_WITH([statedir],
+-  AS_HELP_STRING([--with-statedir=ARG], [use ARG as state dir @<:@default=/var/run/rpcbind@:>@])
+-  ,, [with_statedir=/var/run/rpcbind])
++  AS_HELP_STRING([--with-statedir=ARG], [use ARG as state dir @<:@default=/run/rpcbind@:>@])
++  ,, [with_statedir=/run/rpcbind])
+ AC_SUBST([statedir], [$with_statedir])
+ 
+ AC_ARG_WITH([rpcuser],
+diff -up rpcbind-1.2.5/configure.orig rpcbind-1.2.5/configure
+--- rpcbind-1.2.5/configure.orig	2018-08-15 11:00:32.000000000 -0400
++++ rpcbind-1.2.5/configure	2018-08-21 13:18:30.811307187 -0400
+@@ -1391,7 +1391,7 @@ Optional Features:
+ Optional Packages:
+   --with-PACKAGE[=ARG]    use PACKAGE [ARG=yes]
+   --without-PACKAGE       do not use PACKAGE (same as --with-PACKAGE=no)
+-  --with-statedir=ARG     use ARG as state dir [default=/var/run/rpcbind]
++  --with-statedir=ARG     use ARG as state dir [default=/run/rpcbind]
+ 
+   --with-rpcuser=ARG      use ARG for RPC [default=root]
+ 
+@@ -3901,7 +3901,7 @@ fi
+ if test "${with_statedir+set}" = set; then :
+   withval=$with_statedir;
+ else
+-  with_statedir=/var/run/rpcbind
++  with_statedir=/run/rpcbind
+ fi
+ 
+ statedir=$with_statedir
+diff -up rpcbind-1.2.5/man/rpcbind-fr.8.orig rpcbind-1.2.5/man/rpcbind-fr.8
+--- rpcbind-1.2.5/man/rpcbind-fr.8.orig	2018-08-15 10:51:19.000000000 -0400
++++ rpcbind-1.2.5/man/rpcbind-fr.8	2018-08-21 13:18:30.812307174 -0400
+@@ -138,8 +138,8 @@ est redémarré.
+ .Xr rpcbind 3 ,
+ .Xr rpcinfo 8
+ .Sh FILES
+-.Bl -tag -width /var/run/rpcbind.sock -compact
+-.It Pa /var/run/rpcbind.sock
++.Bl -tag -width /run/rpcbind.sock -compact
++.It Pa /run/rpcbind.sock
+ .Sh TRADUCTION
+ Aurelien CHARBON (Sept 2003)
+ .El
+diff -up rpcbind-1.2.5/src/rpcbind.c.orig rpcbind-1.2.5/src/rpcbind.c
+--- rpcbind-1.2.5/src/rpcbind.c.orig	2018-08-15 10:51:19.000000000 -0400
++++ rpcbind-1.2.5/src/rpcbind.c	2018-08-21 13:18:30.812307174 -0400
+@@ -106,7 +106,7 @@ char *nss_modules = "files";
+ /* who to suid to if -s is given */
+ #define RUN_AS  "daemon"
+ 
+-#define RPCBINDDLOCK "/var/run/rpcbind.lock"
++#define RPCBINDDLOCK RPCBIND_STATEDIR "/rpcbind.lock"
+ 
+ int runasdaemon = 0;
+ int insecure = 0;

SOURCES/rpcbind-0.2.4-systemd-rundir.patch

@@ -0,0 +1,35 @@
+diff -up rpcbind-0.2.4/src/rpcbind.c.orig rpcbind-0.2.4/src/rpcbind.c
+--- rpcbind-0.2.4/src/rpcbind.c.orig	2017-03-21 10:12:35.005190509 -0400
++++ rpcbind-0.2.4/src/rpcbind.c	2017-03-21 10:36:45.510507649 -0400
+@@ -144,6 +144,8 @@ static void rbllist_add(rpcprog_t, rpcve
+ static void terminate(int);
+ static void parseargs(int, char *[]);
+ 
++char *systemdtmp = "/usr/bin/systemd-tmpfiles --create rpcbind.conf";
++
+ int
+ main(int argc, char *argv[])
+ {
+@@ -151,13 +153,21 @@ main(int argc, char *argv[])
+ 	void *nc_handle;	/* Net config handle */
+ 	struct rlimit rl;
+ 	int maxrec = RPC_MAXDATASIZE;
++	int once = 1;
+ 
+ 	parseargs(argc, argv);
+ 
++tryagain:
+ 	/* Check that another rpcbind isn't already running. */
+ 	if ((rpcbindlockfd = (open(RPCBINDDLOCK,
+-	    O_RDONLY|O_CREAT, 0444))) == -1)
++	    O_RDONLY|O_CREAT, 0444))) == -1) {
++		if (once) {
++			once = system(systemdtmp); /* set once to avoid a warning */
++			once = 0;
++			goto tryagain; 
++		}
+ 		err(1, "%s", RPCBINDDLOCK);
++	}
+ 
+ 	if(flock(rpcbindlockfd, LOCK_EX|LOCK_NB) == -1 && errno == EWOULDBLOCK)
+ 		errx(1, "another rpcbind is already running. Aborting");

SOURCES/rpcbind-0.2.4-systemd-service.patch

@@ -0,0 +1,20 @@
+diff -up rpcbind-1.2.5/systemd/rpcbind.service.in.orig rpcbind-1.2.5/systemd/rpcbind.service.in
+--- rpcbind-1.2.5/systemd/rpcbind.service.in.orig	2020-01-16 11:40:30.329120662 -0500
++++ rpcbind-1.2.5/systemd/rpcbind.service.in	2020-01-16 11:44:26.605895713 -0500
+@@ -7,13 +7,14 @@ RequiresMountsFor=@statedir@
+ # Make sure we use the IP addresses listed for
+ # rpcbind.socket, no matter how this unit is started.
+ Requires=rpcbind.socket
+-Wants=rpcbind.target
++Wants=rpcbind.target systemd-tmpfiles-setup.service
++After=systemd-tmpfiles-setup.service
+ 
+ [Service]
+ Type=notify
+ # distro can provide a drop-in adding EnvironmentFile=-/??? if needed.
+ EnvironmentFile=/etc/sysconfig/rpcbind
+-ExecStart=@_sbindir@/rpcbind $RPCBIND_OPTIONS -w -f
++ExecStart=@_sbindir@/rpcbind $RPCBIND_ARGS -w -f
+ 
+ [Install]
+ WantedBy=multi-user.target

SOURCES/rpcbind-1.2.5-covscan-resource-leaks.patch

@@ -0,0 +1,94 @@
+diff -up rpcbind-1.2.5/src/rpcbind.c.orig rpcbind-1.2.5/src/rpcbind.c
+--- rpcbind-1.2.5/src/rpcbind.c.orig	2020-02-06 14:19:34.199330296 -0500
++++ rpcbind-1.2.5/src/rpcbind.c	2020-02-06 14:20:19.069973902 -0500
+@@ -350,7 +350,7 @@ init_transport(struct netconfig *nconf)
+ {
+ 	int fd = -1;
+ 	struct t_bind taddr;
+-	struct addrinfo hints, *res;
++	struct addrinfo hints, *res = NULL;
+ 	struct __rpc_sockinfo si;
+ 	SVCXPRT	*my_xprt = NULL;
+ 	int status;	/* bound checking ? */
+@@ -827,8 +827,12 @@ got_socket:
+ 	}
+ #endif
+ 
++	if (res != NULL)
++		freeaddrinfo(res);
+ 	return (0);
+ error:
++	if (res != NULL)
++		freeaddrinfo(res);
+ 	close(fd);
+ 	return (1);
+ }
+diff -up rpcbind-1.2.5/src/rpcb_stat.c.orig rpcbind-1.2.5/src/rpcb_stat.c
+--- rpcbind-1.2.5/src/rpcb_stat.c.orig	2018-08-15 10:51:19.000000000 -0400
++++ rpcbind-1.2.5/src/rpcb_stat.c	2020-02-06 14:20:19.073973959 -0500
+@@ -151,7 +151,7 @@ rpcbs_rmtcall(rpcvers_t rtype, rpcproc_t
+ 	rpcbs_rmtcalllist *rl;
+ 	struct netconfig *nconf;
+ 
+-	if (rtype > RPCBVERS_STAT)
++	if (rtype >= RPCBVERS_STAT)
+ 		return;
+ 	for (rl = inf[rtype].rmtinfo; rl; rl = rl->next) {
+ 
+diff -up rpcbind-1.2.5/src/rpcinfo.c.orig rpcbind-1.2.5/src/rpcinfo.c
+--- rpcbind-1.2.5/src/rpcinfo.c.orig	2020-02-06 14:19:34.193330210 -0500
++++ rpcbind-1.2.5/src/rpcinfo.c	2020-02-06 14:20:19.073973959 -0500
+@@ -693,11 +693,11 @@ reply_proc (res, who, nconf)
+     }
+   if (!(uaddr = taddr2uaddr (nconf, who)))
+     {
+-      uaddr = UNKNOWN;
++      printf ("%s\t%s\n", UNKNOWN, hostname);
++    } else {
++      printf ("%s\t%s\n", uaddr, hostname);
++      free ((char *) uaddr);
+     }
+-  printf ("%s\t%s\n", uaddr, hostname);
+-  if (strcmp (uaddr, UNKNOWN))
+-    free ((char *) uaddr);
+   return (FALSE);
+ }
+ 
+diff -up rpcbind-1.2.5/src/util.c.orig rpcbind-1.2.5/src/util.c
+--- rpcbind-1.2.5/src/util.c.orig	2020-02-06 14:20:51.564439986 -0500
++++ rpcbind-1.2.5/src/util.c	2020-02-06 14:20:39.994274027 -0500
+@@ -322,13 +322,20 @@ network_init()
+ 	/*
+ 	 * Now join the RPC ipv6 multicast group on all interfaces.
+ 	 */
+-	if (getifaddrs(&ifp) < 0)
++	if (getifaddrs(&ifp) < 0) {
++		freeaddrinfo (res);
+ 		return;
+-
++	}
+ 	mreq6.ipv6mr_interface = 0;
+ 	inet_pton(AF_INET6, RPCB_MULTICAST_ADDR, &mreq6.ipv6mr_multiaddr);
+ 
+ 	s = socket(AF_INET6, SOCK_DGRAM, IPPROTO_UDP);
++	if (s < 0) {
++	    if (debugging)
++		    fprintf(stderr, "socket(AF_INET6) failed: %s\n", strerror(errno));
++	    freeaddrinfo (res);
++	    return;
++	}
+ 
+ 	/*
+ 	 * Loop through all interfaces. For each IPv6 multicast-capable
+@@ -351,9 +358,9 @@ network_init()
+ 			if (debugging)
+ 				perror("setsockopt v6 multicast");
+ 	}
++	close(s);
+ #endif
+-
+-	/* close(s); */
++	freeaddrinfo (res);
+ }
+ 
+ struct sockaddr *

SOURCES/rpcbind-1.2.5-rpcinfo-bufoverflow.patch

@@ -0,0 +1,64 @@
+commit 0bc1c0ae7ce61a7ac8a8e9a9b2086268f011abf0
+Author: Steve Dickson <steved@redhat.com>
+Date:   Tue Oct 9 09:19:50 2018 -0400
+
+    rpcinfo: Fix stack buffer overflow
+    
+    *** buffer overflow detected ***: rpcinfo terminated
+    ======= Backtrace: =========
+    /lib64/libc.so.6(+0x721af)[0x7ff24c4451af]
+    /lib64/libc.so.6(__fortify_fail+0x37)[0x7ff24c4ccdc7]
+    /lib64/libc.so.6(+0xf8050)[0x7ff24c4cb050]
+    rpcinfo(+0x435f)[0xef3be2635f]
+    rpcinfo(+0x1c62)[0xef3be23c62]
+    /lib64/libc.so.6(__libc_start_main+0xf5)[0x7ff24c3f36e5]
+    rpcinfo(+0x2739)[0xef3be24739]
+    ======= Memory map: ========
+    ...
+    The patch below fixes it.
+    
+    Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
+    Signed-off-by: Thomas Blume <thomas.blume@suse.com>
+    Signed-off-by: Steve Dickson <steved@redhat.com>
+
+diff --git a/src/rpcinfo.c b/src/rpcinfo.c
+index 9b46864..cfdba88 100644
+--- a/src/rpcinfo.c
++++ b/src/rpcinfo.c
+@@ -973,6 +973,7 @@ rpcbdump (dumptype, netid, argc, argv)
+ 	("   program version(s) netid(s)                         service     owner\n");
+       for (rs = rs_head; rs; rs = rs->next)
+ 	{
++	  size_t netidmax = sizeof(buf) - 1;
+ 	  char *p = buf;
+ 
+ 	  printf ("%10ld  ", rs->prog);
+@@ -985,12 +986,22 @@ rpcbdump (dumptype, netid, argc, argv)
+ 	    }
+ 	  printf ("%-10s", buf);
+ 	  buf[0] = '\0';
+-	  for (nl = rs->nlist; nl; nl = nl->next)
+-	    {
+-	      strcat (buf, nl->netid);
+-	      if (nl->next)
+-		strcat (buf, ",");
+-	    }
++
++          for (nl = rs->nlist; nl; nl = nl->next)
++            {
++              strncat (buf, nl->netid, netidmax);
++              if (strlen (nl->netid) < netidmax)
++                netidmax -= strlen(nl->netid);
++              else
++                break;
++
++              if (nl->next && netidmax > 1)
++                {
++                  strncat (buf, ",", netidmax);
++                  netidmax --;
++                }
++            }
++
+ 	  printf ("%-32s", buf);
+ 	  rpc = getrpcbynumber (rs->prog);
+ 	  if (rpc)

SOURCES/rpcbind.sysconfig

@@ -0,0 +1,3 @@
+#
+# Optional arguments passed to rpcbind. See rpcbind(8)
+RPCBIND_ARGS=""

SPECS/rpcbind.spec

@@ -0,0 +1,505 @@
+# These are macros to be usable outside of the build section
+%global rpcbind_user_group rpc
+%global rpcbind_state_dir %{_rundir}/rpcbind
+
+Name:           rpcbind
+Version:        1.2.5
+Release:        7%{?dist}
+Summary:        Universal Addresses to RPC Program Number Mapper
+Group:          System Environment/Daemons
+License:        BSD
+URL:            http://git.linux-nfs.org/?p=steved/rpcbind.git;a=summary
+
+Source0:        http://downloads.sourceforge.net/rpcbind/%{name}-%{version}.tar.bz2
+Source1: %{name}.sysconfig
+
+Requires: glibc-common setup
+Conflicts: man-pages < 2.43-12
+BuildRequires: automake, autoconf, libtool, systemd, systemd-devel
+BuildRequires: libtirpc-devel, quota-devel
+Requires(pre): coreutils shadow-utils
+Requires(post): chkconfig systemd policycoreutils
+Requires(preun): systemd
+Requires(postun): systemd coreutils
+
+#
+# RHEL 8.0
+#
+Patch001: rpcbind-1.2.5-rpcinfo-bufoverflow.patch
+
+#
+# RHEL 8.2
+#
+Patch002: rpcbind-1.2.5-covscan-resource-leaks.patch
+
+Patch100: rpcbind-0.2.3-systemd-envfile.patch
+Patch101: rpcbind-0.2.3-systemd-tmpfiles.patch
+Patch102: rpcbind-0.2.4-runstatdir.patch
+Patch103: rpcbind-0.2.4-systemd-service.patch
+Patch104: rpcbind-0.2.4-systemd-rundir.patch
+
+Provides: portmap = %{version}-%{release}
+Obsoletes: portmap <= 4.0-65.3
+
+%description
+The rpcbind utility is a server that converts RPC program numbers into
+universal addresses.  It must be running on the host to be able to make
+RPC calls on a server on that machine.
+
+%prep
+%setup -q
+
+# 1637565 - rpcinfo: Fix stack buffer overflow 
+%patch001 -p1
+
+# 1602680 - Please review important issues found by covscan...
+%patch002 -p1
+
+%patch100 -p1
+%patch101 -p1
+%patch102 -p1
+%patch103 -p1
+%patch104 -p1
+%build
+autoreconf -fisv
+%configure \
+    --enable-warmstarts \
+    --with-statedir="%rpcbind_state_dir" \
+    --with-rpcuser="%rpcbind_user_group" \
+    --with-nss-modules="files altfiles" \
+    --sbindir=%{_bindir} \
+    --enable-debug
+
+make all
+
+%install
+rm -rf %{buildroot}
+mkdir -p %{buildroot}{%{_sbindir},%{_bindir},/etc/sysconfig}
+mkdir -p %{buildroot}%{_unitdir}
+mkdir -p %{buildroot}%{_tmpfilesdir}
+mkdir -p %{buildroot}%{_mandir}/man8
+mkdir -p %{buildroot}%{rpcbind_state_dir}
+make DESTDIR=$RPM_BUILD_ROOT install
+
+install -m644 %{SOURCE1} %{buildroot}/etc/sysconfig/rpcbind
+
+# The binaries now live in /usr/bin, moving from /usr/sbin
+# For compatibility create a couple symlinks. 
+cd ${RPM_BUILD_ROOT}%{_sbindir}
+ln -sf ../bin/rpcbind
+ln -sf ../bin/rpcinfo
+
+
+%pre
+
+# Softly static allocate the rpc uid and gid.
+getent group rpc >/dev/null || groupadd -f -g 32 -r rpc
+if ! getent passwd rpc >/dev/null ; then
+	if ! getent passwd 32 >/dev/null ; then
+	   useradd -l -c "Rpcbind Daemon" -d /var/lib/rpcbind  \
+	      -g rpc -M -s /sbin/nologin -o -u 32 rpc > /dev/null 2>&1
+	else
+	   useradd -l -c "Rpcbind Daemon" -d /var/lib/rpcbind  \
+	      -g rpc -M -s /sbin/nologin rpc > /dev/null 2>&1
+	fi
+fi
+
+%post
+%systemd_post rpcbind.service rpcbind.socket
+
+%preun
+%systemd_preun rpcbind.service rpcbind.socket
+
+%postun
+%systemd_postun_with_restart rpcbind.service rpcbind.socket
+
+%triggerun -- rpcbind < 0.2.0-15
+%{_bindir}/systemd-sysv-convert --save rpcbind >/dev/null 2>&1 ||:
+/bin/systemctl --no-reload enable rpcbind.service >/dev/null 2>&1
+/sbin/chkconfig --del rpcbind >/dev/null 2>&1 || :
+/bin/systemctl try-restart rpcbind.service >/dev/null 2>&1 || :
+
+%triggerin -- rpcbind > 0.2.2-2.0
+if systemctl -q is-enabled rpcbind.socket
+then
+	/bin/systemctl reenable rpcbind.socket  >/dev/null 2>&1 || :
+	/bin/systemctl restart rpcbind.socket >/dev/null 2>&1 || :
+fi
+if [ ! -d /var/lib/rpcbind ]
+then
+	mkdir /var/lib/rpcbind
+	chown rpc:rpc /var/lib/rpcbind
+	[ -x /usr/sbin/restorecon ] && \
+		/usr/sbin/restorecon /var/lib/rpcbind
+fi
+
+
+%files
+%defattr(-,root,root)
+%config(noreplace) /etc/sysconfig/rpcbind
+%doc AUTHORS ChangeLog README
+%{_bindir}/rpcbind
+%{_bindir}/rpcinfo
+%{_sbindir}/rpcbind
+%{_sbindir}/rpcinfo
+%{_mandir}/man8/*
+%{_unitdir}/%{name}.service
+%{_unitdir}/%{name}.socket
+%{_tmpfilesdir}/%{name}.conf
+%attr(0700, %{rpcbind_user_group}, %{rpcbind_user_group}) %dir %{rpcbind_state_dir}
+
+%changelog
+* Thu Feb  6 2020 Steve Dickson <steved@redhat.com> - 1.2.5-7
+- Clean up a error path found by a covscan (bz 1602680)
+
+* Thu Jan 16 2020 Steve Dickson <steved@redhat.com> - 1.2.5-6
+- Use sysconfig variable in service file (bz 1764985)
+
+* Mon Nov 11 2019 Steve Dickson <steved@redhat.com> - 1.2.5-5
+- Removed some issues found by covscan (bz 1602680)
+
+* Fri Jul 26 2019 Steve Dickson <steved@redhat.com> - 1.2.5-4
+- Enable gating using reverse dependency testing of nfs-utils (bz 1681967
+
+* Sat Oct 20 2018 Steve Dickson <steved@redhat.com> - 1.2.5-3
+- Update the URL (bz 1638664)
+
+* Mon Oct 15 2018 Josh Boyer <jwboyer@redhat.com> - 1.2.5-2
+- Make sure policycoreutils is installed before using it (bz 1628901)
+
+* Wed Oct 10 2018 Steve Dickson <steved@redhat.com> - 1.2.5-1
+- Fixed stack buffer overflow in rpcinfo (bz 1637565)
+- Make sure /var/lib/rpcbind exists (bz 1628901)
+
+* Tue Aug 21 2018 Steve Dickson <steved@redhat.com> - 1.2.5-0
+- Updated to upstream lastest release: 1_2_5 (bz 1605131)
+
+* Sat Feb 24 2018 Florian Weimer <fweimer@redhat.com> - 0.2.4-10.rc3
+- Use default build flags from redhat-rpm-config
+
+* Fri Feb 09 2018 Fedora Release Engineering <releng@fedoraproject.org> - 0.2.4-9.rc3.1
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild
+
+* Mon Dec 18 2017 Steve Dickson <steved@redhat.com> - 0.2.4-9.rc3
+- Removed tcp_wrappers dependency (bz 1518780)
+
+* Sat Dec 16 2017 Steve Dickson <steved@redhat.com> - 0.2.4-8.rc3
+- Updated to latest upstream RC release: rpcbind-0_2_5-rc3 (bz 1431574)
+
+* Wed Sep 06 2017 Nils Philippsen <nils@redhat.com> - 0.2.4-8.rc2
+- create and formally own the state directory so it is available from the time
+  of first installation until reboot
+
+* Thu Aug 03 2017 Fedora Release Engineering <releng@fedoraproject.org> - 0.2.4-7.rc2.2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild
+
+* Thu Jul 27 2017 Fedora Release Engineering <releng@fedoraproject.org> - 0.2.4-7.rc2.1
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild
+
+* Tue May 30 2017 Steve Dickson <steved@redhat.com> - 0.2.4-7.rc2
+- Updated to latest upstream RC release: rpcbind-0_2_5-rc2  (bz 1450765)
+
+* Mon May 15 2017 Steve Dickson <steved@redhat.com> - 0.2.4-7.rc1
+- Fixed typo in memory leaks patch (bz 1448128)
+
+* Thu May 11 2017 Steve Dickson <steved@redhat.com> - 0.2.4-6.rc1
+- Fixed memory leaks (bz 1448128)
+
+* Tue Mar 21 2017 Steve Dickson <steved@redhat.com> - 0.2.4-6
+- Try creating statdir once when opening lock file fails (bz 1401561)
+
+* Sat Feb 11 2017 Fedora Release Engineering <releng@fedoraproject.org> - 0.2.4-5
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild
+
+* Sat Jan 28 2017 Steve Dickson <steved@redhat.com> - 0.2.4-4
+- Corrected boot dependency in systemd files (bz 1401561)
+
+* Mon Jan 23 2017 Steve Dickson <steved@redhat.com> - 0.2.4-3
+- Create a systemd dependency for tmpfiles-setup.service (bz 1401561)
+
+* Mon Jan 16 2017 Steve Dickson <steved@redhat.com> - 0.2.4-2
+- Document /run/rpcbind is the state directory (bz 1401561)
+
+* Tue Jan  3 2017 Steve Dickson <steved@redhat.com> - 0.2.4-1
+- Fix boot dependency in systemd service file (bz 1401561)
+
+* Wed Nov 30 2016 Steve Dickson <steved@redhat.com> - 0.2.4-0
+- Update to the latest upstream release: 0.2.4
+
+* Sat Nov 19 2016 Steve Dickson <steved@redhat.com> - 0.2.3-13.rc2
+- Create the statedir under /run/rpcbind by systemd-tmpfiles.
+
+* Sat Nov 12 2016 Steve Dickson <steved@redhat.com> - 0.2.3-12.rc2
+- Stop enable rpcbind.socket with every update (bz 1393721)
+
+* Mon Nov  7 2016 Steve Dickson <steved@redhat.com> - 0.2.3-11.rc2
+- Updated to the latest RC release rpcbind-0_2_4-rc1
+
+* Mon Aug  1 2016 Steve Dickson <steved@redhat.com> - 0.2.3-11.rc1
+- Removing the braces from the ${RPCBIND_ARGS} in rpcbind.service (bz 1362201)
+- Stop enable rpcbind.socket with every update (bz 1324666)
+
+* Mon Apr  4 2016 Steve Dickson <steved@redhat.com> - 0.2.3-10.rc1
+- Restart rpcbind.socket on restarts (bz 1306824)
+- Soft static allocate rpc uid/gid (bz 1301288)
+
+* Sat Feb 20 2016 Steve Dickson <steved@redhat.com> - 0.2.3-9.rc1
+- Updated to the latest RC release rpcbind-0_2_4-rc1
+
+* Thu Feb 04 2016 Fedora Release Engineering <releng@fedoraproject.org> - 0.2.3-8
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild
+
+* Wed Nov 18 2015 Steve Dickson <steved@redhat.com> - 0.2.3-7
+- Delete the unix socket only if we have created it (bz 1279076)
+
+* Tue Nov  3 2015 Steve Dickson <steved@redhat.com> - 0.2.3-0.6
+- handle_reply: Don't use the xp_auth pointer directly
+
+* Mon Nov  2 2015 Steve Dickson <steved@redhat.com> - 0.2.3-0.5
+- Support nss-altfiles by adding 'altfiles' to nss lookup path (bz 1159941).
+
+* Mon Nov  2 2015 Steve Dickson <steved@redhat.com> - 0.2.3-0.4
+- Fixed Seg fault in PMAP_CALLIT code (bz1264351)
+
+* Sun Nov 01 2015 Kalev Lember <klember@redhat.com> - 0.2.3-0.3
+- Rebuilt for libtirpc soname bump
+
+* Thu Jun 18 2015 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.2.3-0.2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild
+
+* Wed Jun 10 2015 Steve Dickson <steved@redhat.com> - 0.2.3-0.0
+- Make sure rpcbind.socket always gets enabled (bz 1214496)
+
+* Tue Apr 28 2015 Steve Dickson <steved@redhat.com> - 0.2.3-0.0
+- Updated to latest upstream release: 0.2.3
+- Change RPCBDIR to be /tmp since that will exist after a 
+  reboot and bindings wil be perserved during upgrades
+  but not reboots.
+
+* Thu Mar 19 2015 Steve Dickson <steved@redhat.com> - 0.2.2-2.2
+- Changed RPCBDIR to be /var/run so bindings are perserved
+  during upgrades but not reboots.
+- Make sure rpcbind.socket gets enabled
+
+* Thu Feb  5 2015 Steve Dickson <steved@redhat.com> - 0.2.2-2.1
+- Added xlogging debugging to rpcbind
+
+* Wed Feb  4 2015 Steve Dickson <steved@redhat.com> - 0.2.2-2.0
+- Updated to the latest rc release: rpcbind-0_2_3-rc1 (bz 1095021)
+
+* Wed Dec 17 2014 Steve Dickson <steved@redhat.com> - 0.2.2-1.1
+- Fixed NULL fp problem remove error message on warmstart patch
+
+* Tue Dec 16 2014 Steve Dickson <steved@redhat.com> - 0.2.2-1.0
+- Updated to the latest rc release: rpcbind-0_2_3-rc1
+
+* Wed Nov 26 2014 Steve Dickson <steved@redhat.com> - 0.2.2-0.0
+- Updated to the latest upstream release: 0.2.2 (bz 747363)
+- Added BuildRequires systemd-compat-libs
+
+* Mon Nov 10 2014 Steve Dickson <steved@redhat.com> - 0.2.1-4.0
+- Updated to the latest rc release: rpcbind-0_2_2-rc3
+
+* Mon Oct 27 2014 Steve Dickson <steved@redhat.com> - 0.2.1-3.0
+- Updated to the latest rc release: rpcbind-0_2_2-rc2 (bz 1015283)
+
+* Thu Oct 23 2014 Steve Dickson <steved@redhat.com> - 0.2.1-2.1
+- Stop re-enabling with systemd (bz 1087951)
+
+* Thu Aug 21 2014 Kevin Fenzi <kevin@scrye.com> - 0.2.1-2.0
+- Rebuild for rpm bug 1131960
+
+* Mon Aug 18 2014 Steve Dickson <steved@redhat.com> - 0.2.1-1.0
+- Updated to the latest rc release: rpcbind-0_2_2-rc1
+
+* Mon Aug 18 2014 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.2.1-0.4
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_22_Mass_Rebuild
+
+* Sun Jun 08 2014 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.2.1-0.3
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild
+
+* Mon Dec  2 2013 Steve Dickson <steved@redhat.com> - 0.2.1-0.2
+- Removed unnecessary targets from rpcbind.service (bz 963189)
+
+* Wed Aug 21 2013 Steve Dickson <steved@redhat.com> - 0.2.1-0.1
+- Fixed typo in configure.ac file causing rpcuser not to be set.
+
+* Mon Aug 19 2013 Steve Dickson <steved@redhat.com> - 0.2.1-0
+- Update to the latest upstream release: 0.2.1
+
+* Sun Aug 04 2013 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.2.0-22
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild
+
+* Thu Feb 14 2013 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.2.0-21
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_19_Mass_Rebuild
+
+* Tue Oct 23 2012 Steve Dickson <steved@redhat.com> - 0.2.0-20
+- Update to the latest upstream release: rpcbind-0_2_1-rc4 (bz 869365)
+
+* Tue Oct 16 2012 Steve Dickson <steved@redhat.com> - 0.2.0-19
+- Renamed RPCBINDOPTS to RPCBIND_ARGS for backward compatibility (bz 861025)
+
+* Sun Oct 14 2012 Steve Dickson <steved@redhat.com> - 0.2.0-18
+- Fixed typo causing rpcbind to run as root (bz 734598)
+- Added /etc/sysconfig/rpcbind config file (bz 861025)
+
+* Sat Jul 21 2012 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.2.0-17
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild
+
+* Sat Jan 14 2012 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.2.0-16
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild
+
+* Mon Sep 12 2011 Steve Dickson <steved@redhat.com> - 0.2.0-15
+- Bumped up the tigger version to this version, 0.2.0-15 (bz 713574)
+
+* Fri Sep  9 2011 Tom Callaway <spot@fedoraproject.org> - 0.2.0-14
+- fix scriptlets to enable service by default
+
+* Fri Jul  8 2011 Steve Dickson <steved@redhat.com> - 0.2.0-13
+- Spec file clean up
+
+* Thu Jul  7 2011 Steve Dickson <steved@redhat.com> - 0.2.0-12
+- Migrated SysV initscripts to systemd (bz 713574)
+
+* Thu Mar 17 2011 Steve Dickson <steved@redhat.com> - 0.2.0-11
+- Updated to the latest upstream release: rpcbind-0_2_1-rc3
+
+* Wed Feb 09 2011 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.2.0-10
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
+
+* Mon Dec 13 2010 Steve Dickson <steved@redhat.com> - 0.2.0-9
+- Fixed an incorrect exit code for service rpcbind status (bz 662411)
+
+* Tue Nov 30 2010 Steve Dickson <steved@redhat.com> - 0.2.0-8
+- Updated to the latest upstream release: rpcbind-0.2.1-rc2
+
+* Fri Jul 16 2010 Tom "spot" Callaway <tcallawa@redhat.com> - 0.2.0-7
+- correct license tag to BSD
+
+* Tue Jul 13 2010 Steve Dickson <steved@redhat.com> - 0.2.0-6
+- Made initscript LSB compliant (bz 614193)
+- Added no fork patch
+
+* Tue Jul  6 2010 Steve Dickson <steved@redhat.com> - 0.2.0-5
+- Set SO_REUSEADDR on listening sockets (bz 597356)
+
+* Sun Jul 26 2009 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.2.0-4
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
+
+* Mon Jul 06 2009 Adam Jackson <ajax@redhat.com> 0.2.0-3
+- Requires(pre): coreutils for cut(1).
+
+* Thu Jun 25 2009 Steve Dickson <steved@redhat.com> - 0.2.0-2
+- Fixed pre scriptle failure during upgrades (bz 507364)
+- Corrected the usage info to match what the rpcbind man
+    page says. (bz 466332)
+- Correct package issues (bz 503508)
+
+* Fri May 29 2009 Steve Dickson <steved@redhat.com> - 0.2.0-1
+- Updated to latest upstream release: 0.2.0
+
+* Tue May 19 2009 Tom "spot" Callaway <tcallawa@redhat.com> - 0.1.7-3
+- Replace the Sun RPC license with the BSD license, with the explicit permission of Sun Microsystems
+
+* Wed Feb 25 2009 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.1.7-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
+
+* Wed Nov 19 2008 Steve Dickson <steved@redhat.com>  0.1.7-1
+- Update to latest upstream release: 0.1.7
+
+* Tue Sep 30 2008 Steve Dickson <steved@redhat.com>  0.1.6-3
+- Fixed a typo in the rpcbind.init script that stop warm starts
+  from happening with conrestarts
+- Fixed scriptlet failure (bz 462533)
+
+* Tue Sep 16 2008 Steve Dickson <steved@redhat.com> 0.1.6-2
+- Added usptream patches 01 thru 03 that do:
+    * Introduce helpers for ipprot/netid mapping
+    * Change how we decide on the netids to use for portmap
+    * Simplify port live check in pmap_svc.c
+
+* Wed Jul  9 2008 Steve Dickson <steved@redhat.com> 0.1.6-1
+- Updated to latest upstream release 0.1.6
+
+* Wed Jul  2 2008 Steve Dickson <steved@redhat.com> 0.1.5-5
+- Fixed SYNOPSIS section in the rpcinfo man page (bz 453729)
+
+* Fri Jun 27 2008 Steve Dickson <steved@redhat.com> 0.1.5-4
+- Removed the documentation about the non-existent 
+  '-L' flag (bz 446915)
+
+* Fri Jun 27 2008 Steve Dickson <steved@redhat.com> 0.1.5-3
+- Set password and service lookups to be local (bz 447092)
+
+* Mon Jun 23 2008 Steve Dickson <steved@redhat.com> 0.1.5-2
+- rpcbind needs to downgrade to non-priviledgied group.
+
+* Mon Jun 23 2008 Steve Dickson <steved@redhat.com> 0.1.5-1
+- Updated to latest upstream release 0.1.5
+
+* Mon Feb 11 2008 Steve Dickson <steved@redhat.com> 0.1.4-14
+- Fixed a warning in pmap_svc.c
+- Cleaned up warmstarts so uid are longer needed, also
+  changed condrestarts to use warmstarts. (bz 428496)
+
+* Thu Jan 24 2008 Steve Dickson <steved@redhat.com> 0.1.4-13
+- Fixed connectivity with Mac OS clients by making sure handle_reply()
+  sets the correct fromlen in its recvfrom() call (bz 244492)
+
+* Mon Dec 17 2007 Steve Dickson <steved@redhat.com> 0.1.4-12
+- Changed is_loopback() and check_access() see if the calling
+  address is an address on a local interface, just not a loopback
+  address (bz 358621).
+
+* Wed Oct 17 2007 Steve Dickson <steved@redhat.com> 0.1.4-11
+- Reworked logic in initscript so the correct exit is 
+  used when networking does not exist or is set up
+  incorrectly.
+
+* Tue Oct 16 2007 Steve Dickson <steved@redhat.com> 0.1.4-10
+- Corrected a typo in the initscript from previous 
+  commit.
+
+* Mon Oct 15 2007 Steve Dickson <steved@redhat.com> 0.1.4-9
+- Fixed typo in Summary (bz 331811)
+- Corrected init script (bz 247046)
+
+* Sat Sep 15 2007 Steve Dickson <steved@redhat.com> 0.1.4-8
+- Fixed typo in init script (bz 248285)
+- Added autoconf rules to turn on secure host checking
+  via libwrap. Also turned on host check by default (bz 248284)
+- Changed init script to start service in runlevel 2 (bz 251568)
+- Added a couple missing Requires(pre) (bz 247134)
+
+* Fri May 25 2007 Steve Dickson <steved@redhat.com> 0.1.4-7
+- Fixed condrestarts (bz 241332)
+
+* Tue May 22 2007 Steve Dickson <steved@redhat.com> 0.1.4-6
+- Fixed an ipv6 related segfault on startup (bz 240873)
+
+* Wed Apr 18 2007 Steve Dickson <steved@redhat.com> 0.1.4-5
+- Added dependency on setup which contains the correct
+  rpcbind /etc/service entry which in turns stops 
+  rpcbind from haning when NIS is enabled. (bz 236865)
+
+* Wed Apr 11 2007 Jeremy Katz <katzj@redhat.com> - 0.1.4-4
+- change man-pages requires into a conflicts as we don't have to have 
+  man-pages installed, but if we do, we need the newer version
+
+* Fri Apr  6 2007 Steve Dickson <steved@redhat.com> 0.1.4-3
+- Fixed the Provides and Obsoletes statments to correctly
+  obsolete the portmap package.
+* Tue Apr  3 2007 Steve Dickson <steved@redhat.com> 0.1.4-2
+- Added dependency on glibc-common which allows the
+  rpcinfo command to be installed in the correct place.
+- Added dependency on man-pages so the rpcinfo man 
+  pages don't conflict.
+- Added the creation of /var/lib/rpcbind which will be
+  used to store state files.
+- Make rpcbind run with the 'rpc' uid/gid when it exists.
+
+* Wed Feb 21 2007 Steve Dickson <steved@redhat.com> 0.1.4-1
+- Initial commit
+- Spec reviewed (bz 228894)
+- Added the Provides/Obsoletes which should
+  cause rpcbind to replace portmapper