From 6aee6d7f3b6628f5161d5bf9795ab53d52fa1819 Mon Sep 17 00:00:00 2001 From: Petr Stodulka Date: Fri, 10 Mar 2023 13:34:41 +0100 Subject: [PATCH 02/30] Update codespell ignorelist: couldn,repositor The new version of codespell contains additional "typos" for the detection in the dictionary, which produces FP fails in tests as typos are detected also in cases like: couldn\'t repositor{suffix} etc. For now, we will just update the ignorelist, but in future it would be ideal to not generate such cases. Doing differences between singular/plural is not providing big benefit in report. Escaping is not so problematic I would say, but in case of issues, we could just switch to longer form - like "could not". But there is no beenfit to update the existing code now, so let's focus in future on better texts and keep the existing strings as they are until they are reworded due to additional wanted changes (I mean, if there is any additional reason in future to change them). FYI: https://github.com/codespell-project/codespell/issues/2786 --- .github/workflows/codespell.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/codespell.yml b/.github/workflows/codespell.yml index e7532d98..681669ab 100644 --- a/.github/workflows/codespell.yml +++ b/.github/workflows/codespell.yml @@ -17,7 +17,7 @@ jobs: - uses: actions/checkout@v3 - uses: codespell-project/actions-codespell@master with: - ignore_words_list: ro,fo + ignore_words_list: ro,fo,couldn,repositor skip: "./repos/system_upgrade/common/actors/storagescanner/tests/files/mounts,\ ./repos/system_upgrade/el7toel8/actors/networkmanagerreadconfig/tests/files/nm_cfg_file_error,\ ./repos/system_upgrade/common/actors/scancpu/tests/files/lscpu_s390x" -- 2.40.1