From 73d2f315114c05c1385c854da3b560be506479d6 Mon Sep 17 00:00:00 2001 From: Tomas Fratrik Date: Mon, 18 Aug 2025 11:09:30 +0200 Subject: [PATCH 38/55] pylint: enable useless-object-inheritance Jira: RHELMISC-16038 --- .pylintrc | 1 - commands/upgrade/breadcrumbs.py | 2 +- .../tests/unit_test_addupgradebootentry.py | 4 ++-- .../adjustlocalrepos/tests/test_adjustlocalrepos.py | 4 ++-- .../tests/unit_test_applytransactionworkarounds.py | 2 +- .../actors/biosdevname/tests/test_biosdevname.py | 6 +++--- .../tests/unit_test_checkbootavailspace.py | 2 +- .../actors/checksaphana/tests/test_checksaphana.py | 6 +++--- .../checktargetrepos/tests/test_checktargetrepos.py | 2 +- .../tests/test_convertgrubenvtofile.py | 2 +- .../scanhybridimage/tests/test_scanhybridimage.py | 2 +- .../tests/test_enablerhsmtargetrepos.py | 4 ++-- ...aultboot_forcedefaultboottotargetkernelversion.py | 2 +- .../tests/test_targetinitramfsgenerator.py | 2 +- .../tests/unit_test_upgradeinitramfsgenerator.py | 6 +++--- .../tests/test_kernelcmdlineconfig.py | 2 +- .../tests/test_image_generation.py | 2 +- .../tests/test_livemode_userspace_modifications.py | 8 ++++---- .../actors/luksscanner/libraries/luksdump_parser.py | 4 ++-- .../actors/luksscanner/tests/test_luksscaner.py | 2 +- .../tests/unit_test_migrateopensslconf.py | 8 ++++---- .../tests/test_persistentnetnames.py | 2 +- .../tests/test_persistentnetnamesinitramfs.py | 2 +- .../libraries/peseventsscanner_repomap.py | 2 +- .../tests/unit_test_removebootfiles.py | 2 +- .../tests/unit_test_removeupgradebootentry.py | 2 +- .../libraries/repositoriesmapping.py | 2 +- .../actors/rpmscanner/tests/test_rpmscanner.py | 2 +- .../tests/unit_test_satellite_upgrader.py | 2 +- .../tests/test_unit_scanclienablerepo.py | 2 +- .../common/actors/scancpu/tests/test_scancpu.py | 2 +- .../tests/test_scancustomrepofile.py | 2 +- ...stalledkernel_scaninstalledtargetkernelversion.py | 2 +- .../actors/scansaphana/tests/test_scansaphana.py | 6 +++--- .../tests/unit_test_selinuxcontentscanner.py | 4 ++-- .../selinuxprepare/tests/unit_test_selinuxprepare.py | 2 +- .../setetcreleasever/tests/test_setetcreleasever.py | 2 +- .../libraries/setuptargetrepos_repomap.py | 2 +- .../storagescanner/tests/unit_test_storagescanner.py | 4 ++-- .../tests/test_checksystemdbrokensymlinks.py | 2 +- .../tests/test_repairsystemdsymlinks.py | 2 +- .../tests/test_scansystemdsource.py | 2 +- .../tests/test_scansystemdtarget.py | 2 +- .../tests/test_setsystemdservicesstate.py | 2 +- .../actors/systemfacts/tests/test_systemfacts.py | 4 ++-- .../systemfacts/tests/test_systemfacts_grub.py | 2 +- .../systemfacts/tests/test_systemfacts_selinux.py | 2 +- .../targetuserspacecreator/libraries/userspacegen.py | 2 +- .../tests/unit_test_targetuserspacecreator.py | 4 ++-- .../tests/test_trustedgpgkeys.py | 2 +- .../updategrubcore/tests/test_updategrubcore.py | 2 +- .../tests/unit_test_verifycheckresults.py | 2 +- .../xfsinfoscanner/tests/unit_test_xfsinfoscanner.py | 2 +- repos/system_upgrade/common/libraries/grub.py | 4 ++-- repos/system_upgrade/common/libraries/kernel.py | 2 +- repos/system_upgrade/common/libraries/mounting.py | 12 ++++++------ .../system_upgrade/common/libraries/multipathutil.py | 2 +- repos/system_upgrade/common/libraries/rhui.py | 8 ++++---- repos/system_upgrade/common/libraries/rpms.py | 2 +- .../common/libraries/tests/test_grub.py | 2 +- .../common/libraries/tests/test_mdraid.py | 2 +- .../tests/test_persistentnetnames_library.py | 4 ++-- .../common/libraries/tests/test_rhsm.py | 2 +- repos/system_upgrade/common/libraries/testutils.py | 8 ++++---- .../tests/test_addarmbootloaderworkaround.py | 2 +- .../tests/test_ensurevalidgrubcfghybrid.py | 2 +- .../tests/test_grub2mkconfigonppc64.py | 4 ++-- .../tests/test_opensshdropindirectory_prepend.py | 2 +- .../opensslproviders/tests/test_add_provider.py | 2 +- .../tests/unit_test_scanblacklistca.py | 4 ++-- .../actors/sssdfacts/libraries/sssdfacts8to9.py | 2 +- 71 files changed, 107 insertions(+), 108 deletions(-) diff --git a/.pylintrc b/.pylintrc index 15a69461..d98ab151 100644 --- a/.pylintrc +++ b/.pylintrc @@ -44,7 +44,6 @@ disable= too-many-lines, # we do not want to take care about that one too-many-positional-arguments, # we cannot set yet max-possitional-arguments unfortunately # new for python3 version of pylint - useless-object-inheritance, unnecessary-pass, invalid-envvar-default, # pylint3 warnings envvar returns str/none by default bad-option-value, # python 2 doesn't have import-outside-toplevel, but in some case we need to import outside toplevel diff --git a/commands/upgrade/breadcrumbs.py b/commands/upgrade/breadcrumbs.py index 3a3dcde3..1a90c143 100644 --- a/commands/upgrade/breadcrumbs.py +++ b/commands/upgrade/breadcrumbs.py @@ -36,7 +36,7 @@ def _flattened(d): return dict(items) -class _BreadCrumbs(object): +class _BreadCrumbs: def __init__(self, activity): self._crumbs = { 'activity': activity, diff --git a/repos/system_upgrade/common/actors/addupgradebootentry/tests/unit_test_addupgradebootentry.py b/repos/system_upgrade/common/actors/addupgradebootentry/tests/unit_test_addupgradebootentry.py index e5f632bc..7341602b 100644 --- a/repos/system_upgrade/common/actors/addupgradebootentry/tests/unit_test_addupgradebootentry.py +++ b/repos/system_upgrade/common/actors/addupgradebootentry/tests/unit_test_addupgradebootentry.py @@ -24,7 +24,7 @@ from leapp.models import ( CUR_DIR = os.path.dirname(os.path.abspath(__file__)) -class run_mocked(object): +class run_mocked: def __init__(self): self.args = [] @@ -32,7 +32,7 @@ class run_mocked(object): self.args.append(args) -class write_to_file_mocked(object): +class write_to_file_mocked: def __init__(self): self.content = None diff --git a/repos/system_upgrade/common/actors/adjustlocalrepos/tests/test_adjustlocalrepos.py b/repos/system_upgrade/common/actors/adjustlocalrepos/tests/test_adjustlocalrepos.py index 41cff200..6abf4189 100644 --- a/repos/system_upgrade/common/actors/adjustlocalrepos/tests/test_adjustlocalrepos.py +++ b/repos/system_upgrade/common/actors/adjustlocalrepos/tests/test_adjustlocalrepos.py @@ -83,7 +83,7 @@ def test_adjust_local_file_url(repo_file_line, expected_adjusted_repo_file_line) assert adjusted_repo_file_line == expected_adjusted_repo_file_line -class MockedFileDescriptor(object): +class MockedFileDescriptor: def __init__(self, repo_file, expected_new_repo_file): self.repo_file = repo_file @@ -113,7 +113,7 @@ class MockedFileDescriptor(object): assert expected_repo_file_contents == new_contents -class MockedContext(object): +class MockedContext: def __init__(self, repo_contents, expected_repo_contents): self.repo_contents = repo_contents diff --git a/repos/system_upgrade/common/actors/applytransactionworkarounds/tests/unit_test_applytransactionworkarounds.py b/repos/system_upgrade/common/actors/applytransactionworkarounds/tests/unit_test_applytransactionworkarounds.py index 8fe33645..369514fc 100644 --- a/repos/system_upgrade/common/actors/applytransactionworkarounds/tests/unit_test_applytransactionworkarounds.py +++ b/repos/system_upgrade/common/actors/applytransactionworkarounds/tests/unit_test_applytransactionworkarounds.py @@ -18,7 +18,7 @@ class ShowMessageCurrentActorMocked(CurrentActorMocked): self._show_messages.append(message) -class MockedNotIsolatedActions(object): +class MockedNotIsolatedActions: def __init__(self): self.called = 0 self.args = None diff --git a/repos/system_upgrade/common/actors/biosdevname/tests/test_biosdevname.py b/repos/system_upgrade/common/actors/biosdevname/tests/test_biosdevname.py index c60aa7a4..427eea54 100644 --- a/repos/system_upgrade/common/actors/biosdevname/tests/test_biosdevname.py +++ b/repos/system_upgrade/common/actors/biosdevname/tests/test_biosdevname.py @@ -9,7 +9,7 @@ from leapp.libraries.stdlib import api from leapp.models import Interface, PCIAddress -class LoggerMocked(object): +class LoggerMocked: def __init__(self): self.infomsg = None @@ -32,12 +32,12 @@ def test_biosdevname_enabled(monkeypatch): assert not biosdevname.is_biosdevname_disabled() -class pyudev_enum_mock(object): +class pyudev_enum_mock: def __init__(self, vendor): self.vendor = vendor def match_sys_name(self, _): - class dev(object): + class dev: attributes = {'sys_vendor': self.vendor} return [dev()] diff --git a/repos/system_upgrade/common/actors/checkbootavailspace/tests/unit_test_checkbootavailspace.py b/repos/system_upgrade/common/actors/checkbootavailspace/tests/unit_test_checkbootavailspace.py index 094164c7..fbcd0820 100644 --- a/repos/system_upgrade/common/actors/checkbootavailspace/tests/unit_test_checkbootavailspace.py +++ b/repos/system_upgrade/common/actors/checkbootavailspace/tests/unit_test_checkbootavailspace.py @@ -10,7 +10,7 @@ from leapp.libraries.common.testutils import create_report_mocked from leapp.utils.report import is_inhibitor -class fake_get_avail_bytes_on_boot(object): +class fake_get_avail_bytes_on_boot: def __init__(self, size): self.size = size diff --git a/repos/system_upgrade/common/actors/checksaphana/tests/test_checksaphana.py b/repos/system_upgrade/common/actors/checksaphana/tests/test_checksaphana.py index 1e43f403..29e9c930 100644 --- a/repos/system_upgrade/common/actors/checksaphana/tests/test_checksaphana.py +++ b/repos/system_upgrade/common/actors/checksaphana/tests/test_checksaphana.py @@ -97,7 +97,7 @@ def _parse_manifest_data(manifest): return result -class MockSapHanaInstanceInfo(object): +class MockSapHanaInstanceInfo: def __init__(self, name, number, path, admin, manifest_data, running=True): self.manifest = _parse_manifest_data(manifest_data) self.name = name @@ -118,7 +118,7 @@ def _gen_instance_info(name, manifest_data, index, running=True): ) -class MockSapHanaInfo(object): +class MockSapHanaInfo: def __init__(self, v1names, v2names, v2lownames, running=None): self.installed = bool(v1names or v2names or v2lownames) self.running = running if running is not None else self.installed @@ -151,7 +151,7 @@ def _consume_mock_sap_hana_info(v1names=(), v2names=(), v2lownames=(), running=T return _consume -class MockSAPHanaVersionInstance(object): +class MockSAPHanaVersionInstance: def __init__(self, major, rev, patchlevel): self.name = "TestName" diff --git a/repos/system_upgrade/common/actors/checktargetrepos/tests/test_checktargetrepos.py b/repos/system_upgrade/common/actors/checktargetrepos/tests/test_checktargetrepos.py index e055b3a6..dfe5d06a 100644 --- a/repos/system_upgrade/common/actors/checktargetrepos/tests/test_checktargetrepos.py +++ b/repos/system_upgrade/common/actors/checktargetrepos/tests/test_checktargetrepos.py @@ -16,7 +16,7 @@ from leapp.utils.deprecation import suppress_deprecation from leapp.utils.report import is_inhibitor -class MockedConsume(object): +class MockedConsume: def __init__(self, *args): self._msgs = [] for arg in args: diff --git a/repos/system_upgrade/common/actors/cloud/convertgrubenvtofile/tests/test_convertgrubenvtofile.py b/repos/system_upgrade/common/actors/cloud/convertgrubenvtofile/tests/test_convertgrubenvtofile.py index c4534bd6..257060cc 100644 --- a/repos/system_upgrade/common/actors/cloud/convertgrubenvtofile/tests/test_convertgrubenvtofile.py +++ b/repos/system_upgrade/common/actors/cloud/convertgrubenvtofile/tests/test_convertgrubenvtofile.py @@ -14,7 +14,7 @@ def raise_call_error(args=None): ) -class run_mocked(object): +class run_mocked: def __init__(self, raise_err=False): self.called = 0 self.args = [] diff --git a/repos/system_upgrade/common/actors/cloud/scanhybridimage/tests/test_scanhybridimage.py b/repos/system_upgrade/common/actors/cloud/scanhybridimage/tests/test_scanhybridimage.py index a0f6fd4c..660a1382 100644 --- a/repos/system_upgrade/common/actors/cloud/scanhybridimage/tests/test_scanhybridimage.py +++ b/repos/system_upgrade/common/actors/cloud/scanhybridimage/tests/test_scanhybridimage.py @@ -36,7 +36,7 @@ def raise_call_error(args=None): ) -class run_mocked(object): +class run_mocked: def __init__(self, hypervisor='', raise_err=False): self.hypervisor = hypervisor self.called = 0 diff --git a/repos/system_upgrade/common/actors/enablerhsmtargetrepos/tests/test_enablerhsmtargetrepos.py b/repos/system_upgrade/common/actors/enablerhsmtargetrepos/tests/test_enablerhsmtargetrepos.py index 12d53d26..f7b3f34a 100644 --- a/repos/system_upgrade/common/actors/enablerhsmtargetrepos/tests/test_enablerhsmtargetrepos.py +++ b/repos/system_upgrade/common/actors/enablerhsmtargetrepos/tests/test_enablerhsmtargetrepos.py @@ -13,7 +13,7 @@ from leapp.models import EnvVar, UsedTargetRepositories, UsedTargetRepository def not_isolated_actions(raise_err=False): commands_called = [] - class MockNotIsolatedActions(object): + class MockNotIsolatedActions: def __init__(self, base_dir=None): pass @@ -33,7 +33,7 @@ def raise_call_error(args=None): ) -class run_mocked(object): +class run_mocked: def __init__(self, raise_err=False): self.called = 0 self.args = [] diff --git a/repos/system_upgrade/common/actors/forcedefaultboottotargetkernelversion/tests/test_forcedefaultboot_forcedefaultboottotargetkernelversion.py b/repos/system_upgrade/common/actors/forcedefaultboottotargetkernelversion/tests/test_forcedefaultboot_forcedefaultboottotargetkernelversion.py index b903df45..a39e29a7 100644 --- a/repos/system_upgrade/common/actors/forcedefaultboottotargetkernelversion/tests/test_forcedefaultboot_forcedefaultboottotargetkernelversion.py +++ b/repos/system_upgrade/common/actors/forcedefaultboottotargetkernelversion/tests/test_forcedefaultboot_forcedefaultboottotargetkernelversion.py @@ -69,7 +69,7 @@ initrd=/boot/initramfs-{kernel_version}.img ''' -class MockedRun(object): +class MockedRun: def __init__(self, case): self.case = case self.called_setdefault = False diff --git a/repos/system_upgrade/common/actors/initramfs/targetinitramfsgenerator/tests/test_targetinitramfsgenerator.py b/repos/system_upgrade/common/actors/initramfs/targetinitramfsgenerator/tests/test_targetinitramfsgenerator.py index b4c9dd89..4df9a485 100644 --- a/repos/system_upgrade/common/actors/initramfs/targetinitramfsgenerator/tests/test_targetinitramfsgenerator.py +++ b/repos/system_upgrade/common/actors/initramfs/targetinitramfsgenerator/tests/test_targetinitramfsgenerator.py @@ -33,7 +33,7 @@ def raise_call_error(args=None): }) -class RunMocked(object): +class RunMocked: def __init__(self, raise_err=False): self.called = 0 diff --git a/repos/system_upgrade/common/actors/initramfs/upgradeinitramfsgenerator/tests/unit_test_upgradeinitramfsgenerator.py b/repos/system_upgrade/common/actors/initramfs/upgradeinitramfsgenerator/tests/unit_test_upgradeinitramfsgenerator.py index 8408233e..185cd4f0 100644 --- a/repos/system_upgrade/common/actors/initramfs/upgradeinitramfsgenerator/tests/unit_test_upgradeinitramfsgenerator.py +++ b/repos/system_upgrade/common/actors/initramfs/upgradeinitramfsgenerator/tests/unit_test_upgradeinitramfsgenerator.py @@ -82,7 +82,7 @@ def gen_UDM_list(data): return [UpgradeDracutModule(name=i[0], module_path=i[1]) for i in data] -class MockedContext(object): +class MockedContext: def __init__(self): self.called_copy_from = [] self.called_copytree_from = [] @@ -174,7 +174,7 @@ def test_copy_boot_files(monkeypatch, arch): assert actual_boot_content == bootc -class MockedCopyArgs(object): +class MockedCopyArgs: def __init__(self): self.args = None @@ -250,7 +250,7 @@ def test_prepare_userspace_for_initram(monkeypatch, adjust_cwd, input_msgs, pkgs assert _sort_files(upgradeinitramfsgenerator._copy_files.args[1]) == _files -class MockedGetFspace(object): +class MockedGetFspace: def __init__(self, space): self.space = space diff --git a/repos/system_upgrade/common/actors/kernelcmdlineconfig/tests/test_kernelcmdlineconfig.py b/repos/system_upgrade/common/actors/kernelcmdlineconfig/tests/test_kernelcmdlineconfig.py index e5759a7b..b7e51833 100644 --- a/repos/system_upgrade/common/actors/kernelcmdlineconfig/tests/test_kernelcmdlineconfig.py +++ b/repos/system_upgrade/common/actors/kernelcmdlineconfig/tests/test_kernelcmdlineconfig.py @@ -34,7 +34,7 @@ SAMPLE_GRUBBY_INFO_OUTPUT = TEMPLATE_GRUBBY_INFO_OUTPUT.format(SAMPLE_KERNEL_ARG # pylint: enable=E501 -class MockedRun(object): +class MockedRun: def __init__(self, outputs=None): """ Mock stdlib.run(). diff --git a/repos/system_upgrade/common/actors/livemode/liveimagegenerator/tests/test_image_generation.py b/repos/system_upgrade/common/actors/livemode/liveimagegenerator/tests/test_image_generation.py index 16ae0a09..e3ddce48 100644 --- a/repos/system_upgrade/common/actors/livemode/liveimagegenerator/tests/test_image_generation.py +++ b/repos/system_upgrade/common/actors/livemode/liveimagegenerator/tests/test_image_generation.py @@ -68,7 +68,7 @@ def test_generate_live_image_if_enabled(monkeypatch, livemode_config, should_pro actor_mock = CurrentActorMocked(msgs=messages) monkeypatch.setattr(api, 'current_actor', actor_mock) - class NspawnMock(object): + class NspawnMock: def __init__(self, *args, **kwargs): pass diff --git a/repos/system_upgrade/common/actors/livemode/modify_userspace_for_livemode/tests/test_livemode_userspace_modifications.py b/repos/system_upgrade/common/actors/livemode/modify_userspace_for_livemode/tests/test_livemode_userspace_modifications.py index 58046b61..e890f45a 100644 --- a/repos/system_upgrade/common/actors/livemode/modify_userspace_for_livemode/tests/test_livemode_userspace_modifications.py +++ b/repos/system_upgrade/common/actors/livemode/modify_userspace_for_livemode/tests/test_livemode_userspace_modifications.py @@ -26,7 +26,7 @@ _LiveModeConfig = functools.partial(LiveModeConfig, squashfs_fullpath='