mirror of
https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git
synced 2024-09-12 11:27:21 +00:00
This adds a new script - cleanup-needles.py - to use for cleaning up old needles. It has to be used in conjunction with a database query; the comment at the top explains how to do that query and export the needed information. It produces a git commit with needles that haven't matched since a certain date (specified in the sql query) removed, subject to a 'keeplist' of needles we keep even if they seem to be old. I also enhanced check-needles.py to check for cases where tests seem to be trying to match a tag we have no needles for. This was necessary to find cases where the cleanup script was too aggressive (i.e. the things that wound up in the 'keeplist'), but it also turned out to find quite a lot of cases where the code really *was* looking for a needle that had gone in a previous cleanup or that never existed; the commits before this one clean up a lot of those cases. The code to decide which string literals are needle tags is pretty dumb and hacky and needs some manual cueing sometimes - that's what the `# testtag` changes in this commit are for. Making it smarter would probably require this script to get a lot more complicated and either incorporate or become a tokenizer, which I don't really want to do. Signed-off-by: Adam Williamson <awilliam@redhat.com>
146 lines
5.4 KiB
Perl
146 lines
5.4 KiB
Perl
use base "installedtest";
|
|
use strict;
|
|
use testapi;
|
|
use utils;
|
|
use packagetest;
|
|
|
|
sub run {
|
|
my $self = shift;
|
|
my $desktop = get_var('DESKTOP');
|
|
my $relnum = get_release_number;
|
|
# use a tty console for repo config and package prep
|
|
$self->root_console(tty => 3);
|
|
assert_script_run 'dnf config-manager --set-disabled updates-testing';
|
|
# for update tests, disable koji-rawhide at this point, otherwise
|
|
# gnome-software will complain about things being unsigned even
|
|
# though the repo has gpgcheck=0
|
|
if (get_var("ADVISORY_OR_TASK") && get_var("VERSION") eq get_var("RAWREL")) {
|
|
assert_script_run 'dnf config-manager --set-disabled koji-rawhide';
|
|
}
|
|
prepare_test_packages;
|
|
# get back to the desktop
|
|
desktop_vt;
|
|
|
|
# run the updater
|
|
if ($desktop eq 'kde') {
|
|
menu_launch_type('discover');
|
|
# Wait for it to run and maximize it to make sure we see the
|
|
# Updates entry
|
|
assert_screen('discover_runs');
|
|
wait_still_screen 2;
|
|
wait_screen_change { send_key "super-pgup"; };
|
|
wait_still_screen 2;
|
|
}
|
|
else {
|
|
# this launches GNOME Software on GNOME, dunno for any other
|
|
# desktop yet
|
|
sleep 3;
|
|
menu_launch_type('update');
|
|
}
|
|
# GNOME Software 44+ has a 3rd party source pop-up, get rid of it
|
|
# if it shows up (but don't fail if it doesn't, we're not testing that)
|
|
if ($desktop eq 'gnome' && check_screen 'gnome_software_ignore', 10) {
|
|
wait_still_screen 3;
|
|
# match again as the dialog may have moved a bit
|
|
assert_and_click 'gnome_software_ignore';
|
|
}
|
|
# go to the 'update' interface. We may be waiting some time at a
|
|
# 'Software catalog is being loaded' screen.
|
|
for my $n (1 .. 5) {
|
|
last if (check_screen 'desktop_package_tool_update', 120);
|
|
mouse_set 10, 10;
|
|
mouse_hide;
|
|
}
|
|
assert_and_click 'desktop_package_tool_update';
|
|
# wait for things to settle if e.g. GNOME is refreshing
|
|
wait_still_screen 5, 90;
|
|
# we always want to refresh to make sure we get the prepared update
|
|
assert_and_click 'desktop_package_tool_update_refresh', timeout => 120;
|
|
# for GNOME, the apply/download buttons remain visible for a long
|
|
# time, annoyingly. So let's actually watch the 'refreshing' state
|
|
# till it goes away
|
|
if ($desktop eq 'gnome') {
|
|
assert_screen 'desktop_package_tool_update_refreshing';
|
|
# now wait for it to go away
|
|
for my $n (1 .. 30) {
|
|
last unless (check_screen 'desktop_package_tool_update_refreshing', 6);
|
|
# if we matched, we likely matched *immediately*, so sleep
|
|
# the other five seconds
|
|
sleep 5;
|
|
}
|
|
sleep 3;
|
|
}
|
|
else {
|
|
# just wait a bit to make sure the UI clears to a 'refreshing'
|
|
# state
|
|
sleep 5;
|
|
}
|
|
|
|
my $tags = ['desktop_package_tool_update_download', 'desktop_package_tool_update_apply']; # testtag
|
|
|
|
# Apply updates, moving the mouse every two minutes to avoid the
|
|
# idle screen blank kicking in. Depending on whether this is KDE
|
|
# or GNOME and what Fedora release, we may see 'apply' right away,
|
|
# or 'download' then 'apply'
|
|
for (my $n = 1; $n < 6; $n++) {
|
|
if (check_screen $tags, 120) {
|
|
# if we see 'apply', we're done here, quit out of the loop
|
|
last if (match_has_tag 'desktop_package_tool_update_apply');
|
|
# if we see 'download', let's hit it, and continue waiting
|
|
# for apply (only)
|
|
wait_screen_change { click_lastmatch; };
|
|
$n -= 1 if ($n > 1);
|
|
$tags = ['desktop_package_tool_update_apply'];
|
|
next;
|
|
}
|
|
# move the mouse to stop the screen blanking on idle
|
|
mouse_set 10, 10;
|
|
mouse_hide;
|
|
}
|
|
# Magic wait, clicking this right after the last click sometimes
|
|
# goes wrong
|
|
wait_still_screen 5;
|
|
assert_and_click 'desktop_package_tool_update_apply';
|
|
# on GNOME, wait for reboots.
|
|
if ($desktop eq 'gnome') {
|
|
# handle reboot confirm screen which pops up when user is
|
|
# logged in (but don't fail if it doesn't as we're not testing
|
|
# that)
|
|
if (check_screen 'gnome_reboot_confirm', 15) {
|
|
send_key 'tab';
|
|
send_key 'ret';
|
|
}
|
|
boot_to_login_screen;
|
|
}
|
|
elsif ($desktop eq 'kde') {
|
|
# KDE does offline updates now, we have to trigger the reboot
|
|
# FIXME: also sometimes the update apply button just doesn't
|
|
# work, so keep clicking till it does:
|
|
# https://bugzilla.redhat.com/show_bug.cgi?id=1943943
|
|
for my $n (1 .. 10) {
|
|
sleep 2;
|
|
assert_screen ['kde_offline_update_reboot', 'desktop_package_tool_update_apply'];
|
|
# break out if we reached the reboot button
|
|
last if (match_has_tag 'kde_offline_update_reboot');
|
|
# otherwise, try refresh and apply or reboot
|
|
assert_and_click 'desktop_package_tool_update_refresh';
|
|
assert_screen ['kde_offline_update_reboot', 'desktop_package_tool_update_apply'];
|
|
last if (match_has_tag 'kde_offline_update_reboot');
|
|
click_lastmatch;
|
|
}
|
|
assert_and_click 'kde_offline_update_reboot';
|
|
boot_to_login_screen;
|
|
}
|
|
# back to console to verify updates
|
|
$self->root_console(tty => 3);
|
|
verify_updated_packages;
|
|
}
|
|
|
|
sub test_flags {
|
|
return {fatal => 1};
|
|
}
|
|
|
|
1;
|
|
|
|
# vim: set sw=4 et:
|