srbala
/
os-autoinst-distri-fedora
mirror of https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git
1
0
Fork 0
Code Issues Releases Activity
os-autoinst-distri-fedora/tests
History
Adam Williamson dcb68d93c8 drop our implementation of script_run in favour of os-autoinst 
Summary:
os-autoinst implements `script_run` itself now, we aren't
required to implement it ourselves any more. os-autoinst's
implementation is better than ours, as it allows for verifying
the script actually ran (via the redirect-output-to-serial-
console trick).

So this drops our implementation so we'll just use the upstream
one. Where I judged we don't want to bother with the 'check
the command actually ran' feature I've adjusted our direct
`script_run` calls to pass a wait time of 0, which skips the
'wait for command to run' stuff entirely and just does a simple
'type the string and hit enter'.

Because of how the inheritance works, our `assert_script_run`
calls already used the os-autoinst `script_run`, rather than
the one from our distribution.

This should prevent `prepare_test_packages` sometimes going
wrong right after removing the python3-kickstart package, as
we'll properly wait for that removal to complete now (before
we weren't, we'd just start typing the next command while it
was still running, which could result in lost keypresses).

Test Plan:
Check all tests still run OK (I've tried this on
staging and it seems fine).

Reviewers: jskladan, garretraziel

Reviewed By: garretraziel

Subscribers: tflink

Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1034
 		2016-10-20 09:24:48 -07:00
..
_boot_to_anaconda.pm make sure we get logs from failed kickstart installs 2016-09-20 10:51:51 -07:00
_check_install_source.pm add NFS tests (and DHCP/DNS in the support server) 2016-06-13 08:42:30 -07:00
_console_shutdown.pm redo console_login with multiple matches, move to main_common 2016-09-30 08:42:45 -07:00
_console_wait_login.pm redo console_login with multiple matches, move to main_common 2016-09-30 08:42:45 -07:00
_do_install_and_reboot.pm type root password faster on ostree installs 2016-10-13 18:39:33 -07:00
_graphical_wait_login.pm consolidate login waits, use postinstall not entrypoint for base 2016-09-27 11:48:15 -07:00
_network_static.pm try to be safer when typing in X: slower, more checks 2016-09-12 10:24:30 -07:00
_software_selection.pm try to be safer when typing in X: slower, more checks 2016-09-12 10:24:30 -07:00
_support_server.pm support_server: give the DVD copy a bit longer to complete 2016-10-11 18:11:34 -07:00
base_selinux.pm consolidate login waits, use postinstall not entrypoint for base 2016-09-27 11:48:15 -07:00
base_service_manipulation.pm drop our implementation of script_run in favour of os-autoinst 2016-10-20 09:24:48 -07:00
base_services_start.pm consolidate login waits, use postinstall not entrypoint for base 2016-09-27 11:48:15 -07:00
base_update_cli.pm consolidate login waits, use postinstall not entrypoint for base 2016-09-27 11:48:15 -07:00
database_client.pm consolidate login waits, use postinstall not entrypoint for base 2016-09-27 11:48:15 -07:00
desktop_browser.pm consolidate login waits, use postinstall not entrypoint for base 2016-09-27 11:48:15 -07:00
desktop_notifications.pm fix desktop_notifications to use assert_screen not check 2016-09-30 09:21:01 -07:00
desktop_terminal.pm consolidate login waits, use postinstall not entrypoint for base 2016-09-27 11:48:15 -07:00
desktop_update_graphical.pm consolidate login waits, use postinstall not entrypoint for base 2016-09-27 11:48:15 -07:00
disk_custom_btrfs.pm add ext3, btrfs and LVM thin tests, tweaks to custom methods 2015-08-10 11:01:12 -07:00
disk_custom_ext3.pm add ext3, btrfs and LVM thin tests, tweaks to custom methods 2015-08-10 11:01:12 -07:00
disk_custom_iscsi.pm add an iscsi test, and a support_server test to support it 2016-06-09 08:43:46 -07:00
disk_custom_iscsi_postinstall.pm add an iscsi test, and a support_server test to support it 2016-06-09 08:43:46 -07:00
disk_custom_lvmthin.pm add ext3, btrfs and LVM thin tests, tweaks to custom methods 2015-08-10 11:01:12 -07:00
disk_custom_no_swap.pm small fix: wait a sec between clicks of 'Done' in no_swap 2015-08-31 17:02:27 -07:00
disk_custom_software_raid.pm add an iscsi test, and a support_server test to support it 2016-06-09 08:43:46 -07:00
disk_custom_software_raid_postinstall.pm use validate_script_output instead of typing and needles matching 2015-11-04 14:38:36 +01:00
disk_custom_xfs.pm add custom partitioning xfs tests 2015-11-26 13:50:45 +01:00
disk_guided_delete_all.pm add comments and documentation 2015-08-05 08:23:59 +02:00
disk_guided_delete_partial.pm add comments and documentation 2015-08-05 08:23:59 +02:00
disk_guided_delete_partial_postinstall.pm use assert_script_run when possible 2016-01-12 09:27:14 -08:00
disk_guided_empty.pm rename BOOT_UPDATES_IMG_URL to TEST_UPDATES, add GRUBADD 2016-04-08 13:21:29 -07:00
disk_guided_encrypted.pm try to be safer when typing in X: slower, more checks 2016-09-12 10:24:30 -07:00
disk_guided_encrypted_postinstall.pm add encrypted workstation upgrade tests (current and previous) 2016-07-08 08:56:57 -07:00
disk_guided_free_space_postinstall.pm use assert_script_run when possible 2016-01-12 09:27:14 -08:00
disk_guided_multi.pm add an iscsi test, and a support_server test to support it 2016-06-09 08:43:46 -07:00
disk_guided_multi_empty_all.pm add an iscsi test, and a support_server test to support it 2016-06-09 08:43:46 -07:00
disk_guided_multi_empty_all_postinstall.pm use validate_script_output instead of typing and needles matching 2015-11-04 14:38:36 +01:00
disk_guided_multi_postinstall.pm fix server_multi postinstall for disk being virtio 2016-01-27 01:44:20 -08:00
disk_guided_shrink.pm add guided shrink test 2015-09-08 15:54:22 +02:00
disk_guided_shrink_postinstall.pm use assert_script_run when possible 2016-01-12 09:27:14 -08:00
firewall_configured.pm consolidate login waits, use postinstall not entrypoint for base 2016-09-27 11:48:15 -07:00
firewall_disabled.pm consolidate login waits, use postinstall not entrypoint for base 2016-09-27 11:48:15 -07:00
freeipa_client.pm redo console_login with multiple matches, move to main_common 2016-09-30 08:42:45 -07:00
freeipa_password_change.pm redo console_login with multiple matches, move to main_common 2016-09-30 08:42:45 -07:00
freeipa_webui.pm redo console_login with multiple matches, move to main_common 2016-09-30 08:42:45 -07:00
install_arm_image_deployment.pm redo console_login with multiple matches, move to main_common 2016-09-30 08:42:45 -07:00
install_source_graphical.pm try to be safer when typing in X: slower, more checks 2016-09-12 10:24:30 -07:00
install_text.pm fix install_text test's timezone spoke handling 2016-09-13 12:58:22 -07:00
realmd_join_cockpit.pm consolidate login waits, use postinstall not entrypoint for base 2016-09-27 11:48:15 -07:00
realmd_join_sssd.pm consolidate login waits, use postinstall not entrypoint for base 2016-09-27 11:48:15 -07:00
rescue_mode_encrypted.pm add anaconda rescue test on encrypted disk 2016-09-16 14:44:03 +02:00
role_deploy_database_server.pm consolidate login waits, use postinstall not entrypoint for base 2016-09-27 11:48:15 -07:00
role_deploy_domain_controller.pm consolidate login waits, use postinstall not entrypoint for base 2016-09-27 11:48:15 -07:00
server_cockpit_basic.pm consolidate login waits, use postinstall not entrypoint for base 2016-09-27 11:48:15 -07:00
server_cockpit_default.pm consolidate login waits, use postinstall not entrypoint for base 2016-09-27 11:48:15 -07:00
server_firewall_default.pm consolidate login waits, use postinstall not entrypoint for base 2016-09-27 11:48:15 -07:00
uefi_postinstall.pm use assert_script_run when possible 2016-01-12 09:27:14 -08:00
upgrade_postinstall.pm add desktop_terminal test, refactor test loading a bit 2016-05-05 16:39:47 -07:00
upgrade_preinstall.pm drop our implementation of script_run in favour of os-autoinst 2016-10-20 09:24:48 -07:00
upgrade_run.pm use compose repository (not master repo) for most tests 2016-09-01 08:22:59 -07:00