os-autoinst-distri-fedora/lib
Adam Williamson bacb6f1f7b redo console_login with multiple matches, move to main_common
Summary:
Since we can match on multiple needles, we can drop the loop
from console_login and instead do it this way, which is simpler
and should work better on ARM (the timeouts will scale and
allow ARM to be slow here). Also move it to main_common as
there's no logical reason for it to be a class method.

Also remove the `check` arg. `check` was only set to 0 by two
tests, _console_shutdown and anacondatest's _post_fail_hook.

For _console_shutdown, I think I just wanted to give it the
best possible chance of succeeding. But we're really not going
to lose anything significant by checking, the only case where
check=>0 would've helped is if the 'good' needle had stopped
matching, and all sorts of other tests will fail in that case.

anacondatest was only using it to save a screenshot of whatever
was on the tty if it didn't reach a root console, which doesn't
seem that useful, and we'll get screenshots from check_screen
and assert_screen anyway.

Test Plan:
Run all tests, check they behave as expected and
none inappropriately fails on console login.

Reviewers: jskladan, garretraziel

Reviewed By: garretraziel

Subscribers: tflink

Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1016
2016-09-30 08:42:45 -07:00
..
anacondatest.pm redo console_login with multiple matches, move to main_common 2016-09-30 08:42:45 -07:00
fedorabase.pm redo console_login with multiple matches, move to main_common 2016-09-30 08:42:45 -07:00
fedoradistribution.pm try to be safer when typing in X: slower, more checks 2016-09-12 10:24:30 -07:00
freeipa.pm try to be safer when typing in X: slower, more checks 2016-09-12 10:24:30 -07:00
installedtest.pm redo console_login with multiple matches, move to main_common 2016-09-30 08:42:45 -07:00
main_common.pm redo console_login with multiple matches, move to main_common 2016-09-30 08:42:45 -07:00
packagetest.pm lengthen the wait_idle timeout in prepare_test_packages 2016-09-28 18:26:29 -07:00