1
0
mirror of https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git synced 2024-11-03 15:04:22 +00:00
os-autoinst-distri-fedora/lib
Adam Williamson ba90ef631a fix installedtest post-fail hook when no /var/tmp/abrt
Summary:
you can't use validate_script_output like this, it doesn't just
return a bool, it actually kills the test if the output doesn't
validate. So any time we didn't have anything in /var/tmp/abrt,
the post_fail_hook would die at that point and not upload the
contents of /var/log as we wanted it to.

Note that even script_output will kill the test if the return
code is >0. That's OK in this case, but always be careful with
these subroutines.

Test Plan:
Run a test that fails in post-install but doesn't
produce anything in /var/tmp/abrt (you may have to artificially
break something). Check that it now uploads /var/log. I noticed
this while working on FreeIPA tests...

Reviewers: jskladan, garretraziel

Reviewed By: garretraziel

Subscribers: tflink

Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D830
2016-04-27 09:36:28 -07:00
..
anacondatest.pm anaconda crash reporting: update needles, click Report again 2016-03-08 08:10:51 -08:00
fedorabase.pm dump get_release, just use VERSION 2016-02-23 11:08:45 -08:00
fedoradistribution.pm fix some warnings that are shown during test loading 2016-02-10 09:42:56 +01:00
installedtest.pm fix installedtest post-fail hook when no /var/tmp/abrt 2016-04-27 09:36:28 -07:00