mirror of
https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git
synced 2024-11-28 08:33:08 +00:00
e9ce14a891
Summary: I started out wanting to fix an issue I noticed today where graphical upgrade tests were failing because they didn't wait for the graphical login screen properly; the test was sitting at the 'full Fedora logo' state of plymouth for a long time, so the current boot_to_login_screen's wait_still_screen was triggered by it and the function wound up failing on the assert_screen, because it was still some time before the real login screen appeared. So I tweaked the boot_to_login_screen implementation to work slightly differently (look for a login screen match, *then* - if we're dealing with a graphical login - wait_still_screen to defeat the 'old GPU buffer showing login screen' problem and assert the login screen again). But while working on it, I figured we really should consolidate all the various places that handle the bootloader -> login, we were doing it quite differently in all sorts of different places. And as part of that, I converted the base tests to use POSTINSTALL (and thus go through the shared _wait_login tests) instead of handling boot themselves. As part of *that*, I tweaked main.pm to not require all POSTINSTALL tests have the _postinstall suffix on their names, as it really doesn't make sense, and renamed the tests. Test Plan: Run all tests, see if they work. Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1015
37 lines
1.1 KiB
Perl
37 lines
1.1 KiB
Perl
use base "installedtest";
|
|
use strict;
|
|
use testapi;
|
|
use main_common;
|
|
|
|
sub run {
|
|
my $self=shift;
|
|
assert_screen 'graphical_desktop_clean';
|
|
$self->menu_launch_type('terminal');
|
|
wait_still_screen 5;
|
|
# need to be root
|
|
my $rootpass = get_var("ROOT_PASSWORD", "weakpassword");
|
|
type_string "su\n", 20;
|
|
wait_still_screen 3;
|
|
# can't use type_safely for now as current implementation relies
|
|
# on screen change checks, and there is no screen change here
|
|
type_string "$rootpass\n", 1;
|
|
wait_still_screen 3;
|
|
# if we can run something successfully, we're at a console;
|
|
# we're reinventing assert_script_run instead of using it so
|
|
# we can type safely
|
|
type_very_safely "ls && echo 'ls OK' > /dev/ttyS0\n";
|
|
wait_serial "ls OK" || die "terminal command failed";
|
|
}
|
|
|
|
sub test_flags {
|
|
# without anything - rollback to 'lastgood' snapshot if failed
|
|
# 'fatal' - whole test suite is in danger if this fails
|
|
# 'milestone' - after this test succeeds, update 'lastgood'
|
|
# 'important' - if this fails, set the overall state to 'fail'
|
|
return { fatal => 1 };
|
|
}
|
|
|
|
1;
|
|
|
|
# vim: set sw=4 et:
|