mirror of
https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git
synced 2024-11-24 23:03:08 +00:00
b97c019ae9
Summary: T617 makes some good points about the language tags; this is my suggestion for an improvement. It requires a bit of cleverness in unregister_prefix_tags(), but the upshot is that you don't need to know to set any special tags when creating needles, a needle with no language-related tags will be considered as valid for all languages. You have to explicitly add LANGUAGE- tag(s) to a needle for the language filtering to 'kick in' in any way. If a needle has at least one LANGUAGE- tag, it will be filtered unless it has the appropriate tag for the job's specified language (default is still 'english'). With this approach, only needles which we specifically want to *only* match their tagged language(s) need the tags, so we can drop all those -ALL tags. We're using LANGUAGE- instead of ENV-LANGUAGE- now because the ENV- tag names denote tags that are treated slightly specially by openQA, and this is not one. We cannot cleanly use ENV-INSTLANG because openQA has a hardwired default of 'en_US' for that. Test Plan: Check both English and French tests still work as intended. Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D589
18 lines
296 B
JSON
18 lines
296 B
JSON
{
|
|
"area": [
|
|
{
|
|
"xpos": 351,
|
|
"ypos": 406,
|
|
"width": 304,
|
|
"height": 21,
|
|
"type": "match"
|
|
}
|
|
],
|
|
"tags": [
|
|
"anaconda_part_desired_capacity",
|
|
"ENV-DISTRI-fedora",
|
|
"LANGUAGE-english",
|
|
"ENV-FLAVOR-server"
|
|
],
|
|
"properties": []
|
|
} |