mirror of
https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git
synced 2024-12-31 14:43:08 +00:00
56936df7a5
There's this awkward path for the live image install tests on updates. We run the 'are the correct versions of all the packages installed' check on these tests to ensure the right versions actually made it onto the live image. So we don't run `dnf -y update` at the end of repo_setup_updates on that path, because if we did that, even if the packages on the live image were old, we'd update them there and hide the problem. However, this causes a bit of an ordering issue, because in order to set up the advisory repo, we need to install a few packages. What if the update under test includes one of those packages, or a dependency that wasn't already installed? In that case, we wind up with the older stable version of the package (because obviously we can't install the newer version from the advisory repo *before we've set up the advisory repo*), don't update it later, and so the 'correct version' check at the end of the test fails. See: https://openqa.fedoraproject.org/tests/1778707 for a case of this happening with a python-cryptography update. Up till now I was trying to handle this by just updating the specific packages we install, but that doesn't account for *dependencies* of them. I looked down the path of trying to generate a list of all those dependencies and update all of them but it looks a bit mad. So instead let's try this. On that specific path, we'll generate the "all installed packages" list *before* we run repo_setup, so it just doesn't include anything that gets installed during repo_setup. The implementation is a bit icky but not too horrible. We *could* just *always* generate the all installed packages list earlier, but then that would mean we *wouldn't* catch dep issues in this kind of package on the other test paths, whereas currently we do. I don't want to lose that. Signed-off-by: Adam Williamson <awilliam@redhat.com> |
||
|---|---|---|
| .. | ||
| anaconda.pm | ||
| anacondatest.pm | ||
| bugzilla.pm | ||
| cockpit.pm | ||
| fedoradistribution.pm | ||
| freeipa.pm | ||
| installedtest.pm | ||
| modularity.pm | ||
| packagetest.pm | ||
| tapnet.pm | ||
| utils.pm | ||