mirror of
https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git
synced 2025-07-13 17:11:34 +00:00
4781fc28ce
Any of the four might not exist. At least *one* of the four has to exist, but we can't rely on any particular one existing, so we have to be very defensive. The only rule is that at least one out of profiles and groups has to exist after merge. Signed-off-by: Adam Williamson <awilliam@redhat.com>
234 lines
11 KiB
Python
234 lines
11 KiB
Python
# Copyright Red Hat
|
|
#
|
|
# This file is part of os-autoinst-distri-fedora.
|
|
#
|
|
# os-autoinst-distri-fedora is free software; you can redistribute it
|
|
# and/or modify it under the terms of the GNU General Public License
|
|
# as published by the Free Software Foundation, either version 2 of
|
|
# the License, or (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
# Author: Adam Williamson <awilliam@redhat.com>
|
|
|
|
# these are all kinda inappropriate for pytest patterns
|
|
# pylint: disable=no-init, protected-access, no-self-use, unused-argument
|
|
|
|
"""Tests for fifloader.py."""
|
|
|
|
# core imports
|
|
import json
|
|
import os
|
|
import subprocess
|
|
import tempfile
|
|
from unittest import mock
|
|
|
|
# third party imports
|
|
import jsonschema.exceptions
|
|
import pytest
|
|
|
|
# internal imports
|
|
import fifloader
|
|
|
|
DATAPATH = os.path.join(os.path.dirname(os.path.realpath(__file__)), 'data')
|
|
|
|
def _get_merged(input1='templates.fif.json', input2='templates-updates.fif.json'):
|
|
"""Convenience function as multiple tests need to do this."""
|
|
return fifloader.merge_inputs(
|
|
[os.path.join(DATAPATH, input1), os.path.join(DATAPATH, input2)])
|
|
|
|
def test_schema_validate():
|
|
"""Test for schema_validate."""
|
|
# this one has no Flavors and complete Products, to check such a
|
|
# layout matches the 'complete' schema as it should
|
|
with open(os.path.join(DATAPATH, 'templates.complete.fif.json'), 'r') as tempfh:
|
|
tempdata = json.load(tempfh)
|
|
with open(os.path.join(DATAPATH, 'templates-updates.fif.json'), 'r') as updfh:
|
|
updata = json.load(updfh)
|
|
assert fifloader.schema_validate(tempdata, fif=True, state="complete") is True
|
|
assert fifloader.schema_validate(tempdata, fif=True, state="incomplete") is True
|
|
assert fifloader.schema_validate(updata, fif=True, state="incomplete") is True
|
|
with pytest.raises(jsonschema.exceptions.ValidationError):
|
|
fifloader.schema_validate(updata, fif=True, state="complete")
|
|
with pytest.raises(jsonschema.exceptions.ValidationError):
|
|
fifloader.schema_validate(tempdata, fif=False, state="complete")
|
|
with pytest.raises(jsonschema.exceptions.ValidationError):
|
|
fifloader.schema_validate(tempdata, fif=False, state="incomplete")
|
|
# we test successful openQA validation later in test_run
|
|
|
|
# we test merging in both orders, because it can work in one order
|
|
# but be broken in the other
|
|
@pytest.mark.parametrize(
|
|
"input1, input2",
|
|
[
|
|
('templates.fif.json', 'templates-updates.fif.json'),
|
|
('templates-updates.fif.json', 'templates.fif.json'),
|
|
]
|
|
)
|
|
def test_merge_inputs(input1, input2):
|
|
"""Test for merge_inputs."""
|
|
(machines, flavors, products, profiles, pgroups, testsuites, jobtemplates) = _get_merged(
|
|
input1,
|
|
input2
|
|
)
|
|
# a few known attributes of the test data to ensure the merge worked
|
|
assert len(machines) == 2
|
|
assert len(flavors) == 1
|
|
assert len(products) == 4
|
|
assert len(profiles) == 4
|
|
assert len(pgroups) == 3
|
|
assert not jobtemplates
|
|
# testsuite merging is the most complex feature
|
|
# len should be 4 as there is 1 unique suite in each input file,
|
|
# and two defined in both which should be merged
|
|
assert len(testsuites) == 4
|
|
# check the merged suite was merged correctly
|
|
# we should have the profiles and profile groups from *both*
|
|
# input files...
|
|
assert len(testsuites['base_selinux']['profiles']) == 2
|
|
assert len(testsuites['base_selinux']['profile_groups']) == 2
|
|
# ...including when only one file has each attribute...
|
|
assert len(testsuites['base_update_cli']['profile_groups']) == 1
|
|
assert len(testsuites['base_update_cli']['profiles']) == 1
|
|
# and we should still have the settings (note, combining settings
|
|
# is not supported, the last-read settings dict is always used)
|
|
assert len(testsuites['base_selinux']['settings']) == 6
|
|
# check product defaults were merged correctly
|
|
assert products['fedora-Server-dvd-iso-ppc64le-*']['distri'] == 'fedora'
|
|
assert products['fedora-Server-dvd-iso-ppc64le-*']['version'] == '*'
|
|
assert products['fedora-Server-dvd-iso-x86_64-*']['distri'] == 'fedora'
|
|
assert products['fedora-Server-dvd-iso-x86_64-*']['version'] == 'Rawhide'
|
|
|
|
def test_generate_job_templates():
|
|
"""Test for generate_job_templates."""
|
|
(machines, _, products, profiles, pgroups, testsuites, _) = _get_merged()
|
|
templates = fifloader.generate_job_templates(products, profiles, pgroups, testsuites)
|
|
# we should get one template per profile in merged input
|
|
assert len(templates) == 11
|
|
for template in templates:
|
|
assert template['group_name'] in ['fedora', 'Fedora PowerPC', 'Fedora AArch64',
|
|
'Fedora Updates', 'Fedora PowerPC Updates',
|
|
'Fedora AArch64 Updates']
|
|
assert template['machine_name'] in list(machines.keys())
|
|
assert isinstance(template['prio'], int)
|
|
for item in ('arch', 'distri', 'flavor', 'version'):
|
|
assert item in template
|
|
assert template['test_suite_name'] in list(testsuites.keys())
|
|
|
|
# check profile group expansion
|
|
idus = [t for t in templates if t['test_suite_name'] == 'install_default_upload']
|
|
assert len(idus) == 2
|
|
assert {t['machine_name'] for t in idus} == {'ppc64le', '64bit'}
|
|
aboots = [t for t in templates if t['test_suite_name'] == 'base_selinux']
|
|
assert len(aboots) == 4
|
|
assert {t['machine_name'] for t in aboots} == {'ppc64le', '64bit'}
|
|
|
|
def test_reverse_qol():
|
|
"""Test for reverse_qol."""
|
|
(machines, flavors, products, _, _, testsuites, _) = _get_merged()
|
|
(machines, products, testsuites) = fifloader.reverse_qol(machines, flavors, products, testsuites)
|
|
assert isinstance(machines, list)
|
|
assert isinstance(products, list)
|
|
assert isinstance(testsuites, list)
|
|
assert len(machines) == 2
|
|
assert len(products) == 4
|
|
assert len(testsuites) == 3
|
|
settlists = []
|
|
for datatype in (machines, products, testsuites):
|
|
for item in datatype:
|
|
# all items should have one of these
|
|
settlists.append(item['settings'])
|
|
# no items should have these
|
|
assert 'profiles' not in item
|
|
assert 'profile_groups' not in item
|
|
for settlist in settlists:
|
|
assert isinstance(settlist, list)
|
|
for setting in settlist:
|
|
assert list(setting.keys()) == ['key', 'value']
|
|
# check flavor merge worked
|
|
sdixprod = [prod for prod in products if prod["name"] == "fedora-Server-dvd-iso-x86_64-*"][0]
|
|
sdipprod = [prod for prod in products if prod["name"] == "fedora-Server-dvd-iso-ppc64le-*"][0]
|
|
assert sdipprod["settings"] == [
|
|
{"key": "TEST_TARGET", "value": "ISO"},
|
|
{"key": "RETRY", "value": "1"}
|
|
]
|
|
assert sdixprod["settings"] == [
|
|
{"key": "TEST_TARGET", "value": "COMPOSE"},
|
|
{"key": "RETRY", "value": "1"},
|
|
{"key": "QEMURAM", "value": "3072"}
|
|
]
|
|
|
|
def test_parse_args():
|
|
"""Test for parse_args."""
|
|
args = fifloader.parse_args(['-l', '--host', 'https://openqa.example', '--clean', '--update',
|
|
'--loader', '/tmp/newloader', 'foo.json', 'bar.json'])
|
|
assert args.load is True
|
|
assert args.host == 'https://openqa.example'
|
|
assert args.clean is True
|
|
assert args.update is True
|
|
assert args.write is False
|
|
assert args.loader == '/tmp/newloader'
|
|
assert args.files == ['foo.json', 'bar.json']
|
|
args = fifloader.parse_args(['-l', '-w', 'foo.json', 'bar.json'])
|
|
assert args.load is True
|
|
assert not args.host
|
|
assert args.clean is False
|
|
assert args.update is False
|
|
assert args.write is True
|
|
assert args.filename == 'generated.json'
|
|
assert args.loader == '/usr/share/openqa/script/load_templates'
|
|
assert args.files == ['foo.json', 'bar.json']
|
|
args = fifloader.parse_args(['-w', '--filename', 'newout.json', 'foo.json'])
|
|
assert args.load is False
|
|
assert args.write is True
|
|
assert args.filename == 'newout.json'
|
|
assert args.files == ['foo.json']
|
|
|
|
@mock.patch('subprocess.run', autospec=True)
|
|
def test_run(fakerun):
|
|
"Test for run()."""
|
|
# this is testing our little wrapper doesn't fail
|
|
with pytest.raises(SystemExit, match=r".No such file or directory.*"):
|
|
fifloader.run(['-w', 'foobar.fif.json'])
|
|
with pytest.raises(SystemExit, match=r".neither --write nor --load.*"):
|
|
fifloader.run(['--no-validate', 'foo.json'])
|
|
with pytest.raises(SystemExit) as excinfo:
|
|
fifloader.run(['-l'])
|
|
assert "arguments are required: files" in excinfo.message
|
|
with tempfile.NamedTemporaryFile() as tempfh:
|
|
# this will actually do everything and write out template data
|
|
# parsed from the test inputs to the temporary file
|
|
fifloader.run(['-w', '--filename', tempfh.name,
|
|
os.path.join(DATAPATH, 'templates.fif.json'),
|
|
os.path.join(DATAPATH, 'templates-updates.fif.json')])
|
|
written = json.load(tempfh)
|
|
# check written data matches upstream data schema
|
|
assert fifloader.schema_validate(written, fif=False, state="complete") is True
|
|
# test the loader stuff, first with one failure of subprocess.run
|
|
# and success on the second try:
|
|
fakerun.side_effect=[subprocess.CalledProcessError(1, "cmd"), True]
|
|
fifloader.run(['-l', '--loader', '/tmp/newloader', '--host',
|
|
'https://openqa.example', '--clean', '--update',
|
|
os.path.join(DATAPATH, 'templates.fif.json'),
|
|
os.path.join(DATAPATH, 'templates-updates.fif.json')])
|
|
assert fakerun.call_count == 2
|
|
assert fakerun.call_args[0][0] == ['/tmp/newloader', '--host', 'https://openqa.example',
|
|
'--clean', '--update', '-']
|
|
assert fakerun.call_args[1]['input'] == json.dumps(written)
|
|
assert fakerun.call_args[1]['text'] is True
|
|
# now with all subprocess.run calls failing:
|
|
fakerun.side_effect=subprocess.CalledProcessError(1, "cmd")
|
|
with pytest.raises(SystemExit, match=r"loader failed and all retries exhausted.*"):
|
|
fifloader.run(['-l', '--loader', '/tmp/newloader', '--host',
|
|
'https://openqa.example', '--clean', '--update',
|
|
os.path.join(DATAPATH, 'templates.fif.json'),
|
|
os.path.join(DATAPATH, 'templates-updates.fif.json')])
|
|
|
|
# vim: set textwidth=100 ts=8 et sw=4:
|