1
0
mirror of https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git synced 2024-11-30 01:23:08 +00:00
os-autoinst-distri-fedora/tests/desktop_browser.pm
Adam Williamson b12c529e34 Try and reduce timing failures in desktop_browser new tab
The way this works at present, with a check_screen and then an
assert_and_click, there's a window where the check has passed
so we're committed to the assert, but it takes a half second or
so for the assert to actually complete (checking for a needle
is a somewhat heavy operation). During that half second the
'new update!' notification can...and quite often does...appear.
Changing the assert_and_click to a click_lastmatch should (I
hope) tighten this window; click_lastmatch should fire faster
than assert_and_click so there'll be less of a window for the
update notification to appear and break stuff.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-19 10:30:50 -07:00

83 lines
3.0 KiB
Perl

use base "installedtest";
use strict;
use testapi;
use utils;
sub _open_new_tab {
# I hate life. ctrl-t seems to not always be reliable in openQA
# tests since 2019-01 or so, but the 'new tab' button is not
# always visible because GNOME might pop up a notification that
# blocks it. so, we try both.
if (check_screen 'browser_new_tab') {
click_lastmatch;
}
else {
send_key 'ctrl-t';
}
}
# we are very paranoid with waits and typing speed in this test
# because the system can be very busy; it's effectively first boot of
# a freshly installed system and we're running Firefox for the first
# time, which causes an awful lot of system load, and there's lots of
# screen change potentially going on. This makes the test quite slow,
# but it's best to be safe. If you're working on the test you might
# want to tweak the waits down a bit and use type_safely instead of
# type_very_safely for your test runs, just to save your time.
sub run {
my $self = shift;
check_desktop_clean;
send_key 'alt-f1';
# wait out animations
wait_still_screen(stilltime=>2, similarity_level=>45);
assert_and_click 'browser_launcher';
assert_screen 'browser';
# wait_idle was deprecated, so we just have sleeps throughout
# this test, as firefox is very grind-y :(
sleep 5;
# open a new tab so we don't race with the default page load
# (also focuses the location bar for us)
_open_new_tab;
wait_still_screen(stilltime=>2, similarity_level=>45);
sleep 3;
# check FAS, typing slowly to avoid errors
type_very_safely "https://admin.fedoraproject.org/accounts/\n";
assert_screen "browser_fas_home";
_open_new_tab;
wait_still_screen(stilltime=>2, similarity_level=>45);
sleep 2;
type_very_safely "https://kernel.org\n";
assert_and_click "browser_kernelorg_patch";
assert_and_click "browser_download_save";
send_key 'ret';
# browsers do...something...when the download completes, and we
# expect there's a single click to make it go away and return
# browser to a state where we can open a new tab
assert_and_click "browser_download_complete";
# we'll check it actually downloaded later
# add-on test: at present all desktops we test (KDE, GNOME) are
# using Firefox by default so we do this unconditionally, but we
# may need to conditionalize it if we ever test desktops whose
# default browser doesn't support add-ons or uses different ones
_open_new_tab;
wait_still_screen(stilltime=>2, similarity_level=>45);
sleep 2;
type_very_safely "https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/\n";
assert_and_click "firefox_addon_add";
assert_and_click "firefox_addon_install";
assert_and_click "firefox_addon_success";
# go to a console and check download worked
$self->root_console(tty=>3);
my $user = get_var("USER_LOGIN", "test");
assert_script_run "test -e /home/$user/Downloads/patch-*.xz";
}
sub test_flags {
return { fatal => 1 };
}
1;
# vim: set sw=4 et: