mirror of
https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git
synced 2024-12-26 12:13:14 +00:00
b97c019ae9
Summary: T617 makes some good points about the language tags; this is my suggestion for an improvement. It requires a bit of cleverness in unregister_prefix_tags(), but the upshot is that you don't need to know to set any special tags when creating needles, a needle with no language-related tags will be considered as valid for all languages. You have to explicitly add LANGUAGE- tag(s) to a needle for the language filtering to 'kick in' in any way. If a needle has at least one LANGUAGE- tag, it will be filtered unless it has the appropriate tag for the job's specified language (default is still 'english'). With this approach, only needles which we specifically want to *only* match their tagged language(s) need the tags, so we can drop all those -ALL tags. We're using LANGUAGE- instead of ENV-LANGUAGE- now because the ENV- tag names denote tags that are treated slightly specially by openQA, and this is not one. We cannot cleanly use ENV-INSTLANG because openQA has a hardwired default of 'en_US' for that. Test Plan: Check both English and French tests still work as intended. Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D589 |
||
|---|---|---|
| .. | ||
| _boot_to_anaconda.pm | ||
| _console_wait_login.pm | ||
| _do_install_and_reboot.pm | ||
| _graphical_wait_login.pm | ||
| _software_selection.pm | ||
| disk_custom_btrfs.pm | ||
| disk_custom_ext3.pm | ||
| disk_custom_lvmthin.pm | ||
| disk_custom_no_swap.pm | ||
| disk_custom_software_raid_postinstall.pm | ||
| disk_custom_software_raid.pm | ||
| disk_guided_delete_all.pm | ||
| disk_guided_delete_partial_postinstall.pm | ||
| disk_guided_delete_partial.pm | ||
| disk_guided_empty.pm | ||
| disk_guided_encrypted_postinstall.pm | ||
| disk_guided_encrypted.pm | ||
| disk_guided_free_space_postinstall.pm | ||
| disk_guided_multi_empty_all_postinstall.pm | ||
| disk_guided_multi_empty_all.pm | ||
| disk_guided_multi_postinstall.pm | ||
| disk_guided_multi.pm | ||
| disk_guided_shrink_postinstall.pm | ||
| disk_guided_shrink.pm | ||
| install_source_graphical.pm | ||
| install_source_variation.pm | ||
| uefi_postinstall.pm | ||
| upgrade_postinstall_desktop.pm | ||
| upgrade_postinstall_minimal.pm | ||
| upgrade_preinstall.pm | ||
| upgrade_run.pm | ||