1
0
mirror of https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git synced 2024-12-22 10:23:09 +00:00
os-autoinst-distri-fedora/needles/anaconda/install_destination
Adam Williamson 21eea18562 Add a needle check script, remove some unused needles
I call this...The @lruzicka Catcher!

It's a script that checks for needles that aren't actually used
anywhere. It also checks for cases where we have a needle JSON
file but no image, or an image file but no JSON file (and wipes
one case of the latter). It also adds a run of the script to tox
so we get it in CI.

You could make this script a lot more elaborate if you like, by
being fancier about parsing the test code and templates, but I
don't think it's really warranted, I think it just needs to be
'good enough'. It's not the end of the world if it misses the
odd thing or the whitelisting goes stale.

Quite a lot of the removed needles are remnants of different
approaches to app start/stop testing which weren't caught in the
initial PR review. The short-name partitioning ones are odd; they
were introduced in the commit that moved needles into subdirs,
but at least some of them don't actually appear to be moves. They
may have been non-tracked files Josef had lying around that got
into the commit by mistake, or they may just be old needles we
really used at some point but aren't using any more.
reclaim_space_second_partition was introduced as part of the
shrink test (along with reclaim_space_first_partition) but was
never actually used by that test - I guess, again, the test got
re-written during review but we forgot to remove the needle. We
rejigged user creation to use tab presses not a needle match a
while back, which made user_creation_password_input unnecessary.
The various cockpit_updates_* needles are I think remnants of
rewrites of the cockpit update tests that again were missed in
PR review, the tests as merged never used them.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-08 16:55:46 -07:00
..
arabic Great Needle Cleanup 2020 2020-03-20 14:02:10 -07:00
french Great Needle Cleanup 2020 2020-03-20 14:02:10 -07:00
japanese Great Needle Cleanup 2020 2020-03-20 14:02:10 -07:00
russian Great Needle Cleanup 2020 2020-03-20 14:02:10 -07:00
add_iscsi_target-20200116.json First batch of updates for new version of cantarell 2020-01-17 01:18:52 +00:00
add_iscsi_target-20200116.png First batch of updates for new version of cantarell 2020-01-17 01:18:52 +00:00
add_network_disk-20190321.json Add needle to fix iscsi test. 2019-03-21 13:18:41 +01:00
add_network_disk-20190321.png Add needle to fix iscsi test. 2019-03-21 13:18:41 +01:00
add_network_disk-gtk3245-20190206.json GTK+ 3.24.5 needle retake 2019-02-06 13:27:30 -08:00
add_network_disk-gtk3245-20190206.png GTK+ 3.24.5 needle retake 2019-02-06 13:27:30 -08:00
delete_all_btn-20200116.json First batch of updates for new version of cantarell 2020-01-17 01:18:52 +00:00
delete_all_btn-20200116.png First batch of updates for new version of cantarell 2020-01-17 01:18:52 +00:00
encrypt_data-gtk3245-20190206.json GTK+ 3.24.5 needle retake 2019-02-06 13:27:30 -08:00
encrypt_data-gtk3245-20190206.png GTK+ 3.24.5 needle retake 2019-02-06 13:27:30 -08:00
reclaim_space_btn-20200116.json First batch of updates for new version of cantarell 2020-01-17 01:18:52 +00:00
reclaim_space_btn-20200116.png First batch of updates for new version of cantarell 2020-01-17 01:18:52 +00:00
reclaim_space_delete_btn-20200116.json First batch of updates for new version of cantarell 2020-01-17 01:18:52 +00:00
reclaim_space_delete_btn-20200116.png First batch of updates for new version of cantarell 2020-01-17 01:18:52 +00:00
reclaim_space_first_partition-20200116.json First batch of updates for new version of cantarell 2020-01-17 01:18:52 +00:00
reclaim_space_first_partition-20200116.png First batch of updates for new version of cantarell 2020-01-17 01:18:52 +00:00
reclaim_space_shrink_btn-20200117.json First batch of updates for new version of cantarell 2020-01-17 01:18:52 +00:00
reclaim_space_shrink_btn-20200117.png First batch of updates for new version of cantarell 2020-01-17 01:18:52 +00:00
reclaim_space_shrink_slider-20190301.json Add some new needle variants that failed ppc64 tests 2019-03-01 08:52:25 -08:00
reclaim_space_shrink_slider-20190301.png Add some new needle variants that failed ppc64 tests 2019-03-01 08:52:25 -08:00
save_passphrase-gtk3245-20190206.json GTK+ 3.24.5 needle retake 2019-02-06 13:27:30 -08:00
save_passphrase-gtk3245-20190206.png GTK+ 3.24.5 needle retake 2019-02-06 13:27:30 -08:00
select_disk_1-20200215.json Update 'select_disk_1' needle 2020-02-17 08:33:57 -08:00
select_disk_1-20200215.png Update 'select_disk_1' needle 2020-02-17 08:33:57 -08:00
select_disk_2-gtk3245-20190206.json GTK+ 3.24.5 needle retake 2019-02-06 13:27:30 -08:00
select_disk_2-gtk3245-20190206.png GTK+ 3.24.5 needle retake 2019-02-06 13:27:30 -08:00
select_target-gtk3245-20190206.json GTK+ 3.24.5 needle retake 2019-02-06 13:27:30 -08:00
select_target-gtk3245-20190206.png GTK+ 3.24.5 needle retake 2019-02-06 13:27:30 -08:00
target_auth_type_chap-20200220.json Update an iSCSI needle for font changes 2020-02-20 12:14:35 -08:00
target_auth_type_chap-20200220.png Update an iSCSI needle for font changes 2020-02-20 12:14:35 -08:00
target_auth_type-gtk3245-20190206.json GTK+ 3.24.5 needle retake 2019-02-06 13:27:30 -08:00
target_auth_type-gtk3245-20190206.png GTK+ 3.24.5 needle retake 2019-02-06 13:27:30 -08:00
target_login-gtk3245-20190206.json GTK+ 3.24.5 needle retake 2019-02-06 13:27:30 -08:00
target_login-gtk3245-20190206.png GTK+ 3.24.5 needle retake 2019-02-06 13:27:30 -08:00
updates.json Organize needles to directories (step 2/2) 2016-05-13 13:43:31 +02:00
updates.png Organize needles to directories (step 2/2) 2016-05-13 13:43:31 +02:00