mirror of
https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git
synced 2024-11-28 00:23:09 +00:00
9871c48433
Summary: This requires a PR I sent upstream: https://github.com/os-autoinst/os-autoinst/pull/490 This change is in os-autoinst -10. However, with older packages it won't crash or anything, it'll just behave as before. With the change, this allows log upload to fail, so if one of the logs is missing, the hook doesn't immediately die and fail to upload the rest of the logs. Various anaconda logs are not always present: the DNF logs are not present for Atomic or live installs, and the X.log and syslog are not present for live installs. Adding a fail-tolerant mode to upstream upload_logs seemed a better option than testing for the existence of each log file prior to uploading it, or adding a bunch of GET_VAR calls to try and figure out which log files 'should' exist. Test Plan: Run an Atomic or live install test that fails, and check what logs get uploaded. You can just test a current Rawhide Atomic installer ISO, as they're crashing right now. Without this patch (and the os-autoinst update) the hook dies when it tries to upload dnf.log, so the traceback and /var/tmp archive don't get uploaded; with this patch all the present logs should get uploaded. Compare: https://openqa.fedoraproject.org/tests/14834 https://openqa.stg.fedoraproject.org/tests/15371 (I tested this out on staging). Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D834 |
||
|---|---|---|
| .. | ||
| anacondatest.pm | ||
| fedorabase.pm | ||
| fedoradistribution.pm | ||
| installedtest.pm | ||