nautilus: adjust keyboard shortcut page navigation

As recommended by @mclasen in https://gitlab.gnome.org/GNOME/gtk/-/issues/5831#note_1743386 . Signed-off-by: Adam Williamson <awilliam@redhat.com>
Update blivet part_boot-inactive needle
2024-12-02 18:13:10 +00:00 · 2023-05-16 16:09:04 -07:00 · 2023-05-16 15:46:00 -07:00 · 2023-05-16 15:45:10 -07:00 · 2023-05-16 15:40:02 -07:00 · 2023-05-16 14:42:23 -07:00
13 changed files with 87 additions and 22 deletions
--- a/needles/anaconda/partitioning/blivet/anaconda_blivet_part_boot-inactive-20201216.json
+++ b/needles/anaconda/partitioning/blivet/anaconda_blivet_part_boot-inactive-20201216.json
@ -10,6 +10,7 @@
  ],
  "properties": [],
  "tags": [
-    "anaconda_blivet_part_boot"
+    "anaconda_blivet_part_boot",
+    "anaconda_blivet_part_inactive_boot"
  ]
 }
--- a/needles/anaconda/partitioning/blivet/anaconda_blivet_part_boot-inactive-20230516.json
+++ b/needles/anaconda/partitioning/blivet/anaconda_blivet_part_boot-inactive-20230516.json
@ -0,0 +1,16 @@
+{
+  "area": [
+    {
+      "height": 19,
+      "width": 98,
+      "ypos": 345,
+      "xpos": 342,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "anaconda_blivet_part_boot",
+    "anaconda_blivet_part_inactive_boot"
+  ]
+}
--- a/needles/anaconda/partitioning/blivet/anaconda_blivet_part_boot-inactive-20230516.png
+++ b/needles/anaconda/partitioning/blivet/anaconda_blivet_part_boot-inactive-20230516.png
--- a/needles/anaconda/partitioning/blivet/anaconda_blivet_part_boot-inactive.json
+++ b/needles/anaconda/partitioning/blivet/anaconda_blivet_part_boot-inactive.json
@ -10,6 +10,7 @@
  ],
  "properties": [],
  "tags": [
-    "anaconda_blivet_part_boot"
+    "anaconda_blivet_part_boot",
+    "anaconda_blivet_part_inactive_boot"
  ]
 }
--- a/needles/anaconda/partitioning/scheme_lvm-highlighted-20230516.json
+++ b/needles/anaconda/partitioning/scheme_lvm-highlighted-20230516.json
@ -0,0 +1,18 @@
+{
+  "area": [
+    {
+      "width": 86,
+      "ypos": 255,
+      "height": 18,
+      "type": "match",
+      "xpos": 66
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "anaconda_part_scheme_lvm",
+    "ENV-DISTRI-fedora",
+    "LANGUAGE-english",
+    "ENV-FLAVOR-server"
+  ]
+}
--- a/needles/anaconda/partitioning/scheme_lvm-highlighted-20230516.png
+++ b/needles/anaconda/partitioning/scheme_lvm-highlighted-20230516.png
--- a/needles/anaconda/partitioning/scheme_lvm.json
+++ b/needles/anaconda/partitioning/scheme_lvm.json
@ -1,18 +1,18 @@
 {
-  "area": [
-    {
-      "xpos": 64,
-      "ypos": 311,
-      "width": 33,
-      "height": 18,
-      "type": "match"
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "anaconda_part_scheme_lvm",
-    "ENV-DISTRI-fedora",
-    "LANGUAGE-english",
-    "ENV-FLAVOR-server"
-  ]
+    "area": [
+        {
+            "height": 18,
+            "type": "match",
+            "width": 73,
+            "xpos": 64,
+            "ypos": 311
+        }
+    ],
+    "properties": [],
+    "tags": [
+        "anaconda_part_scheme_lvm",
+        "ENV-DISTRI-fedora",
+        "LANGUAGE-english",
+        "ENV-FLAVOR-server"
+    ]
 }
--- a/needles/gnome/apps/characters/chars_website_opened-20230516.json
+++ b/needles/gnome/apps/characters/chars_website_opened-20230516.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "type": "match",
+      "xpos": 238,
+      "height": 24,
+      "width": 367,
+      "ypos": 84
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "chars_website_opened"
+  ]
+}
--- a/needles/gnome/apps/characters/chars_website_opened-20230516.png
+++ b/needles/gnome/apps/characters/chars_website_opened-20230516.png
--- a/needles/gnome/apps/fonts/fonts_website_opened-20230516.json
+++ b/needles/gnome/apps/fonts/fonts_website_opened-20230516.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "ypos": 84,
+      "width": 381,
+      "height": 24,
+      "xpos": 241,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "fonts_website_opened"
+  ]
+}
--- a/needles/gnome/apps/fonts/fonts_website_opened-20230516.png
+++ b/needles/gnome/apps/fonts/fonts_website_opened-20230516.png
--- a/tests/_do_install_and_reboot.pm
+++ b/tests/_do_install_and_reboot.pm
@ -90,6 +90,7 @@ sub run {
    # the screensaver during install...
    my $interval = 60;
    while ($timeout > 0) {
+        die "Error encountered!" if (check_screen "anaconda_error_report");
        # move the mouse a bit
        mouse_set 100, 100;
        # also click, if we're a VNC client, seems just moving mouse
--- a/tests/applications/nautilus/keyboard_shortcuts.pm
+++ b/tests/applications/nautilus/keyboard_shortcuts.pm
@ -16,14 +16,12 @@ sub run {

    assert_screen("nautilus_shortcuts_first");

-    send_key("right");
-    send_key("ret");
+    send_key("alt-2");
    wait_still_screen(2);

    assert_screen("nautilus_shortcuts_second");

-    send_key("right");
-    send_key("ret");
+    send_key("alt-3");
    wait_still_screen(2);

    assert_screen("nautilus_shortcuts_third");
Author	SHA1	Message	Date
Adam Williamson	37bd56033d	nautilus: adjust keyboard shortcut page navigation As recommended by @mclasen in https://gitlab.gnome.org/GNOME/gtk/-/issues/5831#note_1743386 . Signed-off-by: Adam Williamson <awilliam@redhat.com>	2023-05-16 16:09:04 -07:00
Adam Williamson	ea42516280	Update blivet part_boot-inactive needle This is needed to make the LVM resize test work properly... Signed-off-by: Adam Williamson <awilliam@redhat.com>	2023-05-16 15:46:00 -07:00
Adam Williamson	280139db2b	Add some more variant 'website opened' needles These hit low-90% matches when run on the F38 respins for some reason, just add another variant... Signed-off-by: Adam Williamson <awilliam@redhat.com>	2023-05-16 15:45:10 -07:00
Adam Williamson	b1e975a21f	anaconda: end install immediately if we see the error screen If install errors out, currently we still wait like an hour for an "install_done" screen that will never come, before we give up. Since we have a needle for the "unknown error has occurred" screen, we may as well use it here - if we see that screen, we can just die immediately. This may go stale if we forget to update the needle, but it's only one line, so meh. Signed-off-by: Adam Williamson <awilliam@redhat.com>	2023-05-16 15:40:02 -07:00
Adam Williamson	0e6553f4d1	Tweak LVM partition scheme needles a bit In https://openqa.fedoraproject.org/tests/1938847 , we wound up doing an LVM thinp install when we meant to do a regular LVM install, because LVM was already highlighted (for some reason) in the scheme list, and the "LVM" needle is narrow enough that it matched on the start of "LVM Thin Provisioning". To avoid this, we make the match area in the existing needle wider so it can't match on "LVM Thin Provisioning", and add an alternate needle for LVM when it's highlighted. Signed-off-by: Adam Williamson <awilliam@redhat.com>	2023-05-16 14:42:23 -07:00
Adam Williamson	c9deb243cd	Restore anaconda_blivet_part_inactive_boot tag It's needed for install_blivet_resize_lvm to work properly. Signed-off-by: Adam Williamson <awilliam@redhat.com>	2023-05-16 11:13:29 -07:00