GDM language login needles: Rename, move and mark as workarounds

These are all the new needles for the 'no blue outline on
password entry box any more' issue. The naming was a bit non-
standard and they were not in the right directories, and they
need to be actually tagged as workarounds, like the English
one is. Also, add the correct issue link to the workaround note
for the English one.

Signed-off-by: Adam Williamson <awilliam@redhat.com>

lib/utils.pm

@@ -949,9 +949,9 @@ sub download_modularity_tests {
     my ($whitelist) = @_;
     # we need python3-yaml for the script to run
     assert_script_run 'dnf -y install python3-yaml', 180;
-    assert_script_run 'curl --http1.1 --verbose --retry-delay 10 --max-time 30 --retry 5 -o /root/test.py https://pagure.io/fedora-qa/modularity_testing_scripts/raw/master/f/modular_functions.py', timeout => 180;
+    assert_script_run 'curl --verbose --retry-delay 10 --max-time 30 --retry 5 -o /root/test.py https://pagure.io/fedora-qa/modularity_testing_scripts/raw/master/f/modular_functions.py', timeout => 180;
     if ($whitelist eq 'whitelist') {
-        assert_script_run 'curl --http1.1 --verbose --retry-delay 10 --max-time 30 --retry 5 -o /root/whitelist https://pagure.io/fedora-qa/modularity_testing_scripts/raw/master/f/whitelist', timeout => 180;
+        assert_script_run 'curl --verbose --retry-delay 10 --max-time 30 --retry 5 -o /root/whitelist https://pagure.io/fedora-qa/modularity_testing_scripts/raw/master/f/whitelist', timeout => 180;
     }
     assert_script_run 'chmod 755 /root/test.py';
 }
@@ -1113,7 +1113,7 @@ sub advisory_check_nonmatching_packages {
     upload_logs "/tmp/installedupdatepkgs.txt", failok => 1;
     upload_logs "/mnt/updateiso/updatepkgs.txt", failok => 1;
     # download the check script and run it
-    assert_script_run 'curl --http1.1 --verbose --retry-delay 10 --max-time 30 --retry 5 -o updvercheck.py https://pagure.io/fedora-qa/os-autoinst-distri-fedora/raw/main/f/updvercheck.py', timeout => 180;
+    assert_script_run 'curl --verbose --retry-delay 10 --max-time 30 --retry 5 -o updvercheck.py https://pagure.io/fedora-qa/os-autoinst-distri-fedora/raw/main/f/updvercheck.py', timeout => 180;
     my $advisory = get_var("ADVISORY");
     my $cmd = 'python3 ./updvercheck.py /mnt/updateiso/updatepkgs.txt /tmp/installedupdatepkgs.txt';
     $cmd .= " $advisory" if ($advisory);
@@ -1495,7 +1495,7 @@ sub download_testdata {
     assert_script_run("mkdir temp");
     assert_script_run("cd temp");
     # Download the compressed file with the repository content.
-    assert_script_run("curl --http1.1 --verbose --retry-delay 10 --max-time 120 --retry 5 -o repository.tar.gz https://pagure.io/fedora-qa/openqa_testdata/blob/thetree/f/repository.tar.gz", timeout => 600);
+    assert_script_run("curl --verbose --retry-delay 10 --max-time 120 --retry 5 -o repository.tar.gz https://pagure.io/fedora-qa/openqa_testdata/blob/thetree/f/repository.tar.gz", timeout => 600);
     # Untar it.
     assert_script_run("tar -zxvf repository.tar.gz");
     # Copy out the files into the VMs directory structure.

needles/gnome/arabic/login_gdm_input_arabic-noblue-20230809.json

@@ -0,0 +1,22 @@
+{
+  "area": [
+    {
+      "type": "match",
+      "xpos": 588,
+      "height": 59,
+      "ypos": 451,
+      "width": 58
+    }
+  ],
+  "properties": [
+    {
+      "name": "workaround",
+      "value": "the text box should be surrounded with a blue line to indicate it's active: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6880"
+    }
+  ],
+  "tags": [
+    "DESKTOP-gnome",
+    "LANGUAGE-arabic",
+    "graphical_login_input"
+  ]
+}

needles/gnome/french/login_gdm_input_french-noblue-20230809.json

@@ -0,0 +1,22 @@
+{
+  "area": [
+    {
+      "type": "match",
+      "height": 44,
+      "xpos": 385,
+      "ypos": 458,
+      "width": 84
+    }
+  ],
+  "properties": [
+    {
+      "name": "workaround",
+      "value": "the text box should be surrounded with a blue line to indicate it's active: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6880"
+    }
+  ],
+  "tags": [
+    "DESKTOP-gnome",
+    "LANGUAGE-french",
+    "graphical_login_input"
+  ]
+}

needles/gnome/japanese/login_gdm_input_japanese-noblue-20230809.json

@@ -0,0 +1,22 @@
+{
+  "area": [
+    {
+      "width": 73,
+      "ypos": 455,
+      "height": 49,
+      "xpos": 385,
+      "type": "match"
+    }
+  ],
+  "properties": [
+    {
+      "name": "workaround",
+      "value": "the text box should be surrounded with a blue line to indicate it's active: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6880"
+    }
+  ],
+  "tags": [
+    "DESKTOP-gnome",
+    "LANGUAGE-japanese",
+    "graphical_login_input"
+  ]
+}

needles/gnome/login_gdm_input-noblue-20230808.json

@@ -11,7 +11,7 @@
   "properties": [
     {
       "name": "workaround",
-      "value": "the text box should be surrounded with a blue line to indicate it's active, this broke in 45-beta"
+      "value": "the text box should be surrounded with a blue line to indicate it's active: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6880"
     }
   ],
   "tags": [
@@ -19,4 +19,4 @@
     "DESKTOP-gnome",
     "LANGUAGE-english"
   ]
-}
+}

needles/gnome/login_gdm_input_arabic-20230809_workaround.json

@@ -1,17 +0,0 @@
-{
-  "area": [
-    {
-      "type": "match",
-      "xpos": 588,
-      "height": 59,
-      "ypos": 451,
-      "width": 58
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "DESKTOP-gnome",
-    "LANGUAGE-arabic",
-    "graphical_login_input"
-  ]
-}

needles/gnome/login_gdm_input_french-20230809_workaround.json

@@ -1,17 +0,0 @@
-{
-  "area": [
-    {
-      "type": "match",
-      "height": 44,
-      "xpos": 385,
-      "ypos": 458,
-      "width": 84
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "DESKTOP-gnome",
-    "LANGUAGE-french",
-    "graphical_login_input"
-  ]
-}

needles/gnome/login_gdm_input_japanese-20230809_workaround.json

@@ -1,17 +0,0 @@
-{
-  "area": [
-    {
-      "width": 73,
-      "ypos": 455,
-      "height": 49,
-      "xpos": 385,
-      "type": "match"
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "DESKTOP-gnome",
-    "LANGUAGE-japanese",
-    "graphical_login_input"
-  ]
-}

needles/gnome/login_gdm_input_russian-20230809_workaround.json

@@ -1,17 +0,0 @@
-{
-  "area": [
-    {
-      "ypos": 457,
-      "width": 49,
-      "type": "match",
-      "height": 44,
-      "xpos": 384
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "DESKTOP-gnome",
-    "LANGUAGE-russian",
-    "graphical_login_input"
-  ]
-}

needles/gnome/login_gdm_input_turkish-20230809_workaround.json

@@ -1,17 +0,0 @@
-{
-  "area": [
-    {
-      "type": "match",
-      "height": 46,
-      "xpos": 387,
-      "ypos": 457,
-      "width": 41
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "DESKTOP-gnome",
-    "LANGUAGE-turkish",
-    "graphical_login_input"
-  ]
-}

needles/gnome/russian/login_gdm_input_russian-noblue-20230809.json

@@ -0,0 +1,22 @@
+{
+  "area": [
+    {
+      "ypos": 457,
+      "width": 49,
+      "type": "match",
+      "height": 44,
+      "xpos": 384
+    }
+  ],
+  "properties": [
+    {
+      "name": "workaround",
+      "value": "the text box should be surrounded with a blue line to indicate it's active: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6880"
+    }
+  ],
+  "tags": [
+    "DESKTOP-gnome",
+    "LANGUAGE-russian",
+    "graphical_login_input"
+  ]
+}

needles/gnome/turkish/login_gdm_input_turkish-noblue-20230809.json

@@ -0,0 +1,22 @@
+{
+  "area": [
+    {
+      "type": "match",
+      "height": 46,
+      "xpos": 387,
+      "ypos": 457,
+      "width": 41
+    }
+  ],
+  "properties": [
+    {
+      "name": "workaround",
+      "value": "the text box should be surrounded with a blue line to indicate it's active: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6880"
+    }
+  ],
+  "tags": [
+    "DESKTOP-gnome",
+    "LANGUAGE-turkish",
+    "graphical_login_input"
+  ]
+}

tests/_live_build.pm

@@ -67,10 +67,6 @@ sub run {
     # upload the config so we can check it's OK
     upload_logs "/etc/mock/openqa.cfg";
     # now check out the kickstarts
-    # FIXME using HTTP 1.1 seems to avoid some weird hangs we're
-    # seeing on pagure.io lately as of 2023/07:
-    # https://pagure.io/fedora-infrastructure/issue/11426
-    assert_script_run 'git config --global http.version HTTP/1.1';
     assert_script_run 'git clone https://pagure.io/fedora-kickstarts.git';
     assert_script_run 'cd fedora-kickstarts';
     assert_script_run "git checkout ${branch}";

tests/_ostree_build.pm

@@ -36,10 +36,6 @@ sub run {
     assert_script_run "setenforce Permissive";
     # install the tools we need
     assert_script_run "dnf -y install git lorax flatpak ostree rpm-ostree dbus-daemon moreutils", 300;
-    # FIXME using HTTP 1.1 seems to avoid some weird hangs we're
-    # seeing on pagure.io lately as of 2023/07:
-    # https://pagure.io/fedora-infrastructure/issue/11426
-    assert_script_run 'git config --global http.version HTTP/1.1';
     # now check out workstation-ostree-config
     assert_script_run 'git clone https://pagure.io/workstation-ostree-config.git';
     assert_script_run 'pushd workstation-ostree-config';
@@ -89,7 +85,7 @@ sub run {
     assert_script_run 'git clone https://pagure.io/pungi-fedora.git';
     assert_script_run 'cd pungi-fedora/';
     assert_script_run "git checkout ${branch}";
-    assert_script_run 'curl --http1.1 --retry-delay 10 --max-time 30 --retry 5 -o ostree-parse-pungi.py https://pagure.io/fedora-qa/os-autoinst-distri-fedora/raw/main/f/ostree-parse-pungi.py', timeout => 180;
+    assert_script_run 'curl --retry-delay 10 --max-time 30 --retry 5 -o ostree-parse-pungi.py https://pagure.io/fedora-qa/os-autoinst-distri-fedora/raw/main/f/ostree-parse-pungi.py', timeout => 180;
     my $loraxargs = script_output "python3 ostree-parse-pungi.py $lcsubv $arch";
 
     # this 'temporary file cleanup' thing can actually wipe bits of