Apply some debugging hacks for the periodic failure bug

This is all in aid of trying to figure out what's going on in
https://pagure.io/fedora-qa/os-autoinst-distri-fedora/pull-request/312#comment-199540
 - sometimes the upgrade process just does not work, it seems
like the prepared update file gets wiped for some reason. This
is all trying to figure out exactly when that happens and
whether it's because we're running out of disk space.

Signed-off-by: Adam Williamson <awilliam@redhat.com>

lib/utils.pm

@@ -1476,8 +1476,6 @@ sub check_prerelease {
     $prerelease = 1 if ($build =~ /\.n\.\d+/ && !get_var("LIVE"));
     # if it's a respin compose we *MUST NOT* see tags
     $prerelease = 0 if ($build =~ /Respin/);
-    # bail if we've decided we don't care
-    return if ($prerelease > 1);
     # we *could* go to a console and parse fedora-release-common
     # to decide if a nightly live image should have tags or not, but
     # it seems absurd as we're almost reinventing the code that

tests/_graphical_wait_login.pm

@@ -92,11 +92,8 @@ sub run {
         # root user now, for subsequent tests to work
         select_console "tty3-console";
         console_login(user => get_var("USER_LOGIN", "test"), password => get_var("USER_PASSWORD", "weakpassword"));
-        wait_still_screen 3;
         type_string "sudo su\n";
-        wait_still_screen 3;
         type_string "$password\n";
-        wait_still_screen 3;
         my $root_password = get_var("ROOT_PASSWORD") || "weakpassword";
         assert_script_run "echo 'root:$root_password' | chpasswd";
         desktop_vt;

tests/graphical_upgrade_prerequisites.pm

@@ -28,7 +28,7 @@ sub run {
         # to ensure we have the fix for
         # https://gitlab.gnome.org/GNOME/gnome-software/-/issues/2514
         # drop this when the update is stable
-        if ($curr eq "40") {
+        if ($release eq "40") {
             assert_script_run("dnf -y --enablerepo=updates-testing update gnome-software", 180);
         }
         # Leave the CLI and come back to the login screen.