doublek_workaround: tweak to work for other letters too

In a couple of cases we type something that *doesn't* start with
a 'k', so we should use that other letter for the workaround.

Signed-off-by: Adam Williamson <awilliam@redhat.com>

lib/utils.pm

@@ -1767,11 +1767,13 @@ sub start_applications {
 # close operation before we do anything 'real'. this is repeated in
 # several tests so we share it here
 sub kde_doublek_workaround {
+    my %args = @_;
+    $args{key} //= 'k';
     wait_screen_change { send_key 'super'; };
     wait_still_screen 3;
-    send_key "k";
+    send_key $args{key};
     wait_still_screen 5;
-    send_key "esc";
+    send_key 'esc';
 }
 
 1;

needles/gnome/apps/maps/maps_map_zoomed-20240911.json

@@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "width": 197,
+      "xpos": 415,
+      "ypos": 362,
+      "type": "match",
+      "height": 162
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "maps_map_zoomed"
+  ]
+}

needles/kde/desktop_icon_notifications-kde-darkgrey-20240913.json

@@ -0,0 +1,16 @@
+{
+  "area": [
+    {
+      "type": "match",
+      "height": 18,
+      "xpos": 731,
+      "width": 18,
+      "ypos": 728
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "DESKTOP-kde",
+    "desktop_icon_notifications"
+  ]
+}

tests/_installer_build.pm

@@ -29,10 +29,10 @@ sub run {
         $cmd .= " --isfinal --repo=/etc/yum.repos.d/fedora-updates.repo";
     }
     if (lc($version) eq "eln") {
-        $cmd .= " --variant=BaseOS --nomacboot --volid=Fedora-eln-BaseOS-${arch}"
+        $cmd .= " --variant=BaseOS --nomacboot --volid=Fedora-eln-BaseOS-${arch}";
     }
     else {
-        $cmd .= " --variant=Everything --volid=Fedora-E-dvd-${arch}"
+        $cmd .= " --variant=Everything --volid=Fedora-E-dvd-${arch}";
     }
     $cmd .= " --repo=/etc/yum.repos.d/workarounds.repo" if (get_workarounds);
     $cmd .= " --repo=/etc/yum.repos.d/koji-rawhide.repo" if ($version eq $rawrel);

tests/applications/keyring/keyring_password.pm

@@ -130,8 +130,7 @@ sub perform_login {
     my $password = shift;
     send_key("ret") if ($desktop eq "gnome");
     type_very_safely("$password\n");
-    wait_still_screen(3);
-    send_key("esc");
+    check_desktop;
 }
 
 sub run {

tests/applications/keyring/keyring_passwordless.pm

@@ -80,8 +80,7 @@ sub perform_login {
     my $password = shift;
     send_key("ret") if ($desktop eq "gnome");
     type_very_safely("$password\n");
-    wait_still_screen(3);
-    send_key("esc");
+    check_desktop;
 }
 
 sub run {

tests/desktop_terminal.pm

@@ -8,7 +8,7 @@ sub run {
     my $relnum = get_release_number;
     check_desktop;
     # try and avoid double-typing issues
-    kde_doublek_workaround if (get_var("DESKTOP") eq "kde");
+    kde_doublek_workaround(key => 't') if (get_var("DESKTOP") eq "kde");
     menu_launch_type('terminal');
     assert_screen "apps_run_terminal";
     wait_still_screen(stilltime => 5, similarity_level => 42);

tests/desktop_update_graphical.pm

@@ -24,7 +24,7 @@ sub run {
     # run the updater
     if ($desktop eq 'kde') {
         # try and avoid double-typing issues
-        kde_doublek_workaround;
+        kde_doublek_workaround(key => 'd');
         menu_launch_type('discover');
         # Wait for it to run and maximize it to make sure we see the
         # Updates entry