Apply some debugging hacks for the periodic failure bug

This is all in aid of trying to figure out what's going on in https://pagure.io/fedora-qa/os-autoinst-distri-fedora/pull-request/312#comment-199540 - sometimes the upgrade process just does not work, it seems like the prepared update file gets wiped for some reason. This is all trying to figure out exactly when that happens and whether it's because we're running out of disk space. Signed-off-by: Adam Williamson <awilliam@redhat.com>
Add the graphical upgrade tests.
2024-04-04 18:13:03 -07:00 · 2024-04-04 18:07:04 -07:00 · 2024-04-04 11:19:16 -07:00 · 2024-04-03 09:19:30 +02:00
74 changed files with 548 additions and 2 deletions
--- a/lib/installedtest.pm
+++ b/lib/installedtest.pm
@ -168,6 +168,17 @@ sub post_fail_hook {
        }
    }

+    # TEST TEST FOR DEBUGGING ONLY
+    if (get_var("GUI_UPGRADE")) {
+        script_run "df -h";
+        script_run "ls -l /var/lib/PackageKit";
+        script_run "ls -l /var/lib/PackageKit/prepared-upgrade";
+        $self->root_console(tty => 4);
+        send_key "ctrl-c";
+        upload_logs "/tmp/pk.log", failok => 1;
+    }
+    # END DEBUGGING
+
 }

 1;
--- a/lib/utils.pm
+++ b/lib/utils.pm
@ -1356,12 +1356,12 @@ sub menu_launch_type {
        diag("Moving the mouse away from the launcher.");
        mouse_set(1, 1);
    }
-    send_key 'super';
+    wait_screen_change { send_key 'super'; };
    # srsly KDE y u so slo
    wait_still_screen 3;
    type_very_safely $app;
    # Wait for KDE to place focus correctly.
-    sleep 2;
+    wait_still_screen 2;
    send_key 'ret';
    wait_still_screen(3);
 }
--- a/needles/kde/apps/okular/okular_about_shown.json
+++ b/needles/kde/apps/okular/okular_about_shown.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 352,
+      "ypos": 216,
+      "width": 112,
+      "height": 21,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_about_shown"
+  ]
+}
--- a/needles/kde/apps/okular/okular_about_shown.png
+++ b/needles/kde/apps/okular/okular_about_shown.png
--- a/needles/kde/apps/okular/okular_add_popup.json
+++ b/needles/kde/apps/okular/okular_add_popup.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 216,
+      "ypos": 113,
+      "width": 22,
+      "height": 23,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_add_popup"
+  ]
+}
--- a/needles/kde/apps/okular/okular_add_popup.png
+++ b/needles/kde/apps/okular/okular_add_popup.png
--- a/needles/kde/apps/okular/okular_annotation_added.json
+++ b/needles/kde/apps/okular/okular_annotation_added.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 18,
+      "ypos": 205,
+      "width": 147,
+      "height": 16,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_annotation_added"
+  ]
+}
--- a/needles/kde/apps/okular/okular_annotation_added.png
+++ b/needles/kde/apps/okular/okular_annotation_added.png
--- a/needles/kde/apps/okular/okular_annotation_placed.json
+++ b/needles/kde/apps/okular/okular_annotation_placed.json
@ -0,0 +1,16 @@
+{
+  "area": [
+    {
+      "xpos": 681,
+      "ypos": 589,
+      "width": 35,
+      "height": 48,
+      "type": "match",
+      "match": 90
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_annotation_placed"
+  ]
+}
--- a/needles/kde/apps/okular/okular_annotation_placed.png
+++ b/needles/kde/apps/okular/okular_annotation_placed.png
--- a/needles/kde/apps/okular/okular_annotation_removed.json
+++ b/needles/kde/apps/okular/okular_annotation_removed.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 671,
+      "ypos": 582,
+      "width": 46,
+      "height": 51,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_annotation_removed"
+  ]
+}
--- a/needles/kde/apps/okular/okular_annotation_removed.png
+++ b/needles/kde/apps/okular/okular_annotation_removed.png
--- a/needles/kde/apps/okular/okular_button_credits.json
+++ b/needles/kde/apps/okular/okular_button_credits.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 534,
+      "ypos": 272,
+      "width": 53,
+      "height": 17,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_button_credits"
+  ]
+}
--- a/needles/kde/apps/okular/okular_button_credits.png
+++ b/needles/kde/apps/okular/okular_button_credits.png
--- a/needles/kde/apps/okular/okular_button_save.json
+++ b/needles/kde/apps/okular/okular_button_save.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 781,
+      "ypos": 614,
+      "width": 50,
+      "height": 19,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_button_save"
+  ]
+}
--- a/needles/kde/apps/okular/okular_button_save.png
+++ b/needles/kde/apps/okular/okular_button_save.png
--- a/needles/kde/apps/okular/okular_change_zoom.json
+++ b/needles/kde/apps/okular/okular_change_zoom.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 125,
+      "ypos": 74,
+      "width": 76,
+      "height": 17,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_change_zoom"
+  ]
+}
--- a/needles/kde/apps/okular/okular_change_zoom.png
+++ b/needles/kde/apps/okular/okular_change_zoom.png
--- a/needles/kde/apps/okular/okular_close_annotation.json
+++ b/needles/kde/apps/okular/okular_close_annotation.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 993,
+      "ypos": 118,
+      "width": 17,
+      "height": 20,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_close_annotation"
+  ]
+}
--- a/needles/kde/apps/okular/okular_close_annotation.png
+++ b/needles/kde/apps/okular/okular_close_annotation.png
--- a/needles/kde/apps/okular/okular_content_rotated_once.json
+++ b/needles/kde/apps/okular/okular_content_rotated_once.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 205,
+      "ypos": 435,
+      "width": 105,
+      "height": 42,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_content_rotated_once"
+  ]
+}
--- a/needles/kde/apps/okular/okular_content_rotated_once.png
+++ b/needles/kde/apps/okular/okular_content_rotated_once.png
--- a/needles/kde/apps/okular/okular_content_rotated_twice.json
+++ b/needles/kde/apps/okular/okular_content_rotated_twice.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 610,
+      "ypos": 583,
+      "width": 85,
+      "height": 33,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_content_rotated_twice"
+  ]
+}
--- a/needles/kde/apps/okular/okular_content_rotated_twice.png
+++ b/needles/kde/apps/okular/okular_content_rotated_twice.png
--- a/needles/kde/apps/okular/okular_credits_shown.json
+++ b/needles/kde/apps/okular/okular_credits_shown.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 355,
+      "ypos": 339,
+      "width": 88,
+      "height": 19,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_credits_shown"
+  ]
+}
--- a/needles/kde/apps/okular/okular_credits_shown.png
+++ b/needles/kde/apps/okular/okular_credits_shown.png
--- a/needles/kde/apps/okular/okular_document_zoom_200.json
+++ b/needles/kde/apps/okular/okular_document_zoom_200.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 678,
+      "ypos": 358,
+      "width": 159,
+      "height": 59,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_document_zoom_200"
+  ]
+}
--- a/needles/kde/apps/okular/okular_document_zoom_200.png
+++ b/needles/kde/apps/okular/okular_document_zoom_200.png
--- a/needles/kde/apps/okular/okular_dual_mode.json
+++ b/needles/kde/apps/okular/okular_dual_mode.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 451,
+      "ypos": 709,
+      "width": 101,
+      "height": 26,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_dual_mode"
+  ]
+}
--- a/needles/kde/apps/okular/okular_dual_mode.png
+++ b/needles/kde/apps/okular/okular_dual_mode.png
--- a/needles/kde/apps/okular/okular_facing_pages.json
+++ b/needles/kde/apps/okular/okular_facing_pages.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 244,
+      "ypos": 134,
+      "width": 102,
+      "height": 16,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_facing_pages"
+  ]
+}
--- a/needles/kde/apps/okular/okular_facing_pages.png
+++ b/needles/kde/apps/okular/okular_facing_pages.png
--- a/needles/kde/apps/okular/okular_file_opened.json
+++ b/needles/kde/apps/okular/okular_file_opened.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 448,
+      "ypos": 8,
+      "width": 127,
+      "height": 15,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_file_opened"
+  ]
+}
--- a/needles/kde/apps/okular/okular_file_opened.png
+++ b/needles/kde/apps/okular/okular_file_opened.png
--- a/needles/kde/apps/okular/okular_file_select_pdf.json
+++ b/needles/kde/apps/okular/okular_file_select_pdf.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 262,
+      "ypos": 226,
+      "width": 65,
+      "height": 16,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_file_select_pdf"
+  ]
+}
--- a/needles/kde/apps/okular/okular_file_select_pdf.png
+++ b/needles/kde/apps/okular/okular_file_select_pdf.png
--- a/needles/kde/apps/okular/okular_help_shown.json
+++ b/needles/kde/apps/okular/okular_help_shown.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 388,
+      "ypos": 171,
+      "width": 167,
+      "height": 16,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_help_shown"
+  ]
+}
--- a/needles/kde/apps/okular/okular_help_shown.png
+++ b/needles/kde/apps/okular/okular_help_shown.png
--- a/needles/kde/apps/okular/okular_menu_about.json
+++ b/needles/kde/apps/okular/okular_menu_about.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 416,
+      "ypos": 244,
+      "width": 89,
+      "height": 16,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_menu_about"
+  ]
+}
--- a/needles/kde/apps/okular/okular_menu_about.png
+++ b/needles/kde/apps/okular/okular_menu_about.png
--- a/needles/kde/apps/okular/okular_menu_properties.json
+++ b/needles/kde/apps/okular/okular_menu_properties.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 31,
+      "ypos": 336,
+      "width": 68,
+      "height": 23,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_menu_properties"
+  ]
+}
--- a/needles/kde/apps/okular/okular_menu_properties.png
+++ b/needles/kde/apps/okular/okular_menu_properties.png
--- a/needles/kde/apps/okular/okular_menu_saveas.json
+++ b/needles/kde/apps/okular/okular_menu_saveas.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 15,
+      "ypos": 204,
+      "width": 79,
+      "height": 17,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_menu_saveas"
+  ]
+}
--- a/needles/kde/apps/okular/okular_menu_saveas.png
+++ b/needles/kde/apps/okular/okular_menu_saveas.png
--- a/needles/kde/apps/okular/okular_menu_view.json
+++ b/needles/kde/apps/okular/okular_menu_view.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 47,
+      "ypos": 37,
+      "width": 35,
+      "height": 15,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_menu_view"
+  ]
+}
--- a/needles/kde/apps/okular/okular_menu_view.png
+++ b/needles/kde/apps/okular/okular_menu_view.png
--- a/needles/kde/apps/okular/okular_navi_page_one.json
+++ b/needles/kde/apps/okular/okular_navi_page_one.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 359,
+      "ypos": 115,
+      "width": 73,
+      "height": 18,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_navi_page_one"
+  ]
+}
--- a/needles/kde/apps/okular/okular_navi_page_one.png
+++ b/needles/kde/apps/okular/okular_navi_page_one.png
--- a/needles/kde/apps/okular/okular_navi_page_two.json
+++ b/needles/kde/apps/okular/okular_navi_page_two.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 358,
+      "ypos": 320,
+      "width": 96,
+      "height": 17,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_navi_page_two"
+  ]
+}
--- a/needles/kde/apps/okular/okular_navi_page_two.png
+++ b/needles/kde/apps/okular/okular_navi_page_two.png
--- a/needles/kde/apps/okular/okular_open_file_dialog.json
+++ b/needles/kde/apps/okular/okular_open_file_dialog.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 311,
+      "ypos": 516,
+      "width": 101,
+      "height": 16,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_open_file_dialog"
+  ]
+}
--- a/needles/kde/apps/okular/okular_open_file_dialog.png
+++ b/needles/kde/apps/okular/okular_open_file_dialog.png
--- a/needles/kde/apps/okular/okular_presentation_dialogue.json
+++ b/needles/kde/apps/okular/okular_presentation_dialogue.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 443,
+      "ypos": 317,
+      "width": 120,
+      "height": 17,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_presentation_dialogue"
+  ]
+}
--- a/needles/kde/apps/okular/okular_presentation_dialogue.png
+++ b/needles/kde/apps/okular/okular_presentation_dialogue.png
--- a/needles/kde/apps/okular/okular_presentation_ok.json
+++ b/needles/kde/apps/okular/okular_presentation_ok.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 597,
+      "ypos": 472,
+      "width": 43,
+      "height": 18,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_presentation_ok"
+  ]
+}
--- a/needles/kde/apps/okular/okular_presentation_ok.png
+++ b/needles/kde/apps/okular/okular_presentation_ok.png
--- a/needles/kde/apps/okular/okular_properties_shown.json
+++ b/needles/kde/apps/okular/okular_properties_shown.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 427,
+      "ypos": 422,
+      "width": 110,
+      "height": 16,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_properties_shown"
+  ]
+}
--- a/needles/kde/apps/okular/okular_properties_shown.png
+++ b/needles/kde/apps/okular/okular_properties_shown.png
--- a/needles/kde/apps/okular/okular_remove_annotation.json
+++ b/needles/kde/apps/okular/okular_remove_annotation.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 710,
+      "ypos": 673,
+      "width": 62,
+      "height": 15,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_remove_annotation"
+  ]
+}
--- a/needles/kde/apps/okular/okular_remove_annotation.png
+++ b/needles/kde/apps/okular/okular_remove_annotation.png
--- a/needles/kde/apps/okular/okular_runs.json
+++ b/needles/kde/apps/okular/okular_runs.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 335,
+      "ypos": 396,
+      "width": 46,
+      "height": 54,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_runs"
+  ]
+}
--- a/needles/kde/apps/okular/okular_runs.png
+++ b/needles/kde/apps/okular/okular_runs.png
--- a/needles/kde/apps/okular/okular_search_found.json
+++ b/needles/kde/apps/okular/okular_search_found.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 553,
+      "ypos": 589,
+      "width": 53,
+      "height": 29,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_search_found"
+  ]
+}
--- a/needles/kde/apps/okular/okular_search_found.png
+++ b/needles/kde/apps/okular/okular_search_found.png
--- a/needles/kde/apps/okular/okular_select_annotation_place.json
+++ b/needles/kde/apps/okular/okular_select_annotation_place.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 651,
+      "ypos": 608,
+      "width": 55,
+      "height": 20,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_select_annotation_place"
+  ]
+}
--- a/needles/kde/apps/okular/okular_select_annotation_place.png
+++ b/needles/kde/apps/okular/okular_select_annotation_place.png
--- a/needles/kde/apps/okular/okular_submenu_orientation.json
+++ b/needles/kde/apps/okular/okular_submenu_orientation.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 97,
+      "ypos": 321,
+      "width": 73,
+      "height": 21,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_submenu_orientation"
+  ]
+}
--- a/needles/kde/apps/okular/okular_submenu_orientation.png
+++ b/needles/kde/apps/okular/okular_submenu_orientation.png
--- a/needles/kde/apps/okular/okular_submenu_rotate.json
+++ b/needles/kde/apps/okular/okular_submenu_rotate.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 349,
+      "ypos": 322,
+      "width": 75,
+      "height": 17,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_submenu_rotate"
+  ]
+}
--- a/needles/kde/apps/okular/okular_submenu_rotate.png
+++ b/needles/kde/apps/okular/okular_submenu_rotate.png
--- a/needles/kde/apps/okular/okular_view_mode.json
+++ b/needles/kde/apps/okular/okular_view_mode.json
@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 238,
+      "ypos": 69,
+      "width": 87,
+      "height": 23,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "okular_view_mode"
+  ]
+}
--- a/needles/kde/apps/okular/okular_view_mode.png
+++ b/needles/kde/apps/okular/okular_view_mode.png
--- a/tests/graphical_upgrade_prerequisites.pm
+++ b/tests/graphical_upgrade_prerequisites.pm
@ -64,6 +64,9 @@ sub run {
            record_soft_failure "Modular repos present! Upgrade will fail, so removing";
            assert_script_run "rm -f /etc/yum.repos.d/*modul*";
        }
+        # TEST TEST FOR DEBUGGING ONLY
+        assert_script_run 'sed -i -e "s,libexec/packagekitd,libexec/packagekitd --verbose,g" /usr/lib/systemd/system/packagekit.service';
+        # END DEBUGGING
        # Switch to a user account
        enter_cmd("su -l $user");
        # Navigate to the version file directory
--- a/tests/graphical_upgrade_run.pm
+++ b/tests/graphical_upgrade_run.pm
@ -41,6 +41,12 @@ sub run {
    }
    # Let's check, that the desktop is shown.
    check_desktop();
+    # TEST TEST FOR DEBUGGING ONLY
+    $self->root_console(tty => 4);
+    type_string "while true; do date -u >> /tmp/pk.log; df -h >> /tmp/pk.log; ls -l /var/lib/PackageKit >> /tmp/pk.log 2>&1; sleep 1; done\n";
+    $self->root_console(tty => 3);
+    desktop_vt;
+    # END DEBUGGING

    # Start the package manager application depending
    # on which DE we are on.
Author	SHA1	Message	Date
Adam Williamson	e3da59b33a	Apply some debugging hacks for the periodic failure bug This is all in aid of trying to figure out what's going on in https://pagure.io/fedora-qa/os-autoinst-distri-fedora/pull-request/312#comment-199540 - sometimes the upgrade process just does not work, it seems like the prepared update file gets wiped for some reason. This is all trying to figure out exactly when that happens and whether it's because we're running out of disk space. Signed-off-by: Adam Williamson <awilliam@redhat.com>	2024-04-04 18:13:03 -07:00
Lukas Ruzicka	6b5a562783	Add the graphical upgrade tests. This PR builds on some elements of the current upgrade process, such as upgrade_boot, upgrade_preinstall, upgrade_postinstall, but replaces the upgrade_run with graphical_upgrade_run to use graphical methods to upgrade the system. This would not be possible without necessary settings, that are performed by graphical_upgrade_prerequisites. Works for both Gnome and KDE.	2024-04-04 18:07:04 -07:00
Adam Williamson	5701d1a5a5	Try and robustify menu_launch_type a bit The mistypes on KDE are bugging me. Let's see if this - mainly the wait_screen_change, the other just seems like a logical tweak - helps at all. Signed-off-by: Adam Williamson <awilliam@redhat.com>	2024-04-04 11:19:16 -07:00
Lukáš Růžička	bde855b343	Add needles	2024-04-03 09:19:30 +02:00