Commit Graph

2315 Commits

Author SHA1 Message Date
Adam Williamson 61c988f401 Update some KDE needles for changes in Rawhide
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-03-01 16:05:04 -08:00
Adam Williamson a60f19b5e7 Switch IoT tests to all run on UEFI
It doesn't support BIOS any more...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-03-01 16:02:21 -08:00
Adam Williamson 1493cb9aa9 Update app start/stop needles for GNOME 42.beta
These are taken with the latest gnome-shell build, with CSS
fixes for the overview applied. They don't work for current
F36/Rawhide but will work once that gnome-shell build lands.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-03-01 15:59:57 -08:00
Adam Williamson 1aee5d1ec0 Avoid duplication between desktop_update and 'software' app test
The 'software' test module in GNOME apps_startstop does a subset
of what the desktop_update_graphical test does already, but
using its own needles. Let's just have it use the same needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-03-01 15:58:45 -08:00
Adam Williamson c0e83e3e3d Update KDE menu button needle for Rawhide
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-03-01 14:03:18 -08:00
Adam Williamson 8fab101745 Use lower similarity_level for some terminal wait_still_screens
We can't use the default similarity_level for wait_still_screen
when there's a flashing cursor - flashing cursor will always
cause the similarity level to be too low and the wait will just
time out at 30 seconds. Cut it to 42.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-03-01 10:31:06 -08:00
Adam Williamson abd1d1a698 check_desktop: handle GNOME showing inactive button briefly
check_desktop tries to catch when the overview is open and close
it. But with GNOME 42, it seems the inactive "Activities" button
is shown briefly on login before GNOME opens the overview. If
check_desktop catches that, it will think the overview isn't
open and it doesn't need to do anything. So if we match on first
cycle through the loop, let's wait_still_screen then match again.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-03-01 10:24:48 -08:00
Adam Williamson f75cd0e732 Add another F36 background needle (at 17:25)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-27 23:06:38 -08:00
Adam Williamson 416de35376 More needle updates for GNOME 42 / icon theme changes
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-26 16:38:25 -08:00
Adam Williamson fb214eef03 Update Arabic pre-release needle for font change
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-25 14:47:34 -08:00
Adam Williamson 8a7d5dd1ff Update various KDE/Plasma needles for Rawhide/F36 changes
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-25 14:47:04 -08:00
Adam Williamson c5e6d80684 Fix escaping in the caret workaround
So these kind of things go through perl *and* bash string
interpretation and the escaping can get pretty wacky. Turns out
we need *eight* slashes here to get four through to bash (which
we need to deal with *sed*'s escaping rules), and it only works
in single quotes for some reason, not double quotes.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-25 14:05:10 -08:00
Adam Williamson 371cb1c6eb Work around RPM caret bug when checking advisory packages
There's a bug in rpm where doing `rpm -q [NVRA]` doesn't work
if the NVRA contains a caret. To make it work you have to add
a literal slash character before the caret character, so we add
a sed command to do that, when we're checking whether packages
from the update actually got installed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-25 13:07:46 -08:00
Adam Williamson 71b7572d15 Update check-needles for anaconda user creation help needle rename
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-25 12:41:26 -08:00
Adam Williamson 752a9476be Drop KDE app 'netcon' test
This was originally a test of nm-connection-editor. However,
at some point that app stopped shipping a .desktop file by
default (it's in a subpackage that is not included in a default
KDE install) and the needle got updated to match on what the
same string now launched, which is a random part of the KDE
system settings. But there's no real sense in this - we don't
test launching every other pane of the system settings app from
the launcher, so it doesn't make sense to just test one random
one like this. Let's just throw the test out.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-25 12:37:53 -08:00
Adam Williamson fcac2af4f8 Update and rationalize KDE app "cancel" needles
We have three different needles which all match on a stock KDE
"cancel" button. Let's just have one. Also, update it for latest
Rawhide/F36 KDE.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-25 12:22:47 -08:00
Adam Williamson e305202c84 Make an anaconda help needle smaller to match on KDE
The last line of text is slightly cut off on KDE lives, so shrink
this needle area so it still matches.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-25 09:16:23 -08:00
Adam Williamson 0281cfd7f1 Add another anaconda main hub needle for KDE
One of the icons showed up bigger in a UEFI test. I dunno why.
Just keep adding needles till the pain stops.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-24 08:31:00 -08:00
Adam Williamson 172e5a3fdc Add another 36 background needle (05:34)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-24 08:27:47 -08:00
Adam Williamson 2d67e0b140 desktop_printing: do the file find from a VT
script_output has no arg to make it type slowly, and I'm seeing
that the test often fails trying to do full-speed script_output
at a desktop terminal. Let's do this part from a VT.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-24 08:24:36 -08:00
Adam Williamson dd6ebb2171 Add a second F36 background needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-23 16:11:53 -08:00
Adam Williamson 671a19cda8 Update a KDE needle for F36
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-23 16:08:54 -08:00
Adam Williamson 1417f1023e Add kwin scratch build to fix RHBZ #2047503 as an F36 workaround
Scratch build because we don't have a single-build update with
the fix, it's likely gonna be included in the 5.24.2 megaupdate.
I don't want to use that whole thing as a workaround, so I did
a 5.24.1 scratch build with the fix instead.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-23 13:09:22 -08:00
Adam Williamson 815fc3a758 Drop workarounds that already went stable
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-23 13:08:13 -08:00
Adam Williamson eefe75aa7f Update KDE menu button needle
Dunno what changed here, but it dropped to 93% match when I
rebuilt the F36 KDE base disk image.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-23 10:11:09 -08:00
Adam Williamson 97a109eb3c Add an initial F36 background needle (daytime, 10:47)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-23 09:46:10 -08:00
Adam Williamson 50afc237e6 Add version 37 identification needle for IoT
IoT started doing 37 composes, so we need this.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-23 09:00:56 -08:00
Adam Williamson 3a9b21969d Add one more needle update for GNOME 42
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-23 08:52:52 -08:00
Adam Williamson 67b599d16f Add variant KDE cups-pdf needle for F36 update tests
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-23 08:50:47 -08:00
Adam Williamson c33b137e88 Tweak desktop_vt tty detector a bit
The intent is that if the ps check finds nothing we'll use the
loginctl output, but that doesn't work because script_output
doesn't return the output if the script fails. There's an arg
you can pass to make it do so, but let's just make it always
succeed instead, by adding a ||: to the second grep like we have
for the first.

Also, I noticed this problem because the ps check started not
working on F36 KDE because none of the processes we check for
are shown as running on a tty, so let's add one more that *is*
shown as running on a tty...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-22 16:54:03 -08:00
Adam Williamson 10df5a57bf Update a bunch of needles for GNOME and adwaita-icon-theme 42
GNOME 42 and adwaita-icon-theme 42 changed a lot of things in
GNOME and anaconda, we need to update all these needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-20 15:52:42 -08:00
Adam Williamson e45fc488fc Fix operators in UEFI post-install load check
&! is not a thing, and os-autoinst has been warning us about
this forever:

Use of uninitialized value in bitwise and (&) at fedora/main.pm line 310.

I just sorta didn't notice. Apparently this turned out to work,
but it wasn't *right*. Let's do it this way instead.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-20 15:41:04 -08:00
Adam Williamson 9bc039b26d Correct JSON error in user_creation-20200219.json
Please endorse my RFE at
https://www.happyassassin.net/posts/2017/09/07/a-modest-proposal/

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-20 15:34:51 -08:00
Adam Williamson 9243fa88fc Avoid duplication of "user creation" needle
The help test had its own needle for the user creation link,
but we already have an existing one. We should probably re-
arrange all the needles that are in 'install_process' now the
root and user creation spokes are moved to the main hub, but
that's a big change so I'll do it separately. This just removes
the duplicate needle and tweaks some match names.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-18 14:59:17 -08:00
Adam Williamson 28600540c0 Update user_creation_screen Arabic needle for a font change
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-17 14:05:16 -08:00
Adam Williamson 08a4e955df Update install_lang_input needle for new icon theme
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-17 14:03:02 -08:00
Adam Williamson 5c011ab567 printing: always use ls to find PDF, update needles
When the printing_builtin test ran on an F35 respin compose it
failed; it turns out the target filename was different for the
built-in print-to-PDF on GNOME on F35. So let's just always
use the 'ls' output to find the file, but pick the directory
to check based on whether we're using cups or not.

Also rename the needles to have unique names, and add one for
F35 GNOME.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-16 17:21:36 -08:00
Adam Williamson b26fa834ef Update Akonadi migration notification needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-14 18:18:35 -08:00
Adam Williamson 4fe497c6df Update KDE login needle for font kerning change
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-14 18:16:51 -08:00
Adam Williamson 9e570a06a1 Add variant printing needles for F34 KDE
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-12 10:51:26 -08:00
Adam Williamson cd139e5f65 Add use_cups_printer needle for F35, rearrange needles a bit
We should not use the same name for two different needles even
in two different directories as it can be confusing in some parts
of the UI which don't account for the directory name. Let's use
names differentiated by desktop. Also add a needle for F35 as
the one from the PR doesn't match (different relative placement
of icon and text).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-11 08:59:48 -08:00
Adam Williamson 4251b7b73a Rename desktop_printing_cups back to desktop_printing
It's best to keep the test name consistent unless we *really*
have to change it; that way the "past runs" history in openQA
still works and the name doesn't change in resultsdb and CI
messages.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-10 09:35:50 -08:00
Adam Williamson ad52e3a94d Add a space to USE_CUPS in templates to match style
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-10 09:33:15 -08:00
Lukáš Růžička 9a56adcfd0 Modify Desktop Printing test to use two different methods.
The PR introduces an improved logic to the desktop_printing.pm
that allows to use the USE_CUPS variable in templates to trigger
the installation of cups-pdf prior to the actual test.
The cups-pdf is then used as an alternative PDF printer
instead the built-in Save As PDF method.
2022-02-10 09:35:22 +01:00
Adam Williamson 4282048819 Drop screenshot app from GNOME app start/stop tests
It was removed from the default install:
https://pagure.io/fedora-comps/c/5371509
in favor of a new screenshot mechanism that's built in to GNOME
Shell.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-09 10:23:38 -08:00
Adam Williamson 29c5c01431 Revert "Fix the os_release.pm and fedora_release.pm."
This reverts commit 182bfdaa55. The
problem was not in the test code here, it's just that the tests
were run with RAWREL set to 36 when it should be 37; this is
because fedfind's data source hadn't been updated for 36 branch
when the tests ran. It's tricky to time this exactly right -
ideally we'd probably update fedfind's data source one second
before the first Branched compose completes, but of course that's
difficult in practice.
2022-02-09 09:59:45 -08:00
Lukáš Růžička 182bfdaa55 Fix the os_release.pm and fedora_release.pm.
It seems that the IoT fix was not limited to the IoT
subvariant only, which caused wierd behaviour when
the version was set to Rawhide when it should not be.
This fixes it.
2022-02-09 18:49:22 +01:00
Adam Williamson d112944526 Shrink Arabic prerelease note match area a bit
We don't need to capture the greyspace.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-09 09:24:40 -08:00
Adam Williamson 2d87ac8ff5 Make the F36 version id needle narrower, drop language variants
It does not need to include any of the language specific text,
I guess Lukas included it in the English needle because it was
based on the IoT needle which is wider. So just shrink it to
not include any language specific text and drop the variants.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-09 09:22:42 -08:00
Adam Williamson 57a35562ad Shrink match area on install_lang needle a bit for IoT
IoT says "FEDORA-IOT" here, not just "FEDORA", and the greyspace
at the right-hand side was making the match fail. Not sure why
this only just started being a problem, but oh well, let's
make it a bit smaller.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-09 09:20:05 -08:00