This started out as just factoring out the repeated pattern for
launching a terminal on the desktop that came in with the i3
tests. But as I worked on desktop_login, which is a major user
of it, I noticed some potential cleanups and improvements in the
user switching stuff, and also realized we can turn that test
back on for KDE now - user switching was re-enabled in KDE a year
ago and is advertised to be reliable.
I don't think the "switch user from a lock screen" test fully
worked before, as we did not verify that we'd really switched
back to an existing session rather than starting a new one. Now
we do. Using the terminal to verify the logged-in user on all
desktops just keeps things simpler than using the kicker menu
on KDE (though if typing proves unreliable on KDE I may switch
this back).
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Without this, all we did on i3 was hit alt-d and...do nothing,
we didn't type the app name.
I was confused at how we didn't notice this before, but it looks
like at present menu_launch_type isn't actually used in any
test we run on i3 (a lot of tests that use it to run a terminal
got a branch for i3 which uses alt-enter instead). This is an
obvious landmine, though, and it caused things to look weird
when rebasing #323 (which is how I noticed the bug).
This also refactors the sub to use the same logic for all
desktops, just with a different key for i3, since they really
all work the same. i3 doesn't need as much waiting as the other
desktops, probably, but it doesn't really hurt and keeps the code
simple.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
We seem to be having quite a few failures lately because the
viewer window in KDE never got maximized. This makes us a bit
more conservative at startup and puts the maximization / sentence
check in a send_key_until_needlematch loop to give it more
chances.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
There's no obvious reason we're not also running these tests on
updates, so let's do it. We have to skip the advisory and UEFI
post checks for desktop_login as the last step of that test is
shutting down the system.
We leave out desktop_login for now because of
https://gitlab.gnome.org/GNOME/gjs/-/issues/647
Signed-off-by: Adam Williamson <awilliam@redhat.com>
This avoids some magic waits by asserting screens (which is much
more reliable), and combines KDE and GNOME flows in the
passwordless test by adding some needle tags to the nautilus
needles.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
The new NetworkManager update needs it. Lack of composes is
starting to bite us more, need to get one through.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Another update depends on it. It's gone stable already, but we
are having issues with composes ATM so it hasn't made a compose.
It's safe to do this as we can be sure the depended-on update
will be in the next stable compose whenever it completes, so we
can't wind up in an inconsistent state.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Over the time, we have changed the test scripts so that the code
in the i3.pm library was no more needed. The only leftover was the
user config subroutine that could be moved to the only file that was
using it and we could get rid of the library file.
There are several other tests doing the same thing (but not as
safely, in some cases). To improve reliability and reduce
duplication, let's factor this out into utils.pm and reuse it
where appropriate.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
This is still the case on the flatpak build as it runs behind the
RPM build, and would still be the case if we run the test on an
F40 respin for e.g.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
New anaconda-webui changes the disk selection flow a bit, this
adapts to it. We can drop the conditional and make it a straight
assert-and-click once the new webui is stable for F41 and F42.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
This is often failing on KDE on Rawhide ATM, apparently because
of a performance regression with software rendering. So let's
wait longer for the browser, but soft fail if it takes longer
than 45 seconds.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
The behavior after we click 'Restart to Install Updates Now'
button has changed in KDE 6.2. The default choice is no longer
'Install Updates and Restart' (even though that's what the button
says), and there is no timer. So if we don't click anything, the
confirm overlay just stays open forever.
This makes us click on the appropriate confirmation button if we
see it. We can also use this to make the test run a bit faster on
other releases, I guess.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
In a couple of cases we type something that *doesn't* start with
a 'k', so we should use that other letter for the workaround.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
The old needle was still matching but on the wrong X button,
so we dismissed the wrong notification and tests failed. This
seems to solve it.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
This should make the installer image build test work for ELN,
so we can try doing some update tests on ELN.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
There's some ambiguity about the case of the ELN version string.
Currently it's "ELN", it's going to be "eln" soon. Let's just
always use case-insensitive comparisons.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
