1
0
mirror of https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git synced 2024-12-05 03:23:09 +00:00
Commit Graph

58 Commits

Author SHA1 Message Date
Adam Williamson
50b4e70a1f Old needle cleanup 2024-01-02
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-03 17:48:30 -08:00
Adam Williamson
3e2b96f33c Make blivet-gui 'folder' volume icon needle not workaround
Per the upstream issue, this change was intentional (as a 'least
worst' option), so we shouldn't mark the needle as workaround.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-05-26 11:38:44 -07:00
Adam Williamson
cdca89a9d7 Add link to explain blivet-gui 'workaround' needle
Add a link to the issue report for blivet-gui using an odd icon
for btrfs volumes, now I finally filed it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-05-26 10:24:33 -07:00
Adam Williamson
ea42516280 Update blivet part_boot-inactive needle
This is needed to make the LVM resize test work properly...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-05-16 15:46:00 -07:00
Adam Williamson
c9deb243cd Restore anaconda_blivet_part_inactive_boot tag
It's needed for install_blivet_resize_lvm to work properly.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-05-16 11:13:29 -07:00
Adam Williamson
d4136392d4 Old needle cleanup 2023-04-28
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-05-04 09:57:15 -07:00
Adam Williamson
c7e0af6e8c Simplify blivet_btrfs_preserve_home, drop unneeded needles
There's no need to do all this 'check whether it's selected and
click it if not' stuff (for three different mount points). Just
always click it. If it's already selected, clicking it again
doesn't hurt (one of these stanzas even clicks it *even if it's
selected*!)

If we need to cover both cases, we just need two needles with
the same tag, we don't need separate code paths. In each case,
though, we actually haven't matched one of the needles for ages
(the most recent was part_boot_selected, but now we're using
GPT by default, we won't hit that any more as it'll be the BIOS
boot partition that's selected by default), so delete the needles
we aren't matching any more. If we *do* hit any case where we
need to handle the 'other' state, we can just add the alternative
needle with the same tag.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-05-04 09:57:15 -07:00
Adam Williamson
73e9c5c27e Drop a check for ext4 filesystem already selected
This has not been hit for a year (on stg; three years on prod).
I *think* it would only be hit if we ran the test on an Everything
image, but as the test is now specifically associated with the
Server install DVD, that doesn't seem likely to happen.

If we somehow *do* hit ext4 pre-selected again, this can still
be handled simply by adding an alternate
anaconda_blivet_part_fs_ext4 needle which matches on ext4 already
being selected; that avoids the need to keep an alternate code
path around.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-05-04 09:57:15 -07:00
Adam Williamson
7abd61077e Update various anaconda and GNOME needles for icon theme changes
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-02-23 13:11:50 -08:00
Adam Williamson
fb93f0cc0d Update some anaconda blivet needles for changes in Rawhide
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-09-20 16:19:23 -07:00
Adam Williamson
f7a8550258 Create biosboot partitions in blivet tests
From anaconda-37.12.1, anaconda defaults to GPT for all BIOS
installs. So we need to create a BIOS boot partition when doing
a BIOS install. I think all other potential configs (x86_64
UEFI, aarch64 (UEFI), ppc64le (OFW)) are covered under the other
two paths, so just making this `else` should be OK.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-08-16 15:39:38 -04:00
Adam Williamson
bc82572a4f Update some more anaconda needles for new icon theme
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-08-11 13:59:20 -07:00
Adam Williamson
10df5a57bf Update a bunch of needles for GNOME and adwaita-icon-theme 42
GNOME 42 and adwaita-icon-theme 42 changed a lot of things in
GNOME and anaconda, we need to update all these needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-20 15:52:42 -08:00
Adam Williamson
803ae7ca57 Add a test of an additional repository using a metalink (#198)
As suggested by @kparal, this adds a test that specifies an
additional repository using a metalink. The repository contains
a single package, 'testpackage', that supplements glibc (so it
should always get installed). The test runs an install then
checks that testpackage got installed.

We also deduplicate a pair of needles which were matching on the
same anaconda UI feature (an "add" button) and use that same
needle in this test.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-08-18 14:03:27 -07:00
Adam Williamson
492fcf62e4 Great Needle Cleanup 2021
Remove a whole chunk of needles that haven't matched for more
than 3 months. Also move a few needles to appropriate locations,
simplify some code chunks that relied on removed needles (if
we're not matching the needles, we don't need those chunks any
more), and drop some other no-longer-needed conditionals for
older releases.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-08-10 11:57:48 -07:00
Adam Williamson
2a7787c1da Update lots of needles for os-autoinst behaviour change
Recent git os-autoinst no longer downsamples screenshots as far
as it did before comparison. This makes a lot of needles where
colors have changed slightly no longer match, so they all needed
updating.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-07-19 13:03:11 -07:00
Adam Williamson
fcf96f73b7 Tweak Blivet LVM device type needles
There's some cheating/sloppiness going on here, with the same tag
and sometimes same needle being used to match "LVM2 Volume Group"
and "LVM2 Logical Volume". Today this caused us to pick the thin
pool entry instead in a test, so let's just clean this up and do
it right, with separate needles for matching each thing.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-07 18:16:46 -07:00
Lukáš Růžička
866a8efa72 Add a new testcase to test creation of LVM with ext4 using Blivet.
This PR adds a test that uses the Blivet interface to create an LVM
layout with ext4 filesystem as well as a postinstall test that checks
that the LVM layout has been created correctly.
2021-02-19 13:42:20 -08:00
Lukáš Růžička
ecca7d3c01 Create testcase to recreate Btrfs layout using Blivet and preserve home.
This PR uses the Anaconda Blivet partitioning to recreate a partition
layout while preserving the content of the /home subvolume.

It also adds the postinstall test to check that the home has been
preserved.
2021-01-28 09:51:32 +01:00
Michel Normand
e9c15a502a ppc64le changes in disk_custom_blivet_resize_lvm.pm
Required because ppc64le has a PReP partition
before boot partition.
PReP partition must not be changed by this script.

Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
2021-01-12 11:14:17 +01:00
Adam Williamson
a2bbd5ecfb Add some needles for universal tests with btrfs default
The 'universal' tests have quite a few failures if you run them
on an image where btrfs is the default (currently they usually
run on the Server DVD, where xfs-on-LVM is still the default).
This fixes some of them, the others would need code fixes.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-09-11 16:20:12 -07:00
Adam Williamson
2e21161785 Update various needles for a GNOME symbol change
The little triangle that's used on drop-down menus and stuff got
bigger. That breaks all these needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-06-05 14:27:34 -07:00
Lukáš Růžička
b5169e602b Use existing needles for fs selection. 2020-05-27 15:54:10 -07:00
Lukáš Růžička
c9bc7f0570 Rename needles to match the tag. 2020-05-27 15:54:10 -07:00
Lukáš Růžička
2a3e67991b Whitelist not recognized needles in check-needles.py 2020-05-27 15:54:09 -07:00
Lukáš Růžička
5f1db40ebe Add to templates. 2020-05-27 15:54:09 -07:00
Lukáš Růžička
c42f62da14 Create a test for resizing using custom partitioning 2020-05-27 15:54:09 -07:00
Lukáš Růžička
9efb0e10e6 Create a test to resize LVM partitions using Blivet. 2020-05-27 15:54:09 -07:00
Adam Williamson
9bad775aae Update a blivet needle for a change to check mark design
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-29 12:19:39 -07:00
Adam Williamson
dc7b7a7241 Great Needle Cleanup 2020
Remove a bunch of needles that have not been used for some time,
plus a few workarounds that are similarly stale.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-20 14:02:10 -07:00
Adam Williamson
95e6ddc896 Update blivet vdb selected needle yet again
I do not know why this needle seems so troublesome...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-25 23:02:29 -08:00
Adam Williamson
deab03a80d Update another partitioning needle for GTK+ widget changes
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-20 08:12:16 -08:00
Adam Williamson
12b0fb04dc Update a ppc64le-only blivet needle for Cantarell 0.201
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-24 15:20:54 +01:00
Adam Williamson
21febe3592 First batch of updates for new version of cantarell
Still need to do the non-English languages. I'll do those
tomorrow.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-17 01:18:52 +00:00
Adam Williamson
acf27fcd4a Update the blivet 'bluebox-alt' needle used on alt arches
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-06 10:56:44 -08:00
Adam Williamson
7fbaa426e8 Update a bunch of needles for font rendering change in Rawhide
Not sure what changed; it seems like mostly browser needles got
broken, but there's a few installer needles too.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-11-29 13:00:54 -08:00
Adam Williamson
0f9fd1a76a Add alternative vdb selected needle for new blue checkboxes
This checkbox sometimes renders slightly differently, especially
on non-x86_64. We're not really sure why, but we just add more
needles to handle it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-16 11:23:47 -07:00
Adam Williamson
a3c207a045 Add a few more 'blue button' needle variants
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-05 18:09:14 -07:00
Adam Williamson
26308a6b47 Update rarely-used installer ext4/xfs partitioning needles
These only get used when we run universal tests on a non-Server
image, which is pretty rare (these days, as Server DVD is a
critical image and composes fail if it fails, it only really
happens when we do it manually for some reason, like I did
today). So they get stale and aren't updated for font rendering
changes and stuff. As I said I had to do a run like that today,
so I had to update all these needles...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-28 14:04:13 -07:00
Adam Williamson
77a6c0ed4d Add yet another variant 'vdb selected' needle
This screen often seems to show slight variances in color,
really not sure why.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-26 16:28:44 -07:00
Guy Menanteau
9475fec56f New needle anaconda_blivet_vdb_selected-20190416
as previous needle only matched 96%
https://openqa.stg.fedoraproject.org/tests/520670#step/disk_custom_blivet_software_raid/36

Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
2019-04-16 17:01:13 +01:00
Adam Williamson
bd4edb0da7 GTK+ 3.24.5 needle retake
New GTK+ changed something so the background of many interface
elements is a slightly lighter grey, this broke a bunch of
needles. Here are the retakes. Includes one not-strictly-related
SDDM update and a rename of the one @lruzicka did to match the
others.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-02-06 13:27:30 -08:00
Adam Williamson
ad29a8fcde Great Stale Needle Cleanup 2018: anaconda
It's my second least favorite day of the year again: Stale
Needle Cleanup Day!

This should get rid of all anaconda needles that definitely are
not being used any more. A few borderline cases (where I'm not
100% sure if they may still be useful in odd corner cases, like
running universal tests on non-server images, and runs outside
of the US, and stuff) are kept around.

Cleanup of all non-anaconda needles will be in the next commit.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-12-17 16:30:57 -08:00
Adam Williamson
5d501433e8 Add another cantarell111 needles (for non-x86_64 arches)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-09-26 23:15:11 -07:00
Adam Williamson
e9785f5e5a Add a few more Cantarell 0.111 needles
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-09-16 08:44:38 -07:00
Adam Williamson
1034104526 Add a large chunk of needles for Cantarell 0.111
This should cover nearly everything, I hope.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-09-10 02:44:50 -07:00
Adam Williamson
22dc620fa7 Add a couple more cantarell 101 needles (ppc64)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-04-25 15:16:08 -07:00
Adam Williamson
7643357397 Another cantarell101 needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-03-16 13:10:06 -07:00
Adam Williamson
fa73d2b8be Initial dump of Cantarell 100 / 101 needles
There will be more to come, but I want to push these out and go
to sleep.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-03-16 04:44:17 -07:00
Adam Williamson
672d60a840 Clean up a whole bunch of unused needles
Time for an annual spring clean. Based on the admin UI's list
of needles that haven't been matched for a long time, but with
some manual tweaking (some are actually still needed).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-01-02 16:13:47 -08:00