Commit Graph

949 Commits

Author SHA1 Message Date
Adam Williamson a64cadb8fe Make the Software welcome->ignore change in apps_startstop too
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-01-11 09:16:31 -08:00
Adam Williamson 2a157bbd4e Fix up the Ignore button clicking
The dialog moves a bit.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-01-09 11:45:03 -08:00
Adam Williamson 2db1e57674 Check for 3rd-party popup instead of 'welcome' screen
GNOME Software no longer has a welcome screen in any current
Fedora (it was dropped between 35 and 36), but in Rawhide it now
has a popup that prompts you to enable third-party repos which
we need to get rid of, so just convert the welcome screen check
to handle that, and drop all the welcome screen needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-01-09 10:34:27 -08:00
Adam Williamson 8a36423314 remote_logging_server: sleep at the end
It seems ending the test right after we create the mutex can
cause the client not to catch it, sometimes. So let's sleep for
a few seconds after creating it to make sure it does.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-24 14:30:03 -08:00
Adam Williamson 1dfae9b44e ...and in the other file too.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-24 13:42:16 -08:00
Adam Williamson 21d14ac93d remote_logging: ugh, need to include utils too
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-24 13:31:58 -08:00
Adam Williamson 0a4d86e7bf remote_logging tests: do repo_setup
These tests weren't doing it, I guess it's just an oversight;
this is probably why they often fail on slow repos.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-24 09:57:22 -08:00
Adam Williamson fa3881e80e Revert "Use older grub for _support_server tftp to fix PXE (#2152763)"
This reverts commit 61d77ee108.
The bug looks to be fixed now, and the fix hit stable for F37,
so this should no longer be necessary.
2022-12-23 11:17:00 -08:00
Adam Williamson 2c1a0e8128 desktop_update_graphical: disable koji-rawhide on update tests
...or else we get stuff like
https://openqa.fedoraproject.org/tests/1649309#step/desktop_update_graphical/40

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-16 23:23:26 -08:00
Adam Williamson 6daf9c36a0 Make rpm-ostree tests generic, run on Silverblue and CoreOS
This makes the two rpm-ostree tests written for IoT - overlaying
and rebasing - work across all rpm-ostree-based flavors we
currently test (IoT, CoreOS and Silverblue) and runs them on
all those flavors.

This requires some other changes. For the Workstation ostree
installer update tests, we have install_default_update_ostree
upload a disk image and run these tests on that image. That means
install_default_update_ostree cannot use a scratch disk (as if
we boot it with two disks but only upload one, the subsequent
tests fail to boot, looking for the missing second disk), but its
specified disk size should be large enough for all updates.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-16 08:44:43 -08:00
Adam Williamson 3754ab3d8a Drop all handling of MODULAR
This was from years ago when we briefly did "modular composes".
That died and ain't coming back.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-15 11:10:40 -08:00
Adam Williamson a566f01a79 _boot_to_anaconda: extend the sleep before bootloader re-check
What's supposed to happen here is the `do_bootloader` invocation
a few lines back boots to the installer, then here, we wait for
the install to complete and the system to reboot, and match the
bootloader again. However, on PXE installs, the bootloader screen
can hang around for quite a long time here, and if it does, we
can match it again before the installer starts up, and move on
too early. Hence the sleep.

It seems on current Rawhide 20 seconds isn't long enough - we're
still matching the installer bootloader after the sleep, see
e.g. https://openqa.stg.fedoraproject.org/tests/2431660#step/_boot_to_anaconda/3
This is causing the test to almost always fail (it'll only pass
if the install+reboot takes less than five minutes). Let's bump
it to 60 seconds and hope that's long enough.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-14 12:29:00 -08:00
Adam Williamson 2023172c24 Revert "Try and workaround IoT rebase problems with F37 read-only change"
This reverts commit 093da03139.
As the comment says, this should be safe now F37 is stable.
2022-12-13 14:34:34 -08:00
Adam Williamson 5b3e90e032 _software_selection: simplify a grep (F35 is EOL)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-13 14:34:34 -08:00
Adam Williamson 0b8d1a58e0 desktop_printing: drop gedit, F35 is EOL
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-13 14:34:34 -08:00
Adam Williamson 5acd4ea80b Update notes about clicking root password screen in anaconda
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-13 14:34:34 -08:00
Adam Williamson c6fe9743bd cockpit_autoupdate: update note on the 30s sleep workaround
Sadly, dropping this sleep caused the test to start failing
again at least on F36, so we still need it - update the note.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-13 14:34:05 -08:00
Adam Williamson d28f520dbf os_release: drop a now-unneeded > 34 conditional
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-13 12:45:20 -08:00
Adam Williamson 079eecf23c Update notes about power menus in desktop_login
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-13 12:45:20 -08:00
Adam Williamson a664c10817 _check_install_source: drop branches for EOL releases
Thankfully this all calmed down a bit so we can simplify it a
lot. Clean things up a bit at the same time; escaping nested
single quotes is a lot clearer than concatening blocks with
different quote marks.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-13 12:45:20 -08:00
Adam Williamson ea8e1f950d Drop #2120433 workaround
The bug seems to have gone away, at least I don't see that this
soft failure has been hit much for the last two months.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-13 12:45:20 -08:00
Adam Williamson 2226cea183 Update note as to why we use tty1 in desktop_notifications
It's been on 1 so long now I kinda don't want to change it to 3
or 4 or anything. That might break something. As long as it's not
causing any trouble let's just leave it on 1.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-13 12:45:20 -08:00
Adam Williamson fecf4ea595 Simplify condition for disabling dnssec on FreeIPA upgrade test
We don't need the release number part any more, it's always
more than 34.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-13 12:45:20 -08:00
Adam Williamson 61d77ee108 Use older grub for _support_server tftp to fix PXE (#2152763)
PXE install on UEFI (incl. aarch64) is failing at present, this
seems to be due to a grub bug:
https://bugzilla.redhat.com/show_bug.cgi?id=2152763
we're really intending to test the client side here, not the
server end, so let's work around this problem on the server end
by installing a grub2 scratch build that's the package from just
before the bad change, but with the release and epoch bumped,
from a side repo.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-12 17:51:52 -08:00
Adam Williamson ffbb618d03 Simplify _graphical_wait_login welcome screen logic
This turns out to be overcomplicated. We don't need the special
handling for updates any more, because a few months after we
implemented it, we had to make sure the affected update tests had
an empty START_AFTER_TEST anyway, or else openQA would refuse to
schedule them. So we can just rely on the START_AFTER_TEST
condition for those now. We also don't need the additional
INSTALL_NO_USER condition; the only case where it's actually used
is for install_arm_image_deployment_upload on Workstation, and
that test does not have START_AFTER_TEST set, so the other
condition catches it for welcome screen handling purposes. There
is no need to nest the IMAGE_DEPLOY conditional inside a check
for the desktop and the INSTALL_NO_USER var either; we don't
test any other desktop on ARM, and the IMAGE_DEPLOY var is only
set for that one install_arm_image_deployment_upload test.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-12 08:48:53 -08:00
Adam Williamson f915297475 Use buildroot repo for Rawhide image builds also
We recently started using the buildroot repo for Rawhide update
tests, but weren't including it in the image build tests. This
should include it in all the image build tests.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-12 08:42:18 -08:00
Adam Williamson f752b4c00a Don't snapshot after wait_login tests (usually)
We currently snapshot after every run of _console_wait_login or
_graphical_wait_login, which means we snapshot *twice* on most
update tests as those modules get run twice. However, we almost
never use those snapshots. Snapshotting takes quite some time,
and hits the disk pretty hard, so we should avoid it unless it
is really needed.

We only have a few modules that are not fatal (and so might use
the snapshots), and most of those don't run after one of these
tests, or run after a later module that's also a milestone. Best
I can tell, only two test suites really need to use a snapshot
from a login test: server_cockpit_updates and modularity_tests.
To handle these and potential future cases, we'll add a new
module that does nothing, but is marked 'milestone', so it will
take a snapshot, and load that test after the login test if the
var LOGIN_SNAPSHOT is set, and set that var for those two suites.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-08 09:59:23 -08:00
Adam Williamson a13cd7a08a Add `--squashfs-only` to lorax args
We started using this in real composes a year or two back, so
openQA should do the same. It drops the nesting of an ext4 fs
image inside a squashfs image, just using a single squashfs
image instead. This results in smaller images - missing this
is why the images built by openQA were coming out larger than
the real ones.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-07 14:03:19 -08:00
Adam Williamson 4d3673f811 Simply abrt KDE stuff even more
...wait, this is what 'workaround' needles are for.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-07 11:30:08 -08:00
Adam Williamson 9c6d5459e6 Simplify the KDE abrt logic
This does the same, just cleaner.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-07 11:26:27 -08:00
Lukáš Růžička 179764d49c Fix tests for Maps.
* Scarborough provided quite a messy map that resulted
in frequent needle failure. Changing the location
for something better to make it more reliable.
* The zoom test could have failed with a low resolution
image. Adding some timeout to the needle give more
time to load the proper image.
2022-12-07 11:52:11 +01:00
Lukáš Růžička 0cb57e7511 Add timeout 30 secs to make less fragile.
The check_screen function checks for the existing tag
but it only waits 1 second by default. In this time,
Abrt will not even start so we need to prolong
the check_screen timeout to make sure the application
has started (or at least give it enough time to try).
2022-12-07 10:00:33 +01:00
Adam Williamson 98653847d3 Add missing single quotes
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-06 14:01:51 -08:00
Adam Williamson 7536b6ce10 ostree_build: tee and timestamp the `rpm-ostree` output
Instead of just redirecting it to a log file, let's tee it, so
simple errors can be read off a screenshot without bothering to
download the file. Also, let's timestamp it (via `ts` from
moreutils) so we can see which bits of it take a long time...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-06 13:38:57 -08:00
Lukas Ruzicka 1605706fb3 Set timeout to 60 on startstop needles. 2022-12-05 15:16:16 +01:00
Lukas Ruzicka f29572ba76 Abrt should not fail on found issues but softfail on startup tests. 2022-12-05 14:30:03 +01:00
Lukas Ruzicka 7daa4b3dd0 Give more time to the needle to avoid failing on delayed start. 2022-12-05 14:03:48 +01:00
Adam Williamson 1ae7065961 ostree: use scratch disk as target for rpm-ostree compose
Seems like we might be running out of space on this step on F35.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-03 16:16:39 -08:00
Adam Williamson c2fb8fa83b Use 'main' branch for ostree-parse-pungi.py checkout
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-03 12:29:23 -08:00
Adam Williamson 37412b95a8 ostree_build: bump timeout on ISO build
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-12-03 11:10:37 -08:00
Adam Williamson 03b6663339 Add tests to build a Silverblue installer image and install it
This is like the existing tests that build network install and
live images then install them, only for Silverblue. First we
build an ostree, using the standard configuration for the release
and subvariant but with the 'advisory' and 'workarounds' repos
included, so it will contain current stable packages plus the
packages from the update and any workarounds. Then we build an
ostree installer image with the ostree embedded, again including
advisory and workarounds repos in the installer build config so
packages from them will be included in the installer environment.
The image is uploaded, which completes the _ostree_build test.
Then an install_default_update_ostree test runs, which does a
standard install and boot from the installer image.

We do make a change that affects other tests, too. We now run
_advisory_post on live image install tests, as well as this new
ostree install image install test. It was skipped before because
of an exception that's really only needed for the netinst image
install test. In that test, packages from the update won't be
included in the installed system, so we can't run _advisory_post
on it. But for ostree and live image build/install tests, the
installed system *should* include packages from the update, so
we should check and make sure that it does.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-11-30 13:17:28 -08:00
Adam Williamson 137f2a2176 nautilus: check app started *before* trying to fullscreen it
Seems to make a lot more sense this way around.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-11-29 09:41:47 -08:00
Adam Williamson 9d8a35ed39 cockpit: don't try and get admin privs when re-logging in
There's one point in the tests where we may log into cockpit for
the second time in one run (it depends how a package update
process goes). When this happens, we don't get prompted again
for admin access, so we need to *not* expect that.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-11-25 11:24:52 -08:00
Lukas Ruzicka d4717ff090 Create test suite for Maps. 2022-11-21 18:17:11 +00:00
Adam Williamson 3c13f02679 Revert "_advisory_update: stop the graphical desktop at the start"
This reverts commit 3208d15725 and
the two follow-ups. I'm hoping
https://bugzilla.redhat.com/show_bug.cgi?id=2133829 is now
resolved; this was intended to help with that (though I'm not
sure it ever really did), and so we can hopefully ditch it, which
simplifies this code.
2022-11-18 12:23:33 -08:00
Adam Williamson 82588f4a52 Revert GTK focus bug workarounds
This reverts the last few commits which worked around a focus bug
in GTK. This bug is now (I hope) fixed, so I'm dropping the
workarounds so the tests will confirm whether it's fixed.
2022-11-02 11:03:02 -07:00
Lukas Ruzicka 3e096234d9 Move cursor out of the way in the text field. 2022-11-02 08:42:14 +01:00
Lukas Ruzicka 8dfcbfee48 In Gnome-Text-Editor perform an extra click to move the focus inside the text area. 2022-11-01 18:03:29 +01:00
Lukas Ruzicka c394603058 Make an extra click into the the list view to force correct focus. 2022-11-01 17:35:23 +01:00
Lukas Ruzicka aa98b12c5c Make install times longer to prevent failures on slow VMs 2022-10-31 15:56:04 +01:00