Commit Graph

69 Commits

Author SHA1 Message Date
Adam Williamson 1a65993d36 Add a perltidy check and apply it to the entire codebase
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-28 14:38:38 -07:00
Lukáš Růžička 621f6c13b5 Add wait time to let the application start properly. 2022-07-19 14:49:26 +02:00
Adam Williamson f81dab6739 Clocks: handle auth, check we actually launched the app
Clocks' aaa_setup did not ever actually check the app launched
properly. It also doesn't handle granting permissions if
necessary, which the apps_startstop test for Clocks does do.

This makes the permission check in the apps_startstop test more
efficient, and adds it to the Clocks app aaa_setup test too.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-06-30 13:56:29 -07:00
Lukáš Růžička d09d9d8fe6 Fix the Rhythmbox crash when launched for the first time. 2022-06-15 15:53:20 +02:00
Adam Williamson 1084aa0828 Update KDE vault needles and test
The backend is now cryfs in F36/Rawhide. I don't think we need
to be policing which backend Vault decides to use, so let's just
accept either.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-03-03 08:42:45 -08:00
Adam Williamson 1aee5d1ec0 Avoid duplication between desktop_update and 'software' app test
The 'software' test module in GNOME apps_startstop does a subset
of what the desktop_update_graphical test does already, but
using its own needles. Let's just have it use the same needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-03-01 15:58:45 -08:00
Adam Williamson 752a9476be Drop KDE app 'netcon' test
This was originally a test of nm-connection-editor. However,
at some point that app stopped shipping a .desktop file by
default (it's in a subpackage that is not included in a default
KDE install) and the needle got updated to match on what the
same string now launched, which is a random part of the KDE
system settings. But there's no real sense in this - we don't
test launching every other pane of the system settings app from
the launcher, so it doesn't make sense to just test one random
one like this. Let's just throw the test out.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-25 12:37:53 -08:00
Adam Williamson fcac2af4f8 Update and rationalize KDE app "cancel" needles
We have three different needles which all match on a stock KDE
"cancel" button. Let's just have one. Also, update it for latest
Rawhide/F36 KDE.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-25 12:22:47 -08:00
Adam Williamson 4282048819 Drop screenshot app from GNOME app start/stop tests
It was removed from the default install:
https://pagure.io/fedora-comps/c/5371509
in favor of a new screenshot mechanism that's built in to GNOME
Shell.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-02-09 10:23:38 -08:00
Adam Williamson 3ae23f66a9 Update GNOME apps test for gedit->gnome-text-editor switch
Workstation replaced gedit with gnome-text-editor. This updates
the needles and also changes the name used for 'tagging' the
application for the core_applications test.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-01-18 15:11:50 -08:00
Adam Williamson d5ca75cb04 Also remove system-config-language test from KDE app test
This was also dropped:
https://pagure.io/fedora-kickstarts/c/5b5fba2

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-01-12 17:26:37 -08:00
Adam Williamson 4e15e16824 Drop kcolorchooser and kruler from KDE apps test
Both were dropped from the default KDE install set:
https://pagure.io/fedora-comps/c/edd0d74
so we need to drop them here too.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-01-12 16:59:13 -08:00
Adam Williamson 74927d154a KDE apps: make firefox test handle no 'close tabs' case
Lately Firefox sometimes just closes immediately, it doesn't
show the 'close tabs' dialog. So let's make that optional, but
check we quit properly.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-11-24 10:24:54 -08:00
Adam Williamson de939c17df Update and rationalize KDE "next" needles
kgpg had its own, which doesn't make any sense. There are grey
and blue background variants that weren't consistently named.
This should rationalize things sensibly, and adds a new needle
for the new Plasma in Rawhide, with a lighter blue background.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-09-29 11:05:40 -07:00
Adam Williamson 05a43bdb3c Boxes: workaround #2005458 by hitting esc twice (with softfail)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-09-17 14:33:09 -07:00
Adam Williamson 9882ddcaa5 Robustify and tweak switch out of overview on GNOME boot
This fails sometimes just because we're too early, or something.
Also with GNOME Shell 41rc, alt-f1 no longer works to open and
close the overview. super *does* seem to work in KDE these days,
so let's switch from alt-f1 to super everywhere.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-09-07 11:05:55 -07:00
Adam Williamson 492fcf62e4 Great Needle Cleanup 2021
Remove a whole chunk of needles that haven't matched for more
than 3 months. Also move a few needles to appropriate locations,
simplify some code chunks that relied on removed needles (if
we're not matching the needles, we don't need those chunks any
more), and drop some other no-longer-needed conditionals for
older releases.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-08-10 11:57:48 -07:00
Adam Williamson 2f4ef74def Avoid a needle duplication in KDE vault test
"show_hidden_icons" is the same thing as "desktop_expand_systray".

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-07-17 12:40:15 -07:00
Adam Williamson 6a79565afa Fix up KDE 'plasma-disks' test stuff
In #235 we accidentally included an entire disks.pm test that
wasn't meant to be there - the infocenter module test is the
right thing to exercise plasma-disks, there is no standalone
app, running 'disks' just gets you the KDE Partition Manager,
which we already test. So this removes that test and renames a
needle that looks like it's for that test but is actually for
the kinfocenter module, to make this clearer.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-21 15:16:40 -07:00
Lukáš Růžička 9f0103a95f Enhance the Infocenter test to test the presence of Disks module. 2021-06-18 11:39:28 -07:00
Lukáš Růžička 2c366cc7a4 Add startstop test for Plasma Vault. 2021-06-18 11:39:24 -07:00
Adam Williamson 5a9a65bb5b Remove juk and kget from KDE app tests
They were removed from comps in c4d9287.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-08 15:18:02 -07:00
Adam Williamson 3b4d0aa00b Revert "Prevent the Konqueror test from running on F32 and later."
This reverts commit 603ee871c1. We
are well past F32 at this point so it's not longer needed. Just
wipe the test entirely instead.
2021-06-08 15:17:25 -07:00
Adam Williamson a01d8b6148 GNOME: Document Scanner no longer in utilities either
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-24 17:31:03 -07:00
Adam Williamson 1a16a5a379 System Monitor not in utilities any more, either
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-24 17:19:20 -07:00
Adam Williamson c4f60ab274 GNOME apps: Calculator and Help aren't in utilities any more
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-24 16:03:33 -07:00
Adam Williamson ac9edb4cfb GNOME apps: drop Archiver test
The app was dropped from Workstation's default package set a few
days ago. See:
https://pagure.io/fedora-workstation/issue/167

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-05 18:25:29 -08:00
Adam Williamson 3b0dc6b021 kgpg: don't try and close tip of the day any more
Main UI appears over the tip of the day now, so we can ignore it
and just check the UI ran then close it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-05 17:49:28 -08:00
Adam Williamson 3c92696d98 Convert ksysguard test to Plasma system monitor test
These were switched out in comps recently.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-05 17:20:59 -08:00
Adam Williamson f6fa89f2cf Remove falkon, k3b, krusader, ktorrent from KDE app startstop
They have all been dropped from the spin recently. Remove all
related needles too.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-05 15:58:37 -08:00
Adam Williamson 4758782d56 KDE apps: replace Calligra with LibreOffice
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-04 08:58:55 -08:00
Adam Williamson 1c33d07d38 Drop workaround_ble26, bug was fixed months ago
https://pagure.io/background-logo-extension/issue/26 was fixed
months back, we don't need this any more.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-15 15:36:04 -07:00
Adam Williamson 40974c2f94 Simplify Krusader app test
We don't need a separate 'welcome' needle because it just matches
on an OK button anyway. So turn that needle into an OK needle
(we don't have any existing 'blue OK button' needle) and simplify
the logic to a single loop for kde_ok and krusader_settings_close.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-08 14:47:46 -07:00
Adam Williamson 3f6ac527bb Apply overview workaround to yet one more test
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-07-09 14:29:49 -07:00
Adam Williamson 4a6cd8bcd5 Abstract out overview type-to-search bug workaround
And also use it in GNOME apps settings.pm test.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-07-09 14:25:22 -07:00
Lukáš Růžička 61f845dbbf Make solidify_wallpaper more universal to handle different desktops. 2020-05-05 00:14:35 +00:00
Lukáš Růžička f3d6a9574c Add desktop login test, revise and rename check_desktop
This adds a new test that implementsQA:Testcase_desktop_login
on both GNOME and KDE.

While working on this, we realized that the "desktop_clean"
needles were really "app menu" needles, and for KDE, this was
a duplication with the new "system menu" needles, because on KDE
the app menu and the system menu are the same. So I (Adam)
started to de-duplicate that, but also realized that "app menu
button" is a much more accurate name for these needles, so I was
renaming the old desktop_clean needles to app_menu_button. That
led me to the realization that "check_desktop_clean" is itself a
dumb name, because we don't (at least, any more, way back in the
mists of time we may have done) do anything to check that the
desktop is "clean" - we're really just asserting that we're at a
desktop *at all*. While thinking *that* through, I *also* realized
that the whole "open the overview and look for the app grid icon"
workaround it did is no longer necessary, because GNOME doesn't
use a translucent top bar any more. That went away in GNOME 3.32,
which is in Fedora 30, our oldest supported release.

So I threw that away, renamed the function "check_desktop",
cleaned up all the needle naming and tagging, and also added an
app menu needle for GNOME in Japanese because we were missing
one (the Japanese tests have been using the "app grid icon"
workaround the whole time).
2020-04-17 17:27:04 -07:00
Lukáš Růžička 603ee871c1 Prevent the Konqueror test from running on F32 and later.
Rework changes after the review.
2020-04-02 14:08:19 +02:00
Lukáš Růžička 29f9da9331 Revert "Prevent the Konqueror test from running on F32 and later."
This reverts commit 00b756f0e2.

Unfortunately, I made a typo in the script and the fix did not
work. I do not want to rebase the master (in order not to break
things for everyone) so I am reverting again.
Sorry.
2020-03-31 13:04:50 +02:00
Lukáš Růžička 00b756f0e2 Prevent the Konqueror test from running on F32 and later. 2020-03-31 09:37:11 +02:00
Lukáš Růžička a54f020118 Revert "Fix the Konqueror test - handle Locations dialogue."
This reverts commit d784bf54ca.

It turned out that Locations are not connected to Konqueror
at all. The reason why the test is failing is that the
application has been removed to limit the number of
web browsers.
2020-03-31 09:23:13 +02:00
Lukáš Růžička d784bf54ca Fix the Konqueror test - handle Locations dialogue. 2020-03-26 10:57:00 +01:00
Adam Williamson 37f597229a Boxes: drop RHBZ #1692972 workaround, fix for <F32
RHBZ #1692972 was fixed long ago, so we don't need to worry
about that any more. But this test failed on the recent F31 live
respin compose because it was changed to assume the tutorial
would appear on startup, which only happens on F32+. To make the
test work on F31 respins, let's handle both paths. Once F32 is
stable we can drop this as we won't run the test on F31 any more
after that.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-20 14:02:18 -07:00
Lukáš Růžička d19cf9553e Reneedle the Gnome Application StartStop tests. 2020-03-18 18:06:34 +01:00
Lukáš Růžička 5bfc22800c Assert that terminal is really running (#144) 2020-02-25 10:24:38 +01:00
Adam Williamson 0b1d481ae1 Wait a bit longer for different dialogs in KDE app kontact test
See https://openqa.fedoraproject.org/tests/498083 , we didn't
wait long enough for Enable Unified Mailboxes.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-12-14 08:57:32 -08:00
Adam Williamson 5c03c435ca Stop having two 'firefox close tabs' needle tags, drop old ones
We still have a 'apps_run_firefox_stop' needle tag which is for
the same thing as 'firefox_close_tabs'. That's dumb. Get rid of
it and only have the firefox_close_tabs tag and needles. Also
clean up some old firefox_close_tabs needles that haven't matched
for months and all the 'apps_run_firefox_stop' needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-11-29 12:10:35 -08:00
Lukas Ruzicka 22b185abf6 Enable tracking of executed applications in Application Start/Stop tests (FIXES #116)
This PR adds the following:
* moves out the presetting procedures, so that two long terminal tests do not have
to run twice
* add methods for application to register when successfully started
* adds a test that checks if all required applications have registered
2019-10-16 17:36:37 -07:00
Lukas Ruzicka 46bc71afd6 Delete the KDE test for Release Notes due to retirement. 2019-09-05 11:41:18 +02:00
Lukas Ruzicka 022865ab9f KDE app start/stop: launch apps with commands not menus
This is doing slightly less to exercise the launcher menus and see
whether icons appear or disappear, but it's much faster and more
reliable. We do still use menu launch for one app, just to check
the mechanism works in general.
2019-08-23 12:41:49 -07:00