This started out as just factoring out the repeated pattern for
launching a terminal on the desktop that came in with the i3
tests. But as I worked on desktop_login, which is a major user
of it, I noticed some potential cleanups and improvements in the
user switching stuff, and also realized we can turn that test
back on for KDE now - user switching was re-enabled in KDE a year
ago and is advertised to be reliable.
I don't think the "switch user from a lock screen" test fully
worked before, as we did not verify that we'd really switched
back to an existing session rather than starting a new one. Now
we do. Using the terminal to verify the logged-in user on all
desktops just keeps things simpler than using the kicker menu
on KDE (though if typing proves unreliable on KDE I may switch
this back).
Signed-off-by: Adam Williamson <awilliam@redhat.com>
There's no obvious reason we're not also running these tests on
updates, so let's do it. We have to skip the advisory and UEFI
post checks for desktop_login as the last step of that test is
shutting down the system.
We leave out desktop_login for now because of
https://gitlab.gnome.org/GNOME/gjs/-/issues/647
Signed-off-by: Adam Williamson <awilliam@redhat.com>
This avoids some magic waits by asserting screens (which is much
more reliable), and combines KDE and GNOME flows in the
passwordless test by adding some needle tags to the nautilus
needles.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
This is still the case on the flatpak build as it runs behind the
RPM build, and would still be the case if we run the test on an
F40 respin for e.g.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
New anaconda-webui changes the disk selection flow a bit, this
adapts to it. We can drop the conditional and make it a straight
assert-and-click once the new webui is stable for F41 and F42.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
The behavior after we click 'Restart to Install Updates Now'
button has changed in KDE 6.2. The default choice is no longer
'Install Updates and Restart' (even though that's what the button
says), and there is no timer. So if we don't click anything, the
confirm overlay just stays open forever.
This makes us click on the appropriate confirmation button if we
see it. We can also use this to make the test run a bit faster on
other releases, I guess.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
The old needle was still matching but on the wrong X button,
so we dismissed the wrong notification and tests failed. This
seems to solve it.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
This may be a bug, but I'm not entirely sure. Seems like the
notification can show up with or without the button to view the
update.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
There's now a 'Network' entry that does the job of 'Other
Locations', the enter_address needle needed updating, and the
sftp_logged needle needed updating for ptyxis.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Let's not trust hitting enter in just one place but hit the save
button like we do elsewhere (this avoids an awkward issue where
hitting enter doesn't work on the new nautilus version). Also,
let's consolidate the needles under a sensible tag name.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
I forgot this needle has to be with terminal highlighted, not
just present. And now that's fixed, we need another needle for
a later point in the test.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Lately it seems to be clicking on one which doesn't show either
of the properties we currently detect above the fold, so let's
add another.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
In several places we run 'gnome-terminal' explicitly, but as of
today's compose, the default terminal app on GNOME in Rawhide is
ptyxis, not gnome-terminal.
Running 'terminal' should launch whichever is correct, so let's
consistently do that.
Also, add an apps_run_terminal needle and navigation navbar
needle for ptyxis.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
