needle clean up: no ENV-OFW, remove unused needles

Summary:
This removes a couple of unused needles. password_required
needles were dupes of console_password_required, and no tests
actually use password_required. tmp_failed_proc just isn't
used by anything at all (I think it was at some point used in
fedup tests).

This also drops the ENV-OFW-1 tag from all needles, which I
think got in because someone based a needle on a SUSE needle
which has that tag, then it spread. It's of no use or meaning
in Fedora.

Test Plan: Check all tests still run as normal.

Reviewers: garretraziel, jskladan

Reviewed By: jskladan

Subscribers: tflink

Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D579

needles/anaconda_install_destination_encrypt_data.json

@@ -3,7 +3,6 @@
     "anaconda_install_destination_encrypt_data",
     "ENV-DISTRI-fedora",
     "ENV-LANGUAGE-ENGLISH",
-    "ENV-OFW-1",
     "ENV-FLAVOR-server"
   ],
   "area": [

needles/anaconda_install_destination_encrypt_data_french.json

@@ -12,7 +12,6 @@
         "anaconda_install_destination_encrypt_data",
         "ENV-DISTRI-fedora",
         "ENV-LANGUAGE-FRENCH",
-        "ENV-OFW-1",
         "ENV-FLAVOR-server"
     ]
 }

needles/anaconda_install_destination_reclaim_space_delete_btn.json

@@ -3,7 +3,6 @@
     "anaconda_install_destination_reclaim_space_delete_btn",
     "ENV-DISTRI-fedora",
     "ENV-LANGUAGE-ENGLISH",
-    "ENV-OFW-1",
     "ENV-FLAVOR-server"
   ],
   "area": [

needles/anaconda_install_destination_reclaim_space_first_partition.json

@@ -12,7 +12,6 @@
     "anaconda_install_destination_reclaim_space_first_partition",
     "ENV-DISTRI-fedora",
     "ENV-LANGUAGE-ALL",
-    "ENV-OFW-1",
     "ENV-FLAVOR-server"
   ]
 }

needles/anaconda_install_destination_reclaim_space_second_partition.json

@@ -12,7 +12,6 @@
     "anaconda_install_destination_reclaim_space_second_partition",
     "ENV-DISTRI-fedora",
     "ENV-LANGUAGE-ALL",
-    "ENV-OFW-1",
     "ENV-FLAVOR-server"
   ]
 }

needles/anaconda_install_destination_save_passphrase.json

@@ -12,7 +12,6 @@
     "anaconda_install_destination_save_passphrase",
     "ENV-DISTRI-fedora",
     "ENV-LANGUAGE-ENGLISH",
-    "ENV-OFW-1",
     "ENV-FLAVOR-server"
   ]
 }

needles/anaconda_install_destination_save_passphrase_french.json

@@ -12,7 +12,6 @@
         "anaconda_install_destination_save_passphrase",
         "ENV-DISTRI-fedora",
         "ENV-LANGUAGE-FRENCH",
-        "ENV-OFW-1",
         "ENV-FLAVOR-server"
     ]
 }

needles/anaconda_install_source_check_repo_added.json

@@ -3,7 +3,6 @@
     "anaconda_install_source_check_repo_added",
     "ENV-DISTRI-fedora",
     "ENV-LANGUAGE-ALL",
-    "ENV-OFW-1",
     "ENV-FLAVOR-server"
   ],
   "area": [

needles/anaconda_install_source_check_repo_added_eurlatgr.json

@@ -3,7 +3,6 @@
     "anaconda_install_source_check_repo_added",
     "ENV-DISTRI-fedora",
     "ENV-LANGUAGE-ALL",
-    "ENV-OFW-1",
     "ENV-FLAVOR-server"
   ],
   "area": [

needles/anaconda_install_source_check_repo_added_inst_repo.json

@@ -12,7 +12,6 @@
     "anaconda_install_source_check_repo_added",
     "ENV-DISTRI-fedora",
     "ENV-LANGUAGE-ALL",
-    "ENV-OFW-1",
     "ENV-FLAVOR-server"
   ]
 }

needles/anaconda_install_source_on_the_network.json

@@ -3,7 +3,6 @@
     "anaconda_install_source_on_the_network",
     "ENV-DISTRI-fedora",
     "ENV-LANGUAGE-ENGLISH",
-    "ENV-OFW-1",
     "ENV-FLAVOR-server"
   ],
   "area": [

needles/anaconda_install_source_repo_select_mirrorlist.json

@@ -12,7 +12,6 @@
     "anaconda_install_source_repo_select_mirrorlist",
     "ENV-DISTRI-fedora",
     "ENV-LANGUAGE-ENGLISH",
-    "ENV-OFW-1",
     "ENV-FLAVOR-server"
   ]
 }

needles/anaconda_main_hub_install_destination_already_done.json

@@ -12,7 +12,6 @@
         "anaconda_main_hub_install_destination",
         "ENV-DISTRI-fedora",
         "ENV-LANGUAGE-ALL",
-        "ENV-OFW-1",
         "ENV-FLAVOR-server"
     ]
 }

needles/anaconda_main_hub_installation_source.json

@@ -3,7 +3,6 @@
     "anaconda_main_hub_installation_source",
     "ENV-DISTRI-fedora",
     "ENV-LANGUAGE-ENGLISH",
-    "ENV-OFW-1",
     "ENV-FLAVOR-server"
   ],
   "area": [

needles/anaconda_main_hub_select_packages.json

@@ -12,7 +12,6 @@
         "anaconda_main_hub_select_packages",
         "ENV-DISTRI-fedora",
         "ENV-LANGUAGE-ALL",
-        "ENV-OFW-1",
         "ENV-FLAVOR-server"
     ]
 }

needles/anaconda_select_install_lang_english_selected.json

@@ -13,7 +13,6 @@
         "anaconda_select_install_lang_filtered",
         "ENV-DISTRI-fedora",
         "ENV-LANGUAGE-ENGLISH",
-        "ENV-OFW-1",
         "ENV-FLAVOR-server"
     ]
 }

needles/anaconda_select_install_lang_french_selected.json

@@ -13,7 +13,6 @@
         "anaconda_select_install_lang_filtered",
         "ENV-DISTRI-fedora",
         "ENV-LANGUAGE-FRENCH",
-        "ENV-OFW-1",
         "ENV-FLAVOR-server"
     ]
 }

needles/boot_enter_passphrase.json

@@ -3,7 +3,6 @@
     "boot_enter_passphrase",
     "ENV-DISTRI-fedora",
     "ENV-LANGUAGE-ALL",
-    "ENV-OFW-1",
     "ENV-FLAVOR-server"
   ],
   "area": [

needles/boot_enter_passphrase2.json

@@ -3,7 +3,6 @@
     "boot_enter_passphrase",
     "ENV-DISTRI-fedora",
     "ENV-LANGUAGE-ALL",
-    "ENV-OFW-1",
     "ENV-FLAVOR-server"
   ],
   "area": [

needles/password_required.json

@@ -1,18 +0,0 @@
-{
-  "tags": [
-    "password_required",
-    "ENV-DISTRI-fedora",
-    "ENV-LANGUAGE-ENGLISH",
-    "ENV-FLAVOR-server"
-  ],
-  "area": [
-    {
-      "xpos": 0,
-      "ypos": 79,
-      "width": 72,
-      "height": 21,
-      "type": "match"
-    }
-  ],
-  "properties": []
-}

needles/password_required2.json

@@ -1,18 +0,0 @@
-{
-  "area": [
-    {
-      "type": "match",
-      "ypos": 95,
-      "width": 72,
-      "height": 21,
-      "xpos": 0
-    }
-  ],
-  "tags": [
-    "password_required",
-    "ENV-DISTRI-fedora",
-    "ENV-LANGUAGE-ENGLISH",
-    "ENV-FLAVOR-server"
-  ],
-  "properties": []
-}

needles/provided_second_partition_intact.json

@@ -3,7 +3,6 @@
     "provided_second_partition_intact",
     "ENV-DISTRI-fedora",
     "ENV-LANGUAGE-ALL",
-    "ENV-OFW-1",
     "ENV-FLAVOR-server"
   ],
   "area": [

needles/tmp_failed_proc.json

@@ -1,18 +0,0 @@
-{
-  "tags": [
-    "tmp_failed_proc",
-    "ENV-DISTRI-fedora",
-    "ENV-LANGUAGE-ENGLISH",
-    "ENV-FLAVOR-develop"
-  ],
-  "properties": [],
-  "area": [
-    {
-      "xpos": 71,
-      "ypos": 338,
-      "width": 251,
-      "height": 11,
-      "type": "match"
-    }
-  ]
-}