srbala/os-autoinst-distri-fedora
1
0
Fork 0
mirror of https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git synced 2025-10-15 08:08:50 +00:00
Code Issues Releases Activity

Add a simple perl lint script and fix all the errors it found

Browse Source 
This adds a script that checks for common whitespace issues
(per our house style) and can (if run with --write) correct some
of them. It adds a run of the script (without --write) to the
tox config, and includes fixes for all the issues the script
discovered in the existing tests and libs.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
This commit is contained in:
Adam Williamson 2022-07-27 11:25:00 -07:00
parent ad5eb54715
commit f0b9bd3e94
124 changed files with 507 additions and 397 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
lib/anaconda.pm
View File

@ -176,7 +176,7 @@ sub custom_blivet_add_partition {
}
sub custom_blivet_format_partition {
# This subroutine formats a selected partition. To use it, you must select the
# This subroutine formats a selected partition. To use it, you must select the
# partition by other means before you format it using this routine.
# You have to create a needle for any non-existing filesystem that is
# passed via the $type, such as anaconda_blivet_part_fs_ext4.
@ -202,14 +202,14 @@ sub custom_blivet_format_partition {
sub custom_blivet_resize_partition {
# This subroutine resizes the selected (active) partition to a given value. Note, that
# if the selected value is bigger than the available space, it will only be
# resized to fill up the available space no matter the number.
# resized to fill up the available space no matter the number.
# This routine cannot will not be able to select a particular partition!!!
my %args = @_;
# Start editing the partition and select the Resize option
assert_and_click "anaconda_blivet_part_edit";
assert_and_click "anaconda_blivet_part_resize";
# Select the appropriate units. Note, that there must a be needle existing
# for each possible unit that you might want to use, such as
# for each possible unit that you might want to use, such as
# "anaconda_blivet_size_unit_gib".
assert_and_click "anaconda_blivet_part_drop_select";
assert_and_click "anaconda_blivet_size_unit_$args{units}";
@ -365,7 +365,7 @@ sub crash_anaconda_text {
# This routine uses the Anaconda crash trigger to break the ongoing Anaconda installation to simulate
# an Anaconda crash and runs a series of steps that results in creating a bug in Bugzilla.
# It is used in the `install_text.pm` test and can be switched on by using the CRASH_REPORT
# variable set to 1.
# variable set to 1.
#
# First let us navigate to reach the shell window in Anaconda using the alt-f3 combo,
# this should take us to another terminal, where we can simulate the crash.
@ -395,7 +395,7 @@ sub report_bug_text {
# a textual console.
# We will not create a needle for every menu item, and we will fail,
# if there will be no positive Bugzilla confirmation shown at the end
# of the process and then we will fail.
# of the process and then we will fail.
#
# Let us record the time of this test run. Later, we will use it to
# limit the Bugzilla search.
@ -419,12 +419,12 @@ sub report_bug_text {
type_password $password;
type_string "\n";
sleep 10;
# Save the report without changing it.
# Save the report without changing it.
# It would need some more tweaking to actually type into the report, but since
# it is reported even if unchanged, we leave it as such.
type_string ":wq\n";
# Wait until the Crash menu appears again.
# The same screen shows the result of the Bugzilla operation,
# The same screen shows the result of the Bugzilla operation,
# so if the needle matches, the bug has been created in Bugzilla.
# Bugzilla connection is slow so we need to wait out some time,
# therefore let's use a cycle that will check each 10 seconds and
@ -435,7 +435,7 @@ sub report_bug_text {
++$counter;
}
# Sometimes, Bugzilla throws out a communication error although the bug has been
# created successfully. If this happens, we will softfail and leave the creation
# created successfully. If this happens, we will softfail and leave the creation
# check to a later step.
if ($counter > 12) {
record_soft_failure "Warning: Bugzilla has reported an error which could mean that the bug has not been created correctly, but it probably is not a real problem, if the test has not failed completely. ";
@ -443,7 +443,7 @@ sub report_bug_text {
# Now, let us check with Bugzilla directly, if the bug has been created.
# First, we shall get a Bugzilla format timestamp to use it in the query.
# The timestamp will limit the list of bugs to those that have been created since
# The timestamp will limit the list of bugs to those that have been created since
# the then -> resulting with high probability in the one that this test run
# has just created.
$timestamp = convert_to_bz_timestamp($timestamp);
@ -455,7 +455,7 @@ sub report_bug_text {
else {
print("BUGZILLA: The last bug was found: $lastbug\n");
}
# We have found that the bug indeed is in the bugzilla (otherwise
# We have found that the bug indeed is in the bugzilla (otherwise
# we would have died already) so now we close it to clean up after this test run.
my $result = close_notabug($lastbug, $apikey);
unless ($result) {
@ -467,5 +467,4 @@ sub report_bug_text {
# Quit anaconda
type_string "4\n";
}

2
lib/bugzilla.pm
View File

@ -32,7 +32,7 @@ sub convert_to_bz_timestamp {
sub get_newest_bug {
# This subroutine makes an API call to Bugzilla and
# fetches the newest bug that have been created.
# fetches the newest bug that have been created.
# This will be the bug created by Anaconda in this
# test run.
my ($timestamp, $login) = @_;

54
lib/fedoradistribution.pm
View File

@ -64,8 +64,8 @@ sub x11_start_program {
}
# ensure_installed checks if a package is already installed and if not install it.
# To make it happen, it will switch to a virtual terminal (if not already there)
# and try to install the package. DNF will skip the installation,
# To make it happen, it will switch to a virtual terminal (if not already there)
# and try to install the package. DNF will skip the installation,
# if it is already installed.
sub ensure_installed {
my ($self, @packages) = @_;
@ -75,48 +75,48 @@ sub ensure_installed {
# We will check if GUI elements are present, that would suggest that we are not in the
# console but in GUI.
if (check_screen("apps_menu_button")) {
# In that case, we want to return to GUI after the routine finishes.
# In that case, we want to return to GUI after the routine finishes.
$stay_on_console = 0;
# From GUI we need to switch to the console.
send_key("ctrl-alt-f3");
# Let's wait to allow for screen changes.
sleep 5;
# And do the login.
console_login();
# From GUI we need to switch to the console.
send_key("ctrl-alt-f3");
# Let's wait to allow for screen changes.
sleep 5;
# And do the login.
console_login();
}
# Try to install the packages via dnf. If it is already installed, DNF will not do anything
# so there is no need to do any complicated magic.
assert_script_run("dnf install -y @packages", timeout => 240);
# If we need to leave the console.
if ($stay_on_console == 0) {
desktop_vt();
desktop_vt();
}
}
# This subroutine switches to the root account.
# This subroutine switches to the root account.
# On Fedora, the system can be installed with a valid root account (root password assigned)
# or without it (with root password empty). If no root password is provided through environment
# variables, we assume that the system is a "rootless" system. In that case we will use
# `sudo -i` to acquire the administrator access.
# variables, we assume that the system is a "rootless" system. In that case we will use
# `sudo -i` to acquire the administrator access.
sub become_root {
# If ROOT_PASSWORD exists, it means that the root account exists, too.
# If ROOT_PASSWORD exists, it means that the root account exists, too.
# To become root, we will use the real root account and we'll switch to it.
if (check_var("ROOT_PASSWORD")) {
my $password = get_var("ROOT_PASSWORD");
enter_cmd("su -", max_interval => 15, wait_screen_changes => 3);
type_password($password, max_interval => 15);
send_key("ret");
my $password = get_var("ROOT_PASSWORD");
enter_cmd("su -", max_interval => 15, wait_screen_changes => 3);
type_password($password, max_interval => 15);
send_key("ret");
}
# If no root password is set, it means, that we are only using an administrator
# who is in the wheel group and therefore we will use the sudo command to obtain
# the admin rights.
else {
my $password = get_var("USER_PASSWORD") || "weakpassword";
enter_cmd("sudo -i", max_interval => 15, wait_screen_changes => 3);
# The SUDO warning might be displayed so let's wait it out a bit.
sleep 2;
type_password($password, max_interval => 15);
send_key("ret");
enter_cmd("sudo -i", max_interval => 15, wait_screen_changes => 3);
# The SUDO warning might be displayed so let's wait it out a bit.
sleep 2;
type_password($password, max_interval => 15);
send_key("ret");
}
sleep 2;
# Now we should be root. Let's check for root prompt.
@ -132,7 +132,7 @@ sub become_root {
# passed to it after the command has finished to save some time.
# The serial console is only accessible for the root user, so that
# mechanism does not work when not root (why would anyone use sudo
# if they were root already anyway).
# if they were root already anyway).
# To override this, call `make_serial_writable` from `utils.pm` in the
# beginning of the test script to enable serial console for normal users.
sub script_sudo {
@ -144,9 +144,9 @@ sub script_sudo {
my $str;
if ($wait > 0) {
# Create a uniqe hash from the command and the wait time.
# Create a uniqe hash from the command and the wait time.
$str = testapi::hashed_string("SS$prog$wait");
# Chain the commands to pass the message to the serial console.
# Chain the commands to pass the message to the serial console.
$prog = "$prog; echo $str > /dev/$testapi::serialdev";
}
# Run the command with `sudo -k`
@ -156,7 +156,7 @@ sub script_sudo {
type_password($password);
send_key "ret";
# Wait for the message hash to appear on the serial console which indicates
# that the command has finished. No matter what time has passed, finish
# that the command has finished. No matter what time has passed, finish
# or die if no message appears on time.
if ($str) {
return testapi::wait_serial($str, $wait);

2
lib/modularity.pm
View File

@ -11,7 +11,7 @@ use utils;
our @EXPORT = qw(parse_module_list is_listed);
# This subroutine takes the output from the dnf module list command
# and deletes all unnecessary stuff and returns an array of hash
# and deletes all unnecessary stuff and returns an array of hash
# references where each hash consists of (module, stream, profile).
# The subroutine only recognizes one profile but it is enough
# for the sake of the modularity testing.

36
lib/utils.pm
View File

@ -82,14 +82,14 @@ sub boot_to_login_screen {
# The following is true for non-serial console.
my $count = 5;
while (check_screen("login_screen", 3) && $count > 0) {
sleep 5;
$count -= 1;
sleep 5;
$count -= 1;
}
assert_screen "login_screen", $args{timeout};
if (match_has_tag "graphical_login") {
wait_still_screen 10, 30;
assert_screen "login_screen";
}
assert_screen "login_screen", $args{timeout};
if (match_has_tag "graphical_login") {
wait_still_screen 10, 30;
assert_screen "login_screen";
}
}
}
@ -763,7 +763,7 @@ sub gnome_initial_setup {
# wait a bit in case of animation
wait_still_screen 3;
# one more check for frickin auth_required
if (check_screen "auth_required") {
if (check_screen "auth_required") {
record_soft_failure "Unexpected authentication required: https://gitlab.gnome.org/GNOME/gnome-initial-setup/-/issues/106";
send_key "esc";
}
@ -941,7 +941,7 @@ sub download_modularity_tests {
assert_script_run 'dnf -y install python3-yaml', 180;
assert_script_run 'curl -o /root/test.py https://pagure.io/fedora-qa/modularity_testing_scripts/raw/master/f/modular_functions.py';
if ($whitelist eq 'whitelist') {
assert_script_run 'curl -o /root/whitelist https://pagure.io/fedora-qa/modularity_testing_scripts/raw/master/f/whitelist';
assert_script_run 'curl -o /root/whitelist https://pagure.io/fedora-qa/modularity_testing_scripts/raw/master/f/whitelist';
}
assert_script_run 'chmod 755 /root/test.py';
}
@ -1334,10 +1334,10 @@ sub check_prerelease {
assert_screen "prerelease_note";
}
elsif ($prerelease == 0) {
# If the prerelease note is shown, where it should not be, die!
if (check_screen "prerelease_note") {
# If the prerelease note is shown, where it should not be, die!
if (check_screen "prerelease_note") {
die "The PRERELEASE tag is shown, but it should NOT be.";
}
}
}
}
@ -1438,8 +1438,8 @@ sub register_application {
}
# The KDE desktop tests are very difficult to maintain, because the transparency
# of the menu requires a lot of different needles to cover the elements.
# Therefore it is useful to change the background to a solid colour.
# of the menu requires a lot of different needles to cover the elements.
# Therefore it is useful to change the background to a solid colour.
# Since many needles have been already created with a black background
# we will keep it that way. The following code has been taken from the
# KDE startstop tests but it is good to have it here, because it will be
@ -1505,7 +1505,7 @@ sub check_and_install_git {
unless (get_var("CANNED")) {
if (script_run("rpm -q git")) {
assert_script_run("dnf install -y git");
}
}
}
}
@ -1540,8 +1540,8 @@ sub download_testdata {
# On Fedora, the serial console is not writable for regular users which lames
# some of the openQA commands that send messages to the serial console to check
# that a command has finished, for example assert_script_run, etc.
# This routine changes the rights on the serial console file and makes it
# writable for everyone, so that those commands work. This is actually very useful
# This routine changes the rights on the serial console file and makes it
# writable for everyone, so that those commands work. This is actually very useful
# for testing commands from users' perspective. The routine also handles becoming the root.
# We agree that this is not the "correct" way, to enable users to type onto serial console
# and that it correctly should be done via groups (dialout) but that would require rebooting
@ -1555,6 +1555,6 @@ sub make_serial_writable{
# Exit the root account
enter_cmd("exit");
sleep 2;
}
}
1;

110
perllint.py Executable file
View File

@ -0,0 +1,110 @@
#!/usr/bin/python3
# Copyright Red Hat
#
# This file is part of os-autoinst-distri-fedora.
#
# os-autoinst-distri-fedora is free software; you can redistribute it
# and/or modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation, either version 2 of
# the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
# Author: Adam Williamson <awilliam@redhat.com>
"""This is a simple linter for perl files in the repository. It fails
if any line contains a tab, ends with whitespace characters (which
includes lines containing *only* whitespace characters), or starts
with a number of spaces that is not divisible by four. If run with
--write, it will strip trailing whitespace (including turning lines
that contain only whitespace into blank lines). It does not currently
attempt to replace tabs or correct leading whitespace.
"""
import glob
import os
import sys
def run(write):
"""
Main run function.
"""
exitcode = 0
scriptloc = os.path.dirname(os.path.realpath(__file__))
filenames = glob.glob(f"{scriptloc}/**/*.pm", recursive=True)
for filename in filenames:
if check_file(filename, write):
exitcode = 1
if exitcode == 0:
print("No errors found!")
sys.exit(exitcode)
def check_file(filename, write):
"""
Do the checks. Returns false if there is no failure, true if there
is a failure.
"""
failed = False
with open(filename, "r", encoding="UTF-8") as readfh:
lines = readfh.readlines()
newlines = []
for (num, line) in enumerate(lines, 1):
# tab check
if "\t" in line:
print(f"Line {num} of file {filename} contains a tab!")
failed = True
# trailing whitespace check and replace
newline = line.rstrip("\n").rstrip(" \t") + "\n"
if newline != line:
print(f"Line {num} of file {filename} ends with a space or tab!")
failed = True
if write:
# if we're writing changes, feed the *changed* line
# to the next checks
line = newline
# correct number of starting spaces check
spaces = 0
for char in line:
if char != " ":
break
spaces += 1
if spaces > 0 and spaces % 4 != 0:
print(
f"Line {num} of file {filename} starts with an invalid number of spaces!"
)
failed = True
# write the line back to newlines
if write:
newlines.append(line)
if write and newlines != lines:
with open(filename, "w", encoding="UTF-8") as writefh:
writefh.writelines(newlines)
return failed
# Parse args and call run().
if len(sys.argv) > 2:
sys.exit("Too many arguments!")
if len(sys.argv) > 1:
if sys.argv[1] == "--write":
run(write=True)
else:
sys.exit("Invalid argument! Only valid argument is --write")
# no args
run(write=False)

4
tests/_do_install_and_reboot.pm
View File

@ -159,8 +159,8 @@ sub run {
assert_script_run "chroot $mount grub2-mkconfig -o /boot/efi/EFI/fedora/grub.cfg";
}
if (grep {$_ eq 'abrt'} @actions) {
# Chroot in the newly installed system and switch on ABRT systemwide
assert_script_run "chroot $mount abrt-auto-reporting 1";
# Chroot in the newly installed system and switch on ABRT systemwide
assert_script_run "chroot $mount abrt-auto-reporting 1";
}
if (grep {$_ eq 'rootpw'} @actions) {
my $root_password = get_var("ROOT_PASSWORD") || "weakpassword";

32
tests/_memcheck.pm
View File

@ -1,17 +1,17 @@
use base "anacondatest";
use strict;
use testapi;
sub run {
my $self = shift;
$self->root_console();
upload_logs '/tmp/memory.dat';
}
sub test_flags {
return { fatal => 1 };
}
1;
# vim: set sw=4 et:
use strict;
use testapi;
sub run {
my $self = shift;
$self->root_console();
upload_logs '/tmp/memory.dat';
}
sub test_flags {
return { fatal => 1 };
}
1;
# vim: set sw=4 et:

2
tests/_software_selection.pm
View File

@ -42,7 +42,7 @@ sub run {
# select desired environment
# go through the list 20 times at max (to prevent infinite loop when it's missing)
for (my $i = 0; !check_screen("anaconda_".$packageset."_highlighted", 1) && $i < 20; $i++) {
send_key "down";
send_key "down";
}
send_key "spc";

2
tests/applications/clocks/aaa_setup.pm
View File

@ -9,7 +9,7 @@ use utils;
sub run {
my $self = shift;
# At first, we need to set time and time zones manually.
# At first, we need to set time and time zones manually.
$self->root_console(tty=>3);
# Switch off automatic time.
assert_script_run("timedatectl set-ntp 0");

2
tests/applications/eog/aaa_setup.pm
View File

@ -35,7 +35,7 @@ sub run {
# Select the image.jpg file.
assert_and_click("eog_file_select_jpg", button => "left", timeout => 30);
# Hit enter to open it.
send_key("ret");

2
tests/applications/eog/about.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Open the menu
assert_and_click("gnome_burger_menu");
wait_still_screen(3);

2
tests/applications/eog/basic_view.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Check that the picture name is shown
assert_screen "eog_picture_name";

2
tests/applications/eog/browse.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Go to next picture.
send_key("right");
wait_still_screen(2);

2
tests/applications/eog/fullscreen.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Toggle full screen
send_key("f11");
wait_still_screen 2;

2
tests/applications/eog/help.pm
View File

@ -8,7 +8,7 @@ use utils;
sub run {
my $self = shift;
sleep 2;
# Open the shortcuts
send_key("f1");
wait_still_screen(3);

2
tests/applications/eog/rotate.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Rotate left
send_key("shift-ctrl-r");
wait_still_screen(2);

2
tests/applications/eog/save_as.pm
View File

@ -9,7 +9,7 @@ sub run {
my $self = shift;
sleep 2;
assert_screen("eog_image_default");
# Shift-ctrl-S to save a file as a new file.
send_key("shift-ctrl-s");
wait_still_screen(3);

2
tests/applications/eog/shortcuts.pm
View File

@ -8,7 +8,7 @@ use utils;
sub run {
my $self = shift;
sleep 2;
# Open the shortcuts
send_key("ctrl-?");
wait_still_screen(3);

2
tests/applications/eog/show_gallery.pm
View File

@ -22,7 +22,7 @@ sub run {
# Toggle gallery
assert_and_click("eog_gallery_show");
wait_still_screen(2);
}
assert_screen("eog_gallery_shown");
}

2
tests/applications/eog/zoom.pm
View File

@ -8,7 +8,7 @@ use utils;
sub run {
my $self = shift;
sleep 2;
# Make the image size 1:1
send_key("1");
wait_still_screen(2);

2
tests/applications/evince/aaa_setup.pm
View File

@ -34,7 +34,7 @@ sub run {
# Select the evince.pdf file.
assert_and_click("evince_file_select_pdf", button => "left", timeout => 30);
# Click the Open button to open the file
assert_and_click("gnome_button_open", button => "left", timeout => 30);

4
tests/applications/gnome-text-editor/aaa_setup.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Go to the root console to set up the test data and necessary stuff.
$self->root_console(tty=>3);
@ -37,7 +37,7 @@ sub run {
# Open it
send_key("ret");
wait_still_screen(3);
# Make the application fullscreen
send_key("super-up");
wait_still_screen(3);

2
tests/applications/gnome-text-editor/about.pm
View File

@ -10,7 +10,7 @@ sub run {
# Open the menu.
assert_and_click("gnome_burger_menu");
wait_still_screen(3);
# Choose the About item.
assert_and_click "gte_about";
wait_still_screen(2);

2
tests/applications/gnome-text-editor/delete_line.pm
View File

@ -3,7 +3,7 @@ use strict;
use testapi;
use utils;
# This part tests that a line of text can be deleted
# This part tests that a line of text can be deleted
# and the deletion reverted.
sub run {

6
tests/applications/gnome-text-editor/find_text.pm
View File

@ -23,13 +23,13 @@ sub run {
send_key "esc";
# Check that correct word is highlighted.
assert_screen "gte_found_text";
# This tests that a highlight can be removed from a search result.
# Use combo for removing the highlighting.
send_key "ctrl-end";
# Check that the highlighting was removed.
assert_screen "gte_text_added";
# We will continue to search and replace a piece of text.
# Open Switch and replace
send_key "ctrl-h";
@ -43,7 +43,7 @@ sub run {
sleep 1;
send_key("delete");
# Type replacement string. We purposefully produce a typo.
type_safely "Wiend";
type_safely "Wiend";
# Click to find the string
assert_and_click "gte_find_next_occurence";
# and replace it.

2
tests/applications/gnome-text-editor/line_numbering.pm
View File

@ -8,7 +8,7 @@ use utils;
sub run {
my $self = shift;
# Switches on line numbering.
assert_and_click "gte_settings_button";
wait_still_screen(3);

4
tests/applications/gnome-text-editor/new_file.pm
View File

@ -9,7 +9,7 @@ use utils;
sub run {
my $self = shift;
# First we will use key combo to open the new document window.
sleep 5;
send_key("ctrl-t");
@ -19,7 +19,7 @@ sub run {
type_safely "# My shopping list.\n\n";
type_safely "* **Milk**\n* *Apples*\n* `Bananas`\n* Bread\n* Butter\n* Cheese\n\n";
type_safely "Happy shopping.";
# Switch on Markdown Highlighting.
assert_and_click("gte_settings_button");
assert_and_click "gte_select_highlighting";

2
tests/applications/gnome-text-editor/show_help.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Open Help.
send_key("f1");
assert_screen "gte_help_shown";

2
tests/applications/gnome-text-editor/skins.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Check that dark style can be used.
assert_and_click("gnome_burger_menu");
assert_and_click("gte_change_to_dark");

38
tests/applications/help/help.pm
View File

@ -8,31 +8,31 @@ use utils;
# This subroutine opens a section, checks that its content
# is listed and returns to the main page.
sub visit_section {
my $section = shift;
send_key_until_needlematch("help_section_$section", "down", 40, 1 );
click_lastmatch();
assert_screen("help_section_content_$section");
assert_and_click("help_breadcrumbs_home");
assert_screen("help_main_screen");
my $section = shift;
send_key_until_needlematch("help_section_$section", "down", 40, 1 );
click_lastmatch();
assert_screen("help_section_content_$section");
assert_and_click("help_breadcrumbs_home");
assert_screen("help_main_screen");
}
sub run {
my $self = shift;
# Run the application
menu_launch_type("Help");
assert_screen("help_main_screen", timeout => 60);
# Run the application
menu_launch_type("Help");
assert_screen("help_main_screen", timeout => 60);
# Let us click on Section to open it and check that there is content inside.
visit_section("desktop");
visit_section("networking");
visit_section("sound");
visit_section("files");
visit_section("user");
visit_section("hardware");
visit_section("accessibility");
visit_section("tipstricks");
visit_section("morehelp");
# Let us click on Section to open it and check that there is content inside.
visit_section("desktop");
visit_section("networking");
visit_section("sound");
visit_section("files");
visit_section("user");
visit_section("hardware");
visit_section("accessibility");
visit_section("tipstricks");
visit_section("morehelp");
}
sub test_flags {

6
tests/applications/nautilus/aaa_setup.pm
View File

@ -3,7 +3,7 @@ use strict;
use testapi;
use utils;
# This script will download the test files, start Nautilus,
# This script will download the test files, start Nautilus,
# stretch it all over the screen and upload the status to
# set a milestone as a starting point for the other Nautilus tests.
@ -26,10 +26,10 @@ sub run {
# Start the application
menu_launch_type("nautilus");
wait_still_screen("2");
# Fullsize the Nautilus window.
wait_screen_change { send_key("super-up"); };
# Check that is started
assert_screen 'apps_run_files';

10
tests/applications/nautilus/about.pm
View File

@ -7,20 +7,20 @@ use utils;
sub run {
my $self = shift;
# Open the menu by clicking on the Burger icon
assert_and_click("gnome_burger_menu", button => "left", timeout => 30);
wait_still_screen 2;
# In the menu, click on the About item.
assert_and_click("nautilus_menu_about", button => "left", timeout => 30);
# Check that the About section has been displayed.
assert_screen("nautilus_about_show");
# Click on Credits button to see the second part of the dialogue.
assert_and_click("nautilus_about_credits", button => "left", timeout => 30);
# Check that Credits are accessible and visible, too.
assert_screen("nautilus_credits_shown");
}

20
tests/applications/nautilus/copy_file.pm
View File

@ -7,38 +7,38 @@ use utils;
sub run {
my $self = shift;
# Enter the Documents directory to get to the test data.
# Enter the Documents directory to get to the test data.
assert_and_click("nautilus_directory_documents");
# Click onto a file to select it.
assert_and_click("nautilus_test_file");
wait_still_screen(2);
# Press the keyboard shortcut to copy the file
send_key("ctrl-c");
# Select a different location to place the file.
assert_and_click("nautilus_directory_downloads");
wait_still_screen(2);
# Assert that we have entered the correct directory.
assert_screen("nautilus_directory_reached_downloads");
# Put the file in the new location
send_key("ctrl-v");
# Check that the file has appeared.
assert_screen("nautilus_test_file");
# Go into the root console and verify the operation in the background.
$self->root_console(tty=>3);
# Verify that the new file exists in original location.
assert_script_run("ls /home/test/Documents/markdown.md", timeout => '60', fail_message => 'The test file was incorrectly removed from the old location.', quiet => '0');
# And also in the new location.
assert_script_run("ls /home/test/Downloads/markdown.md", timeout => '60', fail_message => 'The test file has not been found in the new location.', quiet => '0');
}
sub test_flags {

14
tests/applications/nautilus/create_directory.pm
View File

@ -8,28 +8,28 @@ use utils;
sub run {
my $self = shift;
# Enter the Documents directory to get to the test data.
# Enter the Documents directory to get to the test data.
assert_and_click("nautilus_directory_documents");
wait_still_screen(2);
# Click on the Burger menu to open it
assert_and_click("gnome_kebab_menu");
wait_still_screen(2);
# Click on the Create directory icon to create a new directory.
assert_and_click("nautilus_menu_new_directory");
wait_still_screen(2);
# Type in the new name
type_safely("new_directory");
send_key("ret");
# Confirm that the directory has appeared in the tree
assert_screen("nautilus_new_directory_check");
# Go into the root console and verify the operation in the background.
$self->root_console(tty=>3);
# Check that the directory can be listed.
assert_script_run("ls /home/test/Documents/new_directory", fail_message => "The expected directory does not exist.");
# Check that it indeed is a directory and that it is user writable and executable.

32
tests/applications/nautilus/delete_file.pm
View File

@ -8,62 +8,62 @@ use utils;
sub run {
my $self = shift;
# Enter the Documents directory to get to the test data.
# Enter the Documents directory to get to the test data.
assert_and_click("nautilus_directory_documents");
# Click onto a file to select it.
assert_and_click("nautilus_test_file");
# Press the keyboard shortcut to delete the file and wait until file disappears
send_key("delete");
wait_still_screen(1);
# Now, find the confirmation and click on Undo to return the operation.
assert_and_click("nautilus_delete_undo");
# Check that the file is still in its location.
assert_and_click("nautilus_test_file");
wait_still_screen(2);
# Delete the file again and this time, let time pass for the confirmation dialogue
# to disappear.
send_key("delete");
sleep(10);
# Select another file and delete it.
assert_and_click("nautilus_test_file_another");
wait_still_screen(2);
send_key("delete");
sleep(10);
# Navigate to the Wastebin and check that the file appeared there.
assert_and_click("nautilus_select_wastebin");
# Confirm that Wastebin is active
assert_screen("nautilus_confirm_wastebin");
# Check that the files are now located here.
assert_screen("nautilus_test_file");
assert_screen("nautilus_test_file_another");
# Select the first file and restore it from the Bin.
assert_and_click("nautilus_test_file");
wait_still_screen(2);
assert_and_click("nautilus_restore_content");
# Go to the Documents again and check that the file reappeared there.
assert_and_click("nautilus_directory_documents");
wait_still_screen(2);
assert_screen("nautilus_test_file");
# Go into the root console and verify the operation in the background.
$self->root_console(tty=>3);
# Verify that the first file still exists in the location as it was restored from the bin.
assert_script_run("ls /home/test/Documents/markdown.md", timeout => '60', fail_message => 'The file has not been found in the location.', quiet => '0');
# Verify that the next file has been deleted from the original location
assert_script_run("! ls /home/test/Documents/konkurz.md");
assert_script_run("! ls /home/test/Documents/konkurz.md");
}
sub test_flags {

12
tests/applications/nautilus/help.pm
View File

@ -7,23 +7,23 @@ use utils;
sub run {
my $self = shift;
# Open help.
send_key("f1");
wait_still_screen 2;
# Check that Help has been shown.
assert_screen("nautilus_help_shown");
# Open one of the topics.
assert_and_click("nautilus_help_browse_files");
# Check that a correct topic has been opened.
assert_screen("nautilus_browse_shown");
# Find a subtopic and open it links
assert_and_click("nautilus_help_search_file");
# Check that it opened
assert_screen("nautilus_search_file_shown");
}

100
tests/applications/nautilus/hidden_files.pm
View File

@ -6,56 +6,56 @@ use utils;
# Show and unshow hidden files.
sub run {
my $self = shift;
# Enter the Documents directory.
assert_and_click("nautilus_directory_documents", timeout => '30', button => 'left', mousehide => '1');
# Check that we are in the Documents directory.
assert_screen("nautilus_documents_active", timeout => '30', no_wait => '0');
# Check if the hidden files are set to shown. If so, let's remember this status quo for further testing.
my $hidden_a = 0;
my $hidden_b = 0;
# Set the a variable to 1, if the hidden files are shown.
if (check_screen("nautilus_hidden_file_shown")) {
$hidden_a = 1;
}
# Now toggle the status of the invisible files and check that it is changed now
# using the keyboard shortcut.
send_key("ctrl-h");
wait_still_screen(2);
# Now let us check again, if the invisible file is seen.
if (check_screen("nautilus_hidden_file_shown")) {
$hidden_b = 1;
}
# Compare the results. They should differ from each other.
if ($hidden_a == $hidden_b) {
die("The ctrl-h keyboard shortcut should have changed the status of invisible files, but the status has not been changed which indicates that the shortcut might not have worked correctly.");
}
# Now use the menu to change the status of the invisible files.
assert_and_click("gnome_burger_menu");
wait_still_screen(2);
assert_and_click("nautilus_toggle_hidden_files", timeout => '30', button => 'left', mousehide => '1');
wait_still_screen(2);
# Check the current status of the invisible files.
if (check_screen("nautilus_hidden_file_shown")) {
$hidden_b = 1;
}
else {
$hidden_b = 0;
}
# Compare the results. They should be the same if everything up til now has worked correctly.
if ($hidden_a != $hidden_b) {
die("The menu item 'Show hidden files' should have changed the status of the invisible files, but the status has not changed which indicates that the menu item might not have worked correctly.");
}
my $self = shift;
# Enter the Documents directory.
assert_and_click("nautilus_directory_documents", timeout => '30', button => 'left', mousehide => '1');
# Check that we are in the Documents directory.
assert_screen("nautilus_documents_active", timeout => '30', no_wait => '0');
# Check if the hidden files are set to shown. If so, let's remember this status quo for further testing.
my $hidden_a = 0;
my $hidden_b = 0;
# Set the a variable to 1, if the hidden files are shown.
if (check_screen("nautilus_hidden_file_shown")) {
$hidden_a = 1;
}
# Now toggle the status of the invisible files and check that it is changed now
# using the keyboard shortcut.
send_key("ctrl-h");
wait_still_screen(2);
# Now let us check again, if the invisible file is seen.
if (check_screen("nautilus_hidden_file_shown")) {
$hidden_b = 1;
}
# Compare the results. They should differ from each other.
if ($hidden_a == $hidden_b) {
die("The ctrl-h keyboard shortcut should have changed the status of invisible files, but the status has not been changed which indicates that the shortcut might not have worked correctly.");
}
# Now use the menu to change the status of the invisible files.
assert_and_click("gnome_burger_menu");
wait_still_screen(2);
assert_and_click("nautilus_toggle_hidden_files", timeout => '30', button => 'left', mousehide => '1');
wait_still_screen(2);
# Check the current status of the invisible files.
if (check_screen("nautilus_hidden_file_shown")) {
$hidden_b = 1;
}
else {
$hidden_b = 0;
}
# Compare the results. They should be the same if everything up til now has worked correctly.
if ($hidden_a != $hidden_b) {
die("The menu item 'Show hidden files' should have changed the status of the invisible files, but the status has not changed which indicates that the menu item might not have worked correctly.");
}
}
sub test_flags {

14
tests/applications/nautilus/keyboard_shortcuts.pm
View File

@ -7,25 +7,25 @@ use utils;
sub run {
my $self = shift;
assert_and_click("gnome_burger_menu");
wait_still_screen(2);
assert_and_click("nautilus_menu_shortcuts");
wait_still_screen(2);
assert_screen("nautilus_shortcuts_first");
send_key("right");
send_key("ret");
wait_still_screen(2);
assert_screen("nautilus_shortcuts_second");
send_key("right");
send_key("ret");
wait_still_screen(2);
assert_screen("nautilus_shortcuts_third");
}

20
tests/applications/nautilus/move_file.pm
View File

@ -7,38 +7,38 @@ use utils;
sub run {
my $self = shift;
# Enter the Documents directory to get to the test data.
# Enter the Documents directory to get to the test data.
assert_and_click("nautilus_directory_documents");
# Click onto a file to select it.
assert_and_click("nautilus_test_file");
wait_still_screen(2);
# Press the keyboard shortcut to cut the file
send_key("ctrl-x");
# Select a different location to place the file.
assert_and_click("nautilus_directory_downloads");
wait_still_screen(2);
# Check that we have entered the Downloads directory
assert_screen("nautilus_directory_reached_downloads");
# Put the file in the new location
send_key("ctrl-v");
# Check that the file has appeared.
assert_screen("nautilus_test_file");
# Go into the root console and verify the operation in the background.
$self->root_console(tty=>3);
# Verify that the new file does not exist in the original location.
assert_script_run("! ls /home/test/Documents/markdown.md", fail_message => 'The test file still exists in the original location, but it should have been removed.');
# And that it exists in the new location.
assert_script_run("ls /home/test/Downloads/markdown.md", fail_message => 'The test file has not been found in the expected location when it should have been copied there.', quiet => '0');
}
sub test_flags {

2
tests/applications/nautilus/move_file_into.pm
View File

@ -8,7 +8,7 @@ use utils;
sub run {
my $self = shift;
# Enter the Documents directory to get to the test data.
# Enter the Documents directory to get to the test data.
assert_and_click("nautilus_directory_documents");
# Right click onto a file to select it and open the context menu

14
tests/applications/nautilus/new_instance.pm
View File

@ -7,25 +7,25 @@ use utils;
sub run {
my $self = shift;
# Enter the Documents directory to get to the test data.
# Enter the Documents directory to get to the test data.
assert_and_click("nautilus_directory_documents");
# Click on the Burger menu to open it
assert_and_click("gnome_burger_menu");
wait_still_screen(2);
# Click on the new instance icon to create a new instance of Nautilus.
assert_and_click("nautilus_menu_new_instance");
wait_still_screen(2);
# Hit the Meta key to switch to the activities mode for further check.
send_key("super");
wait_still_screen(2);
# Confirm that two Nautilus windows exist in the view.
assert_screen("nautilus_instances_check");
}
sub test_flags {

14
tests/applications/nautilus/open_new_tab.pm
View File

@ -7,26 +7,26 @@ use utils;
sub run {
my $self = shift;
# Enter the Documents directory to get to the test data.
# Enter the Documents directory to get to the test data.
assert_and_click("nautilus_directory_documents");
# Click on the Burger menu to open it
assert_and_click("gnome_burger_menu");
wait_still_screen(2);
# Click on the New tab to start a new tab of Nautilus.
assert_and_click("nautilus_menu_new_tab");
wait_still_screen(2);
# The new tab will open in the same directory, so let us choose
# another directory to be able to compare in the needle.
assert_and_click("nautilus_directory_videos");
wait_still_screen(2);
# Confirm that two tabs exists with Documents and Video locations.
assert_screen("nautilus_tabs_check");
}
sub test_flags {

28
tests/applications/nautilus/permissions.pm
View File

@ -7,18 +7,18 @@ use utils;
sub run {
my $self = shift;
# Enter the Documents directory to get to the test data.
# Enter the Documents directory to get to the test data.
assert_and_click("nautilus_directory_documents");
# Rigth click onto a file to open context menu.
assert_and_click("nautilus_test_file", button => "right");
wait_still_screen(2);
# Click on the Properties menu item
assert_and_click("nautilus_context_properties");
wait_still_screen(2);
# Check that the Properties window has appeared and close it.
assert_screen("nautilus_properties_check");
send_key("esc");
@ -29,31 +29,31 @@ sub run {
# Send a key combination to open the Properties again.
send_key("ctrl-i");
# Check that the Properties window has appeared again.
assert_screen("nautilus_properties_check");
# Click on the Permissions tab
assert_and_click("nautilus_select_permissions");
# Check that the owner can read and write the file
assert_screen("nautilus_owner_permissions");
# Check that others cannot do anything.
assert_screen("nautilus_others_permissions");
# Set the permission for others to None
assert_and_click("nautilus_permissions_read_only");
# Click on Read Only to select it.
assert_and_click("nautilus_permissions_set_none");
# Close the Properties
send_key("esc");
# Go into the root console and verify the operation in the background.
$self->root_console(tty=>3);
# Check that the permissions have been changed.
validate_script_output("ls -l /home/test/Documents/markdown.md", sub { m/-rw-r-----/ });

20
tests/applications/nautilus/rename_file.pm
View File

@ -7,32 +7,32 @@ use utils;
sub run {
my $self = shift;
# Enter the Documents directory to get to the test data.
# Enter the Documents directory to get to the test data.
assert_and_click("nautilus_directory_documents");
# Click onto a file to select it.
assert_and_click("nautilus_test_file");
# Press the keyboard shortcut to rename the file
send_key("f2");
# Check that a rename dialogue has been displayed.
assert_screen("nautilus_rename_dialogue");
# Type a new name and confirm it.
type_very_safely("renamed");
send_key("ret");
# Check that the file has been renamed.
assert_screen("nautilus_rename_check");
# Go into the root console and verify the operation in the background.
$self->root_console(tty=>3);
# Verify that the new file exists in the location.
assert_script_run("ls /home/test/Documents/renamed.md", timeout => '60', fail_message => 'The renamed file has not been found in the location.', quiet => '0');
}
sub test_flags {

26
tests/applications/nautilus/side_panel.pm
View File

@ -7,49 +7,49 @@ use utils;
sub run {
my $self = shift;
# It seems that the following checks run so quickly that the tested
# It seems that the following checks run so quickly that the tested
# virtual machine is unable to properly reload from the previous test
# and it keeps failing.
# Let's give it some time to settle.
sleep(5);
my $side_panel = 0;
if (check_screen("nautilus_side_panel")) {
$side_panel = 1;
$side_panel = 1;
}
# Switch off the side panel
send_key("f9");
wait_still_screen(2);
# Recheck if side panel is visible
my $off_panel = 0;
if (check_screen("nautilus_side_panel")) {
$off_panel = 1;
}
# Compare the results, they should be different.
if ($off_panel == $side_panel) {
die("The side panel visibility should have been toggled and it is not. That indicates that the keyboard shortcut to toggle it does not work properly.");
die("The side panel visibility should have been toggled and it is not. That indicates that the keyboard shortcut to toggle it does not work properly.");
}
# Use menu to toggle the side panel back.
assert_and_click("gnome_burger_menu");
wait_still_screen(2);
assert_and_click("nautilus_show_sidebar");
wait_still_screen(2);
# Recheck if side panel is visible
if (check_screen("nautilus_side_panel")) {
$off_panel = 1;
}
# Compare the results. If everything has been ok until now, the values should not be different.
if ($off_panel != $side_panel) {
die("The side panel visibility should have been toggled back, but it has not been. That indicates that the menu item to toggle it does not work properly.");
die("The side panel visibility should have been toggled back, but it has not been. That indicates that the menu item to toggle it does not work properly.");
}
}
sub test_flags {

16
tests/applications/nautilus/star_file.pm
View File

@ -7,28 +7,28 @@ use utils;
sub run {
my $self = shift;
# Enter the Documents directory to get to the test data.
# Enter the Documents directory to get to the test data.
assert_and_click("nautilus_directory_documents");
# Right click onto a file to select it to see the
# context menu.
assert_and_click("nautilus_test_file", button => "right");
wait_still_screen(2);
# Click to Star it.
assert_and_click("nautilus_context_star");
# Check that a star gets solid on the right part of the selected file
assert_screen("nautilus_star_confirm");
# Click on Starred to see all the starred files in a new view.
assert_and_click("nautilus_directory_starred");
wait_still_screen(2);
# Check that the view switched to Starred
assert_screen("nautilus_starred_selected");
# Check that the file has appeared.
assert_screen("nautilus_test_file");
}

2
tests/apps_gnome_preset.pm
View File

@ -12,7 +12,7 @@ sub run {
solidify_wallpaper;
}
# If this test fails, the others will probably start failing too,
# If this test fails, the others will probably start failing too,
# so there is no need to continue.
# Also, when subsequent tests fail, the suite will revert to this state for further testing.
sub test_flags {

2
tests/apps_startstop/gnome/abrt.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
start_with_launcher('apps_menu_abrt', 'apps_menu_utilities');
# Check that it is started

2
tests/apps_startstop/gnome/calculator.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
start_with_launcher('apps_menu_calculator');
# Check that it is started

6
tests/apps_startstop/gnome/calendar.pm
View File

@ -7,10 +7,10 @@ use utils;
sub run {
my $self = shift;
# Start the application
start_with_launcher('apps_menu_calendar');
# give access to location if the vm asks for it
if (check_screen('apps_run_access', 1)) {
assert_and_click 'apps_run_access';
@ -21,7 +21,7 @@ sub run {
register_application("gnome-calendar");
# close the application
quit_with_shortcut();
}
sub test_flags {

4
tests/apps_startstop/gnome/chars.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
start_with_launcher('apps_menu_chars', 'apps_menu_utilities');
# Check that is started
@ -16,7 +16,7 @@ sub run {
register_application("gnome-characters");
# Close the application
quit_with_shortcut();
}
sub test_flags {

2
tests/apps_startstop/gnome/cheese.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
start_with_launcher('apps_menu_cheese');
# Check that is started

2
tests/apps_startstop/gnome/clocks.pm
View File

@ -19,7 +19,7 @@ sub run {
register_application("gnome-clocks");
# close the application
quit_with_shortcut();
}
sub test_flags {

2
tests/apps_startstop/gnome/diskusage.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
start_with_launcher('apps_menu_diskusage', 'apps_menu_utilities');
# Check that is started

4
tests/apps_startstop/gnome/files.pm
View File

@ -3,7 +3,7 @@ use strict;
use testapi;
use utils;
# This tests if Files starts
# This tests if Files starts
sub run {
my $self = shift;
@ -15,7 +15,7 @@ sub run {
register_application("nautilus");
# Close the application
quit_with_shortcut();
}
sub test_flags {

2
tests/apps_startstop/gnome/fonts.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
start_with_launcher('apps_menu_fonts', 'apps_menu_utilities');
# Check that is started

2
tests/apps_startstop/gnome/imageviewer.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
start_with_launcher('apps_menu_imageviewer', 'apps_menu_utilities');
# Check that is started

2
tests/apps_startstop/gnome/lcalc.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
start_with_launcher('apps_menu_lcalc');
# Check that is started

2
tests/apps_startstop/gnome/logs.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
start_with_launcher('apps_menu_logs', 'apps_menu_utilities');
# Check that is started

4
tests/apps_startstop/gnome/maps.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
start_with_launcher('apps_menu_maps');
# Check that is started
@ -20,7 +20,7 @@ sub run {
register_application("gnome-maps");
# Close the application
quit_with_shortcut();
}
sub test_flags {

2
tests/apps_startstop/gnome/monitor.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
start_with_launcher('apps_menu_monitor');
# Check that is started

2
tests/apps_startstop/gnome/photos.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
start_with_launcher('apps_menu_photos');
# Check that is started

4
tests/apps_startstop/gnome/rhythmbox.pm
View File

@ -7,12 +7,12 @@ use utils;
sub run {
my $self = shift;
# Start the application
start_with_launcher('apps_menu_rhythmbox');
# To give the screen a bit of time.
wait_still_screen(2);
# On June 15th, 2022, we realized that Rhythmbox tends to
# On June 15th, 2022, we realized that Rhythmbox tends to
# crash on fresh installation when run for the first time.
# When this happens, softfail and try to start it again.
unless (check_screen("apps_run_rhythmbox")) {

4
tests/apps_startstop/gnome/scan.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
start_with_launcher('apps_menu_scan');
# Check that is started
@ -16,7 +16,7 @@ sub run {
register_application("simple-scan");
# Close the application
quit_with_shortcut();
}
sub test_flags {

4
tests/apps_startstop/gnome/settings.pm
View File

@ -13,7 +13,7 @@ sub run {
# select Background menu item
assert_and_click 'apps_settings_menu_background';
wait_still_screen 5;
# close the application
send_key 'alt-f4';
wait_still_screen 5;
@ -22,7 +22,7 @@ sub run {
assert_screen 'workspace';
# Register application
register_application("gnome-control-center");
}
sub test_flags {

8
tests/apps_startstop/gnome/software.pm
View File

@ -7,11 +7,11 @@ use utils;
sub run {
my $self = shift;
# Start the application
start_with_launcher('apps_menu_software');
# check if a welcome screen appears, if so, click on it
send_key 'ret' if (check_screen('gnome_software_welcome', 10));
assert_screen 'desktop_package_tool_update';
@ -19,7 +19,7 @@ sub run {
register_application("gnome-software");
# Close the application
quit_with_shortcut();
}
sub test_flags {

2
tests/apps_startstop/gnome/terminal.pm
View File

@ -18,7 +18,7 @@ sub run {
quit_with_shortcut();
}
# If this test fails, the others will probably start failing too,
# If this test fails, the others will probably start failing too,
# so there is no need to continue.
# Also, when subsequent tests fail, the suite will revert to this state for further testing.
sub test_flags {

2
tests/apps_startstop/gnome/texteditor.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
start_with_launcher('apps_menu_texteditor');
# Check that is started

2
tests/apps_startstop/gnome/videos.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
start_with_launcher('apps_menu_videos');
# Check that is started

2
tests/apps_startstop/gnome/weather.pm
View File

@ -19,7 +19,7 @@ sub run {
register_application("gnome-weather");
# close the application
quit_with_shortcut();
}
sub test_flags {

2
tests/apps_startstop/kde/cteditor.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
menu_launch_type 'contactthemeeditor';
# Check that it is started
assert_screen 'cteditor_runs';

2
tests/apps_startstop/kde/dbusviewer.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
menu_launch_type 'dbusviewer';
# Check that it is started
assert_screen 'dbusviewer_runs';

2
tests/apps_startstop/kde/discover.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'discover';
# Check that it is started

2
tests/apps_startstop/kde/dnfdragora.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'dnfdragora';
# Check that it is started

2
tests/apps_startstop/kde/dolphin.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'dolphin';
# Check that it is started

2
tests/apps_startstop/kde/firefox.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'firefox';
# Check that it is started; this needle is from

2
tests/apps_startstop/kde/firewall.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'firewall';
sleep 5;

2
tests/apps_startstop/kde/gwenview.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'gwenview';
# Check that it is started

2
tests/apps_startstop/kde/help.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'help';
# Check that it is started

2
tests/apps_startstop/kde/infocenter.pm
View File

@ -9,7 +9,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'info';
# Check that it is started

2
tests/apps_startstop/kde/kaddressbook.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'kaddressbook';
# Check that it is started

2
tests/apps_startstop/kde/kcalc.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'kcalc';
# Check that it is started

2
tests/apps_startstop/kde/kcharselect.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'kcharselect';
# Check that it is started

2
tests/apps_startstop/kde/kfind.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'kfind';
# Check that it is started

2
tests/apps_startstop/kde/kgpg.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'kgpg';
# Deal with the first wizard screen

2
tests/apps_startstop/kde/kimport.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'akonadiimportwizard';
# Click ok to go further

2
tests/apps_startstop/kde/kmag.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'kmag';
# Check that it is started

2
tests/apps_startstop/kde/kmail.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'kmail';
# Cancel Kmail data wizard

2
tests/apps_startstop/kde/kmail_header.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'kmail header';
# Check that the application runs

2
tests/apps_startstop/kde/kmousetool.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'kmousetool';
# Check that it is started

4
tests/apps_startstop/kde/kmouth.pm
View File

@ -7,14 +7,14 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'kmouth';
sleep 2;
# Deal with the welcome screens
assert_screen ["kde_next", "kde_finish"];
while (match_has_tag "kde_next") {
assert_and_click "kde_next";
assert_and_click "kde_next";
sleep 2;
assert_screen ["kde_next", "kde_finish"];
}

2
tests/apps_startstop/kde/kolourpaint.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'kolourpaint';
# Check that it is started

2
tests/apps_startstop/kde/konsole.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'konsole';
# Check that it is started

2
tests/apps_startstop/kde/kontakt.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'kontact';
# Get rid of personal data

2
tests/apps_startstop/kde/konversation.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'konversation';
# Connect to Freenode

2
tests/apps_startstop/kde/korganizer.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'korganizer';
# Check that it is started

2
tests/apps_startstop/kde/kparted.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'partition editor';
wait_still_screen 2;

2
tests/apps_startstop/kde/krdc.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'krdc';
# Check that it is started

2
tests/apps_startstop/kde/krfb.pm
View File

@ -7,7 +7,7 @@ use utils;
sub run {
my $self = shift;
# Start the application
menu_launch_type 'krfb';
# Check that it is started

Some files were not shown because too many files have changed in this diff Show More