srbala/os-autoinst-distri-fedora
1
0
Fork 0
mirror of https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git synced 2025-12-24 01:05:58 +00:00
Code Issues Releases Activity

_repo_setup_updates: provide debugging hints for dnf failure

Browse Source 
The failure message here isn't very helpful unless you know what
is going on and where to look for the errors. Let's improve it
so packagers have a better chance of understanding failures.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
This commit is contained in:
Adam Williamson 2025-11-27 08:13:37 -08:00
parent 9a451c32a2
commit e47e711b77
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/utils.pm
View File

@ -781,7 +781,15 @@ sub _repo_setup_updates {
# where the updated packages should have been installed
# already and we want to fail if they weren't, or CANNED
# tests, there's no point updating the toolbox
script_retry "dnf -y --best update", 1200 unless (get_var("UPGRADE") || get_var("INSTALL") || get_var("CANNED"));
my $error = "dnf -y --best update failed after 5 attempts. ";
$error .= "openQA was installing updates, including the packages to be tested."
$error .= "A failure here is usually caused by an infra issue or a dependency issue. "
$error .= "The dependency issue may be in the packages under test, or it may be some "
$error .= "kind of pre-existing issue which was missed in earlier testing. "
$error .= "For debugging, the dnf output should be visible two or three frames before this one, ";
$error .= "or in serial_terminal.txt on the Logs & Assets tab. ";
$error .= "Please contact the Quality team if you need help determining the cause."
script_retry "dnf -y --best update", 1200, 5, $error unless (get_var("UPGRADE") || get_var("INSTALL") || get_var("CANNED"));
# on liveinst tests, we'll remove the packages we installed
# above (and their deps, which dnf will include automatically),
# just in case they're in the update under test; otherwise we