From e353649ed8b8baa655aec1c161bdc027488897f5 Mon Sep 17 00:00:00 2001 From: Adam Williamson Date: Mon, 3 Jun 2024 17:22:39 -0700 Subject: [PATCH] Try launching live installer up to 5 times (#2280840) We already try twice, but that seems to be not enough for the annoying #2280840, we're often seeing failures. Signed-off-by: Adam Williamson --- tests/_boot_to_anaconda.pm | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/tests/_boot_to_anaconda.pm b/tests/_boot_to_anaconda.pm index 959a27fa..1744dcf2 100644 --- a/tests/_boot_to_anaconda.pm +++ b/tests/_boot_to_anaconda.pm @@ -170,11 +170,14 @@ sub run { my $relnum = get_release_number; my $dclick = 0; $dclick = 1 if (get_var("DESKTOP") eq "kde"); - assert_and_click("live_start_anaconda_icon", dclick => $dclick); - unless (check_screen "anaconda_select_install_lang", 180) { - # click it again - on KDE since 2019-10 or so it seems - # like the first attempt sometimes just doesn't work - assert_and_click("live_start_anaconda_icon", dclick => $dclick, timeout => 300); + # FIXME launching the installer sometimes fails on KDE + # https://bugzilla.redhat.com/show_bug.cgi?id=2280840 + my $tries = 5; + while ($tries) { + $tries -= 1; + assert_and_click("live_start_anaconda_icon", dclick => $dclick); + last unless (check_screen "anaconda_select_install_lang", 180); + die "Launching installer failed after 5 tries!" unless ($tries); } } }