apps_startstop: don't rollback, defend against KDE mistypes

This comes from trying to fix the annoying recurring problem with
mistypes in KDE which has been going on since at least December.
First, we add the attempt to kind of 'precache' the kicker menu
in aasetting.pm. Then, I thought, all this snapshot loading has
to be putting a lot of load on the workers. And when each subtest
passes, it shouldn't really be necessary - they all end with
quit_with_shortcut(), which verifies that the app exited and we
got back to a blank desktop, so successful subtests should not
usually interfere with each other. We probably only want to
rollback on *failed* subtests, which is in fact openQA's default
behavior. If any specific tests change the system state such that
later tests might be affected, we can go back and just set those
tests as always_rollback, but I think it should be safe to skip
rollbacks on success for most of them.

Signed-off-by: Adam Williamson <awilliam@redhat.com>

tests/apps_startstop/gnome/abrt.pm

@@ -19,7 +19,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/gnome/boxes.pm

@@ -25,7 +25,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/calculator.pm

@@ -19,7 +19,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/calendar.pm

@@ -25,7 +25,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/camera.pm

@@ -25,7 +25,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/chars.pm

@@ -20,7 +20,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/clocks.pm

@@ -23,7 +23,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/contacts.pm

@@ -19,7 +19,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/disks.pm

@@ -18,7 +18,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/diskusage.pm

@@ -19,7 +19,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/dviewer.pm

@@ -18,7 +18,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/files.pm

@@ -19,7 +19,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/firefox.pm

@@ -30,7 +30,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/fonts.pm

@@ -19,7 +19,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/help.pm

@@ -18,7 +18,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/imageviewer.pm

@@ -19,7 +19,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/lcalc.pm

@@ -19,7 +19,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/limpress.pm

@@ -20,7 +20,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/logs.pm

@@ -19,7 +19,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/lwriter.pm

@@ -19,7 +19,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/maps.pm

@@ -24,7 +24,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/monitor.pm

@@ -19,7 +19,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/rhythmbox.pm

@@ -28,7 +28,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/scan.pm

@@ -20,7 +20,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/settings.pm

@@ -26,7 +26,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/software.pm

@@ -27,7 +27,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/terminal.pm

@@ -19,7 +19,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/texteditor.pm

@@ -19,7 +19,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/videos.pm

@@ -19,7 +19,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/gnome/weather.pm

@@ -23,7 +23,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/kde/aasetting.pm

@@ -9,6 +9,14 @@ use utils;
 sub run {
     my $self = shift;
     solidify_wallpaper;
+    # to try and avoid problems with kde grinding a lot on first
+    # attempt to do a menu_launch_type, let's do a throwaway one
+    # here before we snapshot
+    wait_screen_change { send_key 'super'; };
+    wait_still_screen 3;
+    send_key "k";
+    wait_still_screen 5;
+    send_key "esc";
 }
 
 sub test_flags {

tests/apps_startstop/kde/abrt.pm

@@ -15,7 +15,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/akregator.pm

@@ -16,7 +16,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/ark.pm

@@ -16,7 +16,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/cpteditor.pm

@@ -15,7 +15,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/cteditor.pm

@@ -16,7 +16,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/discover.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/docviewer.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/dolphin.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/firefox.pm

@@ -26,7 +26,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/firewall.pm

@@ -26,7 +26,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/gwenview.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/help.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/infocenter.pm

@@ -25,7 +25,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/kaddressbook.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/kcalc.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/kcharselect.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/kfind.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/kgpg.pm

@@ -35,7 +35,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/kmag.pm

@@ -20,7 +20,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/kmail.pm

@@ -24,7 +24,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/kmail_header.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/kmousetool.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/kmouth.pm

@@ -31,7 +31,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 1;

tests/apps_startstop/kde/kolourpaint.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/konsole.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/kontakt.pm

@@ -23,7 +23,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/konversation.pm

@@ -30,7 +30,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/korganizer.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/kparted.pm

@@ -22,7 +22,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/krdc.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/krfb.pm

@@ -30,7 +30,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/ktnef.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/kwallet.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/kwrite.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/lcalc.pm

@@ -16,7 +16,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/limpress.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/lwriter.pm

@@ -15,7 +15,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/mahjong.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/mediawriter.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/minesweeper.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/patience.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/pimexporter.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/plasmasystemmonitor.pm

@@ -16,7 +16,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/spectacle.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/system_settings.pm

@@ -17,7 +17,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }
 
 

tests/apps_startstop/kde/vault.pm

@@ -69,7 +69,7 @@ sub run {
 }
 
 sub test_flags {
-    return {always_rollback => 1};
+    return {};
 }