srbala/os-autoinst-distri-fedora
1
0
Fork 0
mirror of https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git synced 2024-11-16 03:33:08 +00:00
Code Issues Releases Activity

Use test3 not test1 for FreeIPA password change test module

Browse Source 
Previously this module changed test1's password, so that it
would still be able to work even if the webui test module
failed (so test3/test4 didn't get created). But this means
that, for about 30 seconds, test1's password is 'loremipsum'
not 'batterystaple', and if one of the *other* client test
jobs happens to hit a point where it has to auth as test1
during the 30 seconds test1's password is different, it will
fail. This looks to be what happened to the join_kickstart
test the last few days - it failed because it tried to login
as test1 during the password change window.

By using the test3 user instead (which is only used by the
join_cockpit test, currently) we avoid this problem, at the
cost that the password_change module will always fail if the
webui module fails.
This commit is contained in:
Adam Williamson 2017-05-04 17:29:35 -07:00
parent 7d07147b7e
commit c2b1ea4e8c
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tests/freeipa_password_change.pm
View File

@ -11,7 +11,11 @@ sub run {
assert_script_run 'rm -rf /root/.mozilla'; assert_script_run 'rm -rf /root/.mozilla';
# clear kerberos ticket so we don't auto-auth as 'test4' # clear kerberos ticket so we don't auto-auth as 'test4'
assert_script_run 'kdestroy -A'; assert_script_run 'kdestroy -A';
start_webui("test1", "batterystaple"); # we use test3 for this test; this means it'll fail if the webUI
# test fails before creating test3 and setting its password, but
# changing test1's password can cause other client tests to fail
# if they try and auth as test1 while it's changed
start_webui("test3", "batterystaple");
assert_and_click "freeipa_webui_actions"; assert_and_click "freeipa_webui_actions";
assert_and_click "freeipa_webui_reset_password_link"; assert_and_click "freeipa_webui_reset_password_link";
wait_still_screen 3; wait_still_screen 3;
@ -34,13 +38,15 @@ sub run {
# finishing (and handing off to freeipa_client_postinstall) # finishing (and handing off to freeipa_client_postinstall)
wait_still_screen 5; wait_still_screen 5;
# check we can kinit with changed password # check we can kinit with changed password
assert_script_run 'printf "loremipsum" | kinit test1'; assert_script_run 'printf "loremipsum" | kinit test3';
# change password via CLI (back to batterystaple, as that's what # change password via CLI (back to batterystaple, as that's what
# freeipa_client test expects) # freeipa_client test expects)
assert_script_run 'dnf -y install freeipa-admintools'; assert_script_run 'dnf -y install freeipa-admintools';
assert_script_run 'printf "batterystaple\nbatterystaple" | ipa user-mod test1 --password'; assert_script_run 'printf "batterystaple\nbatterystaple" | ipa user-mod test3 --password';
# check we can kinit again # check we can kinit again
assert_script_run 'printf "batterystaple" | kinit test1'; assert_script_run 'printf "batterystaple" | kinit test3';
# clear kerberos ticket for freeipa_client test
assert_script_run 'kdestroy -A';
# we just stay here - freeipa_client will pick right up # we just stay here - freeipa_client will pick right up
} }