Don't check version or pre-release note on banners

This reduces the coverage of the identification test a bit but
also *substantially* simplifies it. We run into a ton of problems
when we try to check the version and prerelease text on screens
where it appears on banners:

* The banners differ between variants
* The pre-release text is translated
* The banners have gradients so for RTL languages, even if some
  text is untranslated (e.g. 'Fedora 31') it appears on a
  different background color than on LTR languages
* The prerelease text is dark red; if it appears on a dark blue
  area of the banner this can trigger an os-autoinst needle
  comparison bug: https://progress.opensuse.org/issues/56822

All of this together means we wind up continually fighting these
checks and we have a whole forest of needles just for them, and
it doesn't seem worthwhile. So let's drop all the places where
we were checking version and prerelease on banners, and only
check them in two places where they appear on a grey background,
which avoids most of the problems (we just need one version
needle per release, and one prerelease needle per language).

Signed-off-by: Adam Williamson <awilliam@redhat.com>

needles/anaconda/identification/arabic/prerelease_note-arabic-rtl-server-orange-20190911.json

@@ -1,16 +0,0 @@
-{
-  "area": [
-    {
-      "width": 136,
-      "ypos": 34,
-      "xpos": 86,
-      "height": 18,
-      "type": "match"
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "LANGUAGE-arabic",
-    "prerelease_note"
-  ]
-}

needles/anaconda/identification/french/prerelease_note-french-blue-20190911.json

@@ -1,16 +0,0 @@
-{
-  "area": [
-    {
-      "xpos": 764,
-      "type": "match",
-      "height": 25,
-      "ypos": 35,
-      "width": 138
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "LANGUAGE-french",
-    "prerelease_note"
-  ]
-}

needles/anaconda/identification/japanese/prerelease_note-japanese-generic-blue-20190828.json

@@ -1,16 +0,0 @@
-{
-  "area": [
-    {
-      "ypos": 37,
-      "width": 141,
-      "xpos": 791,
-      "height": 19,
-      "type": "match"
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "LANGUAGE-japanese",
-    "prerelease_note"
-  ]
-}

needles/anaconda/identification/japanese/prerelease_note-japanese-server-blue-20190911.json

@@ -1,16 +0,0 @@
-{
-  "area": [
-    {
-      "ypos": 40,
-      "height": 27,
-      "type": "match",
-      "xpos": 791,
-      "width": 141
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "LANGUAGE-japanese",
-    "prerelease_note"
-  ]
-}

needles/anaconda/identification/prerelease_note_generic_blue.json

@@ -1,15 +0,0 @@
-{
-  "area": [
-    {
-      "xpos": 780,
-      "ypos": 33,
-      "width": 159,
-      "height": 26,
-      "type": "match"
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "prerelease_note"
-  ]
-}

needles/anaconda/identification/prerelease_note_server_blue.json

@@ -1,15 +0,0 @@
-{
-  "area": [
-    {
-      "xpos": 738,
-      "ypos": 33,
-      "width": 159,
-      "height": 26,
-      "type": "match"
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "prerelease_note"
-  ]
-}

needles/anaconda/identification/prerelease_note_workstation_blue-20190829.json

@@ -1,15 +0,0 @@
-{
-    "area": [
-        {
-            "height": 26,
-            "type": "match",
-            "width": 159,
-            "xpos": 781,
-            "ypos": 60
-        }
-    ],
-    "properties": [],
-    "tags": [
-        "prerelease_note"
-    ]
-}

needles/anaconda/identification/version_29_blue.json

@@ -1,15 +0,0 @@
-{
-  "area": [
-    {
-      "xpos": 797,
-      "ypos": 12,
-      "width": 93,
-      "height": 31,
-      "type": "match"
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "version_29_ident"
-  ]
-}

needles/anaconda/identification/version_30_blue.json

@@ -1,15 +0,0 @@
-{
-  "area": [
-    {
-      "xpos": 797,
-      "ypos": 39,
-      "width": 93,
-      "height": 32,
-      "type": "match"
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "version_30_ident"
-  ]
-}

needles/anaconda/identification/version_31-rtl-orange.json

@@ -1,15 +0,0 @@
-{
-  "area": [
-    {
-      "type": "match",
-      "width": 90,
-      "height": 20,
-      "xpos": 50,
-      "ypos": 12
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "version_31_ident"
-  ]
-}

needles/anaconda/identification/version_31_blue.json

@@ -1,15 +0,0 @@
-{
-  "area": [
-    {
-      "xpos": 783,
-      "ypos": 41,
-      "width": 90,
-      "height": 18,
-      "type": "match"
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "version_31_ident"
-  ]
-}

needles/anaconda/identification/version_rawhide_blue.json

@@ -1,15 +0,0 @@
-{
-  "area": [
-    {
-      "xpos": 740,
-      "ypos": 12,
-      "width": 148,
-      "height": 19,
-      "type": "match"
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "version_rawhide_ident"
-  ]
-}

tests/_do_install_and_reboot.pm

@@ -44,7 +44,11 @@ sub _set_root_password {
         my $identification = get_var('IDENTIFICATION');
         if ($identification eq 'true') {
             check_top_bar();
-            check_prerelease();
+            # we don't check version or pre-release because here those
+            # texts appear on the banner which makes the needling
+            # complex and fragile (banner is different between variants,
+            # and has a gradient so for RTL languages the background color
+            # differs; pre-release text is also translated)
         }
         assert_and_click "anaconda_spoke_done";
     }

tests/disk_guided_empty.pm

@@ -22,15 +22,11 @@ sub run {
    my $branched = get_var('VERSION');
    if ($identification eq 'true' or $branched ne "Rawhide") {
         check_top_bar(); # See utils.pm
-       # disabled because we have issues with false needle matches
+        # we don't check version or pre-release because here those
-       # on the pre-release note when it's dark red text on a dark
+        # texts appear on the banner which makes the needling
-       # blue background - os-autoinst greyscales images before
+        # complex and fragile (banner is different between variants,
-       # comparing, and they wind up the same shade of grey, so we
+        # and has a gradient so for RTL languages the background color
-       # will get a 'match' for the pre-release needle even if the
+        # differs; pre-release text is also translated)
-       # text is not there at all:
-       # https://progress.opensuse.org/issues/56822
-       # check_prerelease();
-       check_version();
    }
 
     assert_and_click "anaconda_spoke_done";