From b2aedd5f1207c0de7f17d99d23577067a09131bc Mon Sep 17 00:00:00 2001 From: Adam Williamson Date: Sat, 19 Apr 2025 11:29:21 -0700 Subject: [PATCH] _boot_to_anaconda: drop installer launch retry loop This seems to be sometimes *causing* problems now. In some cases, the first launch actually worked but we don't wait long enough for anaconda to show up, so we launch it twice, and that can cause failures like https://bugzilla.redhat.com/2360859 . I did a dry run for a few days on staging and just dropping the loop entirely didn't seem to produce any failures-to-launch, so maybe the various bugs we added this for in the first place have all gone away? Let's try dropping it. If we run into failure-to -launch problems again, we can add it back but bump the timeout or something. Signed-off-by: Adam Williamson --- tests/_boot_to_anaconda.pm | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/tests/_boot_to_anaconda.pm b/tests/_boot_to_anaconda.pm index 35798f68..7b9f4006 100644 --- a/tests/_boot_to_anaconda.pm +++ b/tests/_boot_to_anaconda.pm @@ -184,18 +184,9 @@ sub run { # if we hit the g-i-s flow we already launched unless ($launched) { # for KDE we need to double-click - my $relnum = get_release_number; my $dclick = 0; $dclick = 1 if (get_var("DESKTOP") eq "kde"); - # FIXME launching the installer sometimes fails on KDE - # https://bugzilla.redhat.com/show_bug.cgi?id=2280840 - my $tries = 5; - while ($tries) { - $tries -= 1; - assert_and_click("live_start_anaconda_icon", dclick => $dclick); - last if (check_screen ["anaconda_select_install_lang", "anaconda_webui_installmethod"], 180); - die "Launching installer failed after 5 tries!" unless ($tries); - } + assert_and_click("live_start_anaconda_icon", dclick => $dclick); } } # wait for anaconda to appear