From adedf40b6f489a89d007f2ee7b4ffc18cd08bb53 Mon Sep 17 00:00:00 2001 From: Adam Williamson Date: Fri, 12 Apr 2024 12:45:47 -0700 Subject: [PATCH] apps_startstop: don't rollback, defend against KDE mistypes This comes from trying to fix the annoying recurring problem with mistypes in KDE which has been going on since at least December. First, we add the attempt to kind of 'precache' the kicker menu in aasetting.pm. Then, I thought, all this snapshot loading has to be putting a lot of load on the workers. And when each subtest passes, it shouldn't really be necessary - they all end with quit_with_shortcut(), which verifies that the app exited and we got back to a blank desktop, so successful subtests should not usually interfere with each other. We probably only want to rollback on *failed* subtests, which is in fact openQA's default behavior. There only seems to be one case where a test changes the system state such that later tests might be affected, so I kept always_rollback just for that one. I've run this through three cycles on GNOME and KDE and it looks good. Signed-off-by: Adam Williamson --- tests/apps_startstop/gnome/abrt.pm | 2 +- tests/apps_startstop/gnome/boxes.pm | 2 +- tests/apps_startstop/gnome/calculator.pm | 2 +- tests/apps_startstop/gnome/calendar.pm | 2 +- tests/apps_startstop/gnome/camera.pm | 2 +- tests/apps_startstop/gnome/chars.pm | 2 +- tests/apps_startstop/gnome/clocks.pm | 2 +- tests/apps_startstop/gnome/contacts.pm | 2 +- tests/apps_startstop/gnome/disks.pm | 2 +- tests/apps_startstop/gnome/diskusage.pm | 2 +- tests/apps_startstop/gnome/dviewer.pm | 2 +- tests/apps_startstop/gnome/files.pm | 2 +- tests/apps_startstop/gnome/firefox.pm | 2 +- tests/apps_startstop/gnome/fonts.pm | 2 +- tests/apps_startstop/gnome/help.pm | 2 +- tests/apps_startstop/gnome/imageviewer.pm | 2 +- tests/apps_startstop/gnome/lcalc.pm | 2 +- tests/apps_startstop/gnome/limpress.pm | 2 +- tests/apps_startstop/gnome/logs.pm | 2 +- tests/apps_startstop/gnome/lwriter.pm | 2 +- tests/apps_startstop/gnome/maps.pm | 2 +- tests/apps_startstop/gnome/monitor.pm | 2 +- tests/apps_startstop/gnome/rhythmbox.pm | 2 +- tests/apps_startstop/gnome/scan.pm | 2 +- tests/apps_startstop/gnome/settings.pm | 2 +- tests/apps_startstop/gnome/software.pm | 2 +- tests/apps_startstop/gnome/terminal.pm | 2 +- tests/apps_startstop/gnome/texteditor.pm | 2 +- tests/apps_startstop/gnome/videos.pm | 2 +- tests/apps_startstop/gnome/weather.pm | 2 +- tests/apps_startstop/kde/aasetting.pm | 8 ++++++++ tests/apps_startstop/kde/abrt.pm | 2 +- tests/apps_startstop/kde/akregator.pm | 2 +- tests/apps_startstop/kde/ark.pm | 2 +- tests/apps_startstop/kde/cpteditor.pm | 2 +- tests/apps_startstop/kde/cteditor.pm | 2 +- tests/apps_startstop/kde/discover.pm | 2 +- tests/apps_startstop/kde/docviewer.pm | 2 +- tests/apps_startstop/kde/dolphin.pm | 2 +- tests/apps_startstop/kde/firefox.pm | 2 +- tests/apps_startstop/kde/firewall.pm | 2 +- tests/apps_startstop/kde/gwenview.pm | 2 +- tests/apps_startstop/kde/help.pm | 2 +- tests/apps_startstop/kde/infocenter.pm | 2 +- tests/apps_startstop/kde/kaddressbook.pm | 2 +- tests/apps_startstop/kde/kcalc.pm | 2 +- tests/apps_startstop/kde/kcharselect.pm | 2 +- tests/apps_startstop/kde/kfind.pm | 2 +- tests/apps_startstop/kde/kgpg.pm | 2 +- tests/apps_startstop/kde/kmag.pm | 2 +- tests/apps_startstop/kde/kmail.pm | 2 +- tests/apps_startstop/kde/kmail_header.pm | 2 +- tests/apps_startstop/kde/kmousetool.pm | 2 +- tests/apps_startstop/kde/kmouth.pm | 2 +- tests/apps_startstop/kde/kolourpaint.pm | 2 +- tests/apps_startstop/kde/konsole.pm | 2 +- tests/apps_startstop/kde/kontakt.pm | 2 +- tests/apps_startstop/kde/konversation.pm | 2 +- tests/apps_startstop/kde/korganizer.pm | 2 +- tests/apps_startstop/kde/kparted.pm | 2 +- tests/apps_startstop/kde/krdc.pm | 2 +- tests/apps_startstop/kde/krfb.pm | 2 +- tests/apps_startstop/kde/ktnef.pm | 2 +- tests/apps_startstop/kde/kwallet.pm | 2 +- tests/apps_startstop/kde/kwrite.pm | 2 +- tests/apps_startstop/kde/lcalc.pm | 2 +- tests/apps_startstop/kde/limpress.pm | 2 +- tests/apps_startstop/kde/lwriter.pm | 2 +- tests/apps_startstop/kde/mahjong.pm | 2 +- tests/apps_startstop/kde/mediawriter.pm | 2 +- tests/apps_startstop/kde/minesweeper.pm | 2 +- tests/apps_startstop/kde/patience.pm | 2 +- tests/apps_startstop/kde/pimexporter.pm | 2 +- tests/apps_startstop/kde/plasmasystemmonitor.pm | 2 +- tests/apps_startstop/kde/spectacle.pm | 2 +- tests/apps_startstop/kde/system_settings.pm | 2 +- tests/apps_startstop/kde/vault.pm | 2 +- 77 files changed, 84 insertions(+), 76 deletions(-) diff --git a/tests/apps_startstop/gnome/abrt.pm b/tests/apps_startstop/gnome/abrt.pm index 91c34e95..9d6cf5bf 100644 --- a/tests/apps_startstop/gnome/abrt.pm +++ b/tests/apps_startstop/gnome/abrt.pm @@ -19,7 +19,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/gnome/boxes.pm b/tests/apps_startstop/gnome/boxes.pm index 538d407e..d9ce5f0f 100644 --- a/tests/apps_startstop/gnome/boxes.pm +++ b/tests/apps_startstop/gnome/boxes.pm @@ -25,7 +25,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/calculator.pm b/tests/apps_startstop/gnome/calculator.pm index c411c287..17eaf3ea 100644 --- a/tests/apps_startstop/gnome/calculator.pm +++ b/tests/apps_startstop/gnome/calculator.pm @@ -19,7 +19,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/calendar.pm b/tests/apps_startstop/gnome/calendar.pm index ba337957..cc8c0c78 100644 --- a/tests/apps_startstop/gnome/calendar.pm +++ b/tests/apps_startstop/gnome/calendar.pm @@ -25,7 +25,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/camera.pm b/tests/apps_startstop/gnome/camera.pm index d0bb04c4..b7338e10 100644 --- a/tests/apps_startstop/gnome/camera.pm +++ b/tests/apps_startstop/gnome/camera.pm @@ -25,7 +25,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/chars.pm b/tests/apps_startstop/gnome/chars.pm index a3ca6c29..12a03106 100644 --- a/tests/apps_startstop/gnome/chars.pm +++ b/tests/apps_startstop/gnome/chars.pm @@ -20,7 +20,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/clocks.pm b/tests/apps_startstop/gnome/clocks.pm index 895b7463..9bf8bb41 100644 --- a/tests/apps_startstop/gnome/clocks.pm +++ b/tests/apps_startstop/gnome/clocks.pm @@ -23,7 +23,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/contacts.pm b/tests/apps_startstop/gnome/contacts.pm index bff3811e..a89c2782 100644 --- a/tests/apps_startstop/gnome/contacts.pm +++ b/tests/apps_startstop/gnome/contacts.pm @@ -19,7 +19,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/disks.pm b/tests/apps_startstop/gnome/disks.pm index 5e4c7939..972066e4 100644 --- a/tests/apps_startstop/gnome/disks.pm +++ b/tests/apps_startstop/gnome/disks.pm @@ -18,7 +18,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/diskusage.pm b/tests/apps_startstop/gnome/diskusage.pm index 8c169b98..08a9fdec 100644 --- a/tests/apps_startstop/gnome/diskusage.pm +++ b/tests/apps_startstop/gnome/diskusage.pm @@ -19,7 +19,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/dviewer.pm b/tests/apps_startstop/gnome/dviewer.pm index dbb200a7..ec0f48d1 100644 --- a/tests/apps_startstop/gnome/dviewer.pm +++ b/tests/apps_startstop/gnome/dviewer.pm @@ -18,7 +18,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/files.pm b/tests/apps_startstop/gnome/files.pm index 8b9d51a3..1302b722 100644 --- a/tests/apps_startstop/gnome/files.pm +++ b/tests/apps_startstop/gnome/files.pm @@ -19,7 +19,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/firefox.pm b/tests/apps_startstop/gnome/firefox.pm index 5557aa5e..b080e8e3 100644 --- a/tests/apps_startstop/gnome/firefox.pm +++ b/tests/apps_startstop/gnome/firefox.pm @@ -30,7 +30,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/fonts.pm b/tests/apps_startstop/gnome/fonts.pm index 8990a7cd..7f7ede40 100644 --- a/tests/apps_startstop/gnome/fonts.pm +++ b/tests/apps_startstop/gnome/fonts.pm @@ -19,7 +19,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/help.pm b/tests/apps_startstop/gnome/help.pm index b5b2dd79..fb15c489 100644 --- a/tests/apps_startstop/gnome/help.pm +++ b/tests/apps_startstop/gnome/help.pm @@ -18,7 +18,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/imageviewer.pm b/tests/apps_startstop/gnome/imageviewer.pm index b1506961..49f50f43 100644 --- a/tests/apps_startstop/gnome/imageviewer.pm +++ b/tests/apps_startstop/gnome/imageviewer.pm @@ -19,7 +19,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/lcalc.pm b/tests/apps_startstop/gnome/lcalc.pm index 9f1b5617..1141b31f 100644 --- a/tests/apps_startstop/gnome/lcalc.pm +++ b/tests/apps_startstop/gnome/lcalc.pm @@ -19,7 +19,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/limpress.pm b/tests/apps_startstop/gnome/limpress.pm index 226aa455..681dbd98 100644 --- a/tests/apps_startstop/gnome/limpress.pm +++ b/tests/apps_startstop/gnome/limpress.pm @@ -20,7 +20,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/logs.pm b/tests/apps_startstop/gnome/logs.pm index f2769854..4dfa8c3a 100644 --- a/tests/apps_startstop/gnome/logs.pm +++ b/tests/apps_startstop/gnome/logs.pm @@ -19,7 +19,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/lwriter.pm b/tests/apps_startstop/gnome/lwriter.pm index 5a38507c..ca9cf4e8 100644 --- a/tests/apps_startstop/gnome/lwriter.pm +++ b/tests/apps_startstop/gnome/lwriter.pm @@ -19,7 +19,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/maps.pm b/tests/apps_startstop/gnome/maps.pm index ed00973e..811de486 100644 --- a/tests/apps_startstop/gnome/maps.pm +++ b/tests/apps_startstop/gnome/maps.pm @@ -24,7 +24,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/monitor.pm b/tests/apps_startstop/gnome/monitor.pm index 9cf0ae13..71301842 100644 --- a/tests/apps_startstop/gnome/monitor.pm +++ b/tests/apps_startstop/gnome/monitor.pm @@ -19,7 +19,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/rhythmbox.pm b/tests/apps_startstop/gnome/rhythmbox.pm index 4deec4d7..31e5688a 100644 --- a/tests/apps_startstop/gnome/rhythmbox.pm +++ b/tests/apps_startstop/gnome/rhythmbox.pm @@ -28,7 +28,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/scan.pm b/tests/apps_startstop/gnome/scan.pm index 2bf17791..8e216492 100644 --- a/tests/apps_startstop/gnome/scan.pm +++ b/tests/apps_startstop/gnome/scan.pm @@ -20,7 +20,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/settings.pm b/tests/apps_startstop/gnome/settings.pm index e16ab3f2..4f7c4ac0 100644 --- a/tests/apps_startstop/gnome/settings.pm +++ b/tests/apps_startstop/gnome/settings.pm @@ -26,7 +26,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/software.pm b/tests/apps_startstop/gnome/software.pm index afc5b928..58d43c00 100644 --- a/tests/apps_startstop/gnome/software.pm +++ b/tests/apps_startstop/gnome/software.pm @@ -27,7 +27,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/terminal.pm b/tests/apps_startstop/gnome/terminal.pm index 6f90854c..745375d2 100644 --- a/tests/apps_startstop/gnome/terminal.pm +++ b/tests/apps_startstop/gnome/terminal.pm @@ -19,7 +19,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/texteditor.pm b/tests/apps_startstop/gnome/texteditor.pm index 40c70f8b..271c9d8f 100644 --- a/tests/apps_startstop/gnome/texteditor.pm +++ b/tests/apps_startstop/gnome/texteditor.pm @@ -19,7 +19,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/videos.pm b/tests/apps_startstop/gnome/videos.pm index a1a8d481..1a64113e 100644 --- a/tests/apps_startstop/gnome/videos.pm +++ b/tests/apps_startstop/gnome/videos.pm @@ -19,7 +19,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/gnome/weather.pm b/tests/apps_startstop/gnome/weather.pm index f973eae9..277c00ce 100644 --- a/tests/apps_startstop/gnome/weather.pm +++ b/tests/apps_startstop/gnome/weather.pm @@ -23,7 +23,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/kde/aasetting.pm b/tests/apps_startstop/kde/aasetting.pm index 53813948..b600838e 100644 --- a/tests/apps_startstop/kde/aasetting.pm +++ b/tests/apps_startstop/kde/aasetting.pm @@ -9,6 +9,14 @@ use utils; sub run { my $self = shift; solidify_wallpaper; + # to try and avoid problems with kde grinding a lot on first + # attempt to do a menu_launch_type, let's do a throwaway one + # here before we snapshot + wait_screen_change { send_key 'super'; }; + wait_still_screen 3; + send_key "k"; + wait_still_screen 5; + send_key "esc"; } sub test_flags { diff --git a/tests/apps_startstop/kde/abrt.pm b/tests/apps_startstop/kde/abrt.pm index 20181ec9..783738f2 100644 --- a/tests/apps_startstop/kde/abrt.pm +++ b/tests/apps_startstop/kde/abrt.pm @@ -15,7 +15,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/akregator.pm b/tests/apps_startstop/kde/akregator.pm index 576d2e38..b148fef2 100644 --- a/tests/apps_startstop/kde/akregator.pm +++ b/tests/apps_startstop/kde/akregator.pm @@ -16,7 +16,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/ark.pm b/tests/apps_startstop/kde/ark.pm index 9d476f19..af961702 100644 --- a/tests/apps_startstop/kde/ark.pm +++ b/tests/apps_startstop/kde/ark.pm @@ -16,7 +16,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/cpteditor.pm b/tests/apps_startstop/kde/cpteditor.pm index 2d8471cd..fef97bb8 100644 --- a/tests/apps_startstop/kde/cpteditor.pm +++ b/tests/apps_startstop/kde/cpteditor.pm @@ -15,7 +15,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/cteditor.pm b/tests/apps_startstop/kde/cteditor.pm index 52826fc5..cf8d5575 100644 --- a/tests/apps_startstop/kde/cteditor.pm +++ b/tests/apps_startstop/kde/cteditor.pm @@ -16,7 +16,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/discover.pm b/tests/apps_startstop/kde/discover.pm index 9686215d..cec5b02b 100644 --- a/tests/apps_startstop/kde/discover.pm +++ b/tests/apps_startstop/kde/discover.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/docviewer.pm b/tests/apps_startstop/kde/docviewer.pm index e58d9588..a5e401da 100644 --- a/tests/apps_startstop/kde/docviewer.pm +++ b/tests/apps_startstop/kde/docviewer.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/dolphin.pm b/tests/apps_startstop/kde/dolphin.pm index 67dec3bd..b1af9f44 100644 --- a/tests/apps_startstop/kde/dolphin.pm +++ b/tests/apps_startstop/kde/dolphin.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/firefox.pm b/tests/apps_startstop/kde/firefox.pm index 386e28b3..ab6a8739 100644 --- a/tests/apps_startstop/kde/firefox.pm +++ b/tests/apps_startstop/kde/firefox.pm @@ -26,7 +26,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/firewall.pm b/tests/apps_startstop/kde/firewall.pm index 2fcd88a6..348f8a08 100644 --- a/tests/apps_startstop/kde/firewall.pm +++ b/tests/apps_startstop/kde/firewall.pm @@ -26,7 +26,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/gwenview.pm b/tests/apps_startstop/kde/gwenview.pm index 49410ada..545d4ee4 100644 --- a/tests/apps_startstop/kde/gwenview.pm +++ b/tests/apps_startstop/kde/gwenview.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/help.pm b/tests/apps_startstop/kde/help.pm index bac4b4d2..57fccff0 100644 --- a/tests/apps_startstop/kde/help.pm +++ b/tests/apps_startstop/kde/help.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/infocenter.pm b/tests/apps_startstop/kde/infocenter.pm index fd9a6f64..f0f580aa 100644 --- a/tests/apps_startstop/kde/infocenter.pm +++ b/tests/apps_startstop/kde/infocenter.pm @@ -25,7 +25,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/kaddressbook.pm b/tests/apps_startstop/kde/kaddressbook.pm index 7da9f635..5f95d612 100644 --- a/tests/apps_startstop/kde/kaddressbook.pm +++ b/tests/apps_startstop/kde/kaddressbook.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/kcalc.pm b/tests/apps_startstop/kde/kcalc.pm index efd8cb3f..48222199 100644 --- a/tests/apps_startstop/kde/kcalc.pm +++ b/tests/apps_startstop/kde/kcalc.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/kcharselect.pm b/tests/apps_startstop/kde/kcharselect.pm index 06c8db5f..4052a8a8 100644 --- a/tests/apps_startstop/kde/kcharselect.pm +++ b/tests/apps_startstop/kde/kcharselect.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/kfind.pm b/tests/apps_startstop/kde/kfind.pm index 9a2e539c..0d2d1c0c 100644 --- a/tests/apps_startstop/kde/kfind.pm +++ b/tests/apps_startstop/kde/kfind.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/kgpg.pm b/tests/apps_startstop/kde/kgpg.pm index a76b0e81..bed46a50 100644 --- a/tests/apps_startstop/kde/kgpg.pm +++ b/tests/apps_startstop/kde/kgpg.pm @@ -35,7 +35,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/kmag.pm b/tests/apps_startstop/kde/kmag.pm index ebd1935f..bae15722 100644 --- a/tests/apps_startstop/kde/kmag.pm +++ b/tests/apps_startstop/kde/kmag.pm @@ -20,7 +20,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/kmail.pm b/tests/apps_startstop/kde/kmail.pm index 26281f36..fcb94334 100644 --- a/tests/apps_startstop/kde/kmail.pm +++ b/tests/apps_startstop/kde/kmail.pm @@ -24,7 +24,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/kmail_header.pm b/tests/apps_startstop/kde/kmail_header.pm index af7f3dc2..e66ec11c 100644 --- a/tests/apps_startstop/kde/kmail_header.pm +++ b/tests/apps_startstop/kde/kmail_header.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/kmousetool.pm b/tests/apps_startstop/kde/kmousetool.pm index c7d4783f..3f43f7f3 100644 --- a/tests/apps_startstop/kde/kmousetool.pm +++ b/tests/apps_startstop/kde/kmousetool.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/kmouth.pm b/tests/apps_startstop/kde/kmouth.pm index 329e2972..024869b7 100644 --- a/tests/apps_startstop/kde/kmouth.pm +++ b/tests/apps_startstop/kde/kmouth.pm @@ -31,7 +31,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } 1; diff --git a/tests/apps_startstop/kde/kolourpaint.pm b/tests/apps_startstop/kde/kolourpaint.pm index 6aebf349..261d38fa 100644 --- a/tests/apps_startstop/kde/kolourpaint.pm +++ b/tests/apps_startstop/kde/kolourpaint.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/konsole.pm b/tests/apps_startstop/kde/konsole.pm index 3449f373..0ed45e60 100644 --- a/tests/apps_startstop/kde/konsole.pm +++ b/tests/apps_startstop/kde/konsole.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/kontakt.pm b/tests/apps_startstop/kde/kontakt.pm index 217ac460..44aa0a3d 100644 --- a/tests/apps_startstop/kde/kontakt.pm +++ b/tests/apps_startstop/kde/kontakt.pm @@ -23,7 +23,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/konversation.pm b/tests/apps_startstop/kde/konversation.pm index 8d36edff..34e9a646 100644 --- a/tests/apps_startstop/kde/konversation.pm +++ b/tests/apps_startstop/kde/konversation.pm @@ -30,7 +30,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/korganizer.pm b/tests/apps_startstop/kde/korganizer.pm index 4e426b5f..2297a7bd 100644 --- a/tests/apps_startstop/kde/korganizer.pm +++ b/tests/apps_startstop/kde/korganizer.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/kparted.pm b/tests/apps_startstop/kde/kparted.pm index cacf55fb..b3362cc0 100644 --- a/tests/apps_startstop/kde/kparted.pm +++ b/tests/apps_startstop/kde/kparted.pm @@ -22,7 +22,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/krdc.pm b/tests/apps_startstop/kde/krdc.pm index 67fa657b..d49e79c1 100644 --- a/tests/apps_startstop/kde/krdc.pm +++ b/tests/apps_startstop/kde/krdc.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/krfb.pm b/tests/apps_startstop/kde/krfb.pm index 1dfa427f..d67643d4 100644 --- a/tests/apps_startstop/kde/krfb.pm +++ b/tests/apps_startstop/kde/krfb.pm @@ -30,7 +30,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/ktnef.pm b/tests/apps_startstop/kde/ktnef.pm index 726ec22b..f955f857 100644 --- a/tests/apps_startstop/kde/ktnef.pm +++ b/tests/apps_startstop/kde/ktnef.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/kwallet.pm b/tests/apps_startstop/kde/kwallet.pm index 8bff90fd..c2021ecc 100644 --- a/tests/apps_startstop/kde/kwallet.pm +++ b/tests/apps_startstop/kde/kwallet.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/kwrite.pm b/tests/apps_startstop/kde/kwrite.pm index b294d141..0ea9f1b4 100644 --- a/tests/apps_startstop/kde/kwrite.pm +++ b/tests/apps_startstop/kde/kwrite.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/lcalc.pm b/tests/apps_startstop/kde/lcalc.pm index 3c165945..43192181 100644 --- a/tests/apps_startstop/kde/lcalc.pm +++ b/tests/apps_startstop/kde/lcalc.pm @@ -16,7 +16,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/limpress.pm b/tests/apps_startstop/kde/limpress.pm index 69e57837..d48915c1 100644 --- a/tests/apps_startstop/kde/limpress.pm +++ b/tests/apps_startstop/kde/limpress.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/lwriter.pm b/tests/apps_startstop/kde/lwriter.pm index 780e17cf..3e330ff6 100644 --- a/tests/apps_startstop/kde/lwriter.pm +++ b/tests/apps_startstop/kde/lwriter.pm @@ -15,7 +15,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/mahjong.pm b/tests/apps_startstop/kde/mahjong.pm index 9d6bdd7d..5681d4f1 100644 --- a/tests/apps_startstop/kde/mahjong.pm +++ b/tests/apps_startstop/kde/mahjong.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/mediawriter.pm b/tests/apps_startstop/kde/mediawriter.pm index 57a5e337..0ad3da3c 100644 --- a/tests/apps_startstop/kde/mediawriter.pm +++ b/tests/apps_startstop/kde/mediawriter.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/minesweeper.pm b/tests/apps_startstop/kde/minesweeper.pm index 2ea93b73..03eced94 100644 --- a/tests/apps_startstop/kde/minesweeper.pm +++ b/tests/apps_startstop/kde/minesweeper.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/patience.pm b/tests/apps_startstop/kde/patience.pm index 0bf002b2..eb1ce185 100644 --- a/tests/apps_startstop/kde/patience.pm +++ b/tests/apps_startstop/kde/patience.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/pimexporter.pm b/tests/apps_startstop/kde/pimexporter.pm index fe4c5839..9d98c2ad 100644 --- a/tests/apps_startstop/kde/pimexporter.pm +++ b/tests/apps_startstop/kde/pimexporter.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/plasmasystemmonitor.pm b/tests/apps_startstop/kde/plasmasystemmonitor.pm index 0f87b9ab..f4d29758 100644 --- a/tests/apps_startstop/kde/plasmasystemmonitor.pm +++ b/tests/apps_startstop/kde/plasmasystemmonitor.pm @@ -16,7 +16,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/spectacle.pm b/tests/apps_startstop/kde/spectacle.pm index 4a6ec4c5..09a019ff 100644 --- a/tests/apps_startstop/kde/spectacle.pm +++ b/tests/apps_startstop/kde/spectacle.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/system_settings.pm b/tests/apps_startstop/kde/system_settings.pm index 31be479b..1884e598 100644 --- a/tests/apps_startstop/kde/system_settings.pm +++ b/tests/apps_startstop/kde/system_settings.pm @@ -17,7 +17,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; } diff --git a/tests/apps_startstop/kde/vault.pm b/tests/apps_startstop/kde/vault.pm index 7fed55e3..7d8af49c 100644 --- a/tests/apps_startstop/kde/vault.pm +++ b/tests/apps_startstop/kde/vault.pm @@ -69,7 +69,7 @@ sub run { } sub test_flags { - return {always_rollback => 1}; + return {}; }