Drop a pre-F34 path for launching update tool on KDE

Before F34 we had to launch the update tool from the systray.
This isn't the case any more, so we can throw all this code and
these needles away.

Signed-off-by: Adam Williamson <awilliam@redhat.com>

needles/kde/desktop_update_notification_systray-kde-20200929.json

@@ -1,17 +0,0 @@
-{
-    "area": [
-        {
-            "height": 18,
-            "type": "match",
-            "width": 18,
-            "xpos": 776,
-            "ypos": 741,
-            "match": 90
-        }
-    ],
-    "properties": [],
-    "tags": [
-        "desktop_update_notification_systray",
-        "desktop_package_tool_update"
-    ]
-}

needles/kde/desktop_update_notification_systray-kde-grey-20210715.json

@@ -1,16 +0,0 @@
-{
-  "area": [
-    {
-      "height": 18,
-      "type": "match",
-      "ypos": 736,
-      "xpos": 773,
-      "width": 18
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "desktop_update_notification_systray",
-    "desktop_package_tool_update"
-  ]
-}

needles/kde/desktop_update_notification_systray-kde-grey-20210721.json

@@ -1,16 +0,0 @@
-{
-  "area": [
-    {
-      "width": 18,
-      "ypos": 736,
-      "type": "match",
-      "xpos": 760,
-      "height": 18
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "desktop_update_notification_systray",
-    "desktop_package_tool_update"
-  ]
-}

needles/kde/desktop_update_notification_systray-kde-grey-20220225.json

@@ -1,16 +0,0 @@
-{
-  "area": [
-    {
-      "xpos": 791,
-      "width": 18,
-      "type": "match",
-      "ypos": 737,
-      "height": 18
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "desktop_update_notification_systray",
-    "desktop_package_tool_update"
-  ]
-}

tests/desktop_update_graphical.pm

@@ -16,22 +16,8 @@ sub run {
     desktop_vt;
 
     # run the updater
-    # FIXME: when F33 goes EOL, remove all the KDE < F34 stuff below
-    # and drop 'desktop_package_tool_update' tag from
-    # desktop_update_notification_systray-kde-20200929.json
     if ($desktop eq 'kde') {
-        # KDE team tells me until F34 the 'preferred' update method
-        # was the systray applet...
-        if ($relnum < 34) {
-            # get rid of notifications which get in the way of the things
-            # we need to click
-            click_unwanted_notifications;
-            assert_and_click 'desktop_expand_systray';
-        }
-        else {
-            # ...from F34 onwards, it's Plasma Discover app
-            menu_launch_type('discover');
-        }
+        menu_launch_type('discover');
     }
     else {
         # this launches GNOME Software on GNOME, dunno for any other
@@ -44,15 +30,12 @@ sub run {
     if ($desktop eq 'gnome' && check_screen 'gnome_software_welcome', 10) {
         send_key 'ret';
     }
-    # go to the 'update' interface. For GNOME or KDE on F34+, we
-    # may be waiting some time at a 'Software catalog is being
-    # loaded' screen.
-    if ($desktop eq 'gnome' || ($desktop eq 'kde' && $relnum > 33)) {
-        for my $n (1..5) {
-            last if (check_screen 'desktop_package_tool_update', 120);
-            mouse_set 10, 10;
-            mouse_hide;
-        }
+    # go to the 'update' interface. We may be waiting some time at a
+    # 'Software catalog is being loaded' screen.
+    for my $n (1..5) {
+        last if (check_screen 'desktop_package_tool_update', 120);
+        mouse_set 10, 10;
+        mouse_hide;
     }
     assert_and_click 'desktop_package_tool_update';
     # wait for things to settle if e.g. GNOME is refreshing