From 9f2d44a18181533ebf1c93e9153a2a4c0fd4fe6e Mon Sep 17 00:00:00 2001 From: Adam Williamson Date: Mon, 22 Apr 2024 16:14:29 -0700 Subject: [PATCH] drop a FIXME on enabling/disabling repos with sed dnf5 config-manager can now do this, but the syntax is different to dnf4, and honestly, it seems easier to just stick with this going forward than make it conditional on dnf version until dnf4 goes away. So let's stop marking this as a FIXME. Signed-off-by: Adam Williamson --- lib/utils.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/utils.pm b/lib/utils.pm index 906e3303..baf947a6 100644 --- a/lib/utils.pm +++ b/lib/utils.pm @@ -496,7 +496,8 @@ sub disable_updates_repos { both => 0, @_ ); - # FIXME as of 2023-06-20 dnf5 doesn't have config-manager plugin yet :( + # we used to do this with config-manager, but the syntax differs + # on dnf 4 vs. dnf 5 and really sed is just as easy assert_script_run 'sed -i -e "s,enabled=1,enabled=0,g" /etc/yum.repos.d/fedora-updates-testing.repo'; assert_script_run 'sed -i -e "s,enabled=1,enabled=0,g" /etc/yum.repos.d/fedora-updates.repo' if ($args{both}); unless (script_run 'test -f /etc/yum.repos.d/fedora-updates-testing-modular.repo') {