From 9cd8ed804e9bd06dff9b276ff9d768788267bf8a Mon Sep 17 00:00:00 2001
From: Adam Williamson <awilliam@redhat.com>
Date: Fri, 11 Aug 2023 10:47:11 -0700
Subject: [PATCH] GDM language login needles: Rename, move and mark as
 workarounds

These are all the new needles for the 'no blue outline on
password entry box any more' issue. The naming was a bit non-
standard and they were not in the right directories, and they
need to be actually tagged as workarounds, like the English
one is. Also, add the correct issue link to the workaround note
for the English one.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
---
 ...ogin_gdm_input_arabic-noblue-20230809.json |  22 ++++++++++++++++++
 ...ogin_gdm_input_arabic-noblue-20230809.png} | Bin
 ...ogin_gdm_input_french-noblue-20230809.json |  22 ++++++++++++++++++
 ...ogin_gdm_input_french-noblue-20230809.png} | Bin
 ...in_gdm_input_japanese-noblue-20230809.json |  22 ++++++++++++++++++
 ...in_gdm_input_japanese-noblue-20230809.png} | Bin
 .../login_gdm_input-noblue-20230808.json      |   4 ++--
 ..._gdm_input_arabic-20230809_workaround.json |  17 --------------
 ..._gdm_input_french-20230809_workaround.json |  17 --------------
 ...dm_input_japanese-20230809_workaround.json |  17 --------------
 ...gdm_input_russian-20230809_workaround.json |  17 --------------
 ...gdm_input_turkish-20230809_workaround.json |  17 --------------
 ...gin_gdm_input_russian-noblue-20230809.json |  22 ++++++++++++++++++
 ...gin_gdm_input_russian-noblue-20230809.png} | Bin
 ...gin_gdm_input_turkish-noblue-20230809.json |  22 ++++++++++++++++++
 ...gin_gdm_input_turkish-noblue-20230809.png} | Bin
 16 files changed, 112 insertions(+), 87 deletions(-)
 create mode 100644 needles/gnome/arabic/login_gdm_input_arabic-noblue-20230809.json
 rename needles/gnome/{login_gdm_input_arabic-20230809_workaround.png => arabic/login_gdm_input_arabic-noblue-20230809.png} (100%)
 create mode 100644 needles/gnome/french/login_gdm_input_french-noblue-20230809.json
 rename needles/gnome/{login_gdm_input_french-20230809_workaround.png => french/login_gdm_input_french-noblue-20230809.png} (100%)
 create mode 100644 needles/gnome/japanese/login_gdm_input_japanese-noblue-20230809.json
 rename needles/gnome/{login_gdm_input_japanese-20230809_workaround.png => japanese/login_gdm_input_japanese-noblue-20230809.png} (100%)
 delete mode 100644 needles/gnome/login_gdm_input_arabic-20230809_workaround.json
 delete mode 100644 needles/gnome/login_gdm_input_french-20230809_workaround.json
 delete mode 100644 needles/gnome/login_gdm_input_japanese-20230809_workaround.json
 delete mode 100644 needles/gnome/login_gdm_input_russian-20230809_workaround.json
 delete mode 100644 needles/gnome/login_gdm_input_turkish-20230809_workaround.json
 create mode 100644 needles/gnome/russian/login_gdm_input_russian-noblue-20230809.json
 rename needles/gnome/{login_gdm_input_russian-20230809_workaround.png => russian/login_gdm_input_russian-noblue-20230809.png} (100%)
 create mode 100644 needles/gnome/turkish/login_gdm_input_turkish-noblue-20230809.json
 rename needles/gnome/{login_gdm_input_turkish-20230809_workaround.png => turkish/login_gdm_input_turkish-noblue-20230809.png} (100%)

diff --git a/needles/gnome/arabic/login_gdm_input_arabic-noblue-20230809.json b/needles/gnome/arabic/login_gdm_input_arabic-noblue-20230809.json
new file mode 100644
index 00000000..b5927af2
--- /dev/null
+++ b/needles/gnome/arabic/login_gdm_input_arabic-noblue-20230809.json
@@ -0,0 +1,22 @@
+{
+  "area": [
+    {
+      "type": "match",
+      "xpos": 588,
+      "height": 59,
+      "ypos": 451,
+      "width": 58
+    }
+  ],
+  "properties": [
+    {
+      "name": "workaround",
+      "value": "the text box should be surrounded with a blue line to indicate it's active: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6880"
+    }
+  ],
+  "tags": [
+    "DESKTOP-gnome",
+    "LANGUAGE-arabic",
+    "graphical_login_input"
+  ]
+}
diff --git a/needles/gnome/login_gdm_input_arabic-20230809_workaround.png b/needles/gnome/arabic/login_gdm_input_arabic-noblue-20230809.png
similarity index 100%
rename from needles/gnome/login_gdm_input_arabic-20230809_workaround.png
rename to needles/gnome/arabic/login_gdm_input_arabic-noblue-20230809.png
diff --git a/needles/gnome/french/login_gdm_input_french-noblue-20230809.json b/needles/gnome/french/login_gdm_input_french-noblue-20230809.json
new file mode 100644
index 00000000..3327969d
--- /dev/null
+++ b/needles/gnome/french/login_gdm_input_french-noblue-20230809.json
@@ -0,0 +1,22 @@
+{
+  "area": [
+    {
+      "type": "match",
+      "height": 44,
+      "xpos": 385,
+      "ypos": 458,
+      "width": 84
+    }
+  ],
+  "properties": [
+    {
+      "name": "workaround",
+      "value": "the text box should be surrounded with a blue line to indicate it's active: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6880"
+    }
+  ],
+  "tags": [
+    "DESKTOP-gnome",
+    "LANGUAGE-french",
+    "graphical_login_input"
+  ]
+}
diff --git a/needles/gnome/login_gdm_input_french-20230809_workaround.png b/needles/gnome/french/login_gdm_input_french-noblue-20230809.png
similarity index 100%
rename from needles/gnome/login_gdm_input_french-20230809_workaround.png
rename to needles/gnome/french/login_gdm_input_french-noblue-20230809.png
diff --git a/needles/gnome/japanese/login_gdm_input_japanese-noblue-20230809.json b/needles/gnome/japanese/login_gdm_input_japanese-noblue-20230809.json
new file mode 100644
index 00000000..9f57b027
--- /dev/null
+++ b/needles/gnome/japanese/login_gdm_input_japanese-noblue-20230809.json
@@ -0,0 +1,22 @@
+{
+  "area": [
+    {
+      "width": 73,
+      "ypos": 455,
+      "height": 49,
+      "xpos": 385,
+      "type": "match"
+    }
+  ],
+  "properties": [
+    {
+      "name": "workaround",
+      "value": "the text box should be surrounded with a blue line to indicate it's active: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6880"
+    }
+  ],
+  "tags": [
+    "DESKTOP-gnome",
+    "LANGUAGE-japanese",
+    "graphical_login_input"
+  ]
+}
diff --git a/needles/gnome/login_gdm_input_japanese-20230809_workaround.png b/needles/gnome/japanese/login_gdm_input_japanese-noblue-20230809.png
similarity index 100%
rename from needles/gnome/login_gdm_input_japanese-20230809_workaround.png
rename to needles/gnome/japanese/login_gdm_input_japanese-noblue-20230809.png
diff --git a/needles/gnome/login_gdm_input-noblue-20230808.json b/needles/gnome/login_gdm_input-noblue-20230808.json
index 1be2fb7c..6909c48a 100644
--- a/needles/gnome/login_gdm_input-noblue-20230808.json
+++ b/needles/gnome/login_gdm_input-noblue-20230808.json
@@ -11,7 +11,7 @@
   "properties": [
     {
       "name": "workaround",
-      "value": "the text box should be surrounded with a blue line to indicate it's active, this broke in 45-beta"
+      "value": "the text box should be surrounded with a blue line to indicate it's active: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6880"
     }
   ],
   "tags": [
@@ -19,4 +19,4 @@
     "DESKTOP-gnome",
     "LANGUAGE-english"
   ]
-}
\ No newline at end of file
+}
diff --git a/needles/gnome/login_gdm_input_arabic-20230809_workaround.json b/needles/gnome/login_gdm_input_arabic-20230809_workaround.json
deleted file mode 100644
index 2215cab6..00000000
--- a/needles/gnome/login_gdm_input_arabic-20230809_workaround.json
+++ /dev/null
@@ -1,17 +0,0 @@
-{
-  "area": [
-    {
-      "type": "match",
-      "xpos": 588,
-      "height": 59,
-      "ypos": 451,
-      "width": 58
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "DESKTOP-gnome",
-    "LANGUAGE-arabic",
-    "graphical_login_input"
-  ]
-}
\ No newline at end of file
diff --git a/needles/gnome/login_gdm_input_french-20230809_workaround.json b/needles/gnome/login_gdm_input_french-20230809_workaround.json
deleted file mode 100644
index 19b85d34..00000000
--- a/needles/gnome/login_gdm_input_french-20230809_workaround.json
+++ /dev/null
@@ -1,17 +0,0 @@
-{
-  "area": [
-    {
-      "type": "match",
-      "height": 44,
-      "xpos": 385,
-      "ypos": 458,
-      "width": 84
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "DESKTOP-gnome",
-    "LANGUAGE-french",
-    "graphical_login_input"
-  ]
-}
\ No newline at end of file
diff --git a/needles/gnome/login_gdm_input_japanese-20230809_workaround.json b/needles/gnome/login_gdm_input_japanese-20230809_workaround.json
deleted file mode 100644
index 81413907..00000000
--- a/needles/gnome/login_gdm_input_japanese-20230809_workaround.json
+++ /dev/null
@@ -1,17 +0,0 @@
-{
-  "area": [
-    {
-      "width": 73,
-      "ypos": 455,
-      "height": 49,
-      "xpos": 385,
-      "type": "match"
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "DESKTOP-gnome",
-    "LANGUAGE-japanese",
-    "graphical_login_input"
-  ]
-}
\ No newline at end of file
diff --git a/needles/gnome/login_gdm_input_russian-20230809_workaround.json b/needles/gnome/login_gdm_input_russian-20230809_workaround.json
deleted file mode 100644
index f0e6acba..00000000
--- a/needles/gnome/login_gdm_input_russian-20230809_workaround.json
+++ /dev/null
@@ -1,17 +0,0 @@
-{
-  "area": [
-    {
-      "ypos": 457,
-      "width": 49,
-      "type": "match",
-      "height": 44,
-      "xpos": 384
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "DESKTOP-gnome",
-    "LANGUAGE-russian",
-    "graphical_login_input"
-  ]
-}
\ No newline at end of file
diff --git a/needles/gnome/login_gdm_input_turkish-20230809_workaround.json b/needles/gnome/login_gdm_input_turkish-20230809_workaround.json
deleted file mode 100644
index 51840019..00000000
--- a/needles/gnome/login_gdm_input_turkish-20230809_workaround.json
+++ /dev/null
@@ -1,17 +0,0 @@
-{
-  "area": [
-    {
-      "type": "match",
-      "height": 46,
-      "xpos": 387,
-      "ypos": 457,
-      "width": 41
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "DESKTOP-gnome",
-    "LANGUAGE-turkish",
-    "graphical_login_input"
-  ]
-}
\ No newline at end of file
diff --git a/needles/gnome/russian/login_gdm_input_russian-noblue-20230809.json b/needles/gnome/russian/login_gdm_input_russian-noblue-20230809.json
new file mode 100644
index 00000000..62ae3088
--- /dev/null
+++ b/needles/gnome/russian/login_gdm_input_russian-noblue-20230809.json
@@ -0,0 +1,22 @@
+{
+  "area": [
+    {
+      "ypos": 457,
+      "width": 49,
+      "type": "match",
+      "height": 44,
+      "xpos": 384
+    }
+  ],
+  "properties": [
+    {
+      "name": "workaround",
+      "value": "the text box should be surrounded with a blue line to indicate it's active: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6880"
+    }
+  ],
+  "tags": [
+    "DESKTOP-gnome",
+    "LANGUAGE-russian",
+    "graphical_login_input"
+  ]
+}
diff --git a/needles/gnome/login_gdm_input_russian-20230809_workaround.png b/needles/gnome/russian/login_gdm_input_russian-noblue-20230809.png
similarity index 100%
rename from needles/gnome/login_gdm_input_russian-20230809_workaround.png
rename to needles/gnome/russian/login_gdm_input_russian-noblue-20230809.png
diff --git a/needles/gnome/turkish/login_gdm_input_turkish-noblue-20230809.json b/needles/gnome/turkish/login_gdm_input_turkish-noblue-20230809.json
new file mode 100644
index 00000000..ebe8a6d0
--- /dev/null
+++ b/needles/gnome/turkish/login_gdm_input_turkish-noblue-20230809.json
@@ -0,0 +1,22 @@
+{
+  "area": [
+    {
+      "type": "match",
+      "height": 46,
+      "xpos": 387,
+      "ypos": 457,
+      "width": 41
+    }
+  ],
+  "properties": [
+    {
+      "name": "workaround",
+      "value": "the text box should be surrounded with a blue line to indicate it's active: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6880"
+    }
+  ],
+  "tags": [
+    "DESKTOP-gnome",
+    "LANGUAGE-turkish",
+    "graphical_login_input"
+  ]
+}
diff --git a/needles/gnome/login_gdm_input_turkish-20230809_workaround.png b/needles/gnome/turkish/login_gdm_input_turkish-noblue-20230809.png
similarity index 100%
rename from needles/gnome/login_gdm_input_turkish-20230809_workaround.png
rename to needles/gnome/turkish/login_gdm_input_turkish-noblue-20230809.png