From 92dbd802e8a9fb85abcce37e248235e9aead5327 Mon Sep 17 00:00:00 2001 From: Adam Williamson Date: Wed, 2 Aug 2023 09:10:55 +0100 Subject: [PATCH] koji-rawhide: set skip_if_unavailable=1 for now due to 404 issues We're seeing a lot of tests fail on 404s when trying to access the koji-rawhide repo (the repo for the Rawhide build tag, which we use to get packages tagged since the last compose. nirik is trying to figure this out from the server end, but for now at least, let's mark the repo as skip_if_unavailable. This should mean that if we hit a 404, the test will continue, it just won't have access to the packages from that repo. Occasionally this will cause a problem - a false failure or false pass - but this still seems better than every test that hits it failing. The false pass case is the most concerning, but I would hope in that case some other tests from the same update would fail, making it not an issue. Signed-off-by: Adam Williamson --- lib/utils.pm | 2 +- tests/_live_build.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/utils.pm b/lib/utils.pm index 0c48ef38..61b5695e 100644 --- a/lib/utils.pm +++ b/lib/utils.pm @@ -582,7 +582,7 @@ sub _repo_setup_updates { # use the buildroot repo on Rawhide: see e.g. # https://pagure.io/fedora-ci/general/issue/376 for why if ($version eq get_var("RAWREL") && get_var("TEST") ne "support_server") { - assert_script_run 'printf "[koji-rawhide]\nname=koji-rawhide\nbaseurl=https://kojipkgs.fedoraproject.org/repos/f' . $version . '-build/latest/' . $arch . '/\ncost=2000\nenabled=1\nmetadata_expire=30\ngpgcheck=0\n" > /etc/yum.repos.d/koji-rawhide.repo'; + assert_script_run 'printf "[koji-rawhide]\nname=koji-rawhide\nbaseurl=https://kojipkgs.fedoraproject.org/repos/f' . $version . '-build/latest/' . $arch . '/\ncost=2000\nenabled=1\nmetadata_expire=30\ngpgcheck=0\nskip_if_unavailable=1\n" > /etc/yum.repos.d/koji-rawhide.repo'; } # set up the workaround repo setup_workaround_repo; diff --git a/tests/_live_build.pm b/tests/_live_build.pm index 7669efab..38e45a47 100644 --- a/tests/_live_build.pm +++ b/tests/_live_build.pm @@ -55,7 +55,7 @@ sub run { $repos .= '\n[workarounds]\nname=Workarounds repo\nbaseurl=file:///mnt/workaroundsiso/workarounds_repo\nenabled=1\nmetadata_expire=3600\ngpgcheck=0\n' if (get_var("ISO_3")); # also the buildroot repo, for Rawhide if ($version eq $rawrel) { - $repos .= '\n[koji-rawhide]\nname=Buildroot repo\nbaseurl=https://kojipkgs.fedoraproject.org/repos/f' . $version . '-build/latest/\$basearch/\nenabled=1\nmetadata_expire=3600\ngpgcheck=0\n'; + $repos .= '\n[koji-rawhide]\nname=Buildroot repo\nbaseurl=https://kojipkgs.fedoraproject.org/repos/f' . $version . '-build/latest/\$basearch/\nenabled=1\nmetadata_expire=3600\ngpgcheck=0\nskip_if_unavailable=1\n'; } $repos .= '\"\"\"'; assert_script_run 'printf "' . $repos . '" >> /etc/mock/openqa.cfg';