From 691e82b1f99d4c5d93049e657fe25d3375503f28 Mon Sep 17 00:00:00 2001 From: Adam Williamson Date: Mon, 22 Apr 2024 17:04:52 -0700 Subject: [PATCH] Drop workaround for RHBZ #1943943 This whole complicated loop looks like it's no longer needed for current KDE. It seems like we always refresh, then we hit "Update All", and from there we go straight to "Restart Now". Clicking the button always seems to work, we never seem to need to click "Refresh" again. So, let's drop it and simply expect to see and click Restart Now. Signed-off-by: Adam Williamson --- tests/desktop_update_graphical.pm | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/tests/desktop_update_graphical.pm b/tests/desktop_update_graphical.pm index ba60c0bf..99c16dfb 100644 --- a/tests/desktop_update_graphical.pm +++ b/tests/desktop_update_graphical.pm @@ -131,21 +131,6 @@ sub run { boot_to_login_screen; } elsif ($desktop eq 'kde') { - # KDE does offline updates now, we have to trigger the reboot - # FIXME: also sometimes the update apply button just doesn't - # work, so keep clicking till it does: - # https://bugzilla.redhat.com/show_bug.cgi?id=1943943 - for my $n (1 .. 10) { - sleep 2; - assert_screen ['kde_offline_update_reboot', 'desktop_package_tool_update_apply']; - # break out if we reached the reboot button - last if (match_has_tag 'kde_offline_update_reboot'); - # otherwise, try refresh and apply or reboot - assert_and_click 'desktop_package_tool_update_refresh'; - assert_screen ['kde_offline_update_reboot', 'desktop_package_tool_update_apply']; - last if (match_has_tag 'kde_offline_update_reboot'); - click_lastmatch; - } assert_and_click 'kde_offline_update_reboot'; boot_to_login_screen; }