From 669df1456687e61515f9214ca573aa05eb591b3d Mon Sep 17 00:00:00 2001
From: Adam Williamson <awilliam@redhat.com>
Date: Wed, 21 Mar 2018 15:43:40 -0700
Subject: [PATCH] FreeIPA: handle unexpected auto-login to webUI

There are cases where we get logged back into the FreeIPA web UI
automatically by a stale kerberos ticket or something. If we're
logged in as the *right* user, let's just treat this as a soft
failure and continue with the test.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
---
 lib/freeipa.pm | 26 ++++++++++++++++++--------
 1 file changed, 18 insertions(+), 8 deletions(-)

diff --git a/lib/freeipa.pm b/lib/freeipa.pm
index 7eeba980..70e6a175 100644
--- a/lib/freeipa.pm
+++ b/lib/freeipa.pm
@@ -34,17 +34,27 @@ sub add_user {
 # it's at a console ready to start Firefox.
 sub start_webui {
     my ($user, $password) = @_;
+    # if we logged in as 'admin' we should land on the admin 'Active
+    # users' screen, otherwise we should land on the user's own page
+    my $user_screen = "freeipa_webui_user";
+    $user_screen = "freeipa_webui_users" if ($user eq 'admin');
+
     # https://bugzilla.redhat.com/show_bug.cgi?id=1439429
     assert_script_run "sed -i -e 's,enable_xauth=1,enable_xauth=0,g' /usr/bin/startx";
     type_string "startx /usr/bin/firefox -width 1024 -height 768 https://ipa001.domain.local\n";
     wait_still_screen 5;
-    assert_screen "freeipa_webui_login";
-    type_safely $user;
-    wait_screen_change { send_key "tab"; };
-    type_safely $password;
-    send_key "ret";
-    # if we logged in as 'admin' we should land on the admin 'Active
-    # users' screen, otherwise we should land on the user's own page
-    $user eq 'admin' ? assert_screen "freeipa_webui_users" : assert_screen "freeipa_webui_user";
+    # softfail on kerberos ticket bugs meaning we get auto-logged in
+    # as the requested user when we don't expect to be
+    if (check_screen $user_screen, 5) {
+        record_soft_failure "already logged in to web UI";
+    }
+    else {
+        assert_screen "freeipa_webui_login", 5;
+        type_safely $user;
+        wait_screen_change { send_key "tab"; };
+        type_safely $password;
+        send_key "ret";
+        assert_screen $user_screen;
+    }
     wait_still_screen 3;
 }