explicitly check for DNF "system is not ready for upgrade"

Summary:
Instead of sitting there waiting 6000 seconds twice, when DNF
explicitly tells us it failed, just die.

This is why we haven't been getting proper compose check reports
lately; the upgrade tests are failing, waiting 6000 seconds to
time out, then being cloned and tried again, waiting another 6000
seconds. This is just barely going beyond check-compose's 8 hour
wait limit, as it's some time before the upgrade tests even get
started (they're low in the priority list). We're still going to
have that problem if the tests fail any other way, but this at
least catches that case.

Test Plan:
Run the upgrade tests and see that they fail quicker
(assuming the dependency problems they're dying on aren't fixed).
Maybe also do a 22-23 upgrade test and check it still succeeds
properly.

Reviewers: jskladan, garretraziel

Reviewed By: garretraziel

Subscribers: tflink

Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D650

needles/upgrade_fail.json

@@ -0,0 +1,16 @@
+{
+    "area": [
+        {
+            "height": 15,
+            "type": "match",
+            "width": 305,
+            "xpos": 0,
+            "ypos": 735
+        }
+    ],
+  "tags": [
+    "upgrade_fail",
+    "ENV-DISTRI-fedora",
+    "ENV-FLAVOR-server"
+  ]
+}

tests/upgrade_run.pm

@@ -23,6 +23,7 @@ sub run {
     upload_logs "/var/log/dnf.rpm.log";
 
     script_run "dnf system-upgrade reboot";
+    die "DNF reported failure" if (check_screen "upgrade_fail");
 
     # now offline upgrading starts. user doesn't have to do anything, just wait untill
     # system reboots and login screen is shown