From 25ed1e236d8d0a336d13b0a625398b7d748d541f Mon Sep 17 00:00:00 2001 From: Adam Williamson Date: Thu, 13 Oct 2022 10:35:38 +0200 Subject: [PATCH] weather: settle before snapshotting in aaa_setup We've seen some failures of the weather test at the start of weather_report, where the test expects to be at the hourly view, and instead it seems to be at a sort of broken state: https://openqa.fedoraproject.org/tests/1505080#step/weather_report/3 I'm guessing this may be because currently aaa_setup clicks the city name then is immediately complete, so it will immediately snapshot. I guess this can result in things being stuck in a kind of intermediate state on snapshot restore. So, to try and avoid this, let's assert that we reach the hourly view after clicking the city name, then wait_still_screen for a few seconds to make sure things are settled down, before we complete and snapshot. Signed-off-by: Adam Williamson --- tests/applications/weather/aaa_setup.pm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/applications/weather/aaa_setup.pm b/tests/applications/weather/aaa_setup.pm index f561a63a..a27fac46 100644 --- a/tests/applications/weather/aaa_setup.pm +++ b/tests/applications/weather/aaa_setup.pm @@ -29,6 +29,10 @@ sub run { } type_very_safely("Brno"); assert_and_click("weather_select_city"); + # check we wind up on the hourly view, then let things settle + # before snapshotting + assert_screen("weather_report_hourly"); + wait_still_screen 3; } sub test_flags {