From 20ef09d4f4d67c30fbd3af8bfd9a51c47acda17d Mon Sep 17 00:00:00 2001 From: Adam Williamson Date: Wed, 12 Oct 2022 10:21:34 +0200 Subject: [PATCH] Protect against long load times in Cockpit We seem to be hitting very long loads on the Services and Logs pages of Cockpit in recent Rawhide testing especially. As I don't have time to deeply debug this at the moment, let's just give it longer (but make it a soft failure when it takes longer than expected). Signed-off-by: Adam Williamson --- tests/server_cockpit_basic.pm | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/tests/server_cockpit_basic.pm b/tests/server_cockpit_basic.pm index 225e0d39..b2072635 100644 --- a/tests/server_cockpit_basic.pm +++ b/tests/server_cockpit_basic.pm @@ -29,12 +29,21 @@ sub run { record_soft_failure "Log refresh took a long time"; } # check we get to the appropriate detail screen - assert_screen "cockpit_logs_detail"; + unless (check_screen "cockpit_logs_detail", 30) { + assert_screen "cockpit_logs_detail", 60; + record_soft_failure "Accessing log entry took a long time"; + } # go to the services screen assert_and_click "cockpit_services"; wait_still_screen(timeout => 90, stilltime => 5); # click on an entry - assert_and_click "cockpit_services_entry"; + if (check_screen "cockpit_services_entry") { + click_lastmatch; + } + else { + assert_and_click "cockpit_services_entry"; + record_soft_failure "Loading services screen took a long time"; + } # check we get to the appropriate detail screen...but this click # often gets lost for some reason, so retry it once assert_and_click "cockpit_services_entry" unless (check_screen "cockpit_services_detail", 10);