make 'first partition' needles more reliable / universal

Summary:
The 'reclaim_space_first_partition' needles aren't very good.
Using the area with the filesystem means we need to duplicate
the needle for NTFS, and the needles in fact also match the
*second* partition in most cases, sometimes causing the tests
to delete the second partition instead of the first and fail.
This design should work better: a single needle should match
all filesystems, and by including some of the highlighted top
row in the match, we should never match on the second row.
Including 'da' in the needle makes this really 'first disk,
first partition', but that's all the cases we currently use
it for. We don't really need this needle to work hard to make
sure we're on the right screen, as the subsequent needles
(which match buttons that only exist on this screen) do that
job fine.

We drop some needles that should no longer be necessary: F23
should now be using the cantarell17 version of the needle,
and F24 the freetype262 needle. We don't run installer tests
for any other release.

We could tweak second_partition needle to match, but nothing
is actually using it anyway.

Test Plan:
Do a full test and run and make sure the tests
which use this needle work, and always select the correct
partition.

Reviewers: jskladan, garretraziel

Reviewed By: garretraziel

Subscribers: tflink

Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D681
This commit is contained in:
Adam Williamson 2015-12-07 09:41:49 -08:00
parent 2e42e6e478
commit 163a8fd94a
12 changed files with 32 additions and 116 deletions

View File

@ -1,17 +1,17 @@
{
"properties": [],
"area": [
{
"ypos": 263,
"height": 24,
"type": "match",
"xpos": 15,
"width": 70
}
],
"tags": [
"anaconda_install_destination_reclaim_space_first_partition",
"ENV-DISTRI-fedora",
"ENV-FLAVOR-server"
]
{
"area": [
{
"height": 39,
"type": "match",
"width": 25,
"xpos": 150,
"ypos": 249
}
],
"properties": [],
"tags": [
"anaconda_install_destination_reclaim_space_first_partition",
"ENV-DISTRI-fedora",
"ENV-FLAVOR-server"
]
}

View File

@ -1,17 +1,17 @@
{
"tags": [
"anaconda_install_destination_reclaim_space_first_partition",
"ENV-DISTRI-fedora",
"ENV-FLAVOR-server"
],
"properties": [],
"area": [
{
"height": 24,
"width": 70,
"ypos": 154,
"xpos": 15,
"type": "match"
}
]
{
"area": [
{
"height": 39,
"type": "match",
"width": 25,
"xpos": 150,
"ypos": 139
}
],
"properties": [],
"tags": [
"anaconda_install_destination_reclaim_space_first_partition",
"ENV-DISTRI-fedora",
"ENV-FLAVOR-server"
]
}

View File

@ -1,16 +0,0 @@
{
"area": [
{
"xpos": 15,
"ypos": 278,
"width": 70,
"height": 24,
"type": "match"
}
],
"tags": [
"anaconda_install_destination_reclaim_space_first_partition",
"ENV-DISTRI-fedora",
"ENV-FLAVOR-server"
]
}

Binary file not shown.

Before

Width:  |  Height:  |  Size: 90 KiB

View File

@ -1,17 +0,0 @@
{
"tags": [
"anaconda_install_destination_reclaim_space_first_partition",
"ENV-DISTRI-fedora",
"ENV-FLAVOR-universal"
],
"area": [
{
"ypos": 263,
"height": 23,
"type": "match",
"xpos": 15,
"width": 70
}
],
"properties": []
}

Binary file not shown.

Before

Width:  |  Height:  |  Size: 68 KiB

View File

@ -1,17 +0,0 @@
{
"tags": [
"anaconda_install_destination_reclaim_space_first_partition",
"ENV-DISTRI-fedora",
"ENV-FLAVOR-universal"
],
"area": [
{
"type": "match",
"ypos": 263,
"height": 23,
"width": 70,
"xpos": 15
}
],
"properties": []
}

Binary file not shown.

Before

Width:  |  Height:  |  Size: 68 KiB

View File

@ -1,17 +0,0 @@
{
"area": [
{
"xpos": 15,
"width": 70,
"ypos": 154,
"height": 23,
"type": "match"
}
],
"properties": [],
"tags": [
"anaconda_install_destination_reclaim_space_first_partition",
"ENV-DISTRI-fedora",
"ENV-FLAVOR-universal"
]
}

Binary file not shown.

Before

Width:  |  Height:  |  Size: 43 KiB

View File

@ -1,17 +0,0 @@
{
"area": [
{
"width": 70,
"type": "match",
"ypos": 278,
"xpos": 15,
"height": 24
}
],
"tags": [
"anaconda_install_destination_reclaim_space_first_partition",
"ENV-DISTRI-fedora",
"ENV-FLAVOR-universal"
],
"properties": []
}

Binary file not shown.

Before

Width:  |  Height:  |  Size: 71 KiB