From 039f3c265e88f0887ee2fefe30b7bce4ba03b2f2 Mon Sep 17 00:00:00 2001 From: Adam Williamson Date: Fri, 28 Apr 2023 15:51:47 -0700 Subject: [PATCH] Drop a useless check_screen (needle missing) This check_screen always fails, because the needle doesn't exist and never has - the commit that added the check_screen didn't add a matching needle. In every run of the test I've checked from the last two months, the initially-selected filesystem is always xfs anyway. Let's just drop the check_screen conditional and always expect we have to set the correct filesystem. Signed-off-by: Adam Williamson --- tests/disk_custom_blivet_btrfs_preserve_home.pm | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/disk_custom_blivet_btrfs_preserve_home.pm b/tests/disk_custom_blivet_btrfs_preserve_home.pm index d777247e..1f145af9 100644 --- a/tests/disk_custom_blivet_btrfs_preserve_home.pm +++ b/tests/disk_custom_blivet_btrfs_preserve_home.pm @@ -23,10 +23,8 @@ sub run { assert_and_click "anaconda_blivet_part_edit"; # Select the Format option assert_and_click "anaconda_blivet_part_format"; - if (not(check_screen "anaconda_blivet_part_fs_efi_filesystem_selected", 30)) { - assert_and_click "anaconda_blivet_part_fs_select"; - assert_and_click "anaconda_blivet_part_fs_efi_filesystem"; - } + assert_and_click "anaconda_blivet_part_fs_select"; + assert_and_click "anaconda_blivet_part_fs_efi_filesystem"; # Select the mountpoint field send_key_until_needlematch("anaconda_blivet_mountpoint_selected", "tab", 3, 5);