2017-01-18 07:15:44 +00:00
|
|
|
package utils;
|
2016-09-07 08:34:54 +00:00
|
|
|
|
|
|
|
use strict;
|
|
|
|
|
|
|
|
use base 'Exporter';
|
|
|
|
use Exporter;
|
|
|
|
|
2017-01-18 07:15:44 +00:00
|
|
|
use lockapi;
|
2016-09-07 08:34:54 +00:00
|
|
|
use testapi;
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
our @EXPORT = qw/run_with_error_check type_safely type_very_safely desktop_vt boot_to_login_screen console_login console_switch_layout desktop_switch_layout console_loadkeys_us do_bootloader boot_decrypt check_release menu_launch_type repo_setup setup_workaround_repo disable_updates_repos cleanup_workaround_repo console_initial_setup handle_welcome_screen gnome_initial_setup anaconda_create_user check_desktop download_modularity_tests quit_firefox advisory_get_installed_packages advisory_check_nonmatching_packages start_with_launcher quit_with_shortcut disable_firefox_studies select_rescue_mode copy_devcdrom_as_isofile get_release_number check_left_bar check_top_bar check_prerelease check_version spell_version_number _assert_and_click is_branched rec_log repos_mirrorlist register_application get_registered_applications solidify_wallpaper check_and_install_git download_testdata make_serial_writable set_update_notification_timestamp/;
|
2023-10-02 10:01:33 +00:00
|
|
|
|
2019-09-19 14:03:50 +00:00
|
|
|
|
|
|
|
# We introduce this global variable to hold the list of applications that have
|
|
|
|
# registered during the apps_startstop_test when they have sucessfully run.
|
|
|
|
our @application_list;
|
2016-09-07 08:34:54 +00:00
|
|
|
|
|
|
|
sub run_with_error_check {
|
|
|
|
my ($func, $error_screen) = @_;
|
2019-11-06 12:55:27 +00:00
|
|
|
# Check screen does not work for serial console, so we need to use
|
|
|
|
# different checking mechanism for it.
|
|
|
|
if (testapi::is_serial_terminal) {
|
|
|
|
# by using 'unless' and 'expect_not_found=>1' here we avoid
|
|
|
|
# the web UI showing each failure to see the error message as
|
|
|
|
# a 'failed match'
|
2022-07-28 20:32:57 +00:00
|
|
|
die "Error screen appeared" unless (wait_serial($error_screen, timeout => 5, expect_not_found => 1));
|
2019-11-06 12:55:27 +00:00
|
|
|
$func->();
|
2022-07-28 20:32:57 +00:00
|
|
|
die "Error screen appeared" unless (wait_serial($error_screen, timeout => 5, expect_not_found => 1));
|
2019-11-06 12:55:27 +00:00
|
|
|
}
|
|
|
|
else {
|
|
|
|
die "Error screen appeared" if (check_screen $error_screen, 5);
|
|
|
|
$func->();
|
|
|
|
die "Error screen appeared" if (check_screen $error_screen, 5);
|
|
|
|
}
|
2016-09-07 08:34:54 +00:00
|
|
|
}
|
2016-09-12 17:24:30 +00:00
|
|
|
|
|
|
|
# high-level 'type this string quite safely but reasonably fast'
|
|
|
|
# function whose specific implementation may vary
|
|
|
|
sub type_safely {
|
|
|
|
my $string = shift;
|
2016-10-20 16:12:55 +00:00
|
|
|
type_string($string, wait_screen_change => 3, max_interval => 20);
|
2022-03-16 18:14:50 +00:00
|
|
|
# similarity level 38 as there will commonly be a flashing
|
|
|
|
# cursor and the default level (47) is too tight
|
2022-07-28 20:32:57 +00:00
|
|
|
wait_still_screen(stilltime => 2, similarity_level => 38);
|
2016-09-12 17:24:30 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
# high-level 'type this string extremely safely and rather slow'
|
|
|
|
# function whose specific implementation may vary
|
|
|
|
sub type_very_safely {
|
|
|
|
my $string = shift;
|
2016-10-20 16:12:55 +00:00
|
|
|
type_string($string, wait_screen_change => 1, max_interval => 1);
|
2022-03-14 23:32:29 +00:00
|
|
|
# similarity level 38 as there will commonly be a flashing
|
|
|
|
# cursor and the default level (47) is too tight
|
2022-07-28 20:32:57 +00:00
|
|
|
wait_still_screen(stilltime => 5, similarity_level => 38);
|
2016-09-12 17:24:30 +00:00
|
|
|
}
|
2016-09-24 19:42:39 +00:00
|
|
|
|
2020-07-09 22:54:33 +00:00
|
|
|
sub get_release_number {
|
|
|
|
# return the release number; so usually VERSION, but for Rawhide,
|
|
|
|
# we return RAWREL. This allows us to avoid constantly doing stuff
|
|
|
|
# like `if ($version eq "Rawhide" || $version > 30)`.
|
|
|
|
my $version = get_var("VERSION");
|
|
|
|
my $rawrel = get_var("RAWREL", "Rawhide");
|
|
|
|
return $rawrel if ($version eq "Rawhide");
|
2022-07-28 20:32:57 +00:00
|
|
|
return $version;
|
2020-07-09 22:54:33 +00:00
|
|
|
}
|
|
|
|
|
consolidate login waits, use postinstall not entrypoint for base
Summary:
I started out wanting to fix an issue I noticed today where
graphical upgrade tests were failing because they didn't wait
for the graphical login screen properly; the test was sitting
at the 'full Fedora logo' state of plymouth for a long time,
so the current boot_to_login_screen's wait_still_screen was
triggered by it and the function wound up failing on the
assert_screen, because it was still some time before the real
login screen appeared.
So I tweaked the boot_to_login_screen implementation to work
slightly differently (look for a login screen match, *then* -
if we're dealing with a graphical login - wait_still_screen
to defeat the 'old GPU buffer showing login screen' problem
and assert the login screen again). But while working on it,
I figured we really should consolidate all the various places
that handle the bootloader -> login, we were doing it quite
differently in all sorts of different places. And as part of
that, I converted the base tests to use POSTINSTALL (and thus
go through the shared _wait_login tests) instead of handling
boot themselves. As part of *that*, I tweaked main.pm to not
require all POSTINSTALL tests have the _postinstall suffix on
their names, as it really doesn't make sense, and renamed the
tests.
Test Plan: Run all tests, see if they work.
Reviewers: jskladan, garretraziel
Reviewed By: garretraziel
Subscribers: tflink
Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1015
2016-09-27 18:48:15 +00:00
|
|
|
# Wait for login screen to appear. Handle the annoying GPU buffer
|
|
|
|
# problem where we see a stale copy of the login screen from the
|
|
|
|
# previous boot. Will suffer a ~30 second delay if there's a chance
|
|
|
|
# we're *already at* the expected login screen.
|
|
|
|
sub boot_to_login_screen {
|
|
|
|
my %args = @_;
|
|
|
|
$args{timeout} //= 300;
|
2019-11-06 12:55:27 +00:00
|
|
|
if (testapi::is_serial_terminal) {
|
|
|
|
# For serial console, just wait for the login prompt
|
2022-07-28 20:32:57 +00:00
|
|
|
unless (wait_serial "login:", timeout => $args{timeout}) {
|
2019-11-06 12:55:27 +00:00
|
|
|
die "No login prompt shown on serial console.";
|
|
|
|
}
|
consolidate login waits, use postinstall not entrypoint for base
Summary:
I started out wanting to fix an issue I noticed today where
graphical upgrade tests were failing because they didn't wait
for the graphical login screen properly; the test was sitting
at the 'full Fedora logo' state of plymouth for a long time,
so the current boot_to_login_screen's wait_still_screen was
triggered by it and the function wound up failing on the
assert_screen, because it was still some time before the real
login screen appeared.
So I tweaked the boot_to_login_screen implementation to work
slightly differently (look for a login screen match, *then* -
if we're dealing with a graphical login - wait_still_screen
to defeat the 'old GPU buffer showing login screen' problem
and assert the login screen again). But while working on it,
I figured we really should consolidate all the various places
that handle the bootloader -> login, we were doing it quite
differently in all sorts of different places. And as part of
that, I converted the base tests to use POSTINSTALL (and thus
go through the shared _wait_login tests) instead of handling
boot themselves. As part of *that*, I tweaked main.pm to not
require all POSTINSTALL tests have the _postinstall suffix on
their names, as it really doesn't make sense, and renamed the
tests.
Test Plan: Run all tests, see if they work.
Reviewers: jskladan, garretraziel
Reviewed By: garretraziel
Subscribers: tflink
Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1015
2016-09-27 18:48:15 +00:00
|
|
|
}
|
2019-11-06 12:55:27 +00:00
|
|
|
else {
|
|
|
|
# we may start at a screen that matches one of the needles; if so,
|
|
|
|
# wait till we don't (e.g. when rebooting at end of live install,
|
|
|
|
# we match text_console_login until the console disappears).
|
|
|
|
# The following is true for non-serial console.
|
|
|
|
my $count = 5;
|
|
|
|
while (check_screen("login_screen", 3) && $count > 0) {
|
2022-07-28 20:32:57 +00:00
|
|
|
sleep 5;
|
|
|
|
$count -= 1;
|
|
|
|
}
|
|
|
|
assert_screen "login_screen", $args{timeout};
|
|
|
|
if (match_has_tag "graphical_login") {
|
2023-02-07 18:02:01 +00:00
|
|
|
wait_still_screen(timeout => 30, stilltime => 10, similarity_level => 38);
|
2022-07-28 20:32:57 +00:00
|
|
|
assert_screen "login_screen";
|
2019-11-06 12:55:27 +00:00
|
|
|
}
|
consolidate login waits, use postinstall not entrypoint for base
Summary:
I started out wanting to fix an issue I noticed today where
graphical upgrade tests were failing because they didn't wait
for the graphical login screen properly; the test was sitting
at the 'full Fedora logo' state of plymouth for a long time,
so the current boot_to_login_screen's wait_still_screen was
triggered by it and the function wound up failing on the
assert_screen, because it was still some time before the real
login screen appeared.
So I tweaked the boot_to_login_screen implementation to work
slightly differently (look for a login screen match, *then* -
if we're dealing with a graphical login - wait_still_screen
to defeat the 'old GPU buffer showing login screen' problem
and assert the login screen again). But while working on it,
I figured we really should consolidate all the various places
that handle the bootloader -> login, we were doing it quite
differently in all sorts of different places. And as part of
that, I converted the base tests to use POSTINSTALL (and thus
go through the shared _wait_login tests) instead of handling
boot themselves. As part of *that*, I tweaked main.pm to not
require all POSTINSTALL tests have the _postinstall suffix on
their names, as it really doesn't make sense, and renamed the
tests.
Test Plan: Run all tests, see if they work.
Reviewers: jskladan, garretraziel
Reviewed By: garretraziel
Subscribers: tflink
Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1015
2016-09-27 18:48:15 +00:00
|
|
|
}
|
|
|
|
}
|
redo console_login with multiple matches, move to main_common
Summary:
Since we can match on multiple needles, we can drop the loop
from console_login and instead do it this way, which is simpler
and should work better on ARM (the timeouts will scale and
allow ARM to be slow here). Also move it to main_common as
there's no logical reason for it to be a class method.
Also remove the `check` arg. `check` was only set to 0 by two
tests, _console_shutdown and anacondatest's _post_fail_hook.
For _console_shutdown, I think I just wanted to give it the
best possible chance of succeeding. But we're really not going
to lose anything significant by checking, the only case where
check=>0 would've helped is if the 'good' needle had stopped
matching, and all sorts of other tests will fail in that case.
anacondatest was only using it to save a screenshot of whatever
was on the tty if it didn't reach a root console, which doesn't
seem that useful, and we'll get screenshots from check_screen
and assert_screen anyway.
Test Plan:
Run all tests, check they behave as expected and
none inappropriately fails on console login.
Reviewers: jskladan, garretraziel
Reviewed By: garretraziel
Subscribers: tflink
Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1016
2016-09-30 15:42:45 +00:00
|
|
|
|
|
|
|
# Switch keyboard layouts at a console
|
|
|
|
sub console_switch_layout {
|
|
|
|
# switcher key combo differs between layouts, for console
|
|
|
|
if (get_var("LANGUAGE", "") eq "russian") {
|
|
|
|
send_key "ctrl-shift";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-12-21 16:41:00 +00:00
|
|
|
# switch to 'native' or 'ascii' input method in a graphical desktop
|
|
|
|
# usually switched configs have one mode for inputting ascii-ish
|
|
|
|
# characters (which may be 'us' keyboard layout, or a local layout for
|
|
|
|
# inputting ascii like 'jp') and one mode for inputting native
|
|
|
|
# characters (which may be another keyboard layout, like 'ru', or an
|
|
|
|
# input method for more complex languages)
|
2016-12-16 17:40:29 +00:00
|
|
|
# 'environment' can be a desktop name or 'anaconda' for anaconda
|
|
|
|
# if not set, will use get_var('DESKTOP') or default 'anaconda'
|
|
|
|
sub desktop_switch_layout {
|
|
|
|
my ($layout, $environment) = @_;
|
2016-12-21 16:41:00 +00:00
|
|
|
$layout //= 'ascii';
|
2016-12-16 17:40:29 +00:00
|
|
|
$environment //= get_var("DESKTOP", "anaconda");
|
|
|
|
# if already selected, we're good
|
|
|
|
return if (check_screen "${environment}_layout_${layout}", 3);
|
|
|
|
# otherwise we need to switch
|
2022-07-28 20:32:57 +00:00
|
|
|
my $switcher = "alt-shift"; # anaconda
|
2016-12-16 17:40:29 +00:00
|
|
|
$switcher = "super-spc" if $environment eq 'gnome';
|
|
|
|
# KDE? not used yet
|
2023-04-01 21:55:27 +00:00
|
|
|
# FIXME we use send_key_until_needlematch because sometimes the
|
|
|
|
# switch just doesn't work in gdm:
|
|
|
|
# https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6066#note_1707051
|
|
|
|
send_key_until_needlematch("${environment}_layout_${layout}", $switcher, 3, 3);
|
2016-12-16 17:40:29 +00:00
|
|
|
}
|
|
|
|
|
2017-08-31 18:39:07 +00:00
|
|
|
# this is used at the end of console_login to check if we got a prompt
|
|
|
|
# indicating that we got a bash shell, but sourcing of /etc/bashrc
|
|
|
|
# failed (the prompt looks different in this case). We treat this as
|
|
|
|
# a soft failure.
|
|
|
|
sub _console_login_finish {
|
2019-11-06 12:55:27 +00:00
|
|
|
# The check differs according to the console used.
|
|
|
|
if (testapi::is_serial_terminal) {
|
2022-07-28 20:32:57 +00:00
|
|
|
unless (wait_serial("-bash-.*[#\$]", timeout => 5, expect_not_found => 1)) {
|
2019-11-06 12:55:27 +00:00
|
|
|
record_soft_failure "It looks like profile sourcing failed";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
if (match_has_tag "bash_noprofile") {
|
|
|
|
record_soft_failure "It looks like profile sourcing failed";
|
|
|
|
}
|
2017-08-31 18:39:07 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
redo console_login with multiple matches, move to main_common
Summary:
Since we can match on multiple needles, we can drop the loop
from console_login and instead do it this way, which is simpler
and should work better on ARM (the timeouts will scale and
allow ARM to be slow here). Also move it to main_common as
there's no logical reason for it to be a class method.
Also remove the `check` arg. `check` was only set to 0 by two
tests, _console_shutdown and anacondatest's _post_fail_hook.
For _console_shutdown, I think I just wanted to give it the
best possible chance of succeeding. But we're really not going
to lose anything significant by checking, the only case where
check=>0 would've helped is if the 'good' needle had stopped
matching, and all sorts of other tests will fail in that case.
anacondatest was only using it to save a screenshot of whatever
was on the tty if it didn't reach a root console, which doesn't
seem that useful, and we'll get screenshots from check_screen
and assert_screen anyway.
Test Plan:
Run all tests, check they behave as expected and
none inappropriately fails on console login.
Reviewers: jskladan, garretraziel
Reviewed By: garretraziel
Subscribers: tflink
Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1016
2016-09-30 15:42:45 +00:00
|
|
|
# this subroutine handles logging in as a root/specified user into console
|
|
|
|
# it requires TTY to be already displayed (handled by the root_console()
|
|
|
|
# method of distribution classes)
|
|
|
|
sub console_login {
|
|
|
|
my %args = (
|
|
|
|
user => "root",
|
|
|
|
password => get_var("ROOT_PASSWORD", "weakpassword"),
|
2018-10-06 15:44:34 +00:00
|
|
|
# default is 10 seconds, set below, 0 means 'default'
|
2018-10-06 15:52:08 +00:00
|
|
|
timeout => 0,
|
2022-07-28 20:32:57 +00:00
|
|
|
@_
|
|
|
|
);
|
2018-10-06 15:44:34 +00:00
|
|
|
$args{timeout} ||= 10;
|
redo console_login with multiple matches, move to main_common
Summary:
Since we can match on multiple needles, we can drop the loop
from console_login and instead do it this way, which is simpler
and should work better on ARM (the timeouts will scale and
allow ARM to be slow here). Also move it to main_common as
there's no logical reason for it to be a class method.
Also remove the `check` arg. `check` was only set to 0 by two
tests, _console_shutdown and anacondatest's _post_fail_hook.
For _console_shutdown, I think I just wanted to give it the
best possible chance of succeeding. But we're really not going
to lose anything significant by checking, the only case where
check=>0 would've helped is if the 'good' needle had stopped
matching, and all sorts of other tests will fail in that case.
anacondatest was only using it to save a screenshot of whatever
was on the tty if it didn't reach a root console, which doesn't
seem that useful, and we'll get screenshots from check_screen
and assert_screen anyway.
Test Plan:
Run all tests, check they behave as expected and
none inappropriately fails on console login.
Reviewers: jskladan, garretraziel
Reviewed By: garretraziel
Subscribers: tflink
Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1016
2016-09-30 15:42:45 +00:00
|
|
|
|
2019-11-06 12:55:27 +00:00
|
|
|
# Since we do not test many serial console tests, and we probably
|
|
|
|
# only want to test serial console on a minimal installation only,
|
|
|
|
# let us not do all the magic to handle different console logins
|
|
|
|
# and let us simplify the process.
|
|
|
|
# We will check if we are logged in, and if so, we will log out to
|
|
|
|
# enable a new proper login based on the user variable.
|
|
|
|
if (get_var("SERIAL_CONSOLE")) {
|
|
|
|
# Check for the usual prompt.
|
2022-07-28 20:32:57 +00:00
|
|
|
if (wait_serial("~\][#\$]", timeout => 5, quiet => 1)) {
|
2019-11-06 12:55:27 +00:00
|
|
|
type_string "logout\n";
|
|
|
|
# Wait a bit to let the logout properly finish.
|
|
|
|
sleep 10;
|
|
|
|
}
|
|
|
|
# Do the new login.
|
|
|
|
type_string $args{user};
|
|
|
|
type_string "\n";
|
|
|
|
sleep 2;
|
|
|
|
type_string $args{password};
|
|
|
|
type_string "\n";
|
|
|
|
# Let's perform a simple login test. This is the same as
|
|
|
|
# whoami, but has the advantage of existing in installer env
|
|
|
|
assert_script_run "id -un";
|
2022-07-28 20:32:57 +00:00
|
|
|
unless (wait_serial $args{user}, timeout => 5) {
|
2019-11-06 12:55:27 +00:00
|
|
|
die "Logging onto the serial console has failed.";
|
|
|
|
}
|
redo console_login with multiple matches, move to main_common
Summary:
Since we can match on multiple needles, we can drop the loop
from console_login and instead do it this way, which is simpler
and should work better on ARM (the timeouts will scale and
allow ARM to be slow here). Also move it to main_common as
there's no logical reason for it to be a class method.
Also remove the `check` arg. `check` was only set to 0 by two
tests, _console_shutdown and anacondatest's _post_fail_hook.
For _console_shutdown, I think I just wanted to give it the
best possible chance of succeeding. But we're really not going
to lose anything significant by checking, the only case where
check=>0 would've helped is if the 'good' needle had stopped
matching, and all sorts of other tests will fail in that case.
anacondatest was only using it to save a screenshot of whatever
was on the tty if it didn't reach a root console, which doesn't
seem that useful, and we'll get screenshots from check_screen
and assert_screen anyway.
Test Plan:
Run all tests, check they behave as expected and
none inappropriately fails on console login.
Reviewers: jskladan, garretraziel
Reviewed By: garretraziel
Subscribers: tflink
Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1016
2016-09-30 15:42:45 +00:00
|
|
|
}
|
|
|
|
else {
|
2019-11-06 12:55:27 +00:00
|
|
|
# There's a timing problem when we switch from a logged-in console
|
|
|
|
# to a non-logged in console and immediately call this function;
|
|
|
|
# if the switch lags a bit, this function will match one of the
|
|
|
|
# logged-in needles for the console we switched from, and get out
|
|
|
|
# of sync (e.g. https://openqa.stg.fedoraproject.org/tests/1664 )
|
|
|
|
# To avoid this, we'll sleep a few seconds before starting
|
|
|
|
sleep 4;
|
redo console_login with multiple matches, move to main_common
Summary:
Since we can match on multiple needles, we can drop the loop
from console_login and instead do it this way, which is simpler
and should work better on ARM (the timeouts will scale and
allow ARM to be slow here). Also move it to main_common as
there's no logical reason for it to be a class method.
Also remove the `check` arg. `check` was only set to 0 by two
tests, _console_shutdown and anacondatest's _post_fail_hook.
For _console_shutdown, I think I just wanted to give it the
best possible chance of succeeding. But we're really not going
to lose anything significant by checking, the only case where
check=>0 would've helped is if the 'good' needle had stopped
matching, and all sorts of other tests will fail in that case.
anacondatest was only using it to save a screenshot of whatever
was on the tty if it didn't reach a root console, which doesn't
seem that useful, and we'll get screenshots from check_screen
and assert_screen anyway.
Test Plan:
Run all tests, check they behave as expected and
none inappropriately fails on console login.
Reviewers: jskladan, garretraziel
Reviewed By: garretraziel
Subscribers: tflink
Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1016
2016-09-30 15:42:45 +00:00
|
|
|
|
2019-11-06 12:55:27 +00:00
|
|
|
my $good = "";
|
|
|
|
my $bad = "";
|
|
|
|
if ($args{user} eq "root") {
|
|
|
|
$good = "root_console";
|
|
|
|
$bad = "user_console";
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
$good = "user_console";
|
|
|
|
$bad = "root_console";
|
|
|
|
}
|
redo console_login with multiple matches, move to main_common
Summary:
Since we can match on multiple needles, we can drop the loop
from console_login and instead do it this way, which is simpler
and should work better on ARM (the timeouts will scale and
allow ARM to be slow here). Also move it to main_common as
there's no logical reason for it to be a class method.
Also remove the `check` arg. `check` was only set to 0 by two
tests, _console_shutdown and anacondatest's _post_fail_hook.
For _console_shutdown, I think I just wanted to give it the
best possible chance of succeeding. But we're really not going
to lose anything significant by checking, the only case where
check=>0 would've helped is if the 'good' needle had stopped
matching, and all sorts of other tests will fail in that case.
anacondatest was only using it to save a screenshot of whatever
was on the tty if it didn't reach a root console, which doesn't
seem that useful, and we'll get screenshots from check_screen
and assert_screen anyway.
Test Plan:
Run all tests, check they behave as expected and
none inappropriately fails on console login.
Reviewers: jskladan, garretraziel
Reviewed By: garretraziel
Subscribers: tflink
Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1016
2016-09-30 15:42:45 +00:00
|
|
|
|
2019-11-06 12:55:27 +00:00
|
|
|
if (check_screen $bad, 0) {
|
|
|
|
# we don't want to 'wait' for this as it won't return
|
2023-06-22 09:53:15 +00:00
|
|
|
my $script = "exit";
|
|
|
|
# If Turkish keyboard is installed, the word "exit" is typed
|
|
|
|
# incorrectly because the keyboard layout is different and
|
|
|
|
# openQA sends keys according to the English layout.
|
|
|
|
# Therefore we need to send a string that is
|
|
|
|
# correctly interpreted by the Turkish layout.
|
|
|
|
if (get_var("LANGUAGE") eq "turkish") {
|
|
|
|
$script = "ex't";
|
|
|
|
}
|
|
|
|
script_run $script, 0;
|
2019-11-06 12:55:27 +00:00
|
|
|
sleep 2;
|
|
|
|
}
|
|
|
|
|
|
|
|
assert_screen [$good, 'text_console_login'], $args{timeout};
|
|
|
|
# if we're already logged in, all is good
|
|
|
|
if (match_has_tag $good) {
|
|
|
|
_console_login_finish();
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
# otherwise, we saw the login prompt, type the username
|
|
|
|
type_string("$args{user}\n");
|
2022-06-01 16:04:34 +00:00
|
|
|
assert_screen [$good, 'console_password_required'], 45;
|
2019-11-06 12:55:27 +00:00
|
|
|
# on a live image, just the user name will be enough
|
|
|
|
if (match_has_tag $good) {
|
2019-12-14 17:06:12 +00:00
|
|
|
# clear the screen (so the remaining login prompt text
|
|
|
|
# doesn't confuse subsequent runs of this)
|
|
|
|
my $clearstr = "clear\n";
|
|
|
|
$clearstr = "cleqr\n" if (get_var("LANGUAGE") eq 'french');
|
|
|
|
type_string $clearstr;
|
2019-11-06 12:55:27 +00:00
|
|
|
_console_login_finish();
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
# otherwise, type the password
|
redo console_login with multiple matches, move to main_common
Summary:
Since we can match on multiple needles, we can drop the loop
from console_login and instead do it this way, which is simpler
and should work better on ARM (the timeouts will scale and
allow ARM to be slow here). Also move it to main_common as
there's no logical reason for it to be a class method.
Also remove the `check` arg. `check` was only set to 0 by two
tests, _console_shutdown and anacondatest's _post_fail_hook.
For _console_shutdown, I think I just wanted to give it the
best possible chance of succeeding. But we're really not going
to lose anything significant by checking, the only case where
check=>0 would've helped is if the 'good' needle had stopped
matching, and all sorts of other tests will fail in that case.
anacondatest was only using it to save a screenshot of whatever
was on the tty if it didn't reach a root console, which doesn't
seem that useful, and we'll get screenshots from check_screen
and assert_screen anyway.
Test Plan:
Run all tests, check they behave as expected and
none inappropriately fails on console login.
Reviewers: jskladan, garretraziel
Reviewed By: garretraziel
Subscribers: tflink
Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1016
2016-09-30 15:42:45 +00:00
|
|
|
type_string "$args{password}";
|
2019-11-06 12:55:27 +00:00
|
|
|
if (get_var("SWITCHED_LAYOUT") and $args{user} ne "root") {
|
|
|
|
# see _do_install_and_reboot; when layout is switched
|
|
|
|
# user password is doubled to contain both US and native
|
|
|
|
# chars
|
|
|
|
console_switch_layout;
|
|
|
|
type_string "$args{password}";
|
|
|
|
console_switch_layout;
|
|
|
|
}
|
|
|
|
send_key "ret";
|
|
|
|
# make sure we reached the console
|
|
|
|
unless (check_screen($good, 30)) {
|
|
|
|
# as of 2018-10 we have a bug in sssd which makes this take
|
|
|
|
# unusually long in the FreeIPA tests, let's allow longer,
|
|
|
|
# with a soft fail - RHBZ #1644919
|
|
|
|
record_soft_failure "Console login is taking a long time - #1644919?";
|
|
|
|
my $timeout = 30;
|
|
|
|
# even an extra 30 secs isn't long enough on aarch64...
|
|
|
|
$timeout = 90 if (get_var("ARCH") eq "aarch64");
|
|
|
|
assert_screen($good, $timeout);
|
|
|
|
}
|
2019-12-14 17:06:12 +00:00
|
|
|
# clear the screen (so the remaining login prompt text
|
|
|
|
# doesn't confuse subsequent runs of this)
|
|
|
|
my $clearstr = "clear\n";
|
|
|
|
$clearstr = "cleqr\n" if (get_var("LANGUAGE") eq 'french');
|
|
|
|
type_string $clearstr;
|
2018-10-31 23:33:32 +00:00
|
|
|
}
|
2017-08-31 18:39:07 +00:00
|
|
|
_console_login_finish();
|
redo console_login with multiple matches, move to main_common
Summary:
Since we can match on multiple needles, we can drop the loop
from console_login and instead do it this way, which is simpler
and should work better on ARM (the timeouts will scale and
allow ARM to be slow here). Also move it to main_common as
there's no logical reason for it to be a class method.
Also remove the `check` arg. `check` was only set to 0 by two
tests, _console_shutdown and anacondatest's _post_fail_hook.
For _console_shutdown, I think I just wanted to give it the
best possible chance of succeeding. But we're really not going
to lose anything significant by checking, the only case where
check=>0 would've helped is if the 'good' needle had stopped
matching, and all sorts of other tests will fail in that case.
anacondatest was only using it to save a screenshot of whatever
was on the tty if it didn't reach a root console, which doesn't
seem that useful, and we'll get screenshots from check_screen
and assert_screen anyway.
Test Plan:
Run all tests, check they behave as expected and
none inappropriately fails on console login.
Reviewers: jskladan, garretraziel
Reviewed By: garretraziel
Subscribers: tflink
Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1016
2016-09-30 15:42:45 +00:00
|
|
|
}
|
2016-12-08 20:03:26 +00:00
|
|
|
|
2021-07-22 20:11:56 +00:00
|
|
|
# Figure out what tty the desktop is on, switch to it. Assumes we're
|
|
|
|
# at a root console
|
|
|
|
sub desktop_vt {
|
|
|
|
# use loginctl or ps to find the tty of test's session (loginctl)
|
|
|
|
# or gnome-session, Xwayland or Xorg (ps); as of 2019-09 we often
|
|
|
|
# get tty? for Xwayland and Xorg processes, so using loginctl can
|
|
|
|
# help
|
|
|
|
my $xout;
|
|
|
|
# don't fail test if we don't find any process, just guess tty1.
|
|
|
|
# os-autoinst calls the script with 'bash -e' which causes it to
|
|
|
|
# stop as soon as any command fails, so we use ||: to make the
|
|
|
|
# first grep return 0 even if it matches nothing
|
2022-02-23 00:54:03 +00:00
|
|
|
eval { $xout = script_output ' loginctl | grep test ||:; ps -e | egrep "(startplasma|gnome-session|Xwayland|Xorg)" | grep -o tty[0-9] ||:' };
|
2022-07-28 20:32:57 +00:00
|
|
|
my $tty = 1; # default
|
2021-07-22 20:11:56 +00:00
|
|
|
while ($xout =~ /tty(\d)/g) {
|
2022-07-28 20:32:57 +00:00
|
|
|
$tty = $1; # most recent match is probably best
|
2021-07-22 20:11:56 +00:00
|
|
|
}
|
|
|
|
send_key "ctrl-alt-f${tty}";
|
|
|
|
# work around https://gitlab.gnome.org/GNOME/gnome-software/issues/582
|
|
|
|
# if it happens. As of 2019-05, seeing something similar on KDE too
|
|
|
|
my $desktop = get_var('DESKTOP');
|
|
|
|
my $sfr = 0;
|
|
|
|
my $timeout = 10;
|
|
|
|
my $count = 6;
|
|
|
|
while (check_screen("auth_required", $timeout) && $count > 0) {
|
|
|
|
$count -= 1;
|
|
|
|
unless ($sfr) {
|
|
|
|
record_soft_failure "spurious 'auth required' - https://gitlab.gnome.org/GNOME/gnome-software/issues/582";
|
|
|
|
$sfr = 1;
|
|
|
|
$timeout = 3;
|
|
|
|
}
|
|
|
|
click_lastmatch if ($desktop eq 'kde');
|
|
|
|
if (match_has_tag "auth_required_fprint") {
|
|
|
|
my $user = get_var("USER_LOGIN", "test");
|
|
|
|
send_key "ctrl-alt-f6";
|
|
|
|
console_login;
|
|
|
|
assert_script_run "echo SCAN ${user}-finger-1 | socat STDIN UNIX-CONNECT:/run/fprintd-virt";
|
|
|
|
send_key "ctrl-alt-f${tty}";
|
|
|
|
}
|
2023-09-12 12:54:56 +00:00
|
|
|
elsif (match_has_tag "auth_required_locked") {
|
|
|
|
# When console operation takes a long time, the screen locks
|
|
|
|
# and typing password fails. If that happens, unlock
|
|
|
|
# the screen first and then type password.
|
|
|
|
send_key("ret");
|
|
|
|
wait_still_screen(2);
|
|
|
|
type_very_safely "weakpassword\n";
|
|
|
|
}
|
2021-07-22 20:11:56 +00:00
|
|
|
else {
|
|
|
|
# bit sloppy but in all cases where this is used, this is the
|
|
|
|
# correct password
|
|
|
|
type_very_safely "weakpassword\n";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-12-08 20:03:26 +00:00
|
|
|
# load US layout (from a root console)
|
|
|
|
sub console_loadkeys_us {
|
|
|
|
if (get_var('LANGUAGE') eq 'french') {
|
|
|
|
script_run "loqdkeys us", 0;
|
2018-06-25 17:31:53 +00:00
|
|
|
# might take a few secs
|
|
|
|
sleep 3;
|
2016-12-08 20:03:26 +00:00
|
|
|
}
|
2023-06-22 09:53:15 +00:00
|
|
|
elsif (get_var('LANGUAGE') eq 'japanese' || get_var('LANGUAGE') eq 'turkish') {
|
2018-06-25 16:34:49 +00:00
|
|
|
script_run "loadkeys us", 0;
|
2018-06-25 17:31:53 +00:00
|
|
|
sleep 3;
|
2018-06-25 16:34:49 +00:00
|
|
|
}
|
2016-12-08 20:03:26 +00:00
|
|
|
}
|
2017-01-18 07:15:44 +00:00
|
|
|
|
|
|
|
sub do_bootloader {
|
2023-05-24 21:48:39 +00:00
|
|
|
# Handle bootloader screen.
|
2017-01-18 07:15:44 +00:00
|
|
|
# 'uefi' is whether this is a UEFI install, will get_var UEFI if
|
|
|
|
# not explicitly set. 'postinstall' is whether we're on an
|
|
|
|
# installed system or at the installer (this matters for how many
|
|
|
|
# times we press 'down' to find the kernel line when typing args).
|
|
|
|
# 'args' is a string of extra kernel args, if desired. 'mutex' is
|
|
|
|
# a parallel test mutex lock to wait for before proceeding, if
|
|
|
|
# desired. 'first' is whether to hit 'up' a couple of times to
|
|
|
|
# make sure we boot the first menu entry. 'timeout' is how long to
|
|
|
|
# wait for the bootloader screen.
|
|
|
|
my %args = (
|
|
|
|
postinstall => 0,
|
|
|
|
params => "",
|
|
|
|
mutex => "",
|
|
|
|
first => 1,
|
|
|
|
timeout => 30,
|
|
|
|
uefi => get_var("UEFI"),
|
2016-11-09 08:16:00 +00:00
|
|
|
ofw => get_var("OFW"),
|
2017-01-18 07:15:44 +00:00
|
|
|
@_
|
|
|
|
);
|
2022-06-17 23:58:34 +00:00
|
|
|
my $relnum = get_release_number;
|
2018-08-18 20:50:23 +00:00
|
|
|
# we use the firmware-type specific tags because we want to be
|
|
|
|
# sure we actually did a UEFI boot
|
|
|
|
my $boottag = "bootloader_bios";
|
|
|
|
$boottag = "bootloader_uefi" if ($args{uefi});
|
2019-04-29 16:49:03 +00:00
|
|
|
assert_screen $boottag, $args{timeout};
|
2017-01-18 07:15:44 +00:00
|
|
|
if ($args{mutex}) {
|
|
|
|
# cancel countdown
|
|
|
|
send_key "left";
|
|
|
|
mutex_lock $args{mutex};
|
|
|
|
mutex_unlock $args{mutex};
|
|
|
|
}
|
|
|
|
if ($args{first}) {
|
|
|
|
# press up a couple of times to make sure we're at first entry
|
|
|
|
send_key "up";
|
|
|
|
send_key "up";
|
|
|
|
}
|
|
|
|
if ($args{params}) {
|
2023-05-24 21:48:39 +00:00
|
|
|
send_key "e";
|
|
|
|
# we need to get to the 'linux' line here, and grub does
|
|
|
|
# not have any easy way to do that. Depending on the arch
|
|
|
|
# and the Fedora release, we may have to press 'down' 2
|
|
|
|
# times, or 13, or 12, or some other goddamn number. That
|
|
|
|
# got painful to keep track of, so let's go bottom-up:
|
|
|
|
# press 'down' 50 times to make sure we're at the bottom,
|
|
|
|
# then 'up' twice to reach the 'linux' line. This seems to
|
|
|
|
# work in every permutation I can think of to test.
|
|
|
|
for (1 .. 50) {
|
|
|
|
send_key 'down';
|
2017-01-18 07:15:44 +00:00
|
|
|
}
|
2023-05-24 21:48:39 +00:00
|
|
|
sleep 1;
|
|
|
|
send_key 'up';
|
|
|
|
sleep 1;
|
|
|
|
send_key 'up';
|
|
|
|
send_key "end";
|
2016-11-09 08:16:00 +00:00
|
|
|
# Change type_string by type_safely because keyboard polling
|
|
|
|
# in SLOF usb-xhci driver failed sometimes in powerpc
|
|
|
|
type_safely " $args{params}";
|
2017-01-18 07:15:44 +00:00
|
|
|
}
|
2022-07-28 20:32:57 +00:00
|
|
|
# for debug purpose
|
|
|
|
save_screenshot;
|
2017-01-18 07:15:44 +00:00
|
|
|
# ctrl-X boots from grub editor mode
|
|
|
|
send_key "ctrl-x";
|
|
|
|
# return boots all other cases
|
|
|
|
send_key "ret";
|
|
|
|
}
|
|
|
|
|
|
|
|
sub boot_decrypt {
|
|
|
|
# decrypt storage during boot; arg is timeout (in seconds)
|
|
|
|
my $timeout = shift || 60;
|
2019-04-29 16:49:03 +00:00
|
|
|
assert_screen "boot_enter_passphrase", $timeout;
|
2024-01-04 01:40:31 +00:00
|
|
|
type_very_safely get_var("ENCRYPT_PASSWORD");
|
2017-01-18 07:15:44 +00:00
|
|
|
send_key "ret";
|
|
|
|
}
|
|
|
|
|
|
|
|
sub check_release {
|
|
|
|
# Checks whether the installed release matches a given value. E.g.
|
|
|
|
# `check_release(23)` checks whether the installed system is
|
|
|
|
# Fedora 23. The value can be 'Rawhide' or a Fedora release
|
|
|
|
# number; often you will want to use `get_var('VERSION')`. Expects
|
|
|
|
# a console prompt to be active when it is called.
|
|
|
|
my $release = shift;
|
2018-11-15 20:46:24 +00:00
|
|
|
my $check_command = "grep SUPPORT_PRODUCT_VERSION /etc/os-release";
|
2017-01-18 07:15:44 +00:00
|
|
|
validate_script_output $check_command, sub { $_ =~ m/REDHAT_SUPPORT_PRODUCT_VERSION=$release/ };
|
|
|
|
}
|
|
|
|
|
2019-02-21 18:35:51 +00:00
|
|
|
sub disable_firefox_studies {
|
2022-05-26 16:13:32 +00:00
|
|
|
if (get_var("CANNED")) {
|
2022-08-18 20:50:29 +00:00
|
|
|
# enable rpm-ostree /usr overlay so we can write to /usr
|
|
|
|
assert_script_run "rpm-ostree usroverlay";
|
2022-05-26 16:13:32 +00:00
|
|
|
}
|
2022-11-25 19:39:39 +00:00
|
|
|
# if the first file exists, we've already run, so we can skip
|
|
|
|
# running again
|
|
|
|
return unless (script_run 'test -f $(rpm --eval %_libdir)/firefox/distribution/policies.json');
|
2019-02-21 18:35:51 +00:00
|
|
|
# create a config file that disables Firefox's dumb 'shield
|
|
|
|
# studies' so they don't break tests:
|
|
|
|
# https://bugzilla.mozilla.org/show_bug.cgi?id=1529626
|
2020-05-06 20:24:30 +00:00
|
|
|
# and also disables the password manager stuff so that doesn't
|
|
|
|
# break password entry:
|
|
|
|
# https://bugzilla.mozilla.org/show_bug.cgi?id=1635833
|
2022-05-25 06:49:31 +00:00
|
|
|
# and *also* tries to disable "first run pages", though this
|
|
|
|
# doesn't seem to be working yet:
|
2022-02-07 20:04:55 +00:00
|
|
|
# https://bugzilla.mozilla.org/show_bug.cgi?id=1703903
|
2022-08-18 20:50:29 +00:00
|
|
|
assert_script_run 'mkdir -p $(rpm --eval %_libdir)/firefox/distribution';
|
|
|
|
assert_script_run 'printf \'{"policies": {"DisableFirefoxStudies": true, "OfferToSaveLogins": false, "OverrideFirstRunPage": "", "OverridePostUpdatePage": ""}}\' > $(rpm --eval %_libdir)/firefox/distribution/policies.json';
|
2022-05-25 06:49:31 +00:00
|
|
|
# Now create a preferences override file that disables the
|
|
|
|
# quicksuggest and total cookie protection onboarding screens
|
|
|
|
# see https://support.mozilla.org/en-US/kb/customizing-firefox-using-autoconfig
|
|
|
|
# for why this wacky pair of files with required values is needed
|
|
|
|
# and https://bugzilla.mozilla.org/show_bug.cgi?id=1703903 again
|
|
|
|
# for the actual values
|
2022-08-18 20:50:29 +00:00
|
|
|
assert_script_run 'mkdir -p $(rpm --eval %_libdir)/firefox/browser/defaults/preferences';
|
|
|
|
assert_script_run 'printf "// required comment\npref(\'general.config.filename\', \'openqa-overrides.cfg\');\npref(\'general.config.obscure_value\', 0);\n" > $(rpm --eval %_libdir)/firefox/browser/defaults/preferences/openqa-overrides.js';
|
|
|
|
assert_script_run 'printf "// required comment\npref(\'browser.urlbar.quicksuggest.shouldShowOnboardingDialog\', false);\npref(\'privacy.restrict3rdpartystorage.rollout.enabledByDefault\', false);\n" > $(rpm --eval %_libdir)/firefox/openqa-overrides.cfg';
|
2019-02-21 18:35:51 +00:00
|
|
|
}
|
|
|
|
|
2019-08-20 21:16:23 +00:00
|
|
|
sub repos_mirrorlist {
|
|
|
|
# Use mirrorlist not metalink so we don't hit the timing issue where
|
|
|
|
# the infra repo is updated but mirrormanager metadata checksums
|
|
|
|
# have not been updated, and the infra repo is rejected as its
|
|
|
|
# metadata checksum isn't known to MM
|
|
|
|
my $files = shift;
|
2019-09-20 05:15:21 +00:00
|
|
|
$files ||= "/etc/yum.repos.d/fedora*.repo";
|
2019-08-20 21:16:23 +00:00
|
|
|
assert_script_run "sed -i -e 's,metalink,mirrorlist,g' ${files}";
|
|
|
|
}
|
|
|
|
|
2020-03-06 22:00:00 +00:00
|
|
|
sub cleanup_workaround_repo {
|
|
|
|
# clean up the workaround repo (see next).
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
script_run "rm -rf /mnt/workarounds_repo";
|
2020-03-06 22:00:00 +00:00
|
|
|
script_run "rm -f /etc/yum.repos.d/workarounds.repo";
|
|
|
|
}
|
|
|
|
|
|
|
|
sub setup_workaround_repo {
|
|
|
|
# we periodically need to pull an update from updates-testing in
|
|
|
|
# to fix some bug or other. so, here's an organized way to do it.
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
# we do this here so the workaround packages are in the repo data
|
|
|
|
# but *not* in the package lists generated above (those should
|
|
|
|
# only include packages from the update under test). we'll define
|
|
|
|
# a hash of releases and update IDs. if no workarounds are needed
|
|
|
|
# for any release, the hash can be empty and this will do nothing
|
2020-03-06 22:00:00 +00:00
|
|
|
my $version = shift || get_var("VERSION");
|
|
|
|
cleanup_workaround_repo;
|
|
|
|
# write a repo config file, unless this is the support_server test
|
|
|
|
# and it is running on a different release than the update is for
|
|
|
|
# (in this case we need the repo to exist but do not want to use
|
|
|
|
# it on the actual support_server system)
|
|
|
|
unless (get_var("TEST") eq "support_server" && $version ne get_var("CURRREL")) {
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
assert_script_run 'printf "[workarounds]\nname=Workarounds repo\nbaseurl=file:///mnt/workarounds_repo\nenabled=1\nmetadata_expire=1\ngpgcheck=0" > /etc/yum.repos.d/workarounds.repo';
|
|
|
|
}
|
|
|
|
assert_script_run "mkdir -p /mnt/workarounds_repo";
|
|
|
|
assert_script_run "pushd /mnt/workarounds_repo";
|
|
|
|
my %workarounds = (
|
|
|
|
"38" => [],
|
|
|
|
"39" => [],
|
|
|
|
"40" => [],
|
|
|
|
);
|
|
|
|
# then we'll download each update for our release:
|
|
|
|
my $advortasks = $workarounds{$version};
|
|
|
|
my $pkgs = "createrepo_c";
|
|
|
|
$pkgs .= " bodhi-client koji" if @$advortasks;
|
|
|
|
script_run "dnf -y install $pkgs", 300;
|
|
|
|
foreach my $advortask (@$advortasks) {
|
|
|
|
my $cmd = "bodhi updates download --updateid=$advortask";
|
|
|
|
if ($advortask =~ /^\d+$/) {
|
|
|
|
my $arch = get_var("ARCH");
|
|
|
|
$cmd = "koji download-task --arch=$arch --arch=noarch $advortask";
|
|
|
|
}
|
|
|
|
my $count = 3;
|
|
|
|
my $success = 0;
|
|
|
|
while ($count) {
|
|
|
|
if (script_run $cmd, 600) {
|
|
|
|
$count -= 1;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
$count = 0;
|
|
|
|
$success = 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
die "Workaround update download failed!" unless $success;
|
2020-03-06 22:00:00 +00:00
|
|
|
}
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
# and create repo metadata
|
|
|
|
assert_script_run "createrepo .";
|
|
|
|
assert_script_run "popd";
|
2020-03-06 22:00:00 +00:00
|
|
|
}
|
|
|
|
|
2022-09-15 17:13:56 +00:00
|
|
|
sub disable_updates_repos {
|
|
|
|
# disable updates-testing, or both updates-testing and updates.
|
|
|
|
# factors out similar code in a few different places.
|
|
|
|
my %args = (
|
|
|
|
both => 0,
|
|
|
|
@_
|
|
|
|
);
|
2023-06-20 10:41:52 +00:00
|
|
|
# FIXME as of 2023-06-20 dnf5 doesn't have config-manager plugin yet :(
|
|
|
|
assert_script_run 'sed -i -e "s,enabled=1,enabled=0,g" /etc/yum.repos.d/fedora-updates-testing.repo';
|
|
|
|
assert_script_run 'sed -i -e "s,enabled=1,enabled=0,g" /etc/yum.repos.d/fedora-updates.repo' if ($args{both});
|
2022-09-15 17:13:56 +00:00
|
|
|
unless (script_run 'test -f /etc/yum.repos.d/fedora-updates-testing-modular.repo') {
|
2023-06-20 10:41:52 +00:00
|
|
|
assert_script_run 'sed -i -e "s,enabled=1,enabled=0,g" /etc/yum.repos.d/fedora-updates-testing-modular.repo';
|
|
|
|
assert_script_run 'sed -i -e "s,enabled=1,enabled=0,g" /etc/yum.repos.d/fedora-updates-modular.repo' if ($args{both});
|
2022-09-15 17:13:56 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
Add support for testing updates
Summary:
This adds an entirely new workflow for testing distribution
updates. The `ADVISORY` variable is introduced: when set,
`main.pm` will load an early post-install test that sets up
a repository containing the packages from the specified update,
runs `dnf -y update`, and reboots. A new templates file is
added, `templates-updates`, which adds two new flavors called
`updates-server` and `updates-workstation`, each containing
job templates for appropriate post-install tests. Scheduler is
expected to post `ADVISORY=(update ID) HDD_1=(base image)
FLAVOR=updates-(server|workstation)`, where (base image) is one
of the stable release base disk images produced by `createhdds`
and usually used for upgrade testing. This will result in the
appropriate job templates being loaded.
We rejig postinstall test loading and static network config a
bit so that this works for both the 'compose' and 'updates' test
flows: we have to ensure we bring up networking for the tap
tests before we try and install the updates, but still allow
later adjustment of the configuration. We take advantage of the
openQA feature that was added a few months back to run the same
module multiple times, so the `_advisory_update` module can
reboot after installing the updates and the modules that take
care of bootloader, encryption and login get run again. This
looks slightly wacky in the web UI, though - it doesn't show the
later runs of each module.
We also use the recently added feature to specify `+HDD_1` in
the test suites which use a disk image uploaded by an earlier
post-install test, so the test suite value will take priority
over the value POSTed by the scheduler for those tests, and we
will use the uploaded disk image (and not the clean base image
POSTed by the scheduler) for those tests.
My intent here is to enhance the scheduler, adding a consumer
which listens out for critpath updates, and runs this test flow
for each one, then reports the results to ResultsDB where Bodhi
could query and display them. We could also add a list of other
packages to have one or both sets of update tests run on it, I
guess.
Test Plan:
Try a post something like:
HDD_1=disk_f25_server_3_x86_64.img DISTRI=fedora VERSION=25
FLAVOR=updates-server ARCH=x86_64 BUILD=FEDORA-2017-376ae2b92c
ADVISORY=FEDORA-2017-376ae2b92c CURRREL=25 PREVREL=24
Pick an appropriate `ADVISORY` (ideally, one containing some
packages which might actually be involved in the tests), and
matching `FLAVOR` and `HDD_1`. The appropriate tests should run,
a repo with the update packages should be created and enabled
(and dnf update run), and the tests should work properly. Also
test a regular compose run to make sure I didn't break anything.
Reviewers: jskladan, jsedlak
Reviewed By: jsedlak
Subscribers: tflink
Differential Revision: https://phab.qa.fedoraproject.org/D1143
2017-01-25 16:16:12 +00:00
|
|
|
sub _repo_setup_compose {
|
2020-08-19 21:58:02 +00:00
|
|
|
# doesn't work for IoT or CoreOS, anything that hits this on those
|
|
|
|
# paths must work with default mirror config...
|
|
|
|
my $subvariant = get_var("SUBVARIANT");
|
|
|
|
return if ($subvariant eq "IoT" || $subvariant eq "CoreOS");
|
Add support for testing updates
Summary:
This adds an entirely new workflow for testing distribution
updates. The `ADVISORY` variable is introduced: when set,
`main.pm` will load an early post-install test that sets up
a repository containing the packages from the specified update,
runs `dnf -y update`, and reboots. A new templates file is
added, `templates-updates`, which adds two new flavors called
`updates-server` and `updates-workstation`, each containing
job templates for appropriate post-install tests. Scheduler is
expected to post `ADVISORY=(update ID) HDD_1=(base image)
FLAVOR=updates-(server|workstation)`, where (base image) is one
of the stable release base disk images produced by `createhdds`
and usually used for upgrade testing. This will result in the
appropriate job templates being loaded.
We rejig postinstall test loading and static network config a
bit so that this works for both the 'compose' and 'updates' test
flows: we have to ensure we bring up networking for the tap
tests before we try and install the updates, but still allow
later adjustment of the configuration. We take advantage of the
openQA feature that was added a few months back to run the same
module multiple times, so the `_advisory_update` module can
reboot after installing the updates and the modules that take
care of bootloader, encryption and login get run again. This
looks slightly wacky in the web UI, though - it doesn't show the
later runs of each module.
We also use the recently added feature to specify `+HDD_1` in
the test suites which use a disk image uploaded by an earlier
post-install test, so the test suite value will take priority
over the value POSTed by the scheduler for those tests, and we
will use the uploaded disk image (and not the clean base image
POSTed by the scheduler) for those tests.
My intent here is to enhance the scheduler, adding a consumer
which listens out for critpath updates, and runs this test flow
for each one, then reports the results to ResultsDB where Bodhi
could query and display them. We could also add a list of other
packages to have one or both sets of update tests run on it, I
guess.
Test Plan:
Try a post something like:
HDD_1=disk_f25_server_3_x86_64.img DISTRI=fedora VERSION=25
FLAVOR=updates-server ARCH=x86_64 BUILD=FEDORA-2017-376ae2b92c
ADVISORY=FEDORA-2017-376ae2b92c CURRREL=25 PREVREL=24
Pick an appropriate `ADVISORY` (ideally, one containing some
packages which might actually be involved in the tests), and
matching `FLAVOR` and `HDD_1`. The appropriate tests should run,
a repo with the update packages should be created and enabled
(and dnf update run), and the tests should work properly. Also
test a regular compose run to make sure I didn't break anything.
Reviewers: jskladan, jsedlak
Reviewed By: jsedlak
Subscribers: tflink
Differential Revision: https://phab.qa.fedoraproject.org/D1143
2017-01-25 16:16:12 +00:00
|
|
|
# Appropriate repo setup steps for testing a compose
|
2017-01-18 07:15:44 +00:00
|
|
|
# disable updates-testing and updates and use the compose location
|
|
|
|
# as the target for fedora and rawhide rather than mirrorlist, so
|
|
|
|
# tools see only packages from the compose under test
|
|
|
|
my $location = get_var("LOCATION");
|
Add support for testing updates
Summary:
This adds an entirely new workflow for testing distribution
updates. The `ADVISORY` variable is introduced: when set,
`main.pm` will load an early post-install test that sets up
a repository containing the packages from the specified update,
runs `dnf -y update`, and reboots. A new templates file is
added, `templates-updates`, which adds two new flavors called
`updates-server` and `updates-workstation`, each containing
job templates for appropriate post-install tests. Scheduler is
expected to post `ADVISORY=(update ID) HDD_1=(base image)
FLAVOR=updates-(server|workstation)`, where (base image) is one
of the stable release base disk images produced by `createhdds`
and usually used for upgrade testing. This will result in the
appropriate job templates being loaded.
We rejig postinstall test loading and static network config a
bit so that this works for both the 'compose' and 'updates' test
flows: we have to ensure we bring up networking for the tap
tests before we try and install the updates, but still allow
later adjustment of the configuration. We take advantage of the
openQA feature that was added a few months back to run the same
module multiple times, so the `_advisory_update` module can
reboot after installing the updates and the modules that take
care of bootloader, encryption and login get run again. This
looks slightly wacky in the web UI, though - it doesn't show the
later runs of each module.
We also use the recently added feature to specify `+HDD_1` in
the test suites which use a disk image uploaded by an earlier
post-install test, so the test suite value will take priority
over the value POSTed by the scheduler for those tests, and we
will use the uploaded disk image (and not the clean base image
POSTed by the scheduler) for those tests.
My intent here is to enhance the scheduler, adding a consumer
which listens out for critpath updates, and runs this test flow
for each one, then reports the results to ResultsDB where Bodhi
could query and display them. We could also add a list of other
packages to have one or both sets of update tests run on it, I
guess.
Test Plan:
Try a post something like:
HDD_1=disk_f25_server_3_x86_64.img DISTRI=fedora VERSION=25
FLAVOR=updates-server ARCH=x86_64 BUILD=FEDORA-2017-376ae2b92c
ADVISORY=FEDORA-2017-376ae2b92c CURRREL=25 PREVREL=24
Pick an appropriate `ADVISORY` (ideally, one containing some
packages which might actually be involved in the tests), and
matching `FLAVOR` and `HDD_1`. The appropriate tests should run,
a repo with the update packages should be created and enabled
(and dnf update run), and the tests should work properly. Also
test a regular compose run to make sure I didn't break anything.
Reviewers: jskladan, jsedlak
Reviewed By: jsedlak
Subscribers: tflink
Differential Revision: https://phab.qa.fedoraproject.org/D1143
2017-01-25 16:16:12 +00:00
|
|
|
return unless $location;
|
2022-09-15 17:13:56 +00:00
|
|
|
disable_updates_repos(both => 1);
|
2018-03-26 19:28:48 +00:00
|
|
|
# we use script_run here as the rawhide and modular repo files
|
|
|
|
# won't always exist and we don't want to bother testing or
|
|
|
|
# predicting their existence; assert_script_run doesn't buy you
|
|
|
|
# much with sed as it'll return 0 even if it replaced nothing
|
Use mirrorlist instead of baseurl for updates tests
The reason we have all this horrible code to use the commented-
out baseurl lines in the repo files instead of the metalinks
that are usually used is a timing issue with the metalink
system. As a protection against stale mirrors, the metalink
system sends the package manager a list of mirrors *and a list
of recent checksums for the repo metadata*. The package manager
goes out and gets the metadata from the first mirror on the
list, then checksums it; if the checksum isn't on the list of
checksums it got from mirrormanager, it assumes that means the
mirror is stale, and tries the next on the list instead.
The problem is that MM's list of checksums is currently only
updated once an hour (by a cron job). So we kept running into
a problem where, when a test ran just after one of the repos
had been regenerated, the infra mirror it's supposed to use
would be rejected because the checksum wasn't on the list - but
not because the mirror was stale, but because it was too fresh,
it had got the new packages and metadata but mirrormanager's
list of checksums hadn't been updated to include the checksum
for the latest metadata.
All this baseurl munging code was getting ridiculous, though,
what with the tests getting more complicated and errors showing
up in the actual repo files and stuff. It occurred to me that
instead of using the baseurl we can just use the 'mirrorlist'
system instead of 'metalink'. mirrorlist is the dumber, older
system which just provides the package manager a list of mirrors
and nothing else - the whole stale-mirror-detection-checksum
thing does not happen with mirrorlists, the package manager just
tries all the mirrors in order and uses the first that works.
And happily, it's very easy to convert the metalink URLs into
mirrorlist URLs, and it saves all that faffing around trying to
fix up baseurls.
Also, adjust upgrade_boot to do the s/metalink/mirrorlist/
substitution, so upgrade tests don't run into the timing issue
in the steps before the main repo_setup run is done by
upgrade_run, and adjust repo_setup_compose to sub this line out
later.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-05-09 19:35:59 +00:00
|
|
|
script_run "sed -i -e 's,^metalink,#metalink,g' -e 's,^mirrorlist,#mirrorlist,g' -e 's,^#baseurl.*basearch,baseurl=${location}/Everything/\$basearch,g' -e 's,^#baseurl.*source,baseurl=${location}/Everything/source,g' /etc/yum.repos.d/{fedora,fedora-rawhide}.repo", 0;
|
|
|
|
script_run "sed -i -e 's,^metalink,#metalink,g' -e 's,^mirrorlist,#mirrorlist,g' -e 's,^#baseurl.*basearch,baseurl=${location}/Modular/\$basearch,g' -e 's,^#baseurl.*source,baseurl=${location}/Modular/source,g' /etc/yum.repos.d/{fedora-modular,fedora-rawhide-modular}.repo", 0;
|
2018-05-03 18:28:30 +00:00
|
|
|
|
|
|
|
# this can be used for debugging if something is going wrong
|
2022-07-28 20:32:57 +00:00
|
|
|
# unless (script_run 'pushd /etc/yum.repos.d && tar czvf yumreposd.tar.gz * && popd') {
|
|
|
|
# upload_logs "/etc/yum.repos.d/yumreposd.tar.gz";
|
|
|
|
# }
|
2017-01-18 07:15:44 +00:00
|
|
|
}
|
|
|
|
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
sub _download_packages_pre {
|
|
|
|
# create and mount the filesystem where we will store update/task packages
|
|
|
|
# this is separate from _download_packages as it has to happen before we
|
|
|
|
# enter the toolbox container on the CANNED workflow
|
|
|
|
assert_script_run "mkdir -p /mnt/update_repo";
|
|
|
|
# if NUMDISKS is above 1, assume we want to put the update repo on
|
|
|
|
# the second disk (to avoid huge updates exhausting space on the main
|
|
|
|
# disk)
|
|
|
|
if (get_var("NUMDISKS") > 1) {
|
|
|
|
# I think the disk will always be vdb. This creates a single large
|
|
|
|
# partition.
|
|
|
|
assert_script_run "echo 'type=83' | sfdisk /dev/vdb";
|
|
|
|
assert_script_run "mkfs.ext4 /dev/vdb1";
|
|
|
|
assert_script_run "echo '/dev/vdb1 /mnt/update_repo ext4 defaults 1 2' >> /etc/fstab";
|
|
|
|
assert_script_run "mount /mnt/update_repo";
|
|
|
|
}
|
|
|
|
assert_script_run "cd /mnt/update_repo";
|
|
|
|
}
|
|
|
|
|
|
|
|
sub _download_packages {
|
|
|
|
# actually do the work of downloading packages and creating a repoistory,
|
|
|
|
# for update and task cases. a repository is needed for various reasons:
|
|
|
|
# to ensure later package operations use the update packages, and for
|
|
|
|
# use when creating deliverables in the tests that do that
|
|
|
|
my $arch = get_var("ARCH");
|
|
|
|
script_run "dnf -y install createrepo_c koji", 300;
|
|
|
|
if (get_var("ADVISORY_NVRS") || get_var("ADVISORY_NVRS_1")) {
|
|
|
|
# regular update case
|
|
|
|
# old style single ADVISORY_NVRS var
|
|
|
|
my @nvrs = split(/ /, get_var("ADVISORY_NVRS"));
|
|
|
|
unless (@nvrs) {
|
|
|
|
# new style chunked ADVISORY_NVRS_N vars
|
|
|
|
my $count = 1;
|
|
|
|
while ($count) {
|
|
|
|
if (get_var("ADVISORY_NVRS_$count")) {
|
|
|
|
push @nvrs, split(/ /, get_var("ADVISORY_NVRS_$count"));
|
|
|
|
$count++;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
$count = 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
foreach my $nvr (@nvrs) {
|
|
|
|
my $kojitime = 600;
|
|
|
|
# texlive has a ridiculous number of subpackages
|
|
|
|
$kojitime = 1500 if ((rindex $nvr, "texlive", 0) == 0);
|
|
|
|
if (script_run "koji download-build --arch=$arch --arch=noarch $nvr 2> download.log", $kojitime) {
|
|
|
|
# if the error was because the build has no packages
|
|
|
|
# for our arch, that's okay, skip it. otherwise, die
|
|
|
|
if (script_run "grep 'No .*available for $nvr' download.log") {
|
|
|
|
die "koji download-build failed!";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
elsif (get_var("KOJITASK")) {
|
|
|
|
# Koji task case (KOJITASK will be set). If multiple tasks,
|
|
|
|
# they're concatenated with underscores
|
|
|
|
my @tasks = split(/_/, get_var("KOJITASK"));
|
|
|
|
foreach my $task (@tasks) {
|
|
|
|
assert_script_run "koji download-task --arch=$arch --arch=noarch $task", 600;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
die "Neither ADVISORY_NVRS nor KOJITASK nor TAG set! Don't know what to do";
|
|
|
|
}
|
|
|
|
|
|
|
|
if (script_run 'ls *.rpm') {
|
|
|
|
# we didn't actually download any packages (as they are all
|
|
|
|
# for an arch we don't test), so write dummy files
|
|
|
|
assert_script_run 'touch /mnt/updatepkgnames.txt /mnt/updatepkgs.txt';
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
# log the exact packages in the update at test time, with their
|
|
|
|
# source packages and epochs. we use /mnt as the path for this
|
|
|
|
# and similar files because, on ostree-based installs where we
|
|
|
|
# have to use a toolbox container for part of this, it's common
|
|
|
|
# to the host system and container
|
|
|
|
assert_script_run 'rpm -qp *.rpm --qf "%{SOURCERPM} %{NAME} %{EPOCHNUM} %{VERSION} %{RELEASE}\n" | sort -u > /mnt/updatepkgs.txt';
|
|
|
|
# also log just the binary package names: this is so we can check
|
|
|
|
# later whether any package from the update *should* have been
|
|
|
|
# installed, but was not
|
|
|
|
assert_script_run 'rpm -qp *.rpm --qf "%{NAME} " > /mnt/updatepkgnames.txt';
|
|
|
|
}
|
|
|
|
upload_logs "/mnt/updatepkgnames.txt";
|
|
|
|
upload_logs "/mnt/updatepkgs.txt";
|
|
|
|
|
|
|
|
# create the repo metadata
|
|
|
|
assert_script_run "createrepo .", timeout => 180;
|
|
|
|
}
|
|
|
|
|
Add support for testing updates
Summary:
This adds an entirely new workflow for testing distribution
updates. The `ADVISORY` variable is introduced: when set,
`main.pm` will load an early post-install test that sets up
a repository containing the packages from the specified update,
runs `dnf -y update`, and reboots. A new templates file is
added, `templates-updates`, which adds two new flavors called
`updates-server` and `updates-workstation`, each containing
job templates for appropriate post-install tests. Scheduler is
expected to post `ADVISORY=(update ID) HDD_1=(base image)
FLAVOR=updates-(server|workstation)`, where (base image) is one
of the stable release base disk images produced by `createhdds`
and usually used for upgrade testing. This will result in the
appropriate job templates being loaded.
We rejig postinstall test loading and static network config a
bit so that this works for both the 'compose' and 'updates' test
flows: we have to ensure we bring up networking for the tap
tests before we try and install the updates, but still allow
later adjustment of the configuration. We take advantage of the
openQA feature that was added a few months back to run the same
module multiple times, so the `_advisory_update` module can
reboot after installing the updates and the modules that take
care of bootloader, encryption and login get run again. This
looks slightly wacky in the web UI, though - it doesn't show the
later runs of each module.
We also use the recently added feature to specify `+HDD_1` in
the test suites which use a disk image uploaded by an earlier
post-install test, so the test suite value will take priority
over the value POSTed by the scheduler for those tests, and we
will use the uploaded disk image (and not the clean base image
POSTed by the scheduler) for those tests.
My intent here is to enhance the scheduler, adding a consumer
which listens out for critpath updates, and runs this test flow
for each one, then reports the results to ResultsDB where Bodhi
could query and display them. We could also add a list of other
packages to have one or both sets of update tests run on it, I
guess.
Test Plan:
Try a post something like:
HDD_1=disk_f25_server_3_x86_64.img DISTRI=fedora VERSION=25
FLAVOR=updates-server ARCH=x86_64 BUILD=FEDORA-2017-376ae2b92c
ADVISORY=FEDORA-2017-376ae2b92c CURRREL=25 PREVREL=24
Pick an appropriate `ADVISORY` (ideally, one containing some
packages which might actually be involved in the tests), and
matching `FLAVOR` and `HDD_1`. The appropriate tests should run,
a repo with the update packages should be created and enabled
(and dnf update run), and the tests should work properly. Also
test a regular compose run to make sure I didn't break anything.
Reviewers: jskladan, jsedlak
Reviewed By: jsedlak
Subscribers: tflink
Differential Revision: https://phab.qa.fedoraproject.org/D1143
2017-01-25 16:16:12 +00:00
|
|
|
sub _repo_setup_updates {
|
|
|
|
# Appropriate repo setup steps for testing a Bodhi update
|
2023-06-20 13:13:14 +00:00
|
|
|
# Check if we already ran, bail if so
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
return unless script_run "test -f /mnt/updatepkgs.txt";
|
2019-12-11 20:02:21 +00:00
|
|
|
my $version = get_var("VERSION");
|
2020-05-07 22:42:08 +00:00
|
|
|
my $currrel = get_var("CURRREL", "0");
|
2022-12-08 19:01:54 +00:00
|
|
|
my $arch = get_var("ARCH");
|
2023-07-04 20:13:15 +00:00
|
|
|
my $tag = get_var("TAG");
|
2020-01-10 22:34:58 +00:00
|
|
|
# this can be used for debugging repo config if something is wrong
|
2022-07-28 20:32:57 +00:00
|
|
|
# unless (script_run 'pushd /etc/yum.repos.d && tar czvf yumreposd.tar.gz * && popd') {
|
|
|
|
# upload_logs "/etc/yum.repos.d/yumreposd.tar.gz";
|
|
|
|
# }
|
Use mirrorlist instead of baseurl for updates tests
The reason we have all this horrible code to use the commented-
out baseurl lines in the repo files instead of the metalinks
that are usually used is a timing issue with the metalink
system. As a protection against stale mirrors, the metalink
system sends the package manager a list of mirrors *and a list
of recent checksums for the repo metadata*. The package manager
goes out and gets the metadata from the first mirror on the
list, then checksums it; if the checksum isn't on the list of
checksums it got from mirrormanager, it assumes that means the
mirror is stale, and tries the next on the list instead.
The problem is that MM's list of checksums is currently only
updated once an hour (by a cron job). So we kept running into
a problem where, when a test ran just after one of the repos
had been regenerated, the infra mirror it's supposed to use
would be rejected because the checksum wasn't on the list - but
not because the mirror was stale, but because it was too fresh,
it had got the new packages and metadata but mirrormanager's
list of checksums hadn't been updated to include the checksum
for the latest metadata.
All this baseurl munging code was getting ridiculous, though,
what with the tests getting more complicated and errors showing
up in the actual repo files and stuff. It occurred to me that
instead of using the baseurl we can just use the 'mirrorlist'
system instead of 'metalink'. mirrorlist is the dumber, older
system which just provides the package manager a list of mirrors
and nothing else - the whole stale-mirror-detection-checksum
thing does not happen with mirrorlists, the package manager just
tries all the mirrors in order and uses the first that works.
And happily, it's very easy to convert the metalink URLs into
mirrorlist URLs, and it saves all that faffing around trying to
fix up baseurls.
Also, adjust upgrade_boot to do the s/metalink/mirrorlist/
substitution, so upgrade tests don't run into the timing issue
in the steps before the main repo_setup run is done by
upgrade_run, and adjust repo_setup_compose to sub this line out
later.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-05-09 19:35:59 +00:00
|
|
|
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
# prepare the directory the packages will be downloaded to, unless we're
|
|
|
|
# testing a side tag
|
|
|
|
_download_packages_pre() unless ($tag);
|
|
|
|
|
Add tests to build a Silverblue installer image and install it
This is like the existing tests that build network install and
live images then install them, only for Silverblue. First we
build an ostree, using the standard configuration for the release
and subvariant but with the 'advisory' and 'workarounds' repos
included, so it will contain current stable packages plus the
packages from the update and any workarounds. Then we build an
ostree installer image with the ostree embedded, again including
advisory and workarounds repos in the installer build config so
packages from them will be included in the installer environment.
The image is uploaded, which completes the _ostree_build test.
Then an install_default_update_ostree test runs, which does a
standard install and boot from the installer image.
We do make a change that affects other tests, too. We now run
_advisory_post on live image install tests, as well as this new
ostree install image install test. It was skipped before because
of an exception that's really only needed for the netinst image
install test. In that test, packages from the update won't be
included in the installed system, so we can't run _advisory_post
on it. But for ostree and live image build/install tests, the
installed system *should* include packages from the update, so
we should check and make sure that it does.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-22 19:22:19 +00:00
|
|
|
# on CANNED, we need to enter the toolbox at this point
|
|
|
|
if (get_var("CANNED")) {
|
2023-08-10 18:24:17 +00:00
|
|
|
type_string "toolbox -y enter\n";
|
Add tests to build a Silverblue installer image and install it
This is like the existing tests that build network install and
live images then install them, only for Silverblue. First we
build an ostree, using the standard configuration for the release
and subvariant but with the 'advisory' and 'workarounds' repos
included, so it will contain current stable packages plus the
packages from the update and any workarounds. Then we build an
ostree installer image with the ostree embedded, again including
advisory and workarounds repos in the installer build config so
packages from them will be included in the installer environment.
The image is uploaded, which completes the _ostree_build test.
Then an install_default_update_ostree test runs, which does a
standard install and boot from the installer image.
We do make a change that affects other tests, too. We now run
_advisory_post on live image install tests, as well as this new
ostree install image install test. It was skipped before because
of an exception that's really only needed for the netinst image
install test. In that test, packages from the update won't be
included in the installed system, so we can't run _advisory_post
on it. But for ostree and live image build/install tests, the
installed system *should* include packages from the update, so
we should check and make sure that it does.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-22 19:22:19 +00:00
|
|
|
# look for the little purple dot
|
|
|
|
assert_screen "console_in_toolbox", 180;
|
|
|
|
}
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
|
Add tests to build a Silverblue installer image and install it
This is like the existing tests that build network install and
live images then install them, only for Silverblue. First we
build an ostree, using the standard configuration for the release
and subvariant but with the 'advisory' and 'workarounds' repos
included, so it will contain current stable packages plus the
packages from the update and any workarounds. Then we build an
ostree installer image with the ostree embedded, again including
advisory and workarounds repos in the installer build config so
packages from them will be included in the installer environment.
The image is uploaded, which completes the _ostree_build test.
Then an install_default_update_ostree test runs, which does a
standard install and boot from the installer image.
We do make a change that affects other tests, too. We now run
_advisory_post on live image install tests, as well as this new
ostree install image install test. It was skipped before because
of an exception that's really only needed for the netinst image
install test. In that test, packages from the update won't be
included in the installed system, so we can't run _advisory_post
on it. But for ostree and live image build/install tests, the
installed system *should* include packages from the update, so
we should check and make sure that it does.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-22 19:22:19 +00:00
|
|
|
# use mirrorlist not metalink in repo configs
|
|
|
|
repos_mirrorlist();
|
|
|
|
# Disable updates-testing so other bad updates don't break us
|
|
|
|
disable_updates_repos(both => 0) if ($version > $currrel);
|
2022-12-08 19:01:54 +00:00
|
|
|
# use the buildroot repo on Rawhide: see e.g.
|
|
|
|
# https://pagure.io/fedora-ci/general/issue/376 for why
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
if (get_var("VERSION") eq get_var("RAWREL") && get_var("TEST") ne "support_server") {
|
|
|
|
assert_script_run 'printf "[koji-rawhide]\nname=koji-rawhide\nbaseurl=https://kojipkgs.fedoraproject.org/repos/rawhide/latest/' . $arch . '/\ncost=2000\nenabled=1\ngpgcheck=0\n" > /etc/yum.repos.d/koji-rawhide.repo';
|
2022-12-08 19:01:54 +00:00
|
|
|
}
|
Add tests to build a Silverblue installer image and install it
This is like the existing tests that build network install and
live images then install them, only for Silverblue. First we
build an ostree, using the standard configuration for the release
and subvariant but with the 'advisory' and 'workarounds' repos
included, so it will contain current stable packages plus the
packages from the update and any workarounds. Then we build an
ostree installer image with the ostree embedded, again including
advisory and workarounds repos in the installer build config so
packages from them will be included in the installer environment.
The image is uploaded, which completes the _ostree_build test.
Then an install_default_update_ostree test runs, which does a
standard install and boot from the installer image.
We do make a change that affects other tests, too. We now run
_advisory_post on live image install tests, as well as this new
ostree install image install test. It was skipped before because
of an exception that's really only needed for the netinst image
install test. In that test, packages from the update won't be
included in the installed system, so we can't run _advisory_post
on it. But for ostree and live image build/install tests, the
installed system *should* include packages from the update, so
we should check and make sure that it does.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-22 19:22:19 +00:00
|
|
|
# set up the workaround repo
|
|
|
|
setup_workaround_repo;
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
if (get_var("CANNED")) {
|
|
|
|
# install and use en_US.UTF-8 locale for consistent sort
|
|
|
|
# ordering
|
|
|
|
assert_script_run "dnf -y install glibc-langpack-en", 300;
|
|
|
|
assert_script_run "export LC_ALL=en_US.UTF-8";
|
|
|
|
}
|
|
|
|
|
|
|
|
# download the packages, unless we're testing a side tag
|
|
|
|
_download_packages unless ($tag);
|
|
|
|
|
2019-02-08 16:20:24 +00:00
|
|
|
# write a repo config file, unless this is the support_server test
|
|
|
|
# and it is running on a different release than the update is for
|
|
|
|
# (in this case we need the repo to exist but do not want to use
|
|
|
|
# it on the actual support_server system)
|
2019-12-11 20:02:21 +00:00
|
|
|
unless (get_var("TEST") eq "support_server" && $version ne get_var("CURRREL")) {
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
assert_script_run 'printf "[advisory]\nname=Advisory repo\nbaseurl=file:///mnt/update_repo\nenabled=1\nmetadata_expire=3600\ngpgcheck=0" > /etc/yum.repos.d/advisory.repo' unless ($tag);
|
|
|
|
assert_script_run 'printf "[openqa-testtag]\nname=openqa-testtag\nbaseurl=https://kojipkgs.fedoraproject.org/repos/' . "$tag/latest/$arch" . '/\ncost=2000\nenabled=1\ngpgcheck=0\n" > /etc/yum.repos.d/openqa-testtag.repo' if ($tag);
|
2022-12-09 21:07:15 +00:00
|
|
|
# run an update now, except for upgrade or install tests,
|
|
|
|
# where the updated packages should have been installed
|
|
|
|
# already and we want to fail if they weren't, or CANNED
|
|
|
|
# tests, there's no point updating the toolbox
|
2023-02-03 17:04:48 +00:00
|
|
|
script_run "dnf -y update", 1200 unless (get_var("UPGRADE") || get_var("INSTALL") || get_var("CANNED"));
|
2023-02-22 23:57:02 +00:00
|
|
|
# on liveinst tests, we'll remove the packages we installed
|
|
|
|
# above (and their deps, which dnf will include automatically),
|
|
|
|
# just in case they're in the update under test; otherwise we
|
|
|
|
# get a bogus failure for the package not being updated
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
script_run "dnf -y remove bodhi-client createrepo_c koji", 600 if (get_var("INSTALL") && !get_var("CANNED"));
|
Add tests to build a Silverblue installer image and install it
This is like the existing tests that build network install and
live images then install them, only for Silverblue. First we
build an ostree, using the standard configuration for the release
and subvariant but with the 'advisory' and 'workarounds' repos
included, so it will contain current stable packages plus the
packages from the update and any workarounds. Then we build an
ostree installer image with the ostree embedded, again including
advisory and workarounds repos in the installer build config so
packages from them will be included in the installer environment.
The image is uploaded, which completes the _ostree_build test.
Then an install_default_update_ostree test runs, which does a
standard install and boot from the installer image.
We do make a change that affects other tests, too. We now run
_advisory_post on live image install tests, as well as this new
ostree install image install test. It was skipped before because
of an exception that's really only needed for the netinst image
install test. In that test, packages from the update won't be
included in the installed system, so we can't run _advisory_post
on it. But for ostree and live image build/install tests, the
installed system *should* include packages from the update, so
we should check and make sure that it does.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-22 19:22:19 +00:00
|
|
|
}
|
|
|
|
# exit the toolbox on CANNED
|
|
|
|
if (get_var("CANNED")) {
|
|
|
|
type_string "exit\n";
|
|
|
|
wait_still_screen 5;
|
2019-02-08 16:20:24 +00:00
|
|
|
}
|
Add support for testing updates
Summary:
This adds an entirely new workflow for testing distribution
updates. The `ADVISORY` variable is introduced: when set,
`main.pm` will load an early post-install test that sets up
a repository containing the packages from the specified update,
runs `dnf -y update`, and reboots. A new templates file is
added, `templates-updates`, which adds two new flavors called
`updates-server` and `updates-workstation`, each containing
job templates for appropriate post-install tests. Scheduler is
expected to post `ADVISORY=(update ID) HDD_1=(base image)
FLAVOR=updates-(server|workstation)`, where (base image) is one
of the stable release base disk images produced by `createhdds`
and usually used for upgrade testing. This will result in the
appropriate job templates being loaded.
We rejig postinstall test loading and static network config a
bit so that this works for both the 'compose' and 'updates' test
flows: we have to ensure we bring up networking for the tap
tests before we try and install the updates, but still allow
later adjustment of the configuration. We take advantage of the
openQA feature that was added a few months back to run the same
module multiple times, so the `_advisory_update` module can
reboot after installing the updates and the modules that take
care of bootloader, encryption and login get run again. This
looks slightly wacky in the web UI, though - it doesn't show the
later runs of each module.
We also use the recently added feature to specify `+HDD_1` in
the test suites which use a disk image uploaded by an earlier
post-install test, so the test suite value will take priority
over the value POSTed by the scheduler for those tests, and we
will use the uploaded disk image (and not the clean base image
POSTed by the scheduler) for those tests.
My intent here is to enhance the scheduler, adding a consumer
which listens out for critpath updates, and runs this test flow
for each one, then reports the results to ResultsDB where Bodhi
could query and display them. We could also add a list of other
packages to have one or both sets of update tests run on it, I
guess.
Test Plan:
Try a post something like:
HDD_1=disk_f25_server_3_x86_64.img DISTRI=fedora VERSION=25
FLAVOR=updates-server ARCH=x86_64 BUILD=FEDORA-2017-376ae2b92c
ADVISORY=FEDORA-2017-376ae2b92c CURRREL=25 PREVREL=24
Pick an appropriate `ADVISORY` (ideally, one containing some
packages which might actually be involved in the tests), and
matching `FLAVOR` and `HDD_1`. The appropriate tests should run,
a repo with the update packages should be created and enabled
(and dnf update run), and the tests should work properly. Also
test a regular compose run to make sure I didn't break anything.
Reviewers: jskladan, jsedlak
Reviewed By: jsedlak
Subscribers: tflink
Differential Revision: https://phab.qa.fedoraproject.org/D1143
2017-01-25 16:16:12 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
sub repo_setup {
|
|
|
|
# Run the appropriate sub-function for the job
|
2019-01-29 09:06:16 +00:00
|
|
|
get_var("ADVISORY_OR_TASK") ? _repo_setup_updates : _repo_setup_compose;
|
2017-03-15 17:02:25 +00:00
|
|
|
# This repo does not always exist for Rawhide or Branched, and
|
|
|
|
# some things (at least realmd) try to update the repodata for
|
|
|
|
# it even though it is disabled, and fail. At present none of the
|
|
|
|
# tests needs it, so let's just unconditionally nuke it.
|
|
|
|
assert_script_run "rm -f /etc/yum.repos.d/fedora-cisco-openh264.repo";
|
Add support for testing updates
Summary:
This adds an entirely new workflow for testing distribution
updates. The `ADVISORY` variable is introduced: when set,
`main.pm` will load an early post-install test that sets up
a repository containing the packages from the specified update,
runs `dnf -y update`, and reboots. A new templates file is
added, `templates-updates`, which adds two new flavors called
`updates-server` and `updates-workstation`, each containing
job templates for appropriate post-install tests. Scheduler is
expected to post `ADVISORY=(update ID) HDD_1=(base image)
FLAVOR=updates-(server|workstation)`, where (base image) is one
of the stable release base disk images produced by `createhdds`
and usually used for upgrade testing. This will result in the
appropriate job templates being loaded.
We rejig postinstall test loading and static network config a
bit so that this works for both the 'compose' and 'updates' test
flows: we have to ensure we bring up networking for the tap
tests before we try and install the updates, but still allow
later adjustment of the configuration. We take advantage of the
openQA feature that was added a few months back to run the same
module multiple times, so the `_advisory_update` module can
reboot after installing the updates and the modules that take
care of bootloader, encryption and login get run again. This
looks slightly wacky in the web UI, though - it doesn't show the
later runs of each module.
We also use the recently added feature to specify `+HDD_1` in
the test suites which use a disk image uploaded by an earlier
post-install test, so the test suite value will take priority
over the value POSTed by the scheduler for those tests, and we
will use the uploaded disk image (and not the clean base image
POSTed by the scheduler) for those tests.
My intent here is to enhance the scheduler, adding a consumer
which listens out for critpath updates, and runs this test flow
for each one, then reports the results to ResultsDB where Bodhi
could query and display them. We could also add a list of other
packages to have one or both sets of update tests run on it, I
guess.
Test Plan:
Try a post something like:
HDD_1=disk_f25_server_3_x86_64.img DISTRI=fedora VERSION=25
FLAVOR=updates-server ARCH=x86_64 BUILD=FEDORA-2017-376ae2b92c
ADVISORY=FEDORA-2017-376ae2b92c CURRREL=25 PREVREL=24
Pick an appropriate `ADVISORY` (ideally, one containing some
packages which might actually be involved in the tests), and
matching `FLAVOR` and `HDD_1`. The appropriate tests should run,
a repo with the update packages should be created and enabled
(and dnf update run), and the tests should work properly. Also
test a regular compose run to make sure I didn't break anything.
Reviewers: jskladan, jsedlak
Reviewed By: jsedlak
Subscribers: tflink
Differential Revision: https://phab.qa.fedoraproject.org/D1143
2017-01-25 16:16:12 +00:00
|
|
|
}
|
|
|
|
|
2020-10-28 21:20:16 +00:00
|
|
|
sub console_initial_setup {
|
|
|
|
# Handle console initial-setup. Currently used only for ARM disk
|
|
|
|
# image tests.
|
|
|
|
assert_screen "console_initial_setup", 500;
|
|
|
|
# IMHO it's better to use sleeps than to have needle for every text screen
|
|
|
|
wait_still_screen 5;
|
|
|
|
|
|
|
|
# Set timezone
|
|
|
|
type_string "2\n";
|
|
|
|
wait_still_screen 5;
|
2022-07-28 20:32:57 +00:00
|
|
|
type_string "1\n"; # Set timezone
|
2020-10-28 21:20:16 +00:00
|
|
|
wait_still_screen 5;
|
2022-07-28 20:32:57 +00:00
|
|
|
type_string "1\n"; # Europe
|
2020-10-28 21:20:16 +00:00
|
|
|
wait_still_screen 5;
|
2022-07-28 20:32:57 +00:00
|
|
|
type_string "37\n"; # Prague
|
2020-10-28 21:20:16 +00:00
|
|
|
wait_still_screen 7;
|
|
|
|
|
|
|
|
# Set root password
|
|
|
|
type_string "4\n";
|
|
|
|
wait_still_screen 5;
|
|
|
|
type_string get_var("ROOT_PASSWORD") || "weakpassword";
|
|
|
|
send_key "ret";
|
|
|
|
wait_still_screen 5;
|
|
|
|
type_string get_var("ROOT_PASSWORD") || "weakpassword";
|
|
|
|
send_key "ret";
|
|
|
|
wait_still_screen 7;
|
|
|
|
|
|
|
|
# Create user
|
|
|
|
type_string "5\n";
|
|
|
|
wait_still_screen 5;
|
2022-07-28 20:32:57 +00:00
|
|
|
type_string "1\n"; # create new
|
2020-10-28 21:20:16 +00:00
|
|
|
wait_still_screen 5;
|
2022-07-28 20:32:57 +00:00
|
|
|
type_string "3\n"; # set username
|
2020-10-28 21:20:16 +00:00
|
|
|
wait_still_screen 5;
|
|
|
|
type_string get_var("USER_LOGIN", "test");
|
|
|
|
send_key "ret";
|
|
|
|
wait_still_screen 5;
|
2022-07-28 20:32:57 +00:00
|
|
|
type_string "5\n"; # set password
|
2020-10-28 21:20:16 +00:00
|
|
|
wait_still_screen 5;
|
|
|
|
type_string get_var("USER_PASSWORD", "weakpassword");
|
|
|
|
send_key "ret";
|
|
|
|
wait_still_screen 5;
|
|
|
|
type_string get_var("USER_PASSWORD", "weakpassword");
|
|
|
|
send_key "ret";
|
|
|
|
wait_still_screen 5;
|
2022-07-28 20:32:57 +00:00
|
|
|
type_string "6\n"; # make him an administrator
|
2020-10-28 21:20:16 +00:00
|
|
|
wait_still_screen 5;
|
|
|
|
type_string "c\n";
|
|
|
|
wait_still_screen 7;
|
|
|
|
|
2022-09-28 06:46:55 +00:00
|
|
|
assert_screen "console_initial_setup_done", 30;
|
2022-07-28 20:32:57 +00:00
|
|
|
type_string "c\n"; # continue
|
2020-10-28 21:20:16 +00:00
|
|
|
}
|
|
|
|
|
2021-02-18 17:56:34 +00:00
|
|
|
sub handle_welcome_screen {
|
2023-02-22 02:16:13 +00:00
|
|
|
# handle the 'welcome' screen on GNOME and KDE since F38. shared
|
|
|
|
# in a few places
|
2021-02-18 17:54:06 +00:00
|
|
|
if (check_screen "getting_started", 45) {
|
2023-02-22 03:57:19 +00:00
|
|
|
if (get_var("DESKTOP") eq "kde") {
|
|
|
|
# just closing it seems to result in it running again on
|
|
|
|
# next boot, so let's click Skip
|
|
|
|
click_lastmatch;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
send_key "alt-f4";
|
|
|
|
# for GNOME 40, alt-f4 doesn't work
|
|
|
|
send_key "esc";
|
|
|
|
}
|
2021-02-18 17:54:06 +00:00
|
|
|
wait_still_screen 5;
|
2023-02-22 16:04:29 +00:00
|
|
|
set_var("_WELCOME_DONE", 1);
|
2021-02-18 17:54:06 +00:00
|
|
|
}
|
|
|
|
else {
|
|
|
|
record_soft_failure "Welcome tour missing";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-04-03 23:23:45 +00:00
|
|
|
sub gnome_initial_setup {
|
2023-08-23 17:15:07 +00:00
|
|
|
# Handle gnome-initial-setup, with variations for live mode (the
|
|
|
|
# short run on live boot since F39), the pre-login mode (when no
|
|
|
|
# user was created during install) and post-login mode (when user
|
|
|
|
# was created during install). post-login mode currently (2023-08)
|
|
|
|
# unused, but may come back in future. 'livetry' indicates whether
|
|
|
|
# to launch the installer (0) or desktop (1) at the end of live
|
|
|
|
# flow
|
2017-04-03 23:23:45 +00:00
|
|
|
my %args = (
|
|
|
|
prelogin => 0,
|
2023-08-21 22:32:08 +00:00
|
|
|
live => 0,
|
2023-08-23 17:15:07 +00:00
|
|
|
livetry => 0,
|
2017-04-03 23:23:45 +00:00
|
|
|
timeout => 120,
|
|
|
|
@_
|
|
|
|
);
|
2021-08-23 19:45:35 +00:00
|
|
|
my $relnum = get_release_number;
|
2023-09-12 18:09:52 +00:00
|
|
|
my $advortask = get_var("ADVISORY_OR_TASK");
|
2023-09-07 19:38:28 +00:00
|
|
|
|
|
|
|
# note: when 'language' is "skipped", it's turned into a 'welcome'
|
|
|
|
# page, which has a "Start Setup" button, not a "Next" button
|
|
|
|
unless (check_screen ["next_button", "start_setup"], $args{timeout}) {
|
|
|
|
record_soft_failure "g-i-s taking longer than expected to start up!";
|
|
|
|
assert_screen ["next_button", "start_setup"], $args{timeout};
|
|
|
|
}
|
|
|
|
# GDM 3.24.1 dumps a cursor in the middle of the screen here...
|
|
|
|
mouse_hide if ($args{prelogin});
|
|
|
|
|
2018-03-29 23:48:25 +00:00
|
|
|
# the pages we *may* need to click 'next' on. *NOTE*: 'language'
|
|
|
|
# is the 'welcome' page, and is in fact never truly skipped; if
|
|
|
|
# it's configured to be skipped, it just shows without the language
|
|
|
|
# selection widget (so it's a bare 'welcome' page). Current openQA
|
|
|
|
# tests never see 'eula' or 'network'. You can find the upstream
|
|
|
|
# list in gnome-initial-setup/gnome-initial-setup.c , and the skip
|
|
|
|
# config file for Fedora is vendor.conf in the package repo.
|
|
|
|
my @nexts = ('language', 'keyboard', 'privacy', 'timezone', 'software');
|
|
|
|
# now, we're going to figure out how many of them this test will
|
|
|
|
# *actually* see...
|
2023-08-21 22:32:08 +00:00
|
|
|
if ($args{live}) {
|
2023-09-12 23:13:49 +00:00
|
|
|
# this is the flow we see when booting an F40+ Workstation live
|
2023-08-21 22:32:08 +00:00
|
|
|
# we only get language and keyboard
|
2023-08-25 21:38:40 +00:00
|
|
|
@nexts = ('language', 'keyboard');
|
2023-08-21 22:32:08 +00:00
|
|
|
}
|
2017-04-03 23:23:45 +00:00
|
|
|
if ($args{prelogin}) {
|
2023-08-21 22:32:08 +00:00
|
|
|
# 'language', 'keyboard' and 'timezone' were skipped between F28
|
2023-09-12 23:13:49 +00:00
|
|
|
# and F39 in the 'new user' mode by
|
2018-03-29 23:48:25 +00:00
|
|
|
# https://fedoraproject.org//wiki/Changes/ReduceInitialSetupRedundancy
|
|
|
|
# https://bugzilla.redhat.com/show_bug.cgi?id=1474787 ,
|
2023-08-21 22:32:08 +00:00
|
|
|
# except 'language' was never *really* skipped (see above)
|
2023-09-12 23:13:49 +00:00
|
|
|
if ($relnum < 40) {
|
2023-08-21 22:32:08 +00:00
|
|
|
@nexts = grep { $_ ne 'keyboard' } @nexts;
|
|
|
|
@nexts = grep { $_ ne 'timezone' } @nexts;
|
|
|
|
}
|
2023-09-07 19:38:28 +00:00
|
|
|
# From gnome-initial-setup 45~beta-3 on, no screens are
|
|
|
|
# skipped in vendor.conf. 'language' and 'keyboard' should be
|
|
|
|
# skipped (meaning 'language' is turned into 'welcome' and
|
|
|
|
# 'keyboard' is really skipped) on live installs because we saw
|
|
|
|
# them already, but this only works from anaconda 39.32.2 /
|
|
|
|
# 40.3 onwards. network installs and disk image deployments
|
|
|
|
# will show these screens (which is good for disk image
|
|
|
|
# deployments, but redundant for network installs)
|
|
|
|
elsif (match_has_tag "start_setup") {
|
|
|
|
# if we saw start_setup, that means 'language' was skipped
|
|
|
|
# and we can assume 'keyboard' will also be skipped
|
|
|
|
@nexts = grep { $_ ne 'keyboard' } @nexts;
|
|
|
|
}
|
2017-04-03 23:23:45 +00:00
|
|
|
}
|
2018-03-29 23:48:25 +00:00
|
|
|
else {
|
|
|
|
# 'timezone' and 'software' are suppressed for the 'existing user'
|
2023-08-21 22:32:08 +00:00
|
|
|
# form of g-i-s (upstream, not in vendor.conf)
|
2022-07-28 20:32:57 +00:00
|
|
|
@nexts = grep { $_ ne 'software' } @nexts;
|
|
|
|
@nexts = grep { $_ ne 'timezone' } @nexts;
|
2018-03-29 23:48:25 +00:00
|
|
|
}
|
|
|
|
|
2023-08-21 22:32:08 +00:00
|
|
|
foreach my $next (@nexts) {
|
2023-09-07 19:38:28 +00:00
|
|
|
# give animations a bit to settle down
|
|
|
|
wait_still_screen 3;
|
2017-04-03 23:23:45 +00:00
|
|
|
# click 'Next' $nexts times, moving the mouse to avoid
|
|
|
|
# highlight problems, sleeping to give it time to get
|
|
|
|
# to the next screen between clicks
|
|
|
|
mouse_set(100, 100);
|
2023-08-21 22:32:08 +00:00
|
|
|
if ($next eq 'language') {
|
2023-08-30 13:37:46 +00:00
|
|
|
my $lang = get_var("LANGUAGE") // "english";
|
2020-12-21 20:51:50 +00:00
|
|
|
# only accept start_setup one time, to avoid matching
|
|
|
|
# on it during transition to next screen. also accept
|
2023-08-30 13:37:46 +00:00
|
|
|
# next_button as in per-user mode, first screen has that
|
|
|
|
# not start_setup
|
|
|
|
assert_screen ["next_button", "start_setup"];
|
|
|
|
if (match_has_tag("start_setup") || check_screen("gis_lang_${lang}_selected")) {
|
|
|
|
# we're at the 'welcome' version of the screen, or we're
|
|
|
|
# at the 'language' version and the language we want is
|
|
|
|
# selected
|
|
|
|
wait_screen_change { click_lastmatch(); };
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
# we're at the language version and the language we want isn't
|
|
|
|
# selected
|
|
|
|
assert_and_click("install_lang_search_field");
|
|
|
|
type_very_safely($lang);
|
|
|
|
assert_and_click("gis_lang_${lang}_select");
|
|
|
|
wait_screen_change { assert_and_click("next_button"); };
|
|
|
|
}
|
2020-12-21 20:51:50 +00:00
|
|
|
}
|
2023-08-21 22:32:08 +00:00
|
|
|
elsif ($next eq 'timezone') {
|
|
|
|
assert_screen ["next_button", "next_button_inactive"];
|
|
|
|
if (match_has_tag "next_button_inactive") {
|
|
|
|
record_soft_failure "geolocation failed!";
|
|
|
|
send_key "tab";
|
|
|
|
wait_still_screen 3;
|
|
|
|
type_very_safely "washington-d";
|
|
|
|
send_key "down";
|
|
|
|
send_key "ret";
|
|
|
|
}
|
|
|
|
wait_screen_change { assert_and_click "next_button"; };
|
|
|
|
}
|
2020-12-21 20:51:50 +00:00
|
|
|
else {
|
2023-08-30 13:37:46 +00:00
|
|
|
# Sometimes, the previous version was expection the next button, although
|
|
|
|
# the wizard had proceeded to the final screen with no such button on it.
|
|
|
|
# Therefore, we also try to assert the installation button to start Anaconda.
|
|
|
|
wait_screen_change { assert_and_click ["next_button"]; };
|
2020-12-21 20:51:50 +00:00
|
|
|
}
|
2017-04-03 23:23:45 +00:00
|
|
|
}
|
2023-08-21 22:32:08 +00:00
|
|
|
unless (get_var("VNC_CLIENT") || $args{live}) {
|
2021-08-24 22:14:22 +00:00
|
|
|
# We should be at the GOA screen, except on VNC_CLIENT case
|
|
|
|
# where network isn't working yet. click 'Skip' one time. If
|
|
|
|
# it's not visible we may have hit
|
|
|
|
# https://bugzilla.redhat.com/show_bug.cgi?id=1997310 , which
|
|
|
|
# we'll handle as a soft failure
|
2022-07-28 20:32:57 +00:00
|
|
|
mouse_set(100, 100);
|
2021-08-24 22:14:22 +00:00
|
|
|
if (check_screen "skip_button", 60) {
|
|
|
|
wait_screen_change { click_lastmatch; };
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
record_soft_failure "GOA screen not seen! Likely RHBZ #1997310";
|
|
|
|
}
|
2019-11-05 20:13:33 +00:00
|
|
|
}
|
2023-09-22 00:59:34 +00:00
|
|
|
send_key "shift-tab" if ($args{live} && $args{livetry});
|
2023-08-21 22:32:08 +00:00
|
|
|
# on the 'live' flow, this will launch the installer
|
2017-04-03 23:23:45 +00:00
|
|
|
send_key "ret";
|
2023-08-21 22:32:08 +00:00
|
|
|
# we don't want to do anything further on the 'live' flow
|
|
|
|
return if ($args{live});
|
2017-04-03 23:23:45 +00:00
|
|
|
if ($args{prelogin}) {
|
|
|
|
# create user
|
|
|
|
my $user_login = get_var("USER_LOGIN") || "test";
|
|
|
|
my $user_password = get_var("USER_PASSWORD") || "weakpassword";
|
|
|
|
type_very_safely $user_login;
|
|
|
|
wait_screen_change { assert_and_click "next_button"; };
|
2023-02-21 01:29:13 +00:00
|
|
|
# temporarily (until the versions are stable) we need to check
|
|
|
|
# whether we're on 43 or 44 here
|
|
|
|
my $extratab = 0;
|
|
|
|
$extratab = 1 if (check_screen 'initial_setup_44', 5);
|
2017-04-03 23:23:45 +00:00
|
|
|
type_very_safely $user_password;
|
|
|
|
send_key "tab";
|
2023-02-21 01:13:37 +00:00
|
|
|
# on GNOME 44+ we need a second tab here to reach the confirm box
|
|
|
|
send_key "tab" if ($extratab);
|
2017-04-03 23:23:45 +00:00
|
|
|
type_very_safely $user_password;
|
|
|
|
wait_screen_change { assert_and_click "next_button"; };
|
|
|
|
send_key "ret";
|
|
|
|
}
|
|
|
|
else {
|
2021-02-18 17:56:34 +00:00
|
|
|
handle_welcome_screen;
|
2017-04-03 23:23:45 +00:00
|
|
|
}
|
2021-02-18 17:54:06 +00:00
|
|
|
# don't do it again on second load
|
2022-09-28 06:18:42 +00:00
|
|
|
set_var("_SETUP_DONE", 1);
|
2017-04-03 23:23:45 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
sub _type_user_password {
|
|
|
|
# convenience function used by anaconda_create_user, not meant
|
|
|
|
# for direct use
|
|
|
|
my $user_password = get_var("USER_PASSWORD") || "weakpassword";
|
|
|
|
if (get_var("SWITCHED_LAYOUT")) {
|
|
|
|
# we double the password, the second time using the native
|
|
|
|
# layout, so the password has both ASCII and native characters
|
|
|
|
desktop_switch_layout "ascii", "anaconda";
|
|
|
|
type_very_safely $user_password;
|
|
|
|
desktop_switch_layout "native", "anaconda";
|
|
|
|
type_very_safely $user_password;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
type_very_safely $user_password;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
sub anaconda_create_user {
|
|
|
|
# Create a user, in the anaconda interface. This is here because
|
|
|
|
# the same code works both during install and for initial-setup,
|
|
|
|
# which runs post-install, so we can share it.
|
|
|
|
my %args = (
|
|
|
|
timeout => 90,
|
|
|
|
@_
|
|
|
|
);
|
2023-06-22 09:53:15 +00:00
|
|
|
# For some languages, i.e. Turkish, we want to use a complicated
|
|
|
|
# geo field to test that turkish letters will be displayed correctly
|
|
|
|
# and that the installer will be able to handle them and change them
|
|
|
|
# into the correct user name without special characters.
|
|
|
|
my $geofield = get_var("USER_GECOS");
|
2017-04-03 23:23:45 +00:00
|
|
|
my $user_login = get_var("USER_LOGIN") || "test";
|
2023-06-22 09:53:15 +00:00
|
|
|
unless ($geofield) {
|
|
|
|
# If geofield is not defined, let it be the same as login.
|
|
|
|
$geofield = $user_login;
|
|
|
|
}
|
2022-07-28 20:32:57 +00:00
|
|
|
assert_and_click("anaconda_install_user_creation", timeout => $args{timeout});
|
2017-04-03 23:23:45 +00:00
|
|
|
assert_screen "anaconda_install_user_creation_screen";
|
|
|
|
# wait out animation
|
|
|
|
wait_still_screen 2;
|
2023-06-22 09:53:15 +00:00
|
|
|
# We will type the $geofield as the user name.
|
|
|
|
type_very_safely $geofield;
|
|
|
|
# For Turkish, we especially want to check that correct characters
|
|
|
|
# are typed, so we will check it here.
|
|
|
|
if (get_var("LANGUAGE") eq "turkish") {
|
|
|
|
assert_screen("username_typed_correctly_turkish");
|
|
|
|
}
|
|
|
|
send_key("tab");
|
|
|
|
# Now set the login name.
|
|
|
|
type_very_safely($user_login);
|
|
|
|
# And fill the password stuff.
|
|
|
|
type_very_safely "\t\t\t";
|
2017-04-03 23:23:45 +00:00
|
|
|
_type_user_password();
|
|
|
|
wait_screen_change { send_key "tab"; };
|
|
|
|
wait_still_screen 2;
|
|
|
|
_type_user_password();
|
|
|
|
# even with all our slow typing this still *sometimes* seems to
|
|
|
|
# miss a character, so let's try again if we have a warning bar.
|
|
|
|
# But not if we're installing with a switched layout, as those
|
|
|
|
# will *always* result in a warning bar at this point (see below)
|
|
|
|
if (!get_var("SWITCHED_LAYOUT") && check_screen "anaconda_warning_bar", 3) {
|
|
|
|
wait_screen_change { send_key "shift-tab"; };
|
|
|
|
wait_still_screen 2;
|
|
|
|
_type_user_password();
|
|
|
|
wait_screen_change { send_key "tab"; };
|
|
|
|
wait_still_screen 2;
|
|
|
|
_type_user_password();
|
|
|
|
}
|
|
|
|
assert_and_click "anaconda_spoke_done";
|
|
|
|
# since 20170105, we will get a warning here when the password
|
|
|
|
# contains non-ASCII characters. Assume only switched layouts
|
|
|
|
# produce non-ASCII characters, though this isn't strictly true
|
|
|
|
if (get_var('SWITCHED_LAYOUT') && check_screen "anaconda_warning_bar", 3) {
|
|
|
|
wait_still_screen 1;
|
|
|
|
assert_and_click "anaconda_spoke_done";
|
|
|
|
}
|
|
|
|
}
|
2017-07-10 18:41:02 +00:00
|
|
|
|
Add desktop login test, revise and rename check_desktop
This adds a new test that implementsQA:Testcase_desktop_login
on both GNOME and KDE.
While working on this, we realized that the "desktop_clean"
needles were really "app menu" needles, and for KDE, this was
a duplication with the new "system menu" needles, because on KDE
the app menu and the system menu are the same. So I (Adam)
started to de-duplicate that, but also realized that "app menu
button" is a much more accurate name for these needles, so I was
renaming the old desktop_clean needles to app_menu_button. That
led me to the realization that "check_desktop_clean" is itself a
dumb name, because we don't (at least, any more, way back in the
mists of time we may have done) do anything to check that the
desktop is "clean" - we're really just asserting that we're at a
desktop *at all*. While thinking *that* through, I *also* realized
that the whole "open the overview and look for the app grid icon"
workaround it did is no longer necessary, because GNOME doesn't
use a translucent top bar any more. That went away in GNOME 3.32,
which is in Fedora 30, our oldest supported release.
So I threw that away, renamed the function "check_desktop",
cleaned up all the needle naming and tagging, and also added an
app menu needle for GNOME in Japanese because we were missing
one (the Japanese tests have been using the "app grid icon"
workaround the whole time).
2020-03-20 09:04:43 +00:00
|
|
|
sub check_desktop {
|
|
|
|
# Check we're at a desktop. We do this by looking for the "apps"
|
|
|
|
# menu button ("Activities" button on GNOME, kicker button on
|
2022-03-01 18:24:48 +00:00
|
|
|
# KDE). This is set up as a helper function so we can handle
|
|
|
|
# GNOME's behaviour of opening the overview on first login; all
|
|
|
|
# our tests were written when GNOME *didn't* do that, so it
|
|
|
|
# would be awkward to find all the places in them where we need
|
|
|
|
# to close the overview. Instead, we just have this function
|
|
|
|
# close it if it's open.
|
2020-04-18 21:54:48 +00:00
|
|
|
my %args = (
|
|
|
|
timeout => 30,
|
|
|
|
@_
|
|
|
|
);
|
2021-09-06 15:34:45 +00:00
|
|
|
my $count = 5;
|
|
|
|
my $activematched = 0;
|
|
|
|
while ($count > 0) {
|
|
|
|
$count -= 1;
|
|
|
|
assert_screen "apps_menu_button", $args{timeout};
|
2022-03-01 18:24:48 +00:00
|
|
|
if ($count == 4) {
|
|
|
|
# GNOME 42 shows the inactive menu button briefly before
|
|
|
|
# opening the overview. So we need to wait a bit on first
|
|
|
|
# cycle in case GNOME is about to open the overview.
|
|
|
|
wait_still_screen 5;
|
|
|
|
assert_screen "apps_menu_button";
|
|
|
|
}
|
|
|
|
# Here's where we detect if the overview is open and close it
|
2021-09-06 15:34:45 +00:00
|
|
|
if (match_has_tag "apps_menu_button_active") {
|
|
|
|
$activematched = 1;
|
|
|
|
wait_still_screen 5;
|
|
|
|
send_key "super";
|
|
|
|
wait_still_screen 5;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
# this means we saw 'inactive', which is what we want
|
|
|
|
last;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if ($activematched) {
|
|
|
|
# make sure we got to inactive after active
|
|
|
|
die "never reached apps_menu_button_inactive!" unless (match_has_tag "apps_menu_button_inactive");
|
2021-03-17 00:24:08 +00:00
|
|
|
}
|
2017-07-10 18:41:02 +00:00
|
|
|
}
|
2018-09-26 13:32:42 +00:00
|
|
|
|
|
|
|
sub download_modularity_tests {
|
2022-07-28 20:32:57 +00:00
|
|
|
# Download the modularity test script, place in the system and then
|
|
|
|
# modify the access rights to make it executable.
|
2019-07-17 17:40:03 +00:00
|
|
|
my ($whitelist) = @_;
|
2019-08-08 00:49:12 +00:00
|
|
|
# we need python3-yaml for the script to run
|
|
|
|
assert_script_run 'dnf -y install python3-yaml', 180;
|
2023-08-10 22:13:04 +00:00
|
|
|
assert_script_run 'curl --verbose --retry-delay 10 --max-time 30 --retry 5 -o /root/test.py https://pagure.io/fedora-qa/modularity_testing_scripts/raw/master/f/modular_functions.py', timeout => 180;
|
2019-07-10 08:47:10 +00:00
|
|
|
if ($whitelist eq 'whitelist') {
|
2023-08-10 22:13:04 +00:00
|
|
|
assert_script_run 'curl --verbose --retry-delay 10 --max-time 30 --retry 5 -o /root/whitelist https://pagure.io/fedora-qa/modularity_testing_scripts/raw/master/f/whitelist', timeout => 180;
|
2019-07-10 08:47:10 +00:00
|
|
|
}
|
2018-09-26 13:32:42 +00:00
|
|
|
assert_script_run 'chmod 755 /root/test.py';
|
|
|
|
}
|
2018-10-31 01:23:19 +00:00
|
|
|
|
|
|
|
sub quit_firefox {
|
2022-07-28 20:32:57 +00:00
|
|
|
# Quit Firefox, handling the 'close multiple tabs' warning screen if
|
|
|
|
# it shows up. Expects to quit to a recognizable console
|
2018-10-31 01:23:19 +00:00
|
|
|
send_key "ctrl-q";
|
|
|
|
# expect to get to either the tabs warning or a console
|
|
|
|
if (check_screen ["user_console", "root_console", "firefox_close_tabs"], 30) {
|
2022-06-07 01:31:57 +00:00
|
|
|
# if we hit a console we're good
|
|
|
|
unless (match_has_tag("firefox_close_tabs")) {
|
|
|
|
wait_still_screen 5;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
# otherwise we hit the tabs warning, click it
|
|
|
|
click_lastmatch;
|
|
|
|
# again, if we hit a console, we're good
|
|
|
|
if (check_screen ["user_console", "root_console"], 30) {
|
|
|
|
wait_still_screen 5;
|
|
|
|
return;
|
|
|
|
}
|
2020-01-10 22:41:41 +00:00
|
|
|
}
|
2022-06-07 01:31:57 +00:00
|
|
|
# if we reach here, we didn't see a console. This is most likely
|
|
|
|
# https://bugzilla.redhat.com/show_bug.cgi?id=2094137 . soft fail
|
|
|
|
# and reboot. this won't work if we need to decrypt or handle boot
|
|
|
|
# args, but I don't think anything that calls this needs it
|
|
|
|
record_soft_failure "No console on exit from Firefox, probably RHBZ #2094137";
|
|
|
|
power "reset";
|
|
|
|
boot_to_login_screen;
|
2022-07-28 20:32:57 +00:00
|
|
|
console_login(user => "root", password => get_var("ROOT_PASSWORD"));
|
2018-10-31 01:23:19 +00:00
|
|
|
}
|
2018-12-13 02:09:38 +00:00
|
|
|
|
2018-12-18 12:07:37 +00:00
|
|
|
sub start_with_launcher {
|
2022-07-28 20:32:57 +00:00
|
|
|
# Get the name of the needle with a launcher, find the launcher in the menu
|
|
|
|
# and click on it to start the application. This function works for the
|
|
|
|
# Gnome desktop.
|
2018-12-18 12:07:37 +00:00
|
|
|
|
|
|
|
# $launcher holds the launcher needle, but some of the apps are hidden in a submenu
|
|
|
|
# so this must be handled first to find the launcher needle.
|
2019-05-16 13:01:52 +00:00
|
|
|
|
2022-07-28 20:32:57 +00:00
|
|
|
my ($launcher, $submenu, $group) = @_;
|
2018-12-18 12:07:37 +00:00
|
|
|
$submenu //= '';
|
2019-01-29 14:40:52 +00:00
|
|
|
$group //= '';
|
|
|
|
my $desktop = get_var('DESKTOP');
|
2019-05-16 13:01:52 +00:00
|
|
|
|
2019-01-29 14:40:52 +00:00
|
|
|
my $item_to_check = $submenu || $launcher;
|
|
|
|
# The following varies for different desktops.
|
|
|
|
if ($desktop eq 'gnome') {
|
|
|
|
# Start the Activities page
|
2021-09-06 15:34:45 +00:00
|
|
|
send_key 'super';
|
2019-01-29 14:40:52 +00:00
|
|
|
wait_still_screen 5;
|
2018-12-18 12:07:37 +00:00
|
|
|
|
2019-01-29 14:40:52 +00:00
|
|
|
# Click on the menu icon to come into the menus
|
2019-06-25 21:00:28 +00:00
|
|
|
assert_and_click 'overview_app_grid';
|
2019-01-29 14:40:52 +00:00
|
|
|
wait_still_screen 5;
|
2018-12-18 12:07:37 +00:00
|
|
|
|
2019-05-16 13:01:52 +00:00
|
|
|
# Find the application launcher in the current menu page.
|
2019-01-29 14:40:52 +00:00
|
|
|
# If it cannot be found there, hit PageDown to go to another page.
|
2018-12-18 12:07:37 +00:00
|
|
|
|
2019-01-29 14:40:52 +00:00
|
|
|
send_key_until_needlematch($item_to_check, 'pgdn', 5, 3);
|
2018-12-18 12:07:37 +00:00
|
|
|
|
2019-01-29 14:40:52 +00:00
|
|
|
# If there was a submenu, click on that first.
|
|
|
|
if ($submenu) {
|
|
|
|
assert_and_click $submenu;
|
|
|
|
wait_still_screen 5;
|
|
|
|
}
|
|
|
|
# Click on the launcher
|
2020-03-17 12:07:52 +00:00
|
|
|
if (!check_screen($launcher)) {
|
2020-07-09 22:54:33 +00:00
|
|
|
# On F33+, this subwindow thingy scrolls horizontally,
|
|
|
|
# but only after we hit 'down' twice to get into it.
|
2021-08-09 22:09:15 +00:00
|
|
|
send_key 'down';
|
|
|
|
send_key 'down';
|
|
|
|
send_key_until_needlematch($launcher, 'right', 5, 6);
|
2020-03-17 12:07:52 +00:00
|
|
|
}
|
2019-01-29 14:40:52 +00:00
|
|
|
assert_and_click $launcher;
|
2018-12-18 12:07:37 +00:00
|
|
|
wait_still_screen 5;
|
|
|
|
}
|
2023-04-28 22:29:29 +00:00
|
|
|
else {
|
|
|
|
die "start_with_launcher is currently only implemented on GNOME!";
|
2019-05-16 13:01:52 +00:00
|
|
|
}
|
2018-12-18 12:07:37 +00:00
|
|
|
}
|
|
|
|
|
2019-01-29 14:40:52 +00:00
|
|
|
|
2018-12-18 12:07:37 +00:00
|
|
|
sub quit_with_shortcut {
|
2022-07-28 20:32:57 +00:00
|
|
|
# Quit the application using the Alt-F4 keyboard shortcut
|
2018-12-18 12:07:37 +00:00
|
|
|
send_key 'alt-f4';
|
|
|
|
wait_still_screen 5;
|
|
|
|
assert_screen 'workspace';
|
|
|
|
|
|
|
|
}
|
|
|
|
|
2022-12-09 23:02:43 +00:00
|
|
|
# For update tests (this only works if we've been through
|
|
|
|
# _repo_setup_updates), figure out which packages from the update
|
|
|
|
# are currently installed. This is here so we can do it both in
|
|
|
|
# _advisory_post and post_fail_hook.
|
2018-12-13 02:09:38 +00:00
|
|
|
sub advisory_get_installed_packages {
|
2023-07-04 20:13:15 +00:00
|
|
|
# can't do anything useful when testing a side tag
|
|
|
|
return if (get_var("TAG"));
|
2022-12-09 23:02:43 +00:00
|
|
|
# bail out if the file doesn't exist: this is in case we get
|
|
|
|
# here in the post-fail hook but we failed before creating it
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
return if script_run "test -f /mnt/updatepkgs.txt";
|
2023-02-22 23:55:24 +00:00
|
|
|
assert_script_run 'rpm -qa --qf "%{SOURCERPM} %{NAME} %{EPOCHNUM} %{VERSION} %{RELEASE}\n" | sort -u > /tmp/allpkgs.txt', timeout => 90;
|
2018-12-13 02:09:38 +00:00
|
|
|
# this finds lines which appear in both files
|
|
|
|
# http://www.unix.com/unix-for-dummies-questions-and-answers/34549-find-matching-lines-between-2-files.html
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
if (script_run 'comm -12 /tmp/allpkgs.txt /mnt/updatepkgs.txt > /mnt/testedpkgs.txt') {
|
2018-12-13 02:09:38 +00:00
|
|
|
# occasionally, for some reason, it's unhappy about sorting;
|
|
|
|
# we shouldn't fail the test in this case, just upload the
|
|
|
|
# files so we can see why...
|
2022-07-28 20:32:57 +00:00
|
|
|
upload_logs "/tmp/allpkgs.txt", failok => 1;
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
upload_logs "/mnt/updatepkgs.txt", failok => 1;
|
2018-12-13 02:09:38 +00:00
|
|
|
}
|
|
|
|
# we'll try and upload the output even if comm 'failed', as it
|
|
|
|
# does in fact still write it in some cases
|
Add tests to build a Silverblue installer image and install it
This is like the existing tests that build network install and
live images then install them, only for Silverblue. First we
build an ostree, using the standard configuration for the release
and subvariant but with the 'advisory' and 'workarounds' repos
included, so it will contain current stable packages plus the
packages from the update and any workarounds. Then we build an
ostree installer image with the ostree embedded, again including
advisory and workarounds repos in the installer build config so
packages from them will be included in the installer environment.
The image is uploaded, which completes the _ostree_build test.
Then an install_default_update_ostree test runs, which does a
standard install and boot from the installer image.
We do make a change that affects other tests, too. We now run
_advisory_post on live image install tests, as well as this new
ostree install image install test. It was skipped before because
of an exception that's really only needed for the netinst image
install test. In that test, packages from the update won't be
included in the installed system, so we can't run _advisory_post
on it. But for ostree and live image build/install tests, the
installed system *should* include packages from the update, so
we should check and make sure that it does.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-22 19:22:19 +00:00
|
|
|
upload_logs "/mnt/testedpkgs.txt", failok => 1;
|
2018-12-13 02:09:38 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
sub advisory_check_nonmatching_packages {
|
|
|
|
# For update tests (this only works if we've been through
|
|
|
|
# _repo_setup_updates), figure out if we have a different version
|
|
|
|
# of any package from the update installed - this indicates a
|
|
|
|
# problem, it likely means a dep issue meant dnf installed an
|
|
|
|
# older version from the frozen release repo
|
|
|
|
my %args = (
|
|
|
|
fatal => 1,
|
|
|
|
@_
|
|
|
|
);
|
2023-07-04 20:13:15 +00:00
|
|
|
# can't do anything useful when testing a side tag
|
|
|
|
return if (get_var("TAG"));
|
2022-12-09 23:02:43 +00:00
|
|
|
# bail out if the file doesn't exist: this is in case we get
|
|
|
|
# here in the post-fail hook but we failed before creating it
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
return if script_run "test -f /mnt/updatepkgnames.txt";
|
2018-12-13 02:09:38 +00:00
|
|
|
# if this fails in advisory_post, we don't want to do it *again*
|
|
|
|
# unnecessarily in post_fail_hook
|
|
|
|
return if (get_var("_ACNMP_DONE"));
|
|
|
|
script_run 'touch /tmp/installedupdatepkgs.txt';
|
2018-12-14 02:52:51 +00:00
|
|
|
# this creates /tmp/installedupdatepkgs.txt as a sorted list of installed
|
|
|
|
# packages with the same name as packages from the update, in the same form
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
# as /mnt/updatepkgs.txt. The '--last | head -1' tries to handle the
|
2022-02-25 21:07:46 +00:00
|
|
|
# problem of installonly packages like the kernel, where we wind up with
|
|
|
|
# *multiple* versions installed after the update; the first line of output
|
|
|
|
# for any given package with --last is the most recent version, i.e. the
|
|
|
|
# one in the update. The sed replaces the caret - "^" - with "\^" (literal
|
|
|
|
# slash then a caret) in the package NVRA; this is necessary to workaround
|
|
|
|
# a bug in RPM - https://bugzilla.redhat.com/show_bug.cgi?id=2002038 . It
|
2022-02-25 22:05:10 +00:00
|
|
|
# can be removed when that bug is fixed. Yes, it really needs eight slashes
|
|
|
|
# (we need four to reach bash, and half of them get eaten by perl or
|
|
|
|
# something along the way). Yes, it only works with *single* quotes. Yes,
|
|
|
|
# I hate escaping
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
script_run 'for pkg in $(cat /mnt/updatepkgnames.txt); do rpm -q $pkg && rpm -q $pkg --last | head -1 | cut -d" " -f1 | sed -e \'s,\^,\\\\\\\\^,g\' | xargs rpm -q --qf "%{SOURCERPM} %{NAME} %{EPOCHNUM} %{VERSION} %{RELEASE}\n" >> /tmp/installedupdatepkgs.txt; done', timeout => 180;
|
2018-12-13 02:09:38 +00:00
|
|
|
script_run 'sort -u -o /tmp/installedupdatepkgs.txt /tmp/installedupdatepkgs.txt';
|
2020-09-08 21:03:23 +00:00
|
|
|
# for debugging, may as well always upload these, can't hurt anything
|
2022-07-28 20:32:57 +00:00
|
|
|
upload_logs "/tmp/installedupdatepkgs.txt", failok => 1;
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
upload_logs "/mnt/updatepkgs.txt", failok => 1;
|
Make the update non-matching package check smarter
With Rawhide updates, we quite often run into a situation where
a test runs after a *later* version of the package has already
gone stable. This even happens for stable releases too, though
less often. The current shell-based check just always fails on
this case, but it's usually OK, and manually marking every case
like this with an "it's OK!" comment gets tiring. Instead, let's
use a smarter Python script to do the check. We compare the EVR
of all installed update packages with the EVR of the package
from the update. If it's the same, fine. If the installed package
is lower-versioned, that's always an error, and we fail. If the
installed package is higher-versioned, we check whether the
update already went stable. If it did, then we soft fail, because
probably nothing can go wrong at this point (this is the usual
Rawhide case). If the update did not yet go stable, we still
hard fail, because something can go wrong in this case: if the
update *now* goes stable, the older version from the update may
be tagged over the newer version the test got (presumably from
current stable).
If anything goes wrong with the Bodhi check, or the test is
running on a task not an advisory, we treat both cases as fatal.
The script also gives easier-to-understand output than the old
approach, which should be a bonus.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-01-31 01:37:06 +00:00
|
|
|
# download the check script and run it
|
2023-08-10 22:13:04 +00:00
|
|
|
assert_script_run 'curl --verbose --retry-delay 10 --max-time 30 --retry 5 -o updvercheck.py https://pagure.io/fedora-qa/os-autoinst-distri-fedora/raw/main/f/updvercheck.py', timeout => 180;
|
Make the update non-matching package check smarter
With Rawhide updates, we quite often run into a situation where
a test runs after a *later* version of the package has already
gone stable. This even happens for stable releases too, though
less often. The current shell-based check just always fails on
this case, but it's usually OK, and manually marking every case
like this with an "it's OK!" comment gets tiring. Instead, let's
use a smarter Python script to do the check. We compare the EVR
of all installed update packages with the EVR of the package
from the update. If it's the same, fine. If the installed package
is lower-versioned, that's always an error, and we fail. If the
installed package is higher-versioned, we check whether the
update already went stable. If it did, then we soft fail, because
probably nothing can go wrong at this point (this is the usual
Rawhide case). If the update did not yet go stable, we still
hard fail, because something can go wrong in this case: if the
update *now* goes stable, the older version from the update may
be tagged over the newer version the test got (presumably from
current stable).
If anything goes wrong with the Bodhi check, or the test is
running on a task not an advisory, we treat both cases as fatal.
The script also gives easier-to-understand output than the old
approach, which should be a bonus.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-01-31 01:37:06 +00:00
|
|
|
my $advisory = get_var("ADVISORY");
|
Revert to having tests, not the scheduler, download packages (#108)
This effectively reverts 97618193 - but had to be done manually
and adjusted to maintain support for testing side tags and for
testing multiple tasks, since those features were added since
the update ISO change.
The 'scheduler injects ISOs of packages into the tests' approach
was intended to speed things up, especially for large updates,
and it did, but it had a few drawbacks. It means restarting
older tests from the web UI doesn't work as the ISOs get garbage
collected (you have to re-schedule in this case). And it has the
rather large problem that you can now only schedule tests from
the openQA server (or at least a machine with the openQA asset
share mounted), because the package download and ISO creation
just happen wherever the scheduler is running and assume that
the openQA asset share that will be used by the tests is at
/var/lib/openqa/share in that filesystem.
That's too big of a drawback to continue with this approach, IMO,
so this reverts back to the old way of doing things, with a bit
of refactoring to clean up the flow a little, and with support
for testing side tags and multiple tasks maintained.
As a follow-up I'm going to see if I can replace
_download_packages with a much more efficient downloader script
to mitigate the time this process takes on each test, especially
for large updates.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-01-05 19:41:50 +00:00
|
|
|
my $cmd = 'python3 ./updvercheck.py /mnt/updatepkgs.txt /tmp/installedupdatepkgs.txt';
|
Make the update non-matching package check smarter
With Rawhide updates, we quite often run into a situation where
a test runs after a *later* version of the package has already
gone stable. This even happens for stable releases too, though
less often. The current shell-based check just always fails on
this case, but it's usually OK, and manually marking every case
like this with an "it's OK!" comment gets tiring. Instead, let's
use a smarter Python script to do the check. We compare the EVR
of all installed update packages with the EVR of the package
from the update. If it's the same, fine. If the installed package
is lower-versioned, that's always an error, and we fail. If the
installed package is higher-versioned, we check whether the
update already went stable. If it did, then we soft fail, because
probably nothing can go wrong at this point (this is the usual
Rawhide case). If the update did not yet go stable, we still
hard fail, because something can go wrong in this case: if the
update *now* goes stable, the older version from the update may
be tagged over the newer version the test got (presumably from
current stable).
If anything goes wrong with the Bodhi check, or the test is
running on a task not an advisory, we treat both cases as fatal.
The script also gives easier-to-understand output than the old
approach, which should be a bonus.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-01-31 01:37:06 +00:00
|
|
|
$cmd .= " $advisory" if ($advisory);
|
|
|
|
my $ret = script_run $cmd;
|
|
|
|
# 2 is warnings only, 3 is problems, 1 means the script died in
|
|
|
|
# some other way (probably a bug)
|
|
|
|
if ($ret == 2) {
|
|
|
|
record_soft_failure "Some update package(s) not installed, but this is probably OK, see script output";
|
2018-12-13 02:09:38 +00:00
|
|
|
}
|
Make the update non-matching package check smarter
With Rawhide updates, we quite often run into a situation where
a test runs after a *later* version of the package has already
gone stable. This even happens for stable releases too, though
less often. The current shell-based check just always fails on
this case, but it's usually OK, and manually marking every case
like this with an "it's OK!" comment gets tiring. Instead, let's
use a smarter Python script to do the check. We compare the EVR
of all installed update packages with the EVR of the package
from the update. If it's the same, fine. If the installed package
is lower-versioned, that's always an error, and we fail. If the
installed package is higher-versioned, we check whether the
update already went stable. If it did, then we soft fail, because
probably nothing can go wrong at this point (this is the usual
Rawhide case). If the update did not yet go stable, we still
hard fail, because something can go wrong in this case: if the
update *now* goes stable, the older version from the update may
be tagged over the newer version the test got (presumably from
current stable).
If anything goes wrong with the Bodhi check, or the test is
running on a task not an advisory, we treat both cases as fatal.
The script also gives easier-to-understand output than the old
approach, which should be a bonus.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-01-31 01:37:06 +00:00
|
|
|
if ($ret == 1 || $ret == 3) {
|
|
|
|
my $message = "Package(s) from update not installed when it should have been! See script output";
|
|
|
|
$message = "Script failed unexpectedly!" if ($ret == 1);
|
2018-12-13 02:09:38 +00:00
|
|
|
if ($args{fatal}) {
|
|
|
|
set_var("_ACNMP_DONE", "1");
|
|
|
|
die $message;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
# if we're already in post_fail_hook, we don't want to die again
|
|
|
|
record_info $message;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2019-04-10 08:11:38 +00:00
|
|
|
|
|
|
|
sub select_rescue_mode {
|
|
|
|
# handle bootloader screen
|
|
|
|
assert_screen "bootloader", 30;
|
|
|
|
if (get_var('OFW')) {
|
|
|
|
# select "rescue system" directly
|
|
|
|
send_key "down";
|
|
|
|
send_key "down";
|
|
|
|
send_key "ret";
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
# select troubleshooting
|
|
|
|
send_key "down";
|
|
|
|
send_key "ret";
|
|
|
|
# select "rescue system"
|
|
|
|
if (get_var('UEFI')) {
|
|
|
|
send_key "down";
|
|
|
|
# we need this on aarch64 till #1661288 is resolved
|
|
|
|
if (get_var('ARCH') eq 'aarch64') {
|
|
|
|
send_key "e";
|
|
|
|
# duped with do_bootloader, sadly...
|
|
|
|
for (1 .. 50) {
|
|
|
|
send_key 'down';
|
|
|
|
}
|
|
|
|
sleep 1;
|
|
|
|
send_key 'up';
|
|
|
|
sleep 1;
|
|
|
|
send_key 'up';
|
|
|
|
send_key "end";
|
|
|
|
type_safely " console=tty0";
|
|
|
|
send_key "ctrl-x";
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
send_key "ret";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
type_string "r\n";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-07-28 20:32:57 +00:00
|
|
|
assert_screen "rescue_select", 180; # it takes time to start anaconda
|
2019-04-10 08:11:38 +00:00
|
|
|
}
|
2019-02-04 14:46:31 +00:00
|
|
|
|
|
|
|
sub copy_devcdrom_as_isofile {
|
|
|
|
# copy /dev/cdrom as iso file and verify checksum is same
|
|
|
|
# as cdrom previously retrieved from ISO_URL
|
|
|
|
my $isoname = shift;
|
|
|
|
assert_script_run "dd if=/dev/cdrom of=$isoname", 360;
|
|
|
|
# verify iso checksum
|
|
|
|
my $cdurl = get_var('ISO_URL');
|
2019-08-16 02:05:59 +00:00
|
|
|
# ISO_URL may not be set if we POSTed manually or something; just assume
|
|
|
|
# we're OK in that case
|
|
|
|
return unless $cdurl;
|
2019-02-04 14:46:31 +00:00
|
|
|
my $cmd = <<EOF;
|
|
|
|
urld="$cdurl"; urld=\${urld%/*}; chkf=\$(curl -fs \$urld/ |grep CHECKSUM | sed -E 's/.*href=.//; s/\".*//') && curl -f \$urld/\$chkf -o /tmp/x
|
|
|
|
chkref=\$(grep -E 'SHA256.*dvd' /tmp/x | sed -e 's/.*= //') && echo "\$chkref $isoname" >/tmp/x
|
|
|
|
sha256sum -c /tmp/x
|
|
|
|
EOF
|
|
|
|
assert_script_run($_) foreach (split /\n/, $cmd);
|
|
|
|
}
|
2019-03-21 09:22:35 +00:00
|
|
|
|
2020-07-09 00:09:45 +00:00
|
|
|
sub menu_launch_type {
|
|
|
|
# Launch an application in a graphical environment, by opening a
|
|
|
|
# launcher, typing the specified string and hitting enter. Pass
|
|
|
|
# the string to be typed to launch whatever it is you want.
|
|
|
|
my $app = shift;
|
2022-06-15 07:50:51 +00:00
|
|
|
# To overcome BZ2097208, let's move the mouse out of the way
|
|
|
|
# and give the launcher some time to take the correct focus.
|
|
|
|
if (get_var("DESKTOP") eq "kde") {
|
|
|
|
diag("Moving the mouse away from the launcher.");
|
|
|
|
mouse_set(1, 1);
|
|
|
|
}
|
2021-09-06 15:34:45 +00:00
|
|
|
send_key 'super';
|
2020-07-09 00:09:45 +00:00
|
|
|
# srsly KDE y u so slo
|
|
|
|
wait_still_screen 3;
|
|
|
|
type_very_safely $app;
|
2022-06-15 07:50:51 +00:00
|
|
|
# Wait for KDE to place focus correctly.
|
|
|
|
sleep 2;
|
2020-07-09 00:09:45 +00:00
|
|
|
send_key 'ret';
|
|
|
|
}
|
|
|
|
|
2019-05-16 13:01:52 +00:00
|
|
|
sub tell_source {
|
|
|
|
# This helper function identifies the Subvariant of the tested system.
|
|
|
|
# For the purposes of identification testing, we are only interested
|
|
|
|
# if the system is Workstation, Server, or something else, because,
|
|
|
|
# except Workstation and Server, there are no graphical differences
|
|
|
|
# between various spins and isos.
|
|
|
|
my $iso = get_var('SUBVARIANT');
|
2022-10-28 18:57:33 +00:00
|
|
|
$iso = lc($iso);
|
2022-10-28 19:06:57 +00:00
|
|
|
if ($iso eq 'workstation' or $iso eq 'server') {
|
|
|
|
# do nothing, but don't hit else
|
|
|
|
}
|
|
|
|
elsif ($iso eq 'atomichost') {
|
2019-05-16 13:01:52 +00:00
|
|
|
$iso = 'atomic';
|
|
|
|
}
|
2022-10-28 18:57:33 +00:00
|
|
|
elsif ($iso eq 'silverblue') {
|
2019-08-21 07:01:47 +00:00
|
|
|
$iso = 'workstation';
|
|
|
|
}
|
2019-05-16 13:01:52 +00:00
|
|
|
else {
|
|
|
|
$iso = 'generic';
|
|
|
|
}
|
|
|
|
return $iso;
|
|
|
|
}
|
|
|
|
|
|
|
|
sub check_left_bar {
|
|
|
|
# This method is used by identification tests to check whether the Anaconda
|
|
|
|
# bar on the left side of the screen corresponds with the correct version.
|
|
|
|
# It looks different for Server, Workstation and others.
|
|
|
|
my $source = tell_source;
|
|
|
|
assert_screen "leftbar_${source}";
|
|
|
|
}
|
|
|
|
|
|
|
|
sub check_top_bar {
|
|
|
|
# This method is used by identification tests to check whether the
|
|
|
|
# top bar in Anaconda corresponds with the correct version of the spin.
|
|
|
|
my $source = tell_source;
|
|
|
|
assert_screen "topbar_${source}";
|
|
|
|
}
|
|
|
|
|
|
|
|
sub check_prerelease {
|
|
|
|
# This method is used by identification tests to check if
|
2020-05-07 22:42:08 +00:00
|
|
|
# Anaconda shows the PRERELEASE tag on various screens. These are
|
|
|
|
# the rules anaconda follows for deciding whether to do this, as
|
|
|
|
# of 2020-05-07:
|
|
|
|
|
|
|
|
# 1. If there's a /.buildstamp and/or /tmp/product/.buildstamp file
|
|
|
|
# the installer environment, and/or the environment variable
|
|
|
|
# PRODBUILDPATH is set and points to a file that exists, it reads
|
|
|
|
# config from those file(s), in that order of precedence, and if
|
|
|
|
# the key 'IsFinal' exists in the section 'Main', its value is
|
|
|
|
# used as anaconda's `product.isFinal`. Installer images built by
|
|
|
|
# lorax have this buildstamp file, and it always sets IsFinal: if
|
|
|
|
# --isfinal was passed to lorax it is set to True, if not it is set
|
|
|
|
# to False. Whether lorax is run with --isfinal can be specified
|
|
|
|
# in the Pungi config, but there's also a heuristic: it usually
|
|
|
|
# defaults to False, but if the compose has a label and it's an
|
|
|
|
# 'RC' or 'Update' or 'SecurityFix' compose (see definition of
|
|
|
|
# SUPPORTED_MILESTONES in productmd.composeinfo), the default is
|
|
|
|
# True. AFAICS, Fedora's pungi configs don't explicitly set this,
|
|
|
|
# but rely on the heuristic. So for installer images, we expect
|
|
|
|
# isFinal to be True for RC candidate composes and post-release
|
|
|
|
# nightly Cloud, IoT etc. composes (these are also marked as 'RC'
|
|
|
|
# composes), but False for Rawhide and Branched nightly composes
|
|
|
|
# and Beta candidate composes. For installer images built by our
|
|
|
|
# own _installer_build test, we control whether --isfinal is set
|
|
|
|
# or not; we pass it if the update is for a stable release, we do
|
|
|
|
# not pass it if the update is for Branched. Live images do not
|
|
|
|
# have the buildstamp file.
|
|
|
|
|
|
|
|
# 2. If there's no buildstamp file, the value of the environment
|
|
|
|
# variable ANACONDA_ISFINAL is used as `product.isFinal`, default
|
|
|
|
# of False if that environment var is not set. The live installer
|
|
|
|
# wrapper script sets ANACONDA_ISFINAL based on the release field
|
|
|
|
# of whatever package provides system-release: if it starts with
|
|
|
|
# "0.", it sets ANACONA_ISFINAL to "false", otherwise it sets it
|
|
|
|
# to "true". So for live images, we expect isFinal to be True
|
|
|
|
# unless the fedora-release-common package release starts with 0.
|
|
|
|
|
|
|
|
# 3. If `product.isFinal` is False, the pre-release warning and
|
|
|
|
# tags are shown; if it is False, they are not shown.
|
|
|
|
|
|
|
|
# We don't really need to check this stuff for update tests, as
|
|
|
|
# the only installer images we test on updates are ones we build
|
|
|
|
# ourselves; there's no value to this check for those really.
|
|
|
|
# For compose tests, we will expect to see the pre-release tags if
|
|
|
|
# the compose is Rawhide, or a Beta candidate, or it's a nightly
|
|
|
|
# and we're checking an installer image. If it's an RC or Updates
|
|
|
|
# candidate, or a respin release, we expect NOT to see the tags.
|
|
|
|
# If it's a nightly and we're checking a live image, we don't do
|
|
|
|
# the check.
|
|
|
|
|
|
|
|
# bail if this is an update test
|
2022-10-22 21:10:13 +00:00
|
|
|
return if (get_var("ADVISORY_OR_TASK"));
|
2020-05-07 22:42:08 +00:00
|
|
|
|
|
|
|
# 0 means "tags MUST NOT be shown", 1 means "tags MUST be shown",
|
|
|
|
# any other value means we don't care
|
|
|
|
my $prerelease = 10;
|
|
|
|
|
|
|
|
# if this is RC or update compose we absolutely *MUST NOT* see tags
|
|
|
|
my $label = get_var("LABEL");
|
|
|
|
$prerelease = 0 if ($label =~ /^(RC|Update)-/);
|
|
|
|
# if it's a Beta compose we *MUST* see tags
|
|
|
|
$prerelease = 1 if ($label =~ /^Beta-/);
|
2019-05-16 13:01:52 +00:00
|
|
|
my $version = get_var('VERSION');
|
2020-05-07 22:42:08 +00:00
|
|
|
# if it's Rawhide we *MUST* see tags
|
|
|
|
$prerelease = 1 if ($version eq "Rawhide");
|
|
|
|
my $build = get_var('BUILD');
|
|
|
|
# if it's a nightly installer image we should see tags
|
|
|
|
$prerelease = 1 if ($build =~ /\.n\.\d+/ && !get_var("LIVE"));
|
|
|
|
# if it's a respin compose we *MUST NOT* see tags
|
|
|
|
$prerelease = 0 if ($build =~ /Respin/);
|
|
|
|
# we *could* go to a console and parse fedora-release-common
|
|
|
|
# to decide if a nightly live image should have tags or not, but
|
|
|
|
# it seems absurd as we're almost reinventing the code that
|
|
|
|
# decides whether to show the tags, at that point, and it's not
|
|
|
|
# really a big deal either way whether a nightly live image has
|
|
|
|
# the tags or not. So we don't.
|
|
|
|
|
2019-05-16 13:01:52 +00:00
|
|
|
# For all prerelease requiring ISOs, assert that prerelease is there.
|
|
|
|
if ($prerelease == 1) {
|
|
|
|
assert_screen "prerelease_note";
|
|
|
|
}
|
|
|
|
elsif ($prerelease == 0) {
|
2022-07-28 20:32:57 +00:00
|
|
|
# If the prerelease note is shown, where it should not be, die!
|
|
|
|
if (check_screen "prerelease_note") {
|
2019-05-16 13:01:52 +00:00
|
|
|
die "The PRERELEASE tag is shown, but it should NOT be.";
|
2022-07-28 20:32:57 +00:00
|
|
|
}
|
2019-05-16 13:01:52 +00:00
|
|
|
}
|
2019-05-22 22:18:08 +00:00
|
|
|
}
|
2019-05-28 16:41:33 +00:00
|
|
|
|
2019-05-16 13:01:52 +00:00
|
|
|
sub check_version {
|
|
|
|
# This function checks if the correct version is display during installation
|
|
|
|
# in Anaconda, i.e. nonlive media showing Rawhide when Rawhide and version numbers
|
|
|
|
# when not Rawhide, while live media always showing version numbers.
|
|
|
|
|
|
|
|
my $version = lc(get_var('VERSION'));
|
|
|
|
if ($version eq 'rawhide' && get_var('LIVE')) {
|
|
|
|
$version = get_var('RAWREL');
|
|
|
|
}
|
|
|
|
assert_screen "version_${version}_ident";
|
|
|
|
}
|
|
|
|
|
|
|
|
sub spell_version_number {
|
|
|
|
my $version = shift;
|
2019-08-21 19:15:59 +00:00
|
|
|
# spelt version of Rawhide is...Rawhide
|
|
|
|
return "Rawhide" if ($version eq 'Rawhide');
|
2019-05-16 13:01:52 +00:00
|
|
|
my %ones = (
|
|
|
|
"0" => "Zero",
|
|
|
|
"1" => "One",
|
|
|
|
"2" => "Two",
|
|
|
|
"3" => "Three",
|
|
|
|
"4" => "Four",
|
|
|
|
"5" => "Five",
|
|
|
|
"6" => "Six",
|
|
|
|
"7" => "Seven",
|
|
|
|
"8" => "Eight",
|
|
|
|
"9" => "Nine",
|
|
|
|
);
|
|
|
|
my %tens = (
|
|
|
|
"2" => "Twenty",
|
|
|
|
"3" => "Thirty",
|
|
|
|
"4" => "Fourty",
|
|
|
|
"5" => "Fifty",
|
|
|
|
"6" => "Sixty",
|
|
|
|
"7" => "Seventy",
|
|
|
|
"8" => "Eighty",
|
|
|
|
"9" => "Ninety",
|
|
|
|
);
|
|
|
|
|
|
|
|
my $ten = substr($version, 0, 1);
|
|
|
|
my $one = substr($version, 1, 1);
|
|
|
|
my $speltnum = "";
|
|
|
|
if ($one eq "0") {
|
|
|
|
$speltnum = "$tens{$ten}";
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
$speltnum = "$tens{$ten} $ones{$one}";
|
|
|
|
}
|
|
|
|
return $speltnum;
|
|
|
|
}
|
|
|
|
|
|
|
|
sub rec_log {
|
2019-08-21 19:15:59 +00:00
|
|
|
my ($line, $condition, $failref, $filename) = @_;
|
|
|
|
$filename ||= '/tmp/os-release.log';
|
2019-05-16 13:01:52 +00:00
|
|
|
if ($condition) {
|
|
|
|
$line = "${line} - SUCCEEDED\n";
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
push @$failref, $line;
|
|
|
|
$line = "${line} - FAILED\n";
|
|
|
|
}
|
2019-08-21 19:15:59 +00:00
|
|
|
script_run "echo \"$line\" >> $filename";
|
2019-05-16 13:01:52 +00:00
|
|
|
|
|
|
|
}
|
|
|
|
|
2019-09-19 14:03:50 +00:00
|
|
|
# In each application test, when the application is started successfully, it
|
|
|
|
# will register to the list of applications.
|
|
|
|
sub register_application {
|
|
|
|
my $application = shift;
|
|
|
|
push(@application_list, $application);
|
|
|
|
print("APPLICATION REGISTERED: $application \n");
|
|
|
|
}
|
|
|
|
|
Add desktop login test, revise and rename check_desktop
This adds a new test that implementsQA:Testcase_desktop_login
on both GNOME and KDE.
While working on this, we realized that the "desktop_clean"
needles were really "app menu" needles, and for KDE, this was
a duplication with the new "system menu" needles, because on KDE
the app menu and the system menu are the same. So I (Adam)
started to de-duplicate that, but also realized that "app menu
button" is a much more accurate name for these needles, so I was
renaming the old desktop_clean needles to app_menu_button. That
led me to the realization that "check_desktop_clean" is itself a
dumb name, because we don't (at least, any more, way back in the
mists of time we may have done) do anything to check that the
desktop is "clean" - we're really just asserting that we're at a
desktop *at all*. While thinking *that* through, I *also* realized
that the whole "open the overview and look for the app grid icon"
workaround it did is no longer necessary, because GNOME doesn't
use a translucent top bar any more. That went away in GNOME 3.32,
which is in Fedora 30, our oldest supported release.
So I threw that away, renamed the function "check_desktop",
cleaned up all the needle naming and tagging, and also added an
app menu needle for GNOME in Japanese because we were missing
one (the Japanese tests have been using the "app grid icon"
workaround the whole time).
2020-03-20 09:04:43 +00:00
|
|
|
# The KDE desktop tests are very difficult to maintain, because the transparency
|
2022-07-28 20:32:57 +00:00
|
|
|
# of the menu requires a lot of different needles to cover the elements.
|
|
|
|
# Therefore it is useful to change the background to a solid colour.
|
Add desktop login test, revise and rename check_desktop
This adds a new test that implementsQA:Testcase_desktop_login
on both GNOME and KDE.
While working on this, we realized that the "desktop_clean"
needles were really "app menu" needles, and for KDE, this was
a duplication with the new "system menu" needles, because on KDE
the app menu and the system menu are the same. So I (Adam)
started to de-duplicate that, but also realized that "app menu
button" is a much more accurate name for these needles, so I was
renaming the old desktop_clean needles to app_menu_button. That
led me to the realization that "check_desktop_clean" is itself a
dumb name, because we don't (at least, any more, way back in the
mists of time we may have done) do anything to check that the
desktop is "clean" - we're really just asserting that we're at a
desktop *at all*. While thinking *that* through, I *also* realized
that the whole "open the overview and look for the app grid icon"
workaround it did is no longer necessary, because GNOME doesn't
use a translucent top bar any more. That went away in GNOME 3.32,
which is in Fedora 30, our oldest supported release.
So I threw that away, renamed the function "check_desktop",
cleaned up all the needle naming and tagging, and also added an
app menu needle for GNOME in Japanese because we were missing
one (the Japanese tests have been using the "app grid icon"
workaround the whole time).
2020-03-20 09:04:43 +00:00
|
|
|
# Since many needles have been already created with a black background
|
|
|
|
# we will keep it that way. The following code has been taken from the
|
|
|
|
# KDE startstop tests but it is good to have it here, because it will be
|
|
|
|
# needed more often now, it seems.
|
2020-04-28 09:12:43 +00:00
|
|
|
sub solidify_wallpaper {
|
|
|
|
my $desktop = get_var("DESKTOP");
|
2020-05-05 17:08:47 +00:00
|
|
|
if ($desktop eq "kde") {
|
2022-07-28 20:32:57 +00:00
|
|
|
# Run the Desktop settings
|
2020-04-28 09:12:43 +00:00
|
|
|
hold_key 'alt';
|
|
|
|
send_key 'd';
|
|
|
|
send_key 's';
|
|
|
|
release_key 'alt';
|
2021-09-29 16:52:59 +00:00
|
|
|
# give the window a few seconds to stabilize
|
|
|
|
wait_still_screen 3;
|
2020-04-28 09:12:43 +00:00
|
|
|
# Select type of background
|
|
|
|
assert_and_click "deskset_select_type";
|
|
|
|
wait_still_screen 2;
|
|
|
|
# Select plain color type
|
|
|
|
assert_and_click "deskset_plain_color";
|
|
|
|
wait_still_screen 2;
|
|
|
|
# Open colors selection
|
|
|
|
assert_and_click "deskset_select_color";
|
|
|
|
wait_still_screen 2;
|
|
|
|
# Select black
|
2023-11-29 18:58:51 +00:00
|
|
|
assert_and_dclick "deskset_html_color";
|
|
|
|
wait_still_screen 2;
|
|
|
|
type_safely "000000";
|
2020-04-28 09:12:43 +00:00
|
|
|
wait_still_screen 2;
|
|
|
|
# Confirm
|
|
|
|
assert_and_click "kde_ok";
|
|
|
|
wait_still_screen 2;
|
|
|
|
# Close the application
|
|
|
|
assert_and_click "kde_ok";
|
|
|
|
}
|
|
|
|
elsif ($desktop eq "gnome") {
|
|
|
|
# Start the terminal to set up backgrounds.
|
|
|
|
menu_launch_type "gnome-terminal";
|
2020-05-05 17:19:31 +00:00
|
|
|
# wait to be sure it's fully open
|
2022-07-28 20:32:57 +00:00
|
|
|
wait_still_screen(stilltime => 5, similarity_level => 38);
|
2020-04-28 09:12:43 +00:00
|
|
|
# When the application opens, run command in it to set the background to black
|
|
|
|
type_very_safely "gsettings set org.gnome.desktop.background picture-uri ''";
|
|
|
|
send_key 'ret';
|
2022-07-28 20:32:57 +00:00
|
|
|
wait_still_screen(stilltime => 2, similarity_level => 38);
|
2020-04-28 09:12:43 +00:00
|
|
|
type_very_safely "gsettings set org.gnome.desktop.background primary-color '#000000'";
|
|
|
|
send_key 'ret';
|
2022-07-28 20:32:57 +00:00
|
|
|
wait_still_screen(stilltime => 2, similarity_level => 38);
|
2020-04-28 09:12:43 +00:00
|
|
|
quit_with_shortcut();
|
|
|
|
# check that is has changed color
|
|
|
|
assert_screen 'apps_settings_screen_black';
|
|
|
|
}
|
Add desktop login test, revise and rename check_desktop
This adds a new test that implementsQA:Testcase_desktop_login
on both GNOME and KDE.
While working on this, we realized that the "desktop_clean"
needles were really "app menu" needles, and for KDE, this was
a duplication with the new "system menu" needles, because on KDE
the app menu and the system menu are the same. So I (Adam)
started to de-duplicate that, but also realized that "app menu
button" is a much more accurate name for these needles, so I was
renaming the old desktop_clean needles to app_menu_button. That
led me to the realization that "check_desktop_clean" is itself a
dumb name, because we don't (at least, any more, way back in the
mists of time we may have done) do anything to check that the
desktop is "clean" - we're really just asserting that we're at a
desktop *at all*. While thinking *that* through, I *also* realized
that the whole "open the overview and look for the app grid icon"
workaround it did is no longer necessary, because GNOME doesn't
use a translucent top bar any more. That went away in GNOME 3.32,
which is in Fedora 30, our oldest supported release.
So I threw that away, renamed the function "check_desktop",
cleaned up all the needle naming and tagging, and also added an
app menu needle for GNOME in Japanese because we were missing
one (the Japanese tests have been using the "app grid icon"
workaround the whole time).
2020-03-20 09:04:43 +00:00
|
|
|
}
|
|
|
|
|
2020-01-09 12:54:54 +00:00
|
|
|
# This routine is used in Desktop test suites, such as Evince or Gedit.
|
|
|
|
# It checks if git is installed and installs it, if necessary.
|
|
|
|
sub check_and_install_git {
|
|
|
|
unless (get_var("CANNED")) {
|
|
|
|
if (script_run("rpm -q git")) {
|
|
|
|
assert_script_run("dnf install -y git");
|
2022-07-28 20:32:57 +00:00
|
|
|
}
|
2020-01-09 12:54:54 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
# This routine is used in Desktop test suites. It downloads the test data from
|
2022-07-01 12:40:10 +00:00
|
|
|
# the repository and populates the directory structure.
|
|
|
|
# The data repository is located at https://pagure.io/fedora-qa/openqa_testdata.
|
|
|
|
|
2020-01-09 12:54:54 +00:00
|
|
|
sub download_testdata {
|
2023-09-12 12:54:56 +00:00
|
|
|
# We can select which Data to copy over.
|
|
|
|
my $data = shift;
|
|
|
|
$data = 'structure' unless ($data);
|
2022-07-01 12:40:10 +00:00
|
|
|
# Navigate to the user's home directory
|
|
|
|
my $user = get_var("USER_LOGIN") // "test";
|
|
|
|
assert_script_run("cd /home/$user/");
|
|
|
|
# Create a temporary directory to unpack the zipped file.
|
|
|
|
assert_script_run("mkdir temp");
|
|
|
|
assert_script_run("cd temp");
|
|
|
|
# Download the compressed file with the repository content.
|
2023-08-10 22:13:04 +00:00
|
|
|
assert_script_run("curl --verbose --retry-delay 10 --max-time 120 --retry 5 -o repository.tar.gz https://pagure.io/fedora-qa/openqa_testdata/blob/thetree/f/repository.tar.gz", timeout => 600);
|
2022-07-01 12:40:10 +00:00
|
|
|
# Untar it.
|
|
|
|
assert_script_run("tar -zxvf repository.tar.gz");
|
|
|
|
# Copy out the files into the VMs directory structure.
|
2023-09-12 12:54:56 +00:00
|
|
|
if ($data eq "structure") {
|
|
|
|
assert_script_run("cp music/* /home/$user/Music");
|
|
|
|
assert_script_run("cp documents/* /home/$user/Documents");
|
|
|
|
assert_script_run("cp pictures/* /home/$user/Pictures");
|
|
|
|
assert_script_run("cp video/* /home/$user/Videos");
|
|
|
|
assert_script_run("cp reference/* /home/$user/");
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
assert_script_run("mkdir /home/$user/$data");
|
|
|
|
assert_script_run("cp $data/* /home/$user/$data/");
|
|
|
|
}
|
2022-07-01 12:40:10 +00:00
|
|
|
# Delete the temporary directory and the downloaded file.
|
|
|
|
assert_script_run("cd");
|
|
|
|
assert_script_run("rm -rf /home/$user/temp");
|
2020-01-09 12:54:54 +00:00
|
|
|
# Change ownership
|
2022-07-01 12:40:10 +00:00
|
|
|
assert_script_run("chown -R test:test /home/$user/");
|
2020-01-09 12:54:54 +00:00
|
|
|
}
|
|
|
|
|
2021-12-23 12:08:13 +00:00
|
|
|
# On Fedora, the serial console is not writable for regular users which lames
|
|
|
|
# some of the openQA commands that send messages to the serial console to check
|
|
|
|
# that a command has finished, for example assert_script_run, etc.
|
2022-07-28 20:32:57 +00:00
|
|
|
# This routine changes the rights on the serial console file and makes it
|
|
|
|
# writable for everyone, so that those commands work. This is actually very useful
|
2021-12-23 12:08:13 +00:00
|
|
|
# for testing commands from users' perspective. The routine also handles becoming the root.
|
|
|
|
# We agree that this is not the "correct" way, to enable users to type onto serial console
|
|
|
|
# and that it correctly should be done via groups (dialout) but that would require rebooting
|
|
|
|
# the virtual machine. Therefore we do it this way, which has immediate effect.
|
2022-07-28 20:32:57 +00:00
|
|
|
sub make_serial_writable {
|
2021-12-23 12:08:13 +00:00
|
|
|
become_root();
|
|
|
|
sleep 2;
|
|
|
|
# Make serial console writable for everyone.
|
|
|
|
enter_cmd("chmod 666 /dev/${serialdev}");
|
|
|
|
sleep 2;
|
|
|
|
# Exit the root account
|
|
|
|
enter_cmd("exit");
|
|
|
|
sleep 2;
|
2022-07-28 20:32:57 +00:00
|
|
|
}
|
2021-12-23 12:08:13 +00:00
|
|
|
|
2023-10-02 10:01:33 +00:00
|
|
|
# Sometimes, especially in between freezes, there are Software Updates available
|
|
|
|
# that trigger a notification pop-up which covers some part of the screen
|
|
|
|
# and possibly steals focus from the applications, thus making tests to fail.
|
|
|
|
# This will set the update notification timestamp to the current time (-30 seconds),
|
|
|
|
# forcing the notification mechanism to think it already had notified.
|
|
|
|
# Note, that this has to be run under the user under which the tests run,
|
|
|
|
# not root.
|
|
|
|
sub set_update_notification_timestamp {
|
|
|
|
# Get the current time
|
|
|
|
my $ep_time = time();
|
|
|
|
# Subtract 30 seconds from the number.
|
|
|
|
$ep_time -= 30;
|
|
|
|
# Run a command using the command dialogue
|
|
|
|
send_key('alt-f2');
|
|
|
|
wait_still_screen(2);
|
|
|
|
# Set the new timestamp using the gsettings command.
|
|
|
|
type_very_safely("gsettings set org.gnome.software update-notification-timestamp $ep_time\n");
|
|
|
|
}
|
|
|
|
|
2019-09-19 14:03:50 +00:00
|
|
|
1;
|