2016-01-08 17:01:33 +00:00
|
|
|
use base "installedtest";
|
|
|
|
use strict;
|
|
|
|
use testapi;
|
|
|
|
|
|
|
|
sub run {
|
consolidate login waits, use postinstall not entrypoint for base
Summary:
I started out wanting to fix an issue I noticed today where
graphical upgrade tests were failing because they didn't wait
for the graphical login screen properly; the test was sitting
at the 'full Fedora logo' state of plymouth for a long time,
so the current boot_to_login_screen's wait_still_screen was
triggered by it and the function wound up failing on the
assert_screen, because it was still some time before the real
login screen appeared.
So I tweaked the boot_to_login_screen implementation to work
slightly differently (look for a login screen match, *then* -
if we're dealing with a graphical login - wait_still_screen
to defeat the 'old GPU buffer showing login screen' problem
and assert the login screen again). But while working on it,
I figured we really should consolidate all the various places
that handle the bootloader -> login, we were doing it quite
differently in all sorts of different places. And as part of
that, I converted the base tests to use POSTINSTALL (and thus
go through the shared _wait_login tests) instead of handling
boot themselves. As part of *that*, I tweaked main.pm to not
require all POSTINSTALL tests have the _postinstall suffix on
their names, as it really doesn't make sense, and renamed the
tests.
Test Plan: Run all tests, see if they work.
Reviewers: jskladan, garretraziel
Reviewed By: garretraziel
Subscribers: tflink
Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1015
2016-09-27 18:48:15 +00:00
|
|
|
my $self = shift;
|
2016-01-08 17:01:33 +00:00
|
|
|
# switch to TTY3 for both, graphical and console tests
|
|
|
|
$self->root_console(tty=>3);
|
2017-01-11 21:49:17 +00:00
|
|
|
# dump the systemctl output
|
|
|
|
assert_script_run "systemctl --failed | tee /tmp/failed.txt";
|
|
|
|
# if we have 0 failed services, we're good
|
2017-01-12 00:03:09 +00:00
|
|
|
my $ret = script_run "grep '0 loaded units' /tmp/failed.txt";
|
|
|
|
return if $ret == 0;
|
2017-01-11 21:49:17 +00:00
|
|
|
# if only mcelog failed, that's a soft fail
|
2017-01-12 00:03:09 +00:00
|
|
|
$ret = script_run "grep '1 loaded units' /tmp/failed.txt";
|
|
|
|
if ($ret != 0) {
|
|
|
|
die "More than one services failed to start";
|
2017-01-11 21:49:17 +00:00
|
|
|
}
|
|
|
|
else {
|
2017-01-12 00:03:09 +00:00
|
|
|
# fail if it's something other than mcelog
|
|
|
|
assert_script_run "systemctl is-failed mcelog.service";
|
2016-06-01 06:12:16 +00:00
|
|
|
record_soft_failure;
|
|
|
|
}
|
2016-01-08 17:01:33 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
sub test_flags {
|
|
|
|
# without anything - rollback to 'lastgood' snapshot if failed
|
|
|
|
# 'fatal' - whole test suite is in danger if this fails
|
|
|
|
# 'milestone' - after this test succeeds, update 'lastgood'
|
|
|
|
# 'important' - if this fails, set the overall state to 'fail'
|
|
|
|
return { fatal => 1 };
|
|
|
|
}
|
|
|
|
|
|
|
|
1;
|
|
|
|
|
|
|
|
# vim: set sw=4 et:
|