srbala/os-autoinst-distri-fedora
1
0
Fork 0
mirror of https://pagure.io/fedora-qa/os-autoinst-distri-fedora.git synced 2024-12-29 13:43:08 +00:00
Code Issues Releases Activity
9c7fb06532
os-autoinst-distri-fedora/tests/base_service_manipulation.pm

57 lines
2.0 KiB
Perl
Raw Normal View History

add base_service_manipulation test Summary: Not much to say, pretty much just implements the test case using some commands I dug up that give us handy 0/1 exit statuses. The assert_script_run function (from testapi) simply runs a command/script and passes or fails based on the exit status; we use a handy bash-ism when we *want* the exit status to be 1. Test Plan: Run the test and check that it passes (properly). Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D713
2016-01-11 20:30:24 +00:00
use base "installedtest";
use strict;
use testapi;
Move all remaining utility functions into exporter modules Summary: This adds a couple of new exporter modules, renames main_common to utils (this is a better name: openSUSE's main_common is functions used in main.pm, utils is what they call their module full of miscellaneous commonly-used functions), and moves a bunch of utility functions that were previously needlessly implemented as instance methods in base classes into the exporter modules. That means we can get rid of all the annoying $self-> syntax for calling them. We get rid of `fedorabase` entirely, as it's no longer useful for anything. Other base classes keep the 'standard' methods (like `post_fail_hook`) and methods which actually need to be methods (like `root_console`, whose behaviour is different in anacondatest and installedtest). Test Plan: Do a full test suite run and check everything lines up. There should be no functional differences from before at all, this is just a re-org. Reviewers: jskladan, garretraziel_but_actually_jsedlak_who_uses_stupid_nicknames Reviewed By: garretraziel_but_actually_jsedlak_who_uses_stupid_nicknames Subscribers: tflink Differential Revision: https://phab.qa.fedoraproject.org/D1080
2017-01-18 07:15:44 +00:00
use utils;
add base_service_manipulation test Summary: Not much to say, pretty much just implements the test case using some commands I dug up that give us handy 0/1 exit statuses. The assert_script_run function (from testapi) simply runs a command/script and passes or fails based on the exit status; we use a handy bash-ism when we *want* the exit status to be 1. Test Plan: Run the test and check that it passes (properly). Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D713
2016-01-11 20:30:24 +00:00
sub run {
consolidate login waits, use postinstall not entrypoint for base Summary: I started out wanting to fix an issue I noticed today where graphical upgrade tests were failing because they didn't wait for the graphical login screen properly; the test was sitting at the 'full Fedora logo' state of plymouth for a long time, so the current boot_to_login_screen's wait_still_screen was triggered by it and the function wound up failing on the assert_screen, because it was still some time before the real login screen appeared. So I tweaked the boot_to_login_screen implementation to work slightly differently (look for a login screen match, *then* - if we're dealing with a graphical login - wait_still_screen to defeat the 'old GPU buffer showing login screen' problem and assert the login screen again). But while working on it, I figured we really should consolidate all the various places that handle the bootloader -> login, we were doing it quite differently in all sorts of different places. And as part of that, I converted the base tests to use POSTINSTALL (and thus go through the shared _wait_login tests) instead of handling boot themselves. As part of *that*, I tweaked main.pm to not require all POSTINSTALL tests have the _postinstall suffix on their names, as it really doesn't make sense, and renamed the tests. Test Plan: Run all tests, see if they work. Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1015
2016-09-27 18:48:15 +00:00
my $self = shift;
add base_service_manipulation test Summary: Not much to say, pretty much just implements the test case using some commands I dug up that give us handy 0/1 exit statuses. The assert_script_run function (from testapi) simply runs a command/script and passes or fails based on the exit status; we use a handy bash-ism when we *want* the exit status to be 1. Test Plan: Run the test and check that it passes (properly). Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D713
2016-01-11 20:30:24 +00:00
# switch to TTY3 for both, graphical and console tests
Add a perltidy check and apply it to the entire codebase Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-28 20:32:57 +00:00
$self->root_console(tty => 3);
base_service_manipulation: use chronyd not sshd We changed the wiki test case this way, and it should work better on Cloud images. Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-06-17 23:34:30 +00:00
# we could make this slightly more 'efficient' by assuming chronyd
add base_service_manipulation test Summary: Not much to say, pretty much just implements the test case using some commands I dug up that give us handy 0/1 exit statuses. The assert_script_run function (from testapi) simply runs a command/script and passes or fails based on the exit status; we use a handy bash-ism when we *want* the exit status to be 1. Test Plan: Run the test and check that it passes (properly). Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D713
2016-01-11 20:30:24 +00:00
# is always going to be enabled/running at first, but it's safer
# to force an expected starting state.
base_service_manipulation: use chronyd not sshd We changed the wiki test case this way, and it should work better on Cloud images. Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-06-17 23:34:30 +00:00
script_run "systemctl stop chronyd.service";
script_run "systemctl disable chronyd.service";
drop our implementation of script_run in favour of os-autoinst Summary: os-autoinst implements `script_run` itself now, we aren't required to implement it ourselves any more. os-autoinst's implementation is better than ours, as it allows for verifying the script actually ran (via the redirect-output-to-serial- console trick). So this drops our implementation so we'll just use the upstream one. Where I judged we don't want to bother with the 'check the command actually ran' feature I've adjusted our direct `script_run` calls to pass a wait time of 0, which skips the 'wait for command to run' stuff entirely and just does a simple 'type the string and hit enter'. Because of how the inheritance works, our `assert_script_run` calls already used the os-autoinst `script_run`, rather than the one from our distribution. This should prevent `prepare_test_packages` sometimes going wrong right after removing the python3-kickstart package, as we'll properly wait for that removal to complete now (before we weren't, we'd just start typing the next command while it was still running, which could result in lost keypresses). Test Plan: Check all tests still run OK (I've tried this on staging and it seems fine). Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1034
2016-10-20 16:24:48 +00:00
script_run "reboot", 0;
consolidate login waits, use postinstall not entrypoint for base Summary: I started out wanting to fix an issue I noticed today where graphical upgrade tests were failing because they didn't wait for the graphical login screen properly; the test was sitting at the 'full Fedora logo' state of plymouth for a long time, so the current boot_to_login_screen's wait_still_screen was triggered by it and the function wound up failing on the assert_screen, because it was still some time before the real login screen appeared. So I tweaked the boot_to_login_screen implementation to work slightly differently (look for a login screen match, *then* - if we're dealing with a graphical login - wait_still_screen to defeat the 'old GPU buffer showing login screen' problem and assert the login screen again). But while working on it, I figured we really should consolidate all the various places that handle the bootloader -> login, we were doing it quite differently in all sorts of different places. And as part of that, I converted the base tests to use POSTINSTALL (and thus go through the shared _wait_login tests) instead of handling boot themselves. As part of *that*, I tweaked main.pm to not require all POSTINSTALL tests have the _postinstall suffix on their names, as it really doesn't make sense, and renamed the tests. Test Plan: Run all tests, see if they work. Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1015
2016-09-27 18:48:15 +00:00
boot_to_login_screen;
Add a perltidy check and apply it to the entire codebase Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-28 20:32:57 +00:00
$self->root_console(tty => 3);
add base_service_manipulation test Summary: Not much to say, pretty much just implements the test case using some commands I dug up that give us handy 0/1 exit statuses. The assert_script_run function (from testapi) simply runs a command/script and passes or fails based on the exit status; we use a handy bash-ism when we *want* the exit status to be 1. Test Plan: Run the test and check that it passes (properly). Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D713
2016-01-11 20:30:24 +00:00
# note the use of ! here is a bash-ism, but it sure makes life easier
base_service_manipulation: use chronyd not sshd We changed the wiki test case this way, and it should work better on Cloud images. Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-06-17 23:34:30 +00:00
assert_script_run '! systemctl is-enabled chronyd.service';
assert_script_run '! systemctl is-active chronyd.service';
assert_script_run '! ps -C chronyd';
script_run "systemctl start chronyd.service";
assert_script_run '! systemctl is-enabled chronyd.service';
assert_script_run 'systemctl is-active chronyd.service';
assert_script_run 'ps -C chronyd';
script_run "systemctl stop chronyd.service";
assert_script_run '! systemctl is-enabled chronyd.service';
assert_script_run '! systemctl is-active chronyd.service';
assert_script_run '! ps -C chronyd';
script_run "systemctl enable chronyd.service";
assert_script_run 'systemctl is-enabled chronyd.service';
assert_script_run '! systemctl is-active chronyd.service';
assert_script_run '! ps -C chronyd';
drop our implementation of script_run in favour of os-autoinst Summary: os-autoinst implements `script_run` itself now, we aren't required to implement it ourselves any more. os-autoinst's implementation is better than ours, as it allows for verifying the script actually ran (via the redirect-output-to-serial- console trick). So this drops our implementation so we'll just use the upstream one. Where I judged we don't want to bother with the 'check the command actually ran' feature I've adjusted our direct `script_run` calls to pass a wait time of 0, which skips the 'wait for command to run' stuff entirely and just does a simple 'type the string and hit enter'. Because of how the inheritance works, our `assert_script_run` calls already used the os-autoinst `script_run`, rather than the one from our distribution. This should prevent `prepare_test_packages` sometimes going wrong right after removing the python3-kickstart package, as we'll properly wait for that removal to complete now (before we weren't, we'd just start typing the next command while it was still running, which could result in lost keypresses). Test Plan: Check all tests still run OK (I've tried this on staging and it seems fine). Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1034
2016-10-20 16:24:48 +00:00
script_run "reboot", 0;
consolidate login waits, use postinstall not entrypoint for base Summary: I started out wanting to fix an issue I noticed today where graphical upgrade tests were failing because they didn't wait for the graphical login screen properly; the test was sitting at the 'full Fedora logo' state of plymouth for a long time, so the current boot_to_login_screen's wait_still_screen was triggered by it and the function wound up failing on the assert_screen, because it was still some time before the real login screen appeared. So I tweaked the boot_to_login_screen implementation to work slightly differently (look for a login screen match, *then* - if we're dealing with a graphical login - wait_still_screen to defeat the 'old GPU buffer showing login screen' problem and assert the login screen again). But while working on it, I figured we really should consolidate all the various places that handle the bootloader -> login, we were doing it quite differently in all sorts of different places. And as part of that, I converted the base tests to use POSTINSTALL (and thus go through the shared _wait_login tests) instead of handling boot themselves. As part of *that*, I tweaked main.pm to not require all POSTINSTALL tests have the _postinstall suffix on their names, as it really doesn't make sense, and renamed the tests. Test Plan: Run all tests, see if they work. Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1015
2016-09-27 18:48:15 +00:00
boot_to_login_screen;
Add a perltidy check and apply it to the entire codebase Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-28 20:32:57 +00:00
$self->root_console(tty => 3);
base_service_manipulation: use chronyd not sshd We changed the wiki test case this way, and it should work better on Cloud images. Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-06-17 23:34:30 +00:00
assert_script_run 'systemctl is-enabled chronyd.service';
assert_script_run 'systemctl is-active chronyd.service';
assert_script_run 'ps -C chronyd';
script_run "systemctl disable chronyd.service";
drop our implementation of script_run in favour of os-autoinst Summary: os-autoinst implements `script_run` itself now, we aren't required to implement it ourselves any more. os-autoinst's implementation is better than ours, as it allows for verifying the script actually ran (via the redirect-output-to-serial- console trick). So this drops our implementation so we'll just use the upstream one. Where I judged we don't want to bother with the 'check the command actually ran' feature I've adjusted our direct `script_run` calls to pass a wait time of 0, which skips the 'wait for command to run' stuff entirely and just does a simple 'type the string and hit enter'. Because of how the inheritance works, our `assert_script_run` calls already used the os-autoinst `script_run`, rather than the one from our distribution. This should prevent `prepare_test_packages` sometimes going wrong right after removing the python3-kickstart package, as we'll properly wait for that removal to complete now (before we weren't, we'd just start typing the next command while it was still running, which could result in lost keypresses). Test Plan: Check all tests still run OK (I've tried this on staging and it seems fine). Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1034
2016-10-20 16:24:48 +00:00
script_run "reboot", 0;
consolidate login waits, use postinstall not entrypoint for base Summary: I started out wanting to fix an issue I noticed today where graphical upgrade tests were failing because they didn't wait for the graphical login screen properly; the test was sitting at the 'full Fedora logo' state of plymouth for a long time, so the current boot_to_login_screen's wait_still_screen was triggered by it and the function wound up failing on the assert_screen, because it was still some time before the real login screen appeared. So I tweaked the boot_to_login_screen implementation to work slightly differently (look for a login screen match, *then* - if we're dealing with a graphical login - wait_still_screen to defeat the 'old GPU buffer showing login screen' problem and assert the login screen again). But while working on it, I figured we really should consolidate all the various places that handle the bootloader -> login, we were doing it quite differently in all sorts of different places. And as part of that, I converted the base tests to use POSTINSTALL (and thus go through the shared _wait_login tests) instead of handling boot themselves. As part of *that*, I tweaked main.pm to not require all POSTINSTALL tests have the _postinstall suffix on their names, as it really doesn't make sense, and renamed the tests. Test Plan: Run all tests, see if they work. Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1015
2016-09-27 18:48:15 +00:00
boot_to_login_screen;
Add a perltidy check and apply it to the entire codebase Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-28 20:32:57 +00:00
$self->root_console(tty => 3);
base_service_manipulation: use chronyd not sshd We changed the wiki test case this way, and it should work better on Cloud images. Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-06-17 23:34:30 +00:00
assert_script_run '! systemctl is-enabled chronyd.service';
assert_script_run '! systemctl is-active chronyd.service';
assert_script_run '! ps -C chronyd';
add base_service_manipulation test Summary: Not much to say, pretty much just implements the test case using some commands I dug up that give us handy 0/1 exit statuses. The assert_script_run function (from testapi) simply runs a command/script and passes or fails based on the exit status; we use a handy bash-ism when we *want* the exit status to be 1. Test Plan: Run the test and check that it passes (properly). Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D713
2016-01-11 20:30:24 +00:00
}
sub test_flags {
Add a perltidy check and apply it to the entire codebase Signed-off-by: Adam Williamson <awilliam@redhat.com>
2022-07-28 20:32:57 +00:00
return {fatal => 1};
add base_service_manipulation test Summary: Not much to say, pretty much just implements the test case using some commands I dug up that give us handy 0/1 exit statuses. The assert_script_run function (from testapi) simply runs a command/script and passes or fails based on the exit status; we use a handy bash-ism when we *want* the exit status to be 1. Test Plan: Run the test and check that it passes (properly). Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D713
2016-01-11 20:30:24 +00:00
}
1;
# vim: set sw=4 et:
Reference in New Issue Copy Permalink